PSA patch v6 to address some of Amit's review comments [1].
--
[1]
https://www.postgresql.org/message-id/CAA4eK1JdwQQsxa%2BzpsBW5rCxEfXopYx381nwcCyeXk6mpF8ChQ%40mail.gmail.com
Kind Regards,
Peter Smith.
Fujitsu Australia
v6-0001-PG-DOCS-page-for-row-filters.patch
Description: Binary data
On Thu, Apr 7, 2022 at 9:41 PM David Rowley wrote:
> On Thu, 7 Apr 2022 at 20:28, Amit Langote wrote:
> > Here's an updated version. In Particular, I removed
> > part_prune_results list from PortalData, in favor of anything that
> > needs to look at the list can instead get it from the
On Fri, Apr 8, 2022 at 1:37 PM Michael Paquier wrote:
>
> On Fri, Apr 08, 2022 at 11:34:17AM +0900, Michael Paquier wrote:
> > Now, 0002 is straight-forward but I need more coffee and lunch..
>
> Done this one as well, as of 76cbf7e with few tweaks. 1.9 and 1.10
> changed the definition of
On Wed, Apr 7, 2022 at 1:34 PM Amit Kapila wrote:
>
Thanks for your comments.
> One comment:
> +static void
> +update_progress(LogicalDecodingContext *ctx, bool skipped_xact, bool
> end_xact)
> +{
> + static int changes_count = 0;
> +
> + if (end_xact)
> + {
> + /* Update progress tracking at
At Thu, 7 Apr 2022 20:59:21 -0700, Andres Freund wrote in
> Hi,
>
> On 2022-04-08 11:10:14 +0900, Kyotaro Horiguchi wrote:
> > I can read it. But I'm not sure that the difference is obvious for
> > average users between "starting a standby from a basebackup" and
> > "starting a standby after a
Michael Paquier writes:
> On Fri, Apr 08, 2022 at 02:56:15PM +1200, Thomas Munro wrote:
>> I propose that we drop support for Windows versions older than
>> 10/Server 2016 in the PostgreSQL 16 cycle,
Do we have any data on what people are actually using?
> Do you think that we could raise the
On Thu, Apr 7, 2022 at 8:59 PM Andres Freund wrote:
>
>
>Cumulative statistics are collected in shared memory. Every
>PostgreSQL process collects statistics
> locally
>then updates the shared data at appropriate intervals. When a server,
>including a physical replica, shuts
On 2022-04-07 16:37:51 -0700, Andres Freund wrote:
> On 2022-04-07 00:28:45 -0700, Andres Freund wrote:
> > I've gotten through the main commits (and then a fix for the apparently
> > inevitable bug that's immediately highlighted by the buildfarm), and the
> > first
> > test. I'll call it a night
On Fri, Apr 08, 2022 at 11:34:17AM +0900, Michael Paquier wrote:
> Now, 0002 is straight-forward but I need more coffee and lunch..
Done this one as well, as of 76cbf7e with few tweaks. 1.9 and 1.10
changed the definition of pg_stat_statements, so I have added two
extra queries for those upgrade
Hi,
On 2022-04-07 20:59:21 -0700, Andres Freund wrote:
>
>
>Cumulative statistics are collected in shared memory. Every
>PostgreSQL process collects statistics locally
>then updates the shared data at appropriate intervals. When a server,
>including a physical replica, shuts
On Fri, Apr 08, 2022 at 02:56:15PM +1200, Thomas Munro wrote:
> I propose that we drop support for Windows versions older than
> 10/Server 2016 in the PostgreSQL 16 cycle, because the OS patches for
> everything older come to an end in October next year[1], and we have a
> lot of patches relating
Greetings,
* Stephen Frost (sfr...@snowman.net) wrote:
> * Jacob Champion (pchamp...@vmware.com) wrote:
> > On Fri, 2022-03-11 at 19:39 -0500, Stephen Frost wrote:
> > > Even so, I’m not against adding an option… but exactly how would that
> > > option be configured? Server level? On the HBA
Hi,
On 2022-04-07 20:51:10 -0700, David G. Johnston wrote:
> On Thu, Apr 7, 2022 at 7:10 PM Kyotaro Horiguchi
> wrote:
> > I can read it. But I'm not sure that the difference is obvious for
> > average users between "starting a standby from a basebackup" and
> > "starting a standby after a
Hi,
On 2022-04-08 11:10:14 +0900, Kyotaro Horiguchi wrote:
> At Thu, 7 Apr 2022 16:37:51 -0700, Andres Freund wrote
> in
> > Hi,
> >
> > On 2022-04-07 00:28:45 -0700, Andres Freund wrote:
> > > I've gotten through the main commits (and then a fix for the apparently
> > > inevitable bug that's
On Thu, Apr 7, 2022 at 7:10 PM Kyotaro Horiguchi
wrote:
> At Thu, 7 Apr 2022 16:37:51 -0700, Andres Freund
> wrote in
> > Hi,
> >
> > On 2022-04-07 00:28:45 -0700, Andres Freund wrote:
> > > I've gotten through the main commits (and then a fix for the apparently
> > > inevitable bug that's
On Thu, 7 Apr 2022 at 22:32, Robert Haas wrote:
>
> On Thu, Apr 7, 2022 at 7:41 PM Tom Lane wrote:
>
> > Possibly a better idea is to add an enum argument telling the function
> > what to do (parse the whole thing as one name regardless of dots,
> > parse as two names if there's a dot, throw
On Thu, Apr 07, 2022 at 10:26:18PM -0400, Robert Haas wrote:
> + pg_log_error("improper relation name (too many dotted names):
> %s", pattern);
>
> Come to think of it, maybe the error text there could stand some
> bikeshedding, but AFAICS
AFAICT the error text deliberately
I've bumped this to the next cycle, so I can hopefully skip the
missing version detection stuff that I have no way to test (no CI, no
build farm, and I have zero interest in dumpster diving for Windows 7
or whatever installations).
I propose that we drop support for Windows versions older than
On Thu, Apr 07, 2022 at 09:48:02PM +0900, Masahiko Sawada wrote:
> Oops, the results are opposite:
>
> HEAD: 5367.234 ms
> Patched: 5418.869 ms
I have been playing with external sorts & friends after running an
instance on scissors (fsync=off, PGDATA on tmpfs, etc.), even forcing
a compilation
On Thu, Apr 7, 2022 at 7:41 PM Tom Lane wrote:
> Mark Dilger writes:
> > The patch submitted changes processSQLNamePattern() to return a dot count
> > by reference. It's up to the caller to decide whether to raise an error.
> > If you pass in no schemavar, and you get back dotcnt=2, you know
On Thu, Apr 7, 2022 at 7:52 PM Tom Lane wrote:
> Michael Paquier writes:
> > On Thu, Apr 07, 2022 at 11:19:15AM -0400, Robert Haas wrote:
> >> Here are patches for master and v14 to do things this way. Comments?
>
> > Thanks for the patches. They look correct. For ~14, I'd rather avoid
> > the
At Thu, 7 Apr 2022 16:37:51 -0700, Andres Freund wrote in
> Hi,
>
> On 2022-04-07 00:28:45 -0700, Andres Freund wrote:
> > I've gotten through the main commits (and then a fix for the apparently
> > inevitable bug that's immediately highlighted by the buildfarm), and the
> > first
> > test.
On Fri, Apr 8, 2022 at 12:55 AM Justin Pryzby wrote:
> The docs seem to be wrong about the default.
>
> +are not yet in the buffer pool, during recovery. Valid values are
> +off (the default), on and
> +try. The setting try enables
Fixed.
> + concurrency and
(Mmm. My mailer automatically teared off the [was: ..] part from the
subject..)
--
Kyotaro Horiguchi
NTT Open Source Software Center
At Fri, 8 Apr 2022 08:47:42 +0900, Michael Paquier wrote
in
> On Thu, Apr 07, 2022 at 11:19:15AM -0400, Robert Haas wrote:
> > Here are patches for master and v14 to do things this way. Comments?
>
> Thanks for the patches. They look correct. For ~14, I'd rather avoid
> the code duplication
Hi,
On 2022-04-07 18:31:35 -0400, Tom Lane wrote:
> Andres Freund writes:
> > On 2022-04-07 09:57:09 -0700, Andres Freund wrote:
> >> Yea :(. I tested debug_discard_caches, but not -DRELCACHE_FORCE_RELEASE
> >> -DCATCACHE_FORCE_RELEASE.
> >>
> >> Not quite sure what to do about it - it's
On 2022-02-22 12:59, Chapman Flack wrote:
It would have been painful to write documentation of get_func_trftypes
saying its result isn't what get_transform_{from.to}sql expect, so
patch 1 does add a get_call_trftypes that returns a List *.
Patch 2 then updates the docs as discussed in this
On Fri, Apr 8, 2022 at 4:38 AM Peter Smith wrote:
>
> Hi Vignesh, FYI the patch is recently broken again and is failing on cfbot
> [1].
>
> --
> [1] http://cfbot.cputube.org/patch_38_3610.log
I'm working on fixing a few review comments, I will be posting an
updated version to handle this
Hello,
I am Joseph Ho, a senior at Dr Norman Bethune Collegiate Institute
interested in going into computer science. I am interested in working to
create and improve the website for pgjdbc during GSoC 2022.
I am wondering how the draft proposal should be made. Will I need to submit
a web design
At Thu, 07 Apr 2022 12:38:43 +0200, Laurenz Albe
wrote in
> On Wed, 2022-04-06 at 21:39 -0400, Robert Haas wrote:
> > On Wed, Apr 6, 2022 at 2:26 PM Tom Lane wrote:
> > > Thoughts?
> >
> > I'm a little bit skeptical about this proposal, mostly because it
> > seems like it has the end result
On Wed, Apr 06, 2022 at 07:43:42PM +0200, Gilles Darold wrote:
> Thanks for the review, all these changes are available in new version v6
> of the patch and attached here.
This is failing in CI (except on macos, which is strangely passing).
http://cfbot.cputube.org/gilles-darold.html
I noticed some typos.
diff --git a/src/backend/utils/adt/jsonb_selfuncs.c
b/src/backend/utils/adt/jsonb_selfuncs.c
index f5520f88a1d..d98cd7020a1 100644
--- a/src/backend/utils/adt/jsonb_selfuncs.c
+++ b/src/backend/utils/adt/jsonb_selfuncs.c
@@ -1342,7 +1342,7 @@
On Thu, Apr 07, 2022 at 05:29:36PM +0200, Guillaume Lelarge a écrit :
> Le jeu. 7 avr. 2022 à 15:44, Frédéric Yhuel a
> écrit :
>> On 4/7/22 14:40, Justin Pryzby wrote:
>> Thank you Justin! I applied your fixes in the v2 patch (attached).
>
> v2 patch sounds good.
The location of the new
Some typos I found before the patch was reverted.
diff --git a/doc/src/sgml/logicaldecoding.sgml
b/doc/src/sgml/logicaldecoding.sgml
index a6ea6ff3fcf..d4bd8d41c4b 100644
--- a/doc/src/sgml/logicaldecoding.sgml
+++ b/doc/src/sgml/logicaldecoding.sgml
@@ -834,9 +834,8 @@ typedef void
On Thu, Apr 07, 2022 at 11:37:15AM -0400, Robert Haas wrote:
> It's also worth noting that there's a bit of a definitional problem
> here. If in the same situation, I ask for pg_walfile_name('11/0'),
> it's going to give me a filename based on TLI 2, but there's also a
> WAL file for that LSN with
On 4/7/22 17:58, Andres Freund wrote:
> Hi,
>
> On 2022-04-07 17:45:09 -0400, Tom Lane wrote:
>> Andres Freund writes:
>>> On 2022-04-07 17:21:09 -0400, Tom Lane wrote:
I too think that the elapsed time is useful. I'm less convinced
that the time-of-day marker is useful.
>>> I think
Michael Paquier writes:
> On Thu, Apr 07, 2022 at 11:19:15AM -0400, Robert Haas wrote:
>> Here are patches for master and v14 to do things this way. Comments?
> Thanks for the patches. They look correct. For ~14, I'd rather avoid
> the code duplication done by GetVirtualXIDsDelayingChkptEnd()
On Thu, Apr 07, 2022 at 11:19:15AM -0400, Robert Haas wrote:
> Here are patches for master and v14 to do things this way. Comments?
Thanks for the patches. They look correct. For ~14, I'd rather avoid
the code duplication done by GetVirtualXIDsDelayingChkptEnd() and
Mark Dilger writes:
> The patch submitted changes processSQLNamePattern() to return a dot count by
> reference. It's up to the caller to decide whether to raise an error. If
> you pass in no schemavar, and you get back dotcnt=2, you know it parsed it as
> a two part pattern, and you can
Hi,
On 2022-04-07 00:28:45 -0700, Andres Freund wrote:
> I've gotten through the main commits (and then a fix for the apparently
> inevitable bug that's immediately highlighted by the buildfarm), and the first
> test. I'll call it a night now, and work on the other tests & docs tomorrow.
I've
> On Apr 7, 2022, at 3:37 PM, Tom Lane wrote:
>
>>
>> I don't know whether that's a bug fix for the existing code or some
>> new bit of functionality that \dconfig requires and nothing else
>> needs.
>
> Well, \dconfig needs it because it would like foo.bar to get processed
> as just a
It looks like this patch got feedback from Andres and Robert with some
significant design change recommendations. I'm marking the patch
Returned with Feedback. Feel free to add it back to a future
commitfest when a new version is ready.
Hi Vignesh, FYI the patch is recently broken again and is failing on cfbot [1].
--
[1] http://cfbot.cputube.org/patch_38_3610.log
Kind Regards,
Peter Smith.
Fujitsu Australia
On Thu, Apr 7, 2022 at 4:01 PM Andres Freund wrote:
> I'm on-board with that - but I think we should rewrite a bunch of places that
> use MaxHeapTuplesPerPage sized-arrays on the stack first. It's not great using
> several KB of stack at the current the current value already (*), but if it
>
Hi,
On 2022-04-04 19:24:22 -0700, Peter Geoghegan wrote:
> We should definitely increase MaxHeapTuplesPerPage before too long,
> for a variety of reasons that I have talked about in the past. Its
> current value is 291 on all mainstream platforms, a value that's
> derived from accidental historic
On Mon, Apr 4, 2022 at 7:24 PM Peter Geoghegan wrote:
> I am sympathetic to the idea that giving the system a more accurate
> picture of how much free space is available on each heap page is an
> intrinsic good. This might help us in a few different areas. For
> example, the FSM cares about
On Fri, 8 Apr 2022 at 02:11, David Rowley wrote:
> Barring any objection, I'm planning to push this one in around 10 hours time.
Pushed. 9d9c02ccd
Thank you all for the reviews.
David
Robert Haas writes:
> I still have a vague feeling that there's probably some way of doing
> this better, but had more or less resolved to commit this patch as is
> anyway and had that all queued up. But then I had to go to a meeting
> and when I came out I discovered that Tom had done this:
Andres Freund writes:
> On 2022-04-07 09:57:09 -0700, Andres Freund wrote:
>> Yea :(. I tested debug_discard_caches, but not -DRELCACHE_FORCE_RELEASE
>> -DCATCACHE_FORCE_RELEASE.
>>
>> Not quite sure what to do about it - it's intentionally trying to test the
>> case of no invalidations being
Chapman Flack writes:
> v4 looks good to me.
Pushed with very minor editorialization. Mainly, I undid the
decision to stop printing the function source text, on the
grounds that (1) it falsified the comment immediately above,
and (2) if you have to print it anyway to avoid compiler warnings,
On Thu, Feb 24, 2022 at 09:55:53AM -0800, Nathan Bossart wrote:
> Yes. I found that a crash at an unfortunate moment can produce multiple
> links to the same file in pg_wal, which seemed bad independent of archival.
> By fixing that (i.e., switching from durable_rename_excl() to
>
On Wed, Apr 6, 2022 at 12:07 PM Mark Dilger
wrote:
> I was able to clean up the "if (left && want_literal_dbname)" stuff, though.
I still have a vague feeling that there's probably some way of doing
this better, but had more or less resolved to commit this patch as is
anyway and had that all
On Thu, Apr 7, 2022 at 7:11 AM David Rowley wrote:
> On Thu, 7 Apr 2022 at 19:01, David Rowley wrote:
> >
> > On Thu, 7 Apr 2022 at 15:41, Zhihong Yu wrote:
> > > +* We must keep the original qual in place if there is
> a
> > > +* PARTITION BY clause as the
Hi,
On 2022-04-07 09:57:09 -0700, Andres Freund wrote:
> Yea :(. I tested debug_discard_caches, but not -DRELCACHE_FORCE_RELEASE
> -DCATCACHE_FORCE_RELEASE.
>
> Not quite sure what to do about it - it's intentionally trying to test the
> case of no invalidations being processed, as that's an
Hi,
On 2022-04-07 17:45:09 -0400, Tom Lane wrote:
> Andres Freund writes:
> > On 2022-04-07 17:21:09 -0400, Tom Lane wrote:
> >> I too think that the elapsed time is useful. I'm less convinced
> >> that the time-of-day marker is useful.
>
> > I think it'd be quite useful if it had more
On Wed, 6 Apr 2022 at 21:59, Julien Rouhaud wrote:
>
>
> FWIW I think that this 5 days threshold before closing a patch with RwF is way
> too short. As far as I know we usually use something like 2/3 weeks.
Yeah, I haven't been enforcing a timeout like that during the
commitfest. But now that
On Thu, 7 Apr 2022 at 21:11, Robert Haas wrote:
>
> On Thu, Apr 7, 2022 at 2:43 PM Peter Geoghegan wrote:
> > But if we were in a green-field situation we'd probably not want to
> > use up several bytes for a nonse anyway. You said so yourself.
>
> I don't know what statement of mine you're
Andres Freund writes:
> On 2022-04-07 17:21:09 -0400, Tom Lane wrote:
>> I too think that the elapsed time is useful. I'm less convinced
>> that the time-of-day marker is useful.
> I think it'd be quite useful if it had more precision - it's a pita to
> correlate regress_log_* output with
Hi,
On 2022-04-07 17:21:09 -0400, Tom Lane wrote:
> Andrew Dunstan writes:
> > On 4/2/22 06:57, Andrew Dunstan wrote:
> >> Here's a version that actually works. It produces traces that look like
> >> this:
> >> andrew@emma:pg_upgrade $ grep '([0-9]*s)'
> >>
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: not tested
Documentation:not tested
v4 looks good to me.
I don't think this requires any documentation
Andrew Dunstan writes:
> On 4/2/22 06:57, Andrew Dunstan wrote:
>> Here's a version that actually works. It produces traces that look like
>> this:
>> andrew@emma:pg_upgrade $ grep '([0-9]*s)'
>> tmp_check/log/regress_log_002_pg_upgrade
>> [21:55:06](63s) ok 1 - dump before running pg_upgrade
>>
On 2022-04-07 15:04, Andres Freund wrote:
And done. Chap, could you confirm this fixes the issue for you?
Looks good from here. One installcheck-world with no failures;
previously,
it failed for me every time.
Regards,
-Chap
On 4/2/22 06:57, Andrew Dunstan wrote:
> Here's a version that actually works. It produces traces that look like
> this:
>
>
> andrew@emma:pg_upgrade $ grep '([0-9]*s)'
> tmp_check/log/regress_log_002_pg_upgrade
> [21:55:06](63s) ok 1 - dump before running pg_upgrade
> [21:55:22](79s) ok 2 - run
On 4/7/22 16:48, Andrew Dunstan wrote:
> On 4/7/22 13:10, Andres Freund wrote:
>> Hi,
>>
>> On 2022-04-06 11:03:37 -0400, Andrew Dunstan wrote:
>>> On 3/30/22 20:26, Andres Freund wrote:
Could you try using dash to invoke configure here, and whether it makes
configure faster?
>>> I
On 4/7/22 13:10, Andres Freund wrote:
> Hi,
>
> On 2022-04-06 11:03:37 -0400, Andrew Dunstan wrote:
>> On 3/30/22 20:26, Andres Freund wrote:
>>> Could you try using dash to invoke configure here, and whether it makes
>>> configure faster?
>> I got weird failures re libxml/parser.h when I tried
Dear Sir or Madam,
My name is Yedil Serzhan, a Computer Science MSc student at the University
of Freiburg. I have had several experiences with PostgreSQL for full-stack
development. Among all the databases I have used, PostgreSQL gives me the
most comfortable user experience. Recently I'm trying
Pavel Stehule writes:
> čt 7. 4. 2022 v 19:04 odesílatel David G. Johnston <
> david.g.johns...@gmail.com> napsal:
>> \dconfig[+] gets my vote. I was going to say "conf" just isn't common
>> jargon to say or write; but the one place it is - file extensions - is
>> relevant and common. But
On Thu, Apr 7, 2022 at 1:09 PM Stephen Frost wrote:
> > > I got that much, of course. That will work, I suppose, but it'll be
> > > the first and last time that anybody gets to do that (unless we accept
> > > it being incompatible with encryption).
> >
> > Yeah.
>
> I don't know that I agree with
Greetings,
* Peter Geoghegan (p...@bowt.ie) wrote:
> On Thu, Apr 7, 2022 at 12:37 PM Robert Haas wrote:
> > On Thu, Apr 7, 2022 at 3:27 PM Peter Geoghegan wrote:
> > > I just meant that it wouldn't be reasonable to impose a fixed cost on
> > > every user, even those not using the feature. Which
Greetings,
* Robert Haas (robertmh...@gmail.com) wrote:
> On Thu, Apr 7, 2022 at 3:27 PM Peter Geoghegan wrote:
> > I just meant that it wouldn't be reasonable to impose a fixed cost on
> > every user, even those not using the feature. Which you said yourself.
>
> Unfortunately, I think there's
On Thu, Apr 7, 2022 at 12:37 PM Robert Haas wrote:
> On Thu, Apr 7, 2022 at 3:27 PM Peter Geoghegan wrote:
> > I just meant that it wouldn't be reasonable to impose a fixed cost on
> > every user, even those not using the feature. Which you said yourself.
>
> Unfortunately, I think there's bound
On 4/6/22 12:34, Andres Freund wrote:
> Hi,
>
> On 2022-04-06 11:03:37 -0400, Andrew Dunstan wrote:
>> On 3/30/22 20:26, Andres Freund wrote:
>>> Could you try using dash to invoke configure here, and whether it makes
>>> configure faster?
>> I got weird failures re libxml/parser.h when I tried
On Thu, Apr 7, 2022 at 3:27 PM Peter Geoghegan wrote:
> I just meant that it wouldn't be reasonable to impose a fixed cost on
> every user, even those not using the feature. Which you said yourself.
Unfortunately, I think there's bound to be some cost. We can avoid
using the space in the page
On Thu, Apr 7, 2022 at 12:11 PM Robert Haas wrote:
> I don't know what statement of mine you're talking about here, and
> while I don't love using up space for a nonce, it seems to be the way
> this encryption stuff works. I don't see that there's a reasonable
> alternative, green field or no.
I
On Thu, Apr 7, 2022 at 2:43 PM Peter Geoghegan wrote:
> But if we were in a green-field situation we'd probably not want to
> use up several bytes for a nonse anyway. You said so yourself.
I don't know what statement of mine you're talking about here, and
while I don't love using up space for a
Hi,
On 2022-04-07 11:54:08 -0700, Andres Freund wrote:
> I'll change it to use distinct payloads..
And done. Chap, could you confirm this fixes the issue for you?
Greetings,
Andres Freund
Hi,
On 2022-04-07 11:02:41 -0700, Andres Freund wrote:
> I've now reproduced this, albeit not reliably yet. Looking.
Caused by me misremembering when deduplication happens - somehow recalled that
deduplication didn't happen when payloads. So the statement that was supposed
to guarantee needing
On Thu, Apr 7, 2022 at 7:01 AM Robert Haas wrote:
> Because there's no place to put them in the existing page format. We
> jammed checksums into the 2-byte field that had previously been set
> aside for the TLI, but that wasn't really an ideal solution because it
> meant we ended up with a
Hi hackers,
I am splitting this off of a previous thread aimed at reducing archiving
overhead [0], as I believe this fix might deserve back-patching.
Presently, WAL recycling uses durable_rename_excl(), which notes that a
crash at an unfortunate moment can result in two links to the same file.
On 2022-Apr-05, Alvaro Herrera wrote:
> Apologies -- I selected the wrong commit to extract the commit message
> from. Here it is again. I also removed an obsolete /* XXX */ comment.
I spent a lot of time staring at this to understand the needs for memory
barriers in the interactions. In the
On Wed, Mar 23, 2022 at 5:33 PM Tom Lane wrote:
>
> Justin Pryzby writes:
> > You have to either include the pre-requisite patches as 0001, and your
> > patch as
> > 0002 (as I'm doing now), or name your patch something other than *.diff or
> > *.patch, so cfbot doesn't think it's a new version
Hi,
On 2022-04-07 13:57:45 -0400, Tom Lane wrote:
> Yeah, with only one instance it could just be cosmic rays or something.
> However, assuming it is real, I guess I wonder why we don't say
> CHECKPOINT_FORCE in standby mode too.
I guess it might partially be that restartpoints require a
> On 7. 4. 2022, at 17:19, Robert Haas wrote:
>
> On Tue, Apr 5, 2022 at 10:17 AM Tom Lane wrote:
>> What I think you need to do is:
>>
>> 1. In the back branches, revert delayChkpt to its previous type and
>> semantics. Squeeze a separate delayChkptEnd bool in somewhere
>> (you can't
Hi,
On 2022-04-07 10:29:10 -0700, Andres Freund wrote:
> On 2022-04-07 13:16:53 -0400, c...@anastigmatix.net wrote:
> > The command that I've just been reusing from my bash_history without
> > thinking about it for some years is:
> >
> > configure --enable-cassert --enable-tap-tests \
> >
Andres Freund writes:
> On 2022-04-07 13:40:30 -0400, Tom Lane wrote:
>> This test is sending a CHECKPOINT command to the standby and
>> expecting it to run the archive_cleanup_command, but it looks
>> like the standby did not actually run any checkpoint:
>> ...
>> I wondered if the recent
Hi,
On 2022-04-07 13:42:49 -0400, Tom Lane wrote:
> Andres Freund writes:
> > On 2022-04-07 09:40:43 -0400, Tom Lane wrote:
> >> If it causes problems down the road, how will we debug it?
>
> > If what causes problems down the road? Afaics the patch doesn't change
> > anything outside of
Hi,
On 2022-04-07 13:40:30 -0400, Tom Lane wrote:
> Michael Paquier writes:
> > Add TAP test for archive_cleanup_command and recovery_end_command
>
> grassquit just showed a non-reproducible failure in this test [1]:
I was just staring at that as well.
> # Postmaster PID for node "standby"
Andres Freund writes:
> On 2022-04-07 09:40:43 -0400, Tom Lane wrote:
>> If it causes problems down the road, how will we debug it?
> If what causes problems down the road? Afaics the patch doesn't change
> anything outside of windows-on-arm, so it shouldn't cause any breakage we care
> about
Michael Paquier writes:
> Add TAP test for archive_cleanup_command and recovery_end_command
grassquit just showed a non-reproducible failure in this test [1]:
# Postmaster PID for node "standby" is 291160
ok 1 - check content from archives
not ok 2 - archive_cleanup_command executed on
Hi,
On 2022-04-07 13:16:53 -0400, c...@anastigmatix.net wrote:
> The command that I've just been reusing from my bash_history without
> thinking about it for some years is:
>
> configure --enable-cassert --enable-tap-tests \
> --with-libxml --enable-debug \
> CFLAGS='-ggdb -Og -g3
Hi,
On 2022-04-07 09:40:43 -0400, Tom Lane wrote:
> If it causes problems down the road, how will we debug it?
If what causes problems down the road? Afaics the patch doesn't change
anything outside of windows-on-arm, so it shouldn't cause any breakage we care
about until we get a buildfarm
On 2022-04-07 12:49, Tom Lane wrote:
So what non-default build options are you using?
The command that I've just been reusing from my bash_history without
thinking about it for some years is:
configure --enable-cassert --enable-tap-tests \
--with-libxml --enable-debug \
CFLAGS='-ggdb -Og
Hi,
On 2022-04-06 11:03:37 -0400, Andrew Dunstan wrote:
> On 3/30/22 20:26, Andres Freund wrote:
> > Could you try using dash to invoke configure here, and whether it makes
> > configure faster?
> I got weird failures re libxml/parser.h when I tried with dash. See
>
čt 7. 4. 2022 v 19:04 odesílatel David G. Johnston <
david.g.johns...@gmail.com> napsal:
> On Thu, Apr 7, 2022 at 9:58 AM Joe Conway wrote:
>
>> On 4/7/22 12:37, Tom Lane wrote:
>> > Mark Dilger writes:
>> >>> On Apr 7, 2022, at 9:29 AM, Tom Lane wrote:
>> >>> I wouldn't
>> >>> fight too hard
On Thu, Apr 7, 2022 at 9:58 AM Joe Conway wrote:
> On 4/7/22 12:37, Tom Lane wrote:
> > Mark Dilger writes:
> >>> On Apr 7, 2022, at 9:29 AM, Tom Lane wrote:
> >>> I wouldn't
> >>> fight too hard if people want to lengthen it to \dconfig for
> consistency
> >>> with set_config().
> >
> >> I'd
On 4/7/22 12:37, Tom Lane wrote:
Mark Dilger writes:
On Apr 7, 2022, at 9:29 AM, Tom Lane wrote:
I wouldn't
fight too hard if people want to lengthen it to \dconfig for consistency
with set_config().
I'd prefer \dconfig, but if the majority on this list view that as pedantically
forcing
Hi,
On 2022-04-07 12:49:07 -0400, Tom Lane wrote:
> c...@anastigmatix.net writes:
> > Running installcheck-world on an unrelated patch, I noticed a failure
> > here in test/isolation/expected/stats_1.out (this is line 3102):
>
> So what non-default build options are you using?
>
> The only
c...@anastigmatix.net writes:
> Running installcheck-world on an unrelated patch, I noticed a failure
> here in test/isolation/expected/stats_1.out (this is line 3102):
So what non-default build options are you using?
The only isolationcheck failure remaining in the buildfarm is
prion's, which I
On 4/7/22 12:42 PM, Mark Dilger wrote:
On Apr 7, 2022, at 9:37 AM, Tom Lane wrote:
Maybe I'm atypical, but I'm probably going to use tab completion
either way, so it's not really more keystrokes.
Same here, because after tab-completing \dcon\t\t into \dconfig, I'm likely to
also
> On Apr 7, 2022, at 9:37 AM, Tom Lane wrote:
>
> Maybe I'm atypical, but I'm probably going to use tab completion
> either way, so it's not really more keystrokes.
Same here, because after tab-completing \dcon\t\t into \dconfig, I'm likely to
also tab-complete to get the list of
1 - 100 of 192 matches
Mail list logo
