On Fri, May 13, 2022 at 7:32 AM wangw.f...@fujitsu.com
wrote:
>
> Attach the patches.(Only changed the patch for HEAD.).
>
Few comments:
=
1.
@@ -1135,6 +1172,15 @@ pg_get_publication_tables(PG_FUNCTION_ARGS)
if (publication->pubviaroot)
tables = filter_partitions(tables);
}
+
Sorry, hit the send button too early :|
Attached here !!
On Fri, May 13, 2022 at 10:20 AM Amul Sul wrote:
>
> Hi,
>
> PFA, attached patch to $SUBJECT.
>
> --
> Regards,
> Amul Sul
> EDB: http://www.enterprisedb.com
code_comment.patch
Description: Binary data
Hi,
PFA, attached patch to $SUBJECT.
--
Regards,
Amul Sul
EDB: http://www.enterprisedb.com
On Thu, 2022-05-12 at 22:26 +0100, Simon Riggs wrote:
> I see multiple uses for the rm_checkpoint() point proposed and I've
> been asked multiple times for a checkpoint hook.
Can you elaborate and/or link to a discussion?
Regards,
Jeff Davis
On Thu, May 12, 2022 at 2:24 PM vignesh C wrote:
>
...
> The attached patch has the implementation for "ALTER PUBLICATION
> pubname RESET". This command will reset the publication to default
> state which includes resetting the publication options, setting ALL
> TABLES option to false and
Hi,
On 2022-05-12 19:14:13 -0700, Andres Freund wrote:
> On 2022-05-12 21:42:43 -0400, Melanie Plageman wrote:
> > Andres drew my attention to this [1] build farm failure.
I just saw that there's another recent timestamp related failure:
On Fri, May 13, 2022 at 6:02 AM Euler Taveira wrote:
>
> On Thu, May 12, 2022, at 11:22 AM, Bruce Momjian wrote:
>
> On Thu, May 12, 2022 at 11:12:54AM -0300, Euler Taveira wrote:
> OB> On Thu, May 12, 2022, at 11:03 AM, Bruce Momjian wrote:
> >
> > I looked at that but thought that everyone
On Fri, May 13, 2022 at 11:44 AM Amit Kapila wrote:
> On Fri, May 13, 2022 at 7:19 AM Amit Langote wrote:
> >
> > On Thu, May 12, 2022 at 10:52 PM Bruce Momjian wrote:
> > > Okay, I went with:
> > >
> > > Previously, such updates ran delete actions on the source
> > > partition
On Fri, May 13, 2022 at 7:19 AM Amit Langote wrote:
>
> On Thu, May 12, 2022 at 10:52 PM Bruce Momjian wrote:
> > Okay, I went with:
> >
> > Previously, such updates ran delete actions on the source
> > partition and insert actions on the target partition. PostgreSQL
> > will
>
On Thu, May 12, 2022 at 4:57 PM Thomas Munro wrote:
> On Thu, May 12, 2022 at 3:13 PM Thomas Munro wrote:
> > error running SQL: 'psql::1: ERROR: source database
> > "conflict_db_template" is being accessed by other users
> > DETAIL: There is 1 other session using the database.'
>
> Oh, for
Hi,
On 2022-05-12 21:42:43 -0400, Melanie Plageman wrote:
> Andres drew my attention to this [1] build farm failure.
>
> Looks like a test I wrote resetting pg_stat_replication_slots is
> failing:
>
> # Failed test 'Check that reset timestamp is later after resetting
> stats for slot
On Fri, May 13, 2022 at 12:01:09PM +1000, Peter Smith wrote:
> I don't know if this is related, but I noticed that the log timestamp
> (19:59:58.342) is reporting the $reset1 value (19:59:58.402808).
>
> I did not understand how a timestamp saved from the past could be
> ahead of the timestamp of
Hi,
I finally pushed the fix for this. Erik, thanks for the report! And thanks
Michael for the ping...
On 2022-05-11 20:32:14 -0700, Andres Freund wrote:
> On 2022-05-11 15:48:40 +0900, Michael Paquier wrote:
> > Ping. It looks annoying to release beta1 with that, as assertions are
> > likely
On Thur, May 12, 2022 9:48 AM osumi.takami...@fujitsu.com
wrote:
> On Wednesday, May 11, 2022 11:33 AM I wrote:
> > On Monday, May 9, 2022 10:51 AM wangw.f...@fujitsu.com
> > wrote:
> > > Attach new patches.
> > > The patch for HEAD:
> > > 1. Modify the approach. Enhance the API of function
> >
On Fri, May 13, 2022 at 11:43 AM Melanie Plageman
wrote:
>
> Andres drew my attention to this [1] build farm failure.
>
> Looks like a test I wrote resetting pg_stat_replication_slots is
> failing:
>
> # Failed test 'Check that reset timestamp is later after resetting
> stats for slot
On Thu, May 12, 2022 at 10:52 PM Bruce Momjian wrote:
> Okay, I went with:
>
> Previously, such updates ran delete actions on the source
> partition and insert actions on the target partition. PostgreSQL will
> now run update actions on the referenced partition root.
Andres drew my attention to this [1] build farm failure.
Looks like a test I wrote resetting pg_stat_replication_slots is
failing:
# Failed test 'Check that reset timestamp is later after resetting
stats for slot 'test_slot' again.'
# at t/006_logical_decoding.pl line 261.
#
On Thursday, May 12, 2022 11:10 PM 'Bruce Momjian' wrote:
> On Thu, May 12, 2022 at 01:35:39PM +, osumi.takami...@fujitsu.com
> wrote:
> > I'd like to suggest that we mention a new option for subscription
> 'disable_on_error'.
> >
> >
> >
>
At Thu, 12 May 2022 10:25:03 -0400, Bruce Momjian wrote in
> On Thu, May 12, 2022 at 01:54:57PM +0900, Kyotaro Horiguchi wrote:
> > At Thu, 12 May 2022 11:44:33 +0900 (JST), Kyotaro Horiguchi
> > wrote in
> > > At Thu, 12 May 2022 10:34:49 +0900 (JST), Tatsuo Ishii
> > > wrote in
> > > >
On Thu, May 12, 2022, at 11:22 AM, Bruce Momjian wrote:
> On Thu, May 12, 2022 at 11:12:54AM -0300, Euler Taveira wrote:
> OB> On Thu, May 12, 2022, at 11:03 AM, Bruce Momjian wrote:
> >
> > I looked at that but thought that everyone would already assume we
> > skipped replication of
On Thu, May 12, 2022 at 06:51:59PM +0300, Anton A. Melnikov wrote:
> Maybe remove the first part from the patchset?
> Because now the Patch Tester is giving apply error for the first part and
> can't test the other.
> http://cfbot.cputube.org/patch_38_3614.log
Yep. As simple as the attached.
--
On Thu, May 12, 2022 at 11:59:49AM -0400, Tom Lane wrote:
>> It seems pretty nonsensical to add PGDLLIMPORT to frontend only headers /
>> variables. What is that supposed to mean?
>
> Yeah, that's why I removed it in 9a374b77.
Perhaps we should try to remove it from the header itself in the long
On Thu, May 12, 2022 at 09:33:05AM -0700, Andres Freund wrote:
> On 2022-05-12 12:12:59 -0400, Tom Lane wrote:
>> But we have not seen any pgstat crashes lately, so I'm content to mark the
>> open item as resolved.
>
> Cool.
Okay, thanks for the feedback. I have marked the item as resolved for
Hi,
On 2022-05-12 22:26:51 +0100, Simon Riggs wrote:
> On Thu, 12 May 2022 at 04:40, Andres Freund wrote:
> > I'm not happy with the idea of random code being executed in the middle of
> > CheckPointGuts(), without any documentation of what is legal to do at that
> > point.
>
> The "I'm not
On Thu, 2022-05-05 at 15:12 +, Jacob Champion wrote:
> On Wed, 2022-05-04 at 15:53 +0200, Peter Eisentraut wrote:
> > In terms of aligning what is printed, I meant that pg_stat_ssl uses the
> > issuer plus serial number to identify the certificate unambiguously.
>
> Oh, that's a great idea.
On Thu, 12 May 2022 at 04:40, Andres Freund wrote:
>
> On 2022-05-11 09:39:48 -0700, Jeff Davis wrote:
> > On Wed, 2022-05-11 at 15:24 +0100, Simon Riggs wrote:
> > > [PATCH: rmgr_001.v1.patch]
> > >
> > > [PATCH: rmgr_002.v1.patch]
> >
> > Thank you. Both of these look like good ideas, and I
I wrote:
> every buildfarm member that's contributing to the typedefs list
> builds with OpenSSL. That wouldn't surprise me, except that
> my own animal sifaka should be filling that gap. Looking at
> its latest attempt[1], it seems to be generating an empty list,
> which I guess means that our
I just completed the v15 pre-beta pgindent run. It went reasonably
smoothly, but I had to hack up typedefs.list a little bit compared
to the version downloaded from the buildfarm.
* The buildfarm's list is missing
pg_md5_ctx
pg_sha1_ctx
pg_sha224_ctx
pg_sha256_ctx
On 2022-05-12 11:38:39 -0700, Andres Freund wrote:
> On 2022-05-12 13:18:05 -0400, Tom Lane wrote:
> > Andres Freund writes:
> > > I think the attached patches are all a good idea and trivial enought that
> > > I
> > > think we should apply them now.
> >
> > +1 to all of that.
>
> Cool.
Hi,
On 2022-05-11 12:18:58 +0200, Peter Eisentraut wrote:
> I fixed the Perl detection issue in my macOS environment that I had reported
> a while ago.
Hm. I wonder if it's right to check with is_file() - perhaps there are
platforms that have split off the include directory?
> Then I added in
On Thu, May 12, 2022 at 08:05:40PM +0530, vignesh C wrote:
> I wonder if this is worth mentioning:
>
> Raise a WARNING for missing publications.
> commit 8f2e2bbf145384784bad07a96d461c6bbd91f597
>
>
Hi,
On 2022-05-12 13:18:05 -0400, Tom Lane wrote:
> Andres Freund writes:
> > I was experimenting with specifying symbol visiblity for functions
> > explicitly,
> > i.e. adding PGDLLIMPORT markers for them, with the goal of getting rid of
> > src/tools/msvc/gendef.pl (and similar AIX stuff).
Andres Freund writes:
> I was experimenting with specifying symbol visiblity for functions explicitly,
> i.e. adding PGDLLIMPORT markers for them, with the goal of getting rid of
> src/tools/msvc/gendef.pl (and similar AIX stuff). While doing that I compared
> the set of exported symbols before /
Hi,
I was experimenting with specifying symbol visiblity for functions explicitly,
i.e. adding PGDLLIMPORT markers for them, with the goal of getting rid of
src/tools/msvc/gendef.pl (and similar AIX stuff). While doing that I compared
the set of exported symbols before / after, leading me to find
Hi,
On 2022-05-12 12:12:59 -0400, Tom Lane wrote:
> Andres Freund writes:
> > On 2022-05-11 15:46:13 +0900, Michael Paquier wrote:
> >> Do we have anything remaining on this thread in light of the upcoming
> >> beta1? One fix has been pushed upthread, but it does not seem we are
> >> completely
Andres Freund writes:
> On 2022-05-11 15:46:13 +0900, Michael Paquier wrote:
>> Do we have anything remaining on this thread in light of the upcoming
>> beta1? One fix has been pushed upthread, but it does not seem we are
>> completely in the clear either.
> I don't know what else there is to
Andres Freund writes:
> On 2022-05-12 15:15:10 +0900, Michael Paquier wrote:
>> After an extra look, PGDLLIMPORT missing from __pg_log_level looks
>> like an imbroglio between 8ec5694, that has added the marking, and
>> 9a374b77 that has removed it the same day. All that has been fixed in
>>
On 12.05.2022 00:01, Nathan Bossart wrote:
On Wed, May 11, 2022 at 04:18:10PM -0400, Robert Haas wrote:
OK, I have committed 0001 now.
Thanks!
Maybe remove the first part from the patchset?
Because now the Patch Tester is giving apply error for the first part
and can't test the other.
Hi,
On 2022-05-11 15:46:13 +0900, Michael Paquier wrote:
> On Tue, Apr 19, 2022 at 08:31:05PM +1200, Thomas Munro wrote:
> > On Tue, Apr 19, 2022 at 2:50 AM Andres Freund wrote:
> > > Kestrel won't go that far back even - I set it up 23 days ago...
> >
> > Here's a ~6 month old example from
Hi,
On 2022-05-12 15:15:10 +0900, Michael Paquier wrote:
> On Tue, May 10, 2022 at 04:09:47PM +0900, Michael Paquier wrote:
> > Well, what about the attached then? While looking at all the headers
> > in the tree, I have noticed that __pg_log_level is not marked, but
> > we'd better paint a
Robert Haas writes:
> Here, that doesn't seem too likely. You could have a column that
> contains 'tom' and ['tom'] and [['tom']] and [[['tom']]] and so forth
> and they all get mapped onto the same bucket and you're sad. But
> probably not.
Yeah, that might be a more useful way to think about
I wonder if this is worth mentioning:
Raise a WARNING for missing publications.
commit 8f2e2bbf145384784bad07a96d461c6bbd91f597
https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=8f2e2bbf145384784bad07a96d461c6bbd91f597
Regards,
Vignesh
On Thu, May 12, 2022 at 7:52 PM Bruce
On Thu, May 12, 2022 at 9:57 AM Tom Lane wrote:
> Andrew Dunstan writes:
> > On 2022-05-12 Th 07:02, Valeriy Meleshkin wrote:
> >> AFAICT it happens because when iterating over a jsonb the hash function
> >> makes no distinction between raw scalars and arrays (it doesn't inspect
> >>
On Thu, May 12, 2022 at 01:54:57PM +0900, Kyotaro Horiguchi wrote:
> At Thu, 12 May 2022 11:44:33 +0900 (JST), Kyotaro Horiguchi
> wrote in
> > At Thu, 12 May 2022 10:34:49 +0900 (JST), Tatsuo Ishii
> > wrote in
> > > Last year we faced a similar problem, namely, a new committer for
> > >
On Thu, May 12, 2022 at 11:12:54AM -0300, Euler Taveira wrote:
OB> On Thu, May 12, 2022, at 11:03 AM, Bruce Momjian wrote:
>
> I looked at that but thought that everyone would already assume we
> skipped replication of empty transactions, and I didn't see much impact
> for the user,
On Thu, May 12, 2022, at 11:03 AM, Bruce Momjian wrote:
> I looked at that but thought that everyone would already assume we
> skipped replication of empty transactions, and I didn't see much impact
> for the user, so I didn't include it.
It certainly has an impact on heavy workloads that
On Thu, May 12, 2022 at 01:35:39PM +, osumi.takami...@fujitsu.com wrote:
> I'd like to suggest that we mention a new option for subscription
> 'disable_on_error'.
>
>
> https://github.com/postgres/postgres/commit/705e20f8550c0e8e47c0b6b20b5f5ffd6ffd9e33
Yes, I missed that one, added:
On Thu, May 12, 2022 at 09:32:48PM +1000, Ajin Cherian wrote:
> On Wed, May 11, 2022 at 1:44 AM Bruce Momjian wrote:
> >
> > I have completed the first draft of the PG 15 release notes and you can
> > see the results here:
> >
> > https://momjian.us/pgsql_docs/release-15.html
> >
> > The
On Thu, May 12, 2022 at 04:40:49PM +0530, Amit Kapila wrote:
> One more point related to logical replication features:
>
> >
> Add SQL functions to monitor the directory contents of replication
> slots (Bharath Rupireddy)
>
> Specifically, the functions are pg_ls_logicalsnapdir(),
>
Andrew Dunstan writes:
> On 2022-05-12 Th 07:02, Valeriy Meleshkin wrote:
>> AFAICT it happens because when iterating over a jsonb the hash function
>> makes no distinction between raw scalars and arrays (it doesn't inspect
>> v.val.array.rawScalar)
> It does look rather like a bug, but I'm
On Thu, May 12, 2022 at 02:25:36PM +0530, Amit Kapila wrote:
> On Wed, May 11, 2022 at 2:02 AM Bruce Momjian wrote:
> > Yes, sorry, I missed that. Oddly, the unlogged sequence patch was
> > retained, even though there is no value for it on the primary. I
> > removed the sentence that mentioned
On Thu, May 12, 2022 at 02:27:26PM +0900, Amit Langote wrote:
> > Yes, this is what I needed to know. The updated text is:
> >
> >
> >
> >
> >
> > Improve foreign key behavior of updates on partitioned tables
> > that move rows between partitions (Amit
On 2022-05-12 Th 07:02, Valeriy Meleshkin wrote:
> Hello,
>
> I've noticed that
>
> jsonb_hash_extended(jsonb_v,0) =
> jsonb_hash_extended(jsonb_build_array(jsonb_v),0)
>
> for any jsonb value jsonb_v.
>
> AFAICT it happens because when iterating over a jsonb the hash function makes
> no
On Wednesday, May 11, 2022 12:44 AM Bruce Momjian wrote:
> I have completed the first draft of the PG 15 release notes and you can see
> the
> results here:
>
> https://momjian.us/pgsql_docs/release-15.html
>
> The feature count is similar to recent major releases:
>
>
Hi Etsuro,
On 5/12/22 7:26 AM, Etsuro Fujita wrote:
I modified the patch to use the old language. Also, I fixed a typo
reported by Justin.
Attached is an updated patch. I'll commit the patch if no objections.
Thanks for reviewing and revising! I think this is much easier to read.
I made
On Tue, May 10, 2022, at 5:37 AM, Antonin Houska wrote:
> My understanding is that the rows/columns filtering is a way for the
> *publisher* to control which data is available to particular replica. From
> this point of view, the publication privileges would just make the control
> complete.
I
On 5/11/22 10:50 PM, Ian Lawrence Barwick wrote:
2022年5月12日(木) 11:46 Bruce Momjian :
On Thu, May 12, 2022 at 11:40:17AM +0900, Ian Lawrence Barwick wrote:
Looking at the release notes from the point of view of someone who has maybe
not been following the long-running debate on removing
On Wed, May 11, 2022 at 1:44 AM Bruce Momjian wrote:
>
> I have completed the first draft of the PG 15 release notes and you can
> see the results here:
>
> https://momjian.us/pgsql_docs/release-15.html
>
> The feature count is similar to recent major releases:
>
> release-10 195
On Wed, May 11, 2022 at 7:25 PM Etsuro Fujita wrote:
> One thing I noticed is this bit:
>
> -When multiple remote (sub)transactions are involved in a local
> -(sub)transaction, by default postgres_fdw commits
> -those remote (sub)transactions one by one when the local (sub)transaction
On Thu, May 12, 2022 at 2:25 PM Amit Kapila wrote:
>
> On Wed, May 11, 2022 at 2:02 AM Bruce Momjian wrote:
> >
> > On Tue, May 10, 2022 at 04:17:59PM -0400, Jonathan Katz wrote:
> > > On 5/10/22 11:44 AM, Bruce Momjian wrote:
> > > > I have completed the first draft of the PG 15 release notes
Hello,
I've noticed that
jsonb_hash_extended(jsonb_v,0) =
jsonb_hash_extended(jsonb_build_array(jsonb_v),0)
for any jsonb value jsonb_v.
AFAICT it happens because when iterating over a jsonb the hash function makes
no distinction between raw scalars and arrays (it doesn't inspect
Hi Dilip,
On Fri, Mar 4, 2022 at 11:07 AM Dilip Kumar wrote:
>
> On Mon, Feb 21, 2022 at 1:21 PM Dilip Kumar wrote:
> >
> > On Thu, Jan 6, 2022 at 1:43 PM Dilip Kumar wrote:
> >
> > 2) GetNewRelFileNode() will not loop for checking the file existence
> > > and retry with other relfilenode.
>
On Wed, May 11, 2022 at 2:02 AM Bruce Momjian wrote:
>
> On Tue, May 10, 2022 at 04:17:59PM -0400, Jonathan Katz wrote:
> > On 5/10/22 11:44 AM, Bruce Momjian wrote:
> > > I have completed the first draft of the PG 15 release notes and you can
> > > see the results here:
> > >
> > >
On Wed, May 11, 2022 at 7:39 PM Etsuro Fujita wrote:
> On Fri, May 6, 2022 at 7:08 PM Etsuro Fujita wrote:
> > > > On Wed, Apr 20, 2022 at 4:55 AM David Zhang
> > > > wrote:
> > > >> + * remote server in parallel at (sub)transaction end.
>
> > I noticed that the comment failed to mention
At Thu, 12 May 2022 16:03:50 +0900 (JST), Tatsuo Ishii
wrote in
> > At Thu, 12 May 2022 14:44:15 +0900 (JST), Tatsuo Ishii
> > wrote in
> BTW,
> > I'm going to try a slightly different steps..
>
> Can you please tell me What you actually did? I am afraid of facing
> similar problem if I
On Thu, May 12, 2022 at 12:15 PM Amit Kapila wrote:
>
> On Wed, May 11, 2022 at 12:55 PM houzj.f...@fujitsu.com
> wrote:
> >
> > On Wednesday, May 11, 2022 11:33 AM Amit Kapila
> > wrote:
> > >
> > > Fair enough, then we should go with a simpler approach to detect it in
> > > pgoutput.c
On Thu, 12 May 2022 at 08:03, Tatsuo Ishii wrote:
> > At Thu, 12 May 2022 14:44:15 +0900 (JST), Tatsuo Ishii <
> is...@sraoss.co.jp> wrote in
> >> >> Thank you for the info, but unfortunately it hasn't worked.
> >> >> I'm going to try a slightly different steps..
> >> >
> >> > And finally I
> At Thu, 12 May 2022 14:44:15 +0900 (JST), Tatsuo Ishii
> wrote in
>> >> Thank you for the info, but unfortunately it hasn't worked.
>> >> I'm going to try a slightly different steps..
>> >
>> > And finally I succeeded to clone from git.postgresql.org and to push a
>> > commit.
>>
>> Is it
On Wed, 2022-05-11 at 11:33 -0500, Justin Pryzby wrote:
> Also, EXPLAIN output currently looks like this:
>
> > Merge on ex_mtarget t (actual rows=0 loops=1)
> > Tuples Inserted: 0
> > Tuples Updated: 50
> > Tuples Deleted: 0
> > Tuples Skipped: 0
>
> Should the "zero" rows be elided
On Wed, May 11, 2022 at 12:55 PM houzj.f...@fujitsu.com
wrote:
>
> On Wednesday, May 11, 2022 11:33 AM Amit Kapila
> wrote:
> >
> > Fair enough, then we should go with a simpler approach to detect it in
> > pgoutput.c (get_rel_sync_entry).
>
> OK, here is the patch that try to check column list
On Thu, 12 May 2022 at 07:11, Kyotaro Horiguchi
wrote:
> At Thu, 12 May 2022 14:44:15 +0900 (JST), Tatsuo Ishii
> wrote in
> > >> Thank you for the info, but unfortunately it hasn't worked.
> > >> I'm going to try a slightly different steps..
> > >
> > > And finally I succeeded to clone from
On Tue, May 10, 2022 at 04:09:47PM +0900, Michael Paquier wrote:
> Well, what about the attached then? While looking at all the headers
> in the tree, I have noticed that __pg_log_level is not marked, but
> we'd better paint a PGDLLIMPORT also for it? This is getting used by
> pgbench for some
At Thu, 12 May 2022 14:44:15 +0900 (JST), Tatsuo Ishii
wrote in
> >> Thank you for the info, but unfortunately it hasn't worked.
> >> I'm going to try a slightly different steps..
> >
> > And finally I succeeded to clone from git.postgresql.org and to push a
> > commit.
>
> Is it
73 matches
Mail list logo
