On Tue, Jul 05, 2022 at 02:08:24PM -0500, Justin Pryzby wrote:
> ..since it tries to apply all the *.patch files to the master branch, one
> after
> another. For branches other than master, I suggest to name the patches *.txt
> or similar. Or, just focus for now on allowing upgrades *to*
On 2022-07-06 01:33:58 -0400, Tom Lane wrote:
> Andres Freund writes:
> > There's also a bunch of #ifdef __ia64__ in
> > src/backend/utils/misc/guc-file.c,
> > contrib/seg/segscan.c and contrib/cube/cubescan.c
>
> And all our other flex output files --- AFAICS that's part of flex's
> recipe and
Andres Freund writes:
> There's also a bunch of #ifdef __ia64__ in src/backend/utils/misc/guc-file.c,
> contrib/seg/segscan.c and contrib/cube/cubescan.c
And all our other flex output files --- AFAICS that's part of flex's
recipe and not under our control.
regards, tom
Hi,
0001 looks good to me.
There's a leftover itanium reference in a comment in
src/include/port/atomics/generic-msvc.h
There's also a bunch of #ifdef __ia64__ in src/backend/utils/misc/guc-file.c,
contrib/seg/segscan.c and contrib/cube/cubescan.c
Otherwise lgtm as well.
Greetings,
Andres
Hi,
On 2022-07-06 12:10:20 +0700, John Naylor wrote:
> diff --git a/src/common/jsonapi.c b/src/common/jsonapi.c
> index eeedc0645a..ad4858c623 100644
> --- a/src/common/jsonapi.c
> +++ b/src/common/jsonapi.c
> @@ -851,10 +851,26 @@ json_lex_string(JsonLexContext *lex)
> }
>
On Sat, Jun 25, 2022 at 8:05 AM Andres Freund wrote:
> > I tried your patch with:
> >
> > DROP TABLE IF EXISTS json_as_text;
> > CREATE TABLE json_as_text AS SELECT (SELECT json_agg(row_to_json(pd)) as t
> > FROM pg_description pd) FROM generate_series(1, 100);
> > VACUUM FREEZE json_as_text;
>
On Wed, Jul 6, 2022 at 3:26 PM Andres Freund wrote:
> On 2022-07-06 14:21:50 +1200, Thomas Munro wrote:
> > - * Notice that this means that we actually clear the word to set
> > - * the lock and set the word to clear the lock. This is the
> > - * opposite behavior from the SPARC
FYI, I confirmed the same patch applies and works OK for tags/REL_15_BETA2.
--
[postgres@CentOS7-x64 ~]$ psql --version
psql (PostgreSQL) 15beta2
[postgres@CentOS7-x64 ~]$ psql
psql (15beta2)
Type "help" for help.
postgres=# create subscription mysub connection 'blah' publication
mypub with
Thomas Munro writes:
> OK, here's a new attempt, this time leaving the hppa bits in. The
> main tricksy bit is where s_lock.h is simplified a bit by moving the
> fully inline GCC-only hppa support up a bit (it was handled a bit
> weirdly with some #undef jiggery-pokery before to share stuff
On Wed, Jul 06, 2022 at 02:48:07AM +, osumi.takami...@fujitsu.com wrote:
> On Tuesday, July 5, 2022 1:05 PM Amit Kapila wrote:
>> It can help if there is any bug-fix in the same code path or if some other
>> code
>> adjustment in the same area is required in the back branch.
>> I feel the
On Tue, Jul 5, 2022 at 7:20 PM Melih Mutlu wrote:
>
> I created a patch to reuse tablesync workers and their replication slots for
> more tables that are not synced yet. So that overhead of creating and
> dropping workers/replication slots can be reduced.
>
> Current version of logical
Michael Paquier writes:
> crake and drongo look unhappy after that, as of the upgrade from 9.6:
Yeah. I think that 08385ed26 fixes this, but we've had no new
reports yet :-(
regards, tom lane
Hi,
On 2022-07-06 14:21:50 +1200, Thomas Munro wrote:
> --- a/src/backend/port/hpux/tas.c.template
> +++ /dev/null
> @@ -1,40 +0,0 @@
> -/*
> - * tas() for HPPA.
> - *
> - * To generate tas.s using this template:
> - * 1. cc +O2 -S -c tas.c
> - * 2. edit tas.s:
> - * - replace the
On Wed, Jul 6, 2022 at 3:24 AM Jacob Champion wrote:
> On Thu, Jun 30, 2022 at 11:23 PM Amit Langote wrote:
> >
> > I will continue investigating what to do about points (1) and (2)
> > mentioned above and see if we can do away with using SQL in the
> > remaining cases.
>
> Hi Amit, looks like
On Tuesday, July 5, 2022 1:05 PM Amit Kapila wrote:
> On Tue, Jul 5, 2022 at 4:03 AM Peter Smith wrote:
> >
> > On Mon, Jul 4, 2022 at 10:29 PM Euler Taveira wrote:
> > >
> > > On Mon, Jul 4, 2022, at 5:37 AM, Amit Kapila wrote:
> > >
> > > Yeah, it seems we have overlooked this point. I think
On Tue, Jul 05, 2022 at 07:47:52PM -0400, Bruce Momjian wrote:
> On Tue, Jul 5, 2022 at 02:57:52PM -0700, Noah Misch wrote:
> > Since having too-permissive ACLs is usually symptom-free, I share your
> > forecast about the more-common question. Expect questions on mailing lists,
> >
On Wed, Jul 6, 2022 at 10:48 AM Andres Freund wrote:
>
> On 2022-07-06 10:25:02 +0900, Masahiko Sawada wrote:
> > > I think most of this could just be pgstat_reset_entry().
> >
> > I think pgstat_reset_entry() doesn't work for this case as it skips
> > resetting the entry if it doesn't exist.
>
>
At Tue, 5 Jul 2022 14:46:13 -0400, James Coleman wrote in
> On Tue, Jul 5, 2022 at 2:39 PM Robert Haas wrote:
> >
> > On Sat, Jun 4, 2022 at 8:59 AM James Coleman wrote:
> > > A quick background refresher: after promoting a standby rewinding the
> > > former primary requires that a checkpoint
On Tue, Jul 5, 2022 at 4:53 PM Tom Lane wrote:
> Thomas Munro writes:
> > On Mon, Jul 4, 2022 at 12:08 PM Tom Lane wrote:
> >> I would not stand in the way of dropping HP-UX and IA64 support as of
> >> v16. (I do still feel that HPPA is of interest, to keep us honest
> >> about spinlock
On Mon, Jul 4, 2022 at 9:42 PM Amit Kapila wrote:
>
> On Mon, May 30, 2022 at 11:13 AM Masahiko Sawada
> wrote:
> >
> > I've attached three POC patches:
> >
>
> I think it will be a good idea if you can add a short commit message
> at least to say which patch is proposed for HEAD and which one
On Tue, Jul 05, 2022 at 01:07:48PM -0400, Tom Lane wrote:
> It looks about ready to me. Pushed with some minor cosmetic
> adjustments.
crake and drongo look unhappy after that, as of the upgrade from 9.6:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake=2022-07-05%2020%3A48%3A21
On 2022-07-06 10:25:02 +0900, Masahiko Sawada wrote:
> > I think most of this could just be pgstat_reset_entry().
>
> I think pgstat_reset_entry() doesn't work for this case as it skips
> resetting the entry if it doesn't exist.
True - but a pgstat_get_entry_ref(create = true);
On Wed, 29 Jun 2022 at 12:59, David Rowley wrote:
> I noticed while doing some memory context related work that since we
> now use generation.c memory contexts for tuplesorts (40af10b57) that
> tuplesort_putindextuplevalues() causes memory "leaks" in the
> generation context due to
On Wed, Jul 6, 2022 at 6:52 AM Andres Freund wrote:
>
> Hi,
>
> On 2022-07-04 11:01:01 +0900, Masahiko Sawada wrote:
> > I've attached the patch, fix_drop_subscriptions_stats.patch, to fix it.
>
> LGTM. Unless somebody sees a reason not to, I'm planning to commit that to 15
> and HEAD.
>
>
> >
At Mon, 4 Jul 2022 10:49:33 +0200, Alvaro Herrera
wrote in
> > Mmm. My patch moves the point of failure of the scenario a bit but
> > still a little short. However, as my understanding, it seems like the
> > task of the PQpipelineSync()-PQgetResult() pair to consume the
> > CloseComplete. If
On Fri, Jul 01, 2022 at 09:58:52AM +0900, Michael Paquier wrote:
> I have kept things as I originally intended, and applied 0001 for the
> refactoring pieces.
And done as well with 0002. So we are good for this thread.
--
Michael
signature.asc
Description: PGP signature
... BTW, I thought of a consideration that we probably need some
answer for. As far as I can see, the patch assigns NodeTag values
sequentially in the order it sees the struct declarations in the
input files; an order that doesn't have a lot to do with our past
practice. The problem with that is
On Wed, Jul 6, 2022 at 11:37 AM Tom Lane wrote:
> qsort_interruptible
+1
FWIW compute_scalar_stats() was already noted as hot and perhaps a
candidate for specialisation (with more study needed), but
qsort_interruptible() seems like a sane use of ~4KB of text to me.
On Tue, Jul 5, 2022 at 5:20 PM Tom Lane wrote:
> "David G. Johnston" writes:
> > In passing, the authentication error examples use the phrase
> > "database user name" in a couple of locations. The word
> > database in both cases is both unusual and unnecessary for
> >
Hi,
On 2022-06-29 11:40:45 +1200, David Rowley wrote:
> On Sat, 18 Jun 2022 at 08:06, Andres Freund wrote:
> > I also attached my heavily-WIP patches for the ExprEvalStep issues, I
> > accidentally had only included a small part of the contents of the json fix.
>
> I've now looked at the 0003
"David G. Johnston" writes:
> In passing, the authentication error examples use the phrase
> "database user name" in a couple of locations. The word
> database in both cases is both unusual and unnecessary for
> understanding. The reference to user name means the one in/for the
Hi,
On 2022-07-04 13:07:50 +0200, Alvaro Herrera wrote:
> On 2022-Jul-01, Andres Freund wrote:
>
> > On 2022-07-01 19:55:16 +0200, Alvaro Herrera wrote:
> > > On 2022-Jul-01, Andres Freund wrote:
>
> > > > What is the reason for the || ProcDiePending || QueryCancelPending bit?
> > > > What
> >
"David G. Johnston" writes:
+ A function that's marked as dependent on an extension is dropped when the
+ extension is dropped, even if cascade is not specified.
+ dependency checking in restrict mode .
+ A function can depend upon multiple extensions, and will be dropped
Japin Li writes:
> [ v4-wal-level-documentation.patch ]
Hm, I don't care for the wording here:
+A precondition for using minimal WAL is to disable WAL archiving and
+streaming replication by setting archive_mode to
+off, and to
+0.
"Precondition" is an overly
On Tue, Jul 05, 2022 at 09:58:38AM -0700, Nathan Bossart wrote:
> Thanks! I wonder if we should add a comment in writeTimeLineHistoryFile()
> about possible concurrent use by a WAL receiver and the startup process and
> why that is okay.
Agreed. Adding an extra note at the top of the routine
On Tue, Jul 05, 2022 at 07:37:03PM -0400, Tom Lane wrote:
> Nonetheless, it'd be a good idea to use an interruptible sort in
> as many places as we can. If we don't mind YA copy of the qsort
> code, I'd be inclined to propose inventing qsort_interruptible
> which is like qsort_arg but also does
On Tue, Jul 5, 2022 at 02:57:52PM -0700, Noah Misch wrote:
> Since having too-permissive ACLs is usually symptom-free, I share your
> forecast about the more-common question. Expect questions on mailing lists,
> stackoverflow, etc. The right way to answer those questions is roughly this:
>
>
Andres Freund writes:
> I'm worried about this. Interrupting random qsorts all over seems like it
> could end up corrupting state. We do things like qsort in building snapshots
> etc. Are we confident that we handle interrupts reliably in all those places?
Nope ... see my followup just now.
I wrote:
>>> I modestly propose the attached. I'm not sure if it's
>>> okay to back-patch this, because maybe someone out there
>>> is relying on qsort() to be incapable of throwing an error
I thought I'd better try to check that, and I soon found several
places that *are* relying on qsort() to
Hi,
On 2022-07-01 19:19:11 -0400, Tom Lane wrote:
> That, um, piqued my interest. After a bit of digging,
> I modestly propose the attached. I'm not sure if it's
> okay to back-patch this, because maybe someone out there
> is relying on qsort() to be incapable of throwing an error
> --- but
Justin Pryzby writes:
> On Fri, Jul 01, 2022 at 07:19:11PM -0400, Tom Lane wrote:
>> That, um, piqued my interest. After a bit of digging,
>> I modestly propose the attached. I'm not sure if it's
>> okay to back-patch this, because maybe someone out there
>> is relying on qsort() to be
Robert Haas writes:
> On Tue, Jul 5, 2022 at 3:42 PM Nathan Bossart
> wrote:
>> On Tue, Jul 05, 2022 at 01:38:43PM -0400, Robert Haas wrote:
>>> I added the catversion bump, but left out the .po
>>> file changes, figuring it was better to let those files get updated
>>> via the normal process.
On 7/5/22 03:37, Bharath Rupireddy wrote:
On Mon, Jul 4, 2022 at 6:23 PM Drouvot, Bertrand wrote:
On 7/2/22 1:00 AM, Nathan Bossart wrote:
> Could we model this after fmgr_hook? The first argument in that hook
> indicates where it is being called from. This doesn't alleviate the need
> for
Andrew Dunstan writes:
> On 2022-07-05 Tu 15:17, Tom Lane wrote:
>> Hmm ... could you first look into why 09878cdd4 broke it? I'd supposed
>> that that was just detecting situations we must already have dealt with
>> in order for the pg_upgrade test to work, but crake's not happy.
> It's
On Tue, Jul 05, 2022 at 04:35:32PM -0400, Bruce Momjian wrote:
> On Tue, Jul 5, 2022 at 12:53:49PM -0700, Noah Misch wrote:
> > On Tue, Jul 05, 2022 at 02:35:39PM -0400, Bruce Momjian wrote:
> > > On Fri, Jul 1, 2022 at 06:21:28PM -0700, Noah Misch wrote:
> > > > Here's what I've been trying to
Hi,
On 2022-07-04 11:01:01 +0900, Masahiko Sawada wrote:
> I've attached the patch, fix_drop_subscriptions_stats.patch, to fix it.
LGTM. Unless somebody sees a reason not to, I'm planning to commit that to 15
and HEAD.
> I've also attached another PoC patch,
>
On 2022-07-05 Tu 15:17, Tom Lane wrote:
> Andrew Dunstan writes:
>> So it's taken us a year to discover the issue :-( Perhaps if we're going
>> to say we support upgrades back to 9.0 we should have some testing to be
>> assured we don't break it without knowing like this. I'll see if I can
>>
On Tue, Jul 5, 2022 at 3:42 PM Nathan Bossart wrote:
> On Tue, Jul 05, 2022 at 01:38:43PM -0400, Robert Haas wrote:
> > Hearing several votes in favor and none opposed, committed and
> > back-patched to v15.
>
> Thanks.
>
> > I added the catversion bump, but left out the .po
> > file changes,
On Tue, Jul 5, 2022 at 3:02 PM Andres Freund wrote:
> Yea. They might not be independent of where you get other dependencies from
> though. Does macports install headers / libraries into a path that's found by
> default? Or does one have to pass --with-includes / --with-libs to configure
> and
On Tue, Jul 5, 2022 at 4:33 AM Dilip Kumar wrote:
> I thought about this comment from Robert
> > that's not quite the same as either of those things. For example, in
> > tableam.h we currently say "This callback needs to create a new
> > relation filenode for `rel`" and how should that be changed
Hi,
There's a number of symbols that are exported by libpq that are also in
binaries (mostly via pgport). That strikes me as not great, because the
behaviour in those cases isn't particularly well defined / OS dependent /
linker option dependent.
How about renaming those functions, turning the
On Fri, Jul 1, 2022 at 6:42 AM Dilip Kumar wrote:
> > - I might be missing something here, but this isn't actually making
> > the relfilenode 56 bits, is it? The reason to do that is to make the
> > BufferTag smaller, so I expected to see that BufferTag either used
> > bitfields like
On Tue, Jul 5, 2022 at 12:53:49PM -0700, Noah Misch wrote:
> On Tue, Jul 05, 2022 at 02:35:39PM -0400, Bruce Momjian wrote:
> > On Fri, Jul 1, 2022 at 06:21:28PM -0700, Noah Misch wrote:
> > > Here's what I've been trying to ask: what do you think of linking to
> > >
On Tue, Jul 05, 2022 at 02:35:39PM -0400, Bruce Momjian wrote:
> On Fri, Jul 1, 2022 at 06:21:28PM -0700, Noah Misch wrote:
> > Here's what I've been trying to ask: what do you think of linking to
> > https://www.postgresql.org/docs/devel/ddl-schemas.html#DDL-SCHEMAS-PATTERNS
> > here? The
On Tue, Jul 5, 2022 at 11:51:31AM -0700, Peter Geoghegan wrote:
> On Tue, Jul 5, 2022 at 11:09 AM Bruce Momjian wrote:
> >
> > Actually, I was wrong. I thought that we only mentioned that we
> > computed a more agressive xid, but now see I was mentioning the _frozen_
> > xid. Reading the
On Tue, Jul 05, 2022 at 01:47:27PM +0200, Alvaro Herrera wrote:
> OK, I have adopted all your proposed changes, thanks for submitting in
> both forms. I did some more wordsmithing and pushed, to branches 12 and
> up. 11 fails 'make check', I think for lack of Docbook id tags, and I
> didn't want
On Sun, Jul 3, 2022 at 11:51 PM Thomas Munro wrote:
> On Wed, Jun 1, 2022 at 12:55 AM Robert Haas wrote:
> > OK, I have access to the box now. I guess I might as well leave the
> > crontab jobs enabled until the next time this happens, since Thomas
> > just took steps to improve the logging, but
On Tue, Jul 5, 2022 at 12:41 PM Peter Geoghegan wrote:
> Actually, commit 74cf7d46 was where pg_resetxlog/pg_resetwal's -u
> argument was first added, for use by pg_upgrade. That commit is only
> about a year old, and was only backpatched to 9.6.
I just realized that this thread was where that
On 2022-Jul-05, Roberto Mello wrote:
> You removed the reference to the functions' documentation at
> functions-admin-index choosing instead to duplicate a summarized
> version of the docs, and to boot getting the next block to be blobbed
> together with it.
Actually, my first instinct was to
On Tue, Jul 05, 2022 at 01:38:43PM -0400, Robert Haas wrote:
> Hearing several votes in favor and none opposed, committed and
> back-patched to v15.
Thanks.
> I added the catversion bump, but left out the .po
> file changes, figuring it was better to let those files get updated
> via the normal
On Tue, Jul 5, 2022 at 11:53 AM Andrew Dunstan wrote:
> > Sure enough, 8.4's pg_controldata doesn't print anything about
> > oldestXID, because that info wasn't there then.
> >
> > Given the lack of field complaints, it's probably not worth trying
> > to do anything to restore that capability.
On 2022-Jul-05, Robert Haas wrote:
> On Mon, Jul 4, 2022 at 5:27 AM Alvaro Herrera wrote:
> > On 2022-Jun-29, Robert Haas wrote:
> > > Why?
> >
> > The reason is that errmsg() marks the message for translation, and we
> > don't want to burden translators with messages that are of little
> >
Michael Paquier wrote on 7/5/2022 9:22 AM:
On Tue, Jun 28, 2022 at 02:14:53PM +0900, Michael Paquier wrote:
Well, the addition of cyrillic does not make necessary the removal of
SOUND RECORDING COPYRIGHT or the DEGREEs, that implies the use of a
dictionnary when manipulating the set of
Andrew Dunstan writes:
> So it's taken us a year to discover the issue :-( Perhaps if we're going
> to say we support upgrades back to 9.0 we should have some testing to be
> assured we don't break it without knowing like this. I'll see if I can
> coax crake to do that - it already tests back to
Hi,
On 2022-07-05 15:06:31 -0400, Tom Lane wrote:
> Andres Freund writes:
> > Yea. They might not be independent of where you get other dependencies from
> > though. Does macports install headers / libraries into a path that's found
> > by
> > default? Or does one have to pass --with-includes /
Hi,
On 2022-06-23 18:51:45 -0700, Andres Freund wrote:
> > Waiting for beta3 would a better move at this stage. Is somebody confident
> > enough in the patches proposed?
>
> 0001 is the one that needs to most careful analysis, I think. 0002 I'd be fine
> with pushing after reviewing it again.
On Tue, Jul 05, 2022 at 09:01:49AM +0300, Anton A. Melnikov wrote:
> On 01.07.2022 20:07, Justin Pryzby wrote:
> > It's silly to say that v9.2 will be supported potentially for a handful more
> > years, but that the upgrade-testing script itself doesn't support that, so
> > developers each have to
Andres Freund writes:
> Yea. They might not be independent of where you get other dependencies from
> though. Does macports install headers / libraries into a path that's found by
> default? Or does one have to pass --with-includes / --with-libs to configure
> and set PKG_CONFIG_PATH, like with
On 2022-07-05 Tu 14:36, Andres Freund wrote:
> Hi,
>
> On 2022-06-24 10:29:06 -0400, Andrew Dunstan wrote:
>> On 2022-06-23 Th 21:51, Andres Freund wrote:
>>> On 2022-06-23 16:38:12 +0900, Michael Paquier wrote:
On Tue, Jun 21, 2022 at 05:41:07PM -0400, Andrew Dunstan wrote:
> Yes, but
Hi,
On 2022-07-05 14:52:05 -0400, Tom Lane wrote:
> I dunno anything about the other steps Andres mentioned, but
> presumably they're independent of where you got meson from.
Yea. They might not be independent of where you get other dependencies from
though. Does macports install headers /
On Thu, Apr 7, 2022 at 11:29 AM Marko Tiikkaja wrote:
> I can help with review and/or other work here. Please give me a
> couple of weeks.
Hi Marko, did you get a chance to pick up this patchset? If not, no
worries; I can mark this RwF and we can try again in a future
commitfest.
Thanks,
On Tue, Jul 5, 2022 at 5:47 AM Alvaro Herrera
wrote:
> OK, I have adopted all your proposed changes, thanks for submitting in
> both forms. I did some more wordsmithing and pushed, to branches 12 and
> up. 11 fails 'make check', I think for lack of Docbook id tags, and I
> didn't want to waste
On 2022-07-05 Tu 12:59, Tom Lane wrote:
> Bruce Momjian writes:
>> This patch has been applied back to 9.6 and will appear in the next
>> minor release.
> I have just discovered that this patch broke pg_upgrade's ability
> to upgrade from 8.4:
>
> $ pg_upgrade -b ~/version84/bin -d ...
>
On Tue, Jul 5, 2022 at 2:52 PM Tom Lane wrote:
> Andres Freund writes:
> > On 2022-07-05 14:42:03 -0400, Robert Haas wrote:
> >> Since I'm a macports user I hope at some point we'll have directions
> >> for that as well as for homebrew.
>
> > But it looks like it's just
> > sudo port install
Andres Freund writes:
> On 2022-07-05 14:42:03 -0400, Robert Haas wrote:
>> Since I'm a macports user I hope at some point we'll have directions
>> for that as well as for homebrew.
> But it looks like it's just
> sudo port install meson
Yeah, that's what I did to install it locally. The
On Tue, Jul 5, 2022 at 11:09 AM Bruce Momjian wrote:
>
> Actually, I was wrong. I thought that we only mentioned that we
> computed a more agressive xid, but now see I was mentioning the _frozen_
> xid. Reading the commit, we do compute the multi-xid and store that too
> so I have updated the
On Tue, Jul 5, 2022 at 2:47 PM Tom Lane wrote:
> Robert Haas writes:
> > Is there anything intrinsic to the mechanism of operation of pg_rewind
> > that requires a timeline change, or could we just rewind within the
> > same timeline to an earlier LSN? In other words, maybe we could just
> >
Hi,
On 2022-07-05 14:42:03 -0400, Robert Haas wrote:
> On Sun, Jul 3, 2022 at 1:17 PM Andres Freund wrote:
> > Yea, I guess I should start a documentation section...
> >
> > I've only used homebrew on mac, but with that it should be something along
> > the
> > lines of
> >
> > brew install
Robert Haas writes:
> Is there anything intrinsic to the mechanism of operation of pg_rewind
> that requires a timeline change, or could we just rewind within the
> same timeline to an earlier LSN? In other words, maybe we could just
> remove this limitation of pg_rewind, and then perhaps it
On Tue, Jul 5, 2022 at 2:39 PM Robert Haas wrote:
>
> On Sat, Jun 4, 2022 at 8:59 AM James Coleman wrote:
> > A quick background refresher: after promoting a standby rewinding the
> > former primary requires that a checkpoint have been completed on the
> > new primary after promotion. This is
On Mon, Jul 4, 2022 at 5:27 AM Alvaro Herrera wrote:
> On 2022-Jun-29, Robert Haas wrote:
> > On Wed, Jun 29, 2022 at 9:26 AM Peter Eisentraut
> > wrote:
> > > On 28.06.22 21:10, Jeff Davis wrote:
> > > > + ereport(DEBUG1, errmsg("executing extension script: %s",
> > > > filename));
> > >
>
On Sun, Jul 3, 2022 at 1:17 PM Andres Freund wrote:
> Yea, I guess I should start a documentation section...
>
> I've only used homebrew on mac, but with that it should be something along the
> lines of
>
> brew install meson
> meson setup --buildtype debug -Dcassert=true build-directory
> cd
On Tue, Jul 5, 2022 at 12:56 PM Justin Pryzby wrote:
> My patch also leaves a 0 byte file around from initdb, which is harmless, but
> dirty.
>
> I've seen before where a bunch of 0 byte files are abandoned in an
> otherwise-empty tablespace, with no associated relation, and I have to "rm"
> them
On Sat, Jun 4, 2022 at 8:59 AM James Coleman wrote:
> A quick background refresher: after promoting a standby rewinding the
> former primary requires that a checkpoint have been completed on the
> new primary after promotion. This is correctly documented. However
> pg_rewind incorrectly reports
Hi,
On 2022-06-24 10:29:06 -0400, Andrew Dunstan wrote:
> On 2022-06-23 Th 21:51, Andres Freund wrote:
> > On 2022-06-23 16:38:12 +0900, Michael Paquier wrote:
> >> On Tue, Jun 21, 2022 at 05:41:07PM -0400, Andrew Dunstan wrote:
> >>> Yes, but I don't guarantee to have a fix in time for Beta2.
>
On Fri, Jul 1, 2022 at 06:21:28PM -0700, Noah Misch wrote:
> Here's what I've been trying to ask: what do you think of linking to
> https://www.postgresql.org/docs/devel/ddl-schemas.html#DDL-SCHEMAS-PATTERNS
> here? The release note text is still vague, and the docs have extensive
> coverage of
On Mon, Jul 4, 2022 at 9:20 AM Alvaro Herrera
wrote:
>
> [Some of] these additions are wrong actually. It says that autovacuum
> will not summarize new entries; but it does. If you just let the table
> sit idle, any autovacuum run that cleans the table will also summarize
> any ranges that
On Thu, Mar 31, 2022 at 11:53 PM Kyotaro Horiguchi
wrote:
> So this is that. v5 creates a regular snapshot.
This patch will need a quick rebase over 905c020bef9, which added
`extern` to several missing locations.
Thanks,
--Jacob
On Thu, Jun 30, 2022 at 11:23 PM Amit Langote wrote:
>
> I will continue investigating what to do about points (1) and (2)
> mentioned above and see if we can do away with using SQL in the
> remaining cases.
Hi Amit, looks like isolation tests are failing in cfbot:
On Wed, Jun 15, 2022 at 3:45 AM Christoph Heiss
wrote:
> `make check-world` reports no regressions.
cfbot is reporting a crash in contrib/btree_gist:
https://cirrus-ci.com/github/postgresql-cfbot/postgresql/commitfest/38/3686
Thanks,
--Jacob
On Sat, Jul 2, 2022 at 08:13:41PM -0400, Bruce Momjian wrote:
> On Fri, Jul 1, 2022 at 09:56:17AM -0700, Peter Geoghegan wrote:
> > On Fri, Jul 1, 2022 at 9:41 AM Bruce Momjian wrote:
> > > > It might be worth explaining the shift directly in the release notes.
> > > > The new approach is
Dean Rasheed writes:
> This was discussed previously in [1], and there seemed to be general
> consensus in favour of it, but no new patch emerged.
As I said in that thread, I'm not super enthused about this, but I was
clearly in the minority so I think it should go forward.
> Attached is a
On Fri, May 27, 2022 at 1:09 AM Amit Langote wrote:
> 0001 contains the mechanical changes of moving PartitionPruneInfo out
> of Append/MergeAppend into a list in PlannedStmt.
>
> 0002 is the main patch to "Optimize AcquireExecutorLocks() by locking
> only unpruned partitions".
This patchset
On Fri, Jul 1, 2022 at 5:50 PM Nathan Bossart wrote:
> On Fri, Jul 01, 2022 at 03:36:48PM +0200, Magnus Hagander wrote:
> > +1 for pg_checkpoint on that -- let's not make it longer than necessary.
> >
> > And yes, +1 for actually changing it. It's a lot cheaper to change it now
> > than it will
On Mon, Mar 21, 2022 at 8:15 PM Andres Freund wrote:
> Hi,
>
> On 2022-02-19 11:06:18 -0500, Melanie Plageman wrote:
> > v21 rebased with compile errors fixed is attached.
>
> This currently doesn't apply (mea culpa likely):
> http://cfbot.cputube.org/patch_37_3272.log
>
> Could you rebase?
Andrey Borodin writes:
> The patch is marked WiP, what is in progress as of now?
It looks about ready to me. Pushed with some minor cosmetic
adjustments.
regards, tom lane
Bruce Momjian writes:
> This patch has been applied back to 9.6 and will appear in the next
> minor release.
I have just discovered that this patch broke pg_upgrade's ability
to upgrade from 8.4:
$ pg_upgrade -b ~/version84/bin -d ...
Performing Consistency Checks
-
On Tue, Jul 05, 2022 at 10:19:49AM +0900, Michael Paquier wrote:
> On Thu, May 05, 2022 at 08:10:02PM +0900, Michael Paquier wrote:
>> I'd agree with removing all the callers at the end. pgrename() is
>> quite robust on Windows, but I'd keep the two checks in
>> writeTimeLineHistory(), as the
On Tue, Jul 05, 2022 at 12:43:54PM -0400, Robert Haas wrote:
> On Sat, Jul 2, 2022 at 11:49 AM Justin Pryzby wrote:
> > I suppose it's like Bruce said, here.
> >
> > https://www.postgresql.org/message-id/20210601140949.GC22012%40momjian.us
>
> Well, I feel dumb. I remember reading that email
On Sat, Jul 2, 2022 at 11:49 AM Justin Pryzby wrote:
> I suppose it's like Bruce said, here.
>
> https://www.postgresql.org/message-id/20210601140949.GC22012%40momjian.us
Well, I feel dumb. I remember reading that email back when Bruce sent
it, but it seems that it slipped out of my head between
1 - 100 of 148 matches
Mail list logo
