On Mon, Oct 3, 2022 at 10:13 PM Jeff Davis wrote:
> Take the case where you load a lot of data in one transaction. After
> the loading transaction finishes, those new pages will soon be marked
> all-visible.
>
> In the future, vacuum runs will have to decide what to do. If a vacuum
> decides to
On 2022-10-02 Su 12:49, Andres Freund wrote:
>
> 2) Use a lockfile containing a pid to protect the choice of a port within a
>build directory. Before accepting a port get_free_port() would check if the
>a lockfile exists for the port and if so, if the test using it is still
>alive.
Hi,
It looks like there's an opportunity to replace explicit WAL file
parsing code with XLogFromFileName() in pg_resetwal.c. This was not
done then (in PG 10) because the XLogFromFileName() wasn't accepting
file size as an input parameter (see [1]) and pg_resetwal needed to
use WAL file size from
On 9/13/22 16:40, Andrey Lepikhov wrote:
On 5/9/2022 12:22, Richard Guo wrote:
On Fri, Sep 2, 2022 at 7:09 PM Andrey Lepikhov
mailto:a.lepik...@postgrespro.ru>> wrote:
To resolve both issues, lower outer join passes through pull_sublinks_*
into flattening routine (see attachment).
I've added
On Wed, Sep 28, 2022 at 12:04 PM Peter Smith wrote:
>
> On Wed, Sep 28, 2022 at 2:21 AM Tom Lane wrote:
> >
> > Peter Smith writes:
> > > Enums index a number of the GUC tables. This all relies on the
> > > elements being carefully arranged to be in the same order as those
> > > enums. There
On Mon, 2022-10-03 at 20:11 -0700, Peter Geoghegan wrote:
> True. Though I think that a strong bias in the direction of advancing
> relfrozenxid by some amount (not necessarily by very many XIDs) still
> makes sense, especially when we're already freezing aggressively.
Take the case where you
The problem is that you're not closing the
Thank you for the reviews and comments.
I closed the so that the problem should be fixed now.
Regards,
--
Ken Kato
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATIONdiff --git
On Mon, Oct 03, 2022 at 10:29:38PM +0200, Tomas Vondra wrote:
> On 10/3/22 21:25, Jaime Casanova wrote:
> > On Mon, Oct 03, 2022 at 07:53:34PM +0200, Tomas Vondra wrote:
> >> On 9/29/22 08:53, Jaime Casanova wrote:
> >>> ...
> >>>
> >>> Just found one more ocurrance of this one with this index
On Mon, Oct 03, 2022 at 08:05:57AM -0300, Ranier Vilela wrote:
> Em seg., 3 de out. de 2022 às 05:01, Masahiko Sawada
> escreveu:
>> On Fri, Sep 30, 2022 at 9:08 AM Ranier Vilela wrote:
>>> 1. Avoid useless reassigning var _logsegno
>> (src/backend/access/transam/xlog.c)
>>> Commit 7d70809 left
On Tue, Oct 4, 2022 at 12:54 PM Tom Lane wrote:
> Amit Langote writes:
> > On Thu, Jul 28, 2022 at 6:18 AM Tom Lane wrote:
> >> ... One more thing: maybe we should rethink where to put
> >> extraUpdatedCols. Between the facts that it's not used for
> >> actual permissions checks, and that it's
Amit Langote writes:
> On Thu, Jul 28, 2022 at 6:18 AM Tom Lane wrote:
>> ... One more thing: maybe we should rethink where to put
>> extraUpdatedCols. Between the facts that it's not used for
>> actual permissions checks, and that it's calculated by the
>> rewriter not parser, it doesn't seem
On Thu, Jul 28, 2022 at 6:18 AM Tom Lane wrote:
> ... One more thing: maybe we should rethink where to put
> extraUpdatedCols. Between the facts that it's not used for
> actual permissions checks, and that it's calculated by the
> rewriter not parser, it doesn't seem like it really belongs
> in
On Mon, Oct 03, 2022 at 06:29:32PM +0100, Dagfinn Ilmari Mannsåker wrote:
> vignesh C writes:
>> +else if (TailMatchesCS("\\dRp*"))
>> +COMPLETE_WITH_QUERY(Query_for_list_of_publications[0].query);
>> +else if (TailMatchesCS("\\dRs*"))
>> +
Hi,
On 2022-09-30 15:35:26 -0700, Andres Freund wrote:
> I was thinking of starting at least the following threads / CF entries once a
> few of the remaining things are resolved:
>
> - PGXS compatibility, plus related autoconf simplification patches
> - pkg-config files for building postgres
On Mon, Oct 3, 2022 at 5:41 PM Jeff Davis wrote:
> I like this general approach. The existing GUCs have evolved in a
> confusing way.
Thanks for taking a look!
> > For the most part the
> > skipping/freezing strategy stuff has a good sense of what matters
> > already, and shouldn't need to be
On Tue, Oct 04, 2022 at 02:27:09PM +1300, David Rowley wrote:
> On Tue, 30 Aug 2022 at 17:44, Justin Pryzby wrote:
> > Would you check if any of these changes are good enough ?
>
> I looked through v5.txt and modified it so that the fix for the shadow
> warnings are more aligned to the
Dear Önder,
> As far as I can see this patch is mostly useful for detecting the failures
> on the initial remote command. This is especially common when the remote
> server does a failover/switchover and postgres_fdw uses a cached connection
> to access to the remote server.
Sounds reasonable.
On Tue, 30 Aug 2022 at 17:44, Justin Pryzby wrote:
> Would you check if any of these changes are good enough ?
I looked through v5.txt and modified it so that the fix for the shadow
warnings are more aligned to the spreadsheet I created.
I also fixed some additional warnings which leaves just 5
On Thu, 2022-09-08 at 13:23 -0700, Peter Geoghegan wrote:
> The new patch unifies the concept of antiwraparound
> VACUUM with the concept of aggressive VACUUM. Now there is only
> antiwraparound and regular VACUUM (uh, barring VACUUM FULL). And now
> antiwraparound VACUUMs are not limited to
On Thu, 29 Sept 2022 at 18:30, David Rowley
wrote:
> Does anyone have any opinions on this?
Hi,
Revisiting my work on reducing memory consumption, I found this patch left
out.
I'm not sure I can help.
But basically I was able to write and read the block size, in the chunk.
Could it be the case
Hi,
while working on installcheck support with meson, that currently running
installcheck-world fails regularly with meson and occasionally with make.
A way to quite reliably reproduce this with make is
make -s -j48 -C contrib/ USE_MODULE_DB=1 installcheck-adminpack-recurse
Sorry, I didn't not tried building using meson.
One line was fixed in the new test module's meson.build.
--
Nikita Glukhov
Postgres Professional:http://www.postgrespro.com
The Russian Postgres Company
errorsafe_functions_v01.tgz
Description: application/compressed-tar
Hi,
Splitting out to a new thread. Started at
https://www.postgresql.org/message-id/20220915051754.ccx35szetbvnjv7g%40awork3.anarazel.de
On 2022-09-14 22:17:54 -0700, Andres Freund wrote:
> On 2022-09-15 01:10:16 -0400, Tom Lane wrote:
> > I realize that there are people for whom other
Hi hackers!
Cfbot failed in meson build with previous patchsets, so I've rebased them
onto the latest master and added necessary meson build info.
Patchset consists of:
v19-0001-toaster-interface.patch - Pluggable TOAST API interface along with
reference TOAST mechanics - new API is introduced
On Mon, Oct 3, 2022 at 2:41 PM Andres Freund wrote:
> Hi,
>
> On 2022-10-03 12:16:12 -0700, Andres Freund wrote:
> > I haven't yet run through the whole regression test with an assert
> enabled
> > llvm because an assert-enabled llvm is *SLOW*, but it got through the
> first
> > few parallel
Hi,
On 2022-10-03 12:16:12 -0700, Andres Freund wrote:
> I haven't yet run through the whole regression test with an assert enabled
> llvm because an assert-enabled llvm is *SLOW*, but it got through the first
> few parallel groups ok. Using an optimized llvm 15, all tests pass with
>
Hi,
On 2022-10-03 19:40:30 +0200, Matthias van de Meent wrote:
> On Mon, 3 Oct 2022, 19:01 Andres Freund, wrote:
> > Random idea: xl_prev is large. Store a full xl_prev in the page header, but
> > only store a 2 byte offset from the page header xl_prev within each record.
>
> With that small
On 10/3/22 21:25, Jaime Casanova wrote:
> On Mon, Oct 03, 2022 at 07:53:34PM +0200, Tomas Vondra wrote:
>> On 9/29/22 08:53, Jaime Casanova wrote:
>>> ...
>>>
>>> Just found one more ocurrance of this one with this index while an
>>> autovacuum was running:
>>>
>>> """
>>> CREATE INDEX
Hi, hackers!
Trying to implement error handling behavior required by SQL/JSON, we
came to agreement that we need special infrastructure for catching
errors in the input and type conversion functions without heavy-weight
things like subtransactions. See the whole thread "SQL/JSON features
for
David Rowley writes:
> Andres did mention to me off-list about perhaps adding a boolean field
> to FunctionCallInfoBaseData to indicate if the return value can be
> assumed to be in CurrentMemoryContext. I feel like that might be
> quite a bit of work to go and change all functions to ensure
On Mon, Oct 03, 2022 at 07:53:34PM +0200, Tomas Vondra wrote:
> On 9/29/22 08:53, Jaime Casanova wrote:
> > ...
> >
> > Just found one more ocurrance of this one with this index while an
> > autovacuum was running:
> >
> > """
> > CREATE INDEX bt_f8_heap_seqno_idx
> > ON public.bt_f8_heap
Hi,
On 2022-10-03 18:34:18 +1300, Thomas Munro wrote:
> One option I thought about as a stopgap measure is to use
> LLVMContextSetOpaquePointers(context, false) to turn the new code
> paths off, but it doesn't seem to work for me and I couldn't figure
> out why yet (it still aborts -- probably
I wrote:
> Ugh. I think we'd better fix that before 15.0, else somebody may
> think this is the new intended behavior and raise compatibility
> concerns when we fix it. I will see if I can squeeze it in before
> this afternoon's 15rc2 wrap.
Pushed after making some corrections.
Given the time
> I think we can probably prototype a callback hook for approach (1)
> pretty quickly. (2) is a lot more work and investigation, but it's
> work that I'm interested in doing (when I get the time). I think there
> are other very good reasons to consider a third-party SASL library,
> and some good
On 9/29/22 08:53, Jaime Casanova wrote:
> ...
>
> Just found one more ocurrance of this one with this index while an
> autovacuum was running:
>
> """
> CREATE INDEX bt_f8_heap_seqno_idx
> ON public.bt_f8_heap
> USING brin (seqno float8_minmax_multi_ops);
> """
> Attached is a
On Mon, 3 Oct 2022, 19:01 Andres Freund, wrote:
>
> Hi,
>
> On 2022-10-03 08:12:39 -0400, Robert Haas wrote:
> > On Fri, Sep 30, 2022 at 8:20 PM Andres Freund wrote:
> > > I think it'd be interesting to look at per-record-type stats between two
> > > equivalent workload, to see where practical
vignesh C writes:
> Hi,
>
> There were a couple of tab completion issues present:
> a) \dRp and \dRs tab completion displays tables instead of displaying
> publications and subscriptions.
> b) "ALTER ... OWNER TO" does not include displaying of CURRENT_ROLE,
> CURRENT_USER and SESSION_USER.
>
>
On 10/3/22 16:05, Tom Lane wrote:
> "Jonathan S. Katz" writes:
>> Based on the above discussion, the RMT asks for a revert of db0d67db2 in
>> the v15 release. The RMT also recommends a revert in HEAD but does not
>> have the power to request that.
>
> Roger, I'll push these shortly.
>
Hi,
On 2022-10-03 08:12:39 -0400, Robert Haas wrote:
> On Fri, Sep 30, 2022 at 8:20 PM Andres Freund wrote:
> > I think it'd be interesting to look at per-record-type stats between two
> > equivalent workload, to see where practical workloads suffer the most
> > (possibly with fpw=off, to make
"Daniel Verite" writes:
> The psql improvement in v15 to output multiple result sets does not
> behave as one might expect with \g: the output file or program
> to pipe into is opened/closed on each result set, overwriting the
> previous ones in the case of \g file.
Ugh. I think we'd better fix
[ Just for the archives' sake at this point, in case somebody has
another go at this feature. ]
I wrote:
> ... I'm now discovering that the code I'd hoped to salvage in
> pathkeys.c (get_useful_group_keys_orderings and related) has its very own
> bugs. It's imagining that it can rearrange a
Hi,
On Mon, Oct 03, 2022 at 06:30:17PM +0300, Олег Целебровский wrote:
>
> Hello, here's my take on masking data when using pg_dump
>
> The main idea is using PostgreSQL functions to replace data during a SELECT.
> When table data is dumped SELECT a,b,c,d ... from ... query is generated, the
>
Hello, here's my take on masking data when using pg_dump
The main idea is using PostgreSQL functions to replace data during a SELECT.
When table data is dumped SELECT a,b,c,d ... from ... query is generated, the
columns that are marked for masking are replaced with result of functions on
Hi,
There were a couple of tab completion issues present:
a) \dRp and \dRs tab completion displays tables instead of displaying
publications and subscriptions.
b) "ALTER ... OWNER TO" does not include displaying of CURRENT_ROLE,
CURRENT_USER and SESSION_USER.
The attached patch has the changes
Hi Hayato Kuroda,
> If the checking function is called not periodically but GetConnection(),
> it means that the health of foreign servers will be check only when remote
> connections are used.
> So following workload described in [1] cannot handle the issue.
>
> BEGIN --- remote operations---
Hi,
We are planning a PostgreSQL 15 RC2 release for October 6, 2022. We are
releasing a second release candidate due to the revert of an
optimization around the GROUP BY clause.
We are still planning the PostgreSQL 15 GA release for October 13, but
we may push this to October 20 based on
"Jonathan S. Katz" writes:
> Based on the above discussion, the RMT asks for a revert of db0d67db2 in
> the v15 release. The RMT also recommends a revert in HEAD but does not
> have the power to request that.
Roger, I'll push these shortly.
regards, tom lane
On 10/2/22 8:45 PM, Michael Paquier wrote:
On Sun, Oct 02, 2022 at 02:11:12PM -0400, Tom Lane wrote:
"Jonathan S. Katz" writes:
OK. For v15 I am heavily in favor for the least risky approach given the
point we are at in the release cycle. The RMT hasn’t met yet to discuss,
but from re-reading
On Thu, Sep 29, 2022 at 10:38 PM Bharath Rupireddy
wrote:
>
> Please review the v4 patch.
I used valgrind for testing. Without patch, there's an obvious memory
leak [1], with patch no memory leak.
I used ALLOCSET_START_SMALL_SIZES instead of ALLOCSET_DEFAULT_SIZES
for backup memory context so
The date of the current commitfest is over, here is the current status of
the "September 2022 commitfest."
There were 296 patches in the commitfest and 58 were get committed.
Total: 296.
Needs review: 155.
Waiting on Author: 41.
Ready for Committer: 19.
Committed: 58.
Moved to next CF: 8.
Em seg., 3 de out. de 2022 às 09:40, Julien Rouhaud
escreveu:
> On Mon, Oct 03, 2022 at 09:05:34AM -0300, Ranier Vilela wrote:
> > >Please let us know if you have any questions. We're excited that we are
> > >very close to officially releasing PostgreSQL 15.
> > Hi, forgive my ignorance.
> >
Em seg., 3 de out. de 2022 às 09:39, Justin Pryzby
escreveu:
> On Mon, Oct 03, 2022 at 09:05:34AM -0300, Ranier Vilela wrote:
> > >Please let us know if you have any questions. We're excited that we are
> > >very close to officially releasing PostgreSQL 15.
> > Hi, forgive my ignorance.
> > What
On Fri, 30 Sep 2022 16:11:09 -0700
Zhihong Yu wrote:
> On Fri, Sep 30, 2022 at 3:30 PM Jehan-Guillaume de Rorthais
> wrote:
...
>
> +* Self-Foreign keys are ignored as the index was preliminary
> created
>
> preliminary created -> primarily created
Thank you! This is fixed and
On Mon, Oct 03, 2022 at 09:05:34AM -0300, Ranier Vilela wrote:
> >Please let us know if you have any questions. We're excited that we are
> >very close to officially releasing PostgreSQL 15.
> Hi, forgive my ignorance.
> What are the rules for a commit to be included in the release notes?
> Does
On Mon, Oct 03, 2022 at 09:05:34AM -0300, Ranier Vilela wrote:
> >Please let us know if you have any questions. We're excited that we are
> >very close to officially releasing PostgreSQL 15.
> Hi, forgive my ignorance.
> What are the rules for a commit to be included in the release notes?
> Does
I attached a new patch which does the following:
1. adds tap tests
2. adds random_seed parameter to libpq (required for tap tests)
3. frees conn->loadbalance in freePGConn
4. add more expansive docs on the feature its behaviour
Apart from bike shedding on the name of the option I think it's
On Fri, Sep 30, 2022 at 8:20 PM Andres Freund wrote:
> I think it'd be interesting to look at per-record-type stats between two
> equivalent workload, to see where practical workloads suffer the most
> (possibly with fpw=off, to make things more repeatable).
I would expect, and Dilip's results
>Please let us know if you have any questions. We're excited that we are
>very close to officially releasing PostgreSQL 15.
Hi, forgive my ignorance.
What are the rules for a commit to be included in the release notes?
Does it need to be explicitly requested?
Why is the commit 8cb2a22
Hi
On Fri, 30 Sept 2022 at 18:58, Andres Freund wrote:
> Hi,
>
> On 2022-09-30 17:58:31 +0200, Vik Fearing wrote:
> > On 9/7/22 12:03, Dave Page wrote:
> > > Here's a v4 patch. This reverts to using
> > > GetCurrentTransactionStopTimestamp() for the last_scan times, and will
> > > set
Hi Takamichi,
Thanks for your reviews.
I addressed your reviews, please find the attached patch.
osumi.takami...@fujitsu.com , 16 Eyl 2022 Cum,
16:51 tarihinde şunu yazdı:
> (1) whitespace issues
>
Fixed
(2) Suggestion to update another general description about the subscription
>
> Kindly
Em seg., 3 de out. de 2022 às 05:01, Masahiko Sawada
escreveu:
> On Fri, Sep 30, 2022 at 9:08 AM Ranier Vilela wrote:
> >
> > Hi.
> >
> > There are assorted fixes to the head branch.
> >
> > 1. Avoid useless reassigning var _logsegno
> (src/backend/access/transam/xlog.c)
> > Commit 7d70809 left
Dear Önder,
Thank you for being interest to my patch! Your suggestions will be included to
newer version.
> In other words, what is the trade-off for calling
> pgfdw_connection_check_internal() inside GetConnection() when we are about
> to use a "cached" connection? I think that might simplify
Hi,
On 10/3/22 9:46 AM, Michael Paquier wrote:
On Fri, Sep 30, 2022 at 07:51:29PM +0200, Drouvot, Bertrand wrote:
Agree that it could be simplified, thanks for the hints!
Attached a simplified version.
While looking at that, I have noticed that it is possible to reduce
the number of
Hi Hayato Kuroda,
Thanks for the patch. I think there are some non-fdw extensions out there
which could benefit from this logic. That's why I want to first learn some
more about high-level design/goals of the patch a little more.
+/*
> + * Call callbacks for checking remote servers.
> + */
>
On Mon, Oct 3, 2022 at 5:15 PM Michael Paquier wrote:
>
> On Fri, Sep 16, 2022 at 10:55:53AM +0900, Kyotaro Horiguchi wrote:
> > Putting an arbitrary upper-bound on the number of subxids to print
> > might work? I'm not sure how we can determine the upper-bound, though.
>
> You could hardcode it
On Fri, Sep 16, 2022 at 10:55:53AM +0900, Kyotaro Horiguchi wrote:
> Putting an arbitrary upper-bound on the number of subxids to print
> might work? I'm not sure how we can determine the upper-bound, though.
You could hardcode it so as it does not blow up the whole view, say
20~30. Anyway, I
On Fri, Sep 30, 2022 at 9:08 AM Ranier Vilela wrote:
>
> Hi.
>
> There are assorted fixes to the head branch.
>
> 1. Avoid useless reassigning var _logsegno (src/backend/access/transam/xlog.c)
> Commit 7d70809 left a little oversight.
> XLByteToPrevSeg and XLByteToSeg are macros, and both assign
I applied this patch in my local environment and would like to reviewthe same
before 14-October-2022 with some test data
postgres=# \d pg_stat_all_tables
View "pg_catalog.pg_stat_all_tables"
Column | Type | Collation | Nullable |
Dear Andres,
> This seems to reliably fail on windows. See
Thanks for reporting. Actually this feature cannot be used on Windows machine.
To check the status of each socket that connects to the foreign server,
the socket event WL_SOCKET_CLOSED is used.
The event is only enabled on some OSes, and
On Fri, Sep 30, 2022 at 07:51:29PM +0200, Drouvot, Bertrand wrote:
> Agree that it could be simplified, thanks for the hints!
>
> Attached a simplified version.
While looking at that, I have noticed that it is possible to reduce
the number of connection attempts (for example no need to re-test
Hi,
On Mon, Sep 26, 2022 at 6:02 AM Peter Eisentraut <
peter.eisentr...@enterprisedb.com> wrote:
> On 24.09.22 20:09, Andres Freund wrote:
> > On 2022-09-24 13:52:29 -0400, Tom Lane wrote:
> >> ... btw, shouldn't the CF entry [1] get closed now?
> >
> > Unfortunately not - there's quite a few
On Mon, Oct 03, 2022 at 04:03:12PM +1300, Thomas Munro wrote:
> So I think that setting is_lnk = false is good enough here. Do
> you see a hole in it?
I cannot think on one, on top of my head. Thanks for the
explanation.
--
Michael
signature.asc
Description: PGP signature
72 matches
Mail list logo
