Hi
so 14. 1. 2023 v 22:56 odesílatel Mikhail Gribkov
napsal:
> Hi Pavel,
>
> Thanks for pointing out the tests. I completely agree that using an
> exception inside on-login trigger should be tested. It cannot be done via
> regular *.sql/*.out regress tests, thus I have added another perl test
On 03.01.2023 at 01:00, Karl O. Pinc wrote:
Attached is a patch: contrib_v1.patch
It modifies Appendix F, the contrib directory.
Review:
The patch applies cleanly (1334b79a35 - 2023-01-14 18:05:09 +0900).
It adds a brief explanatory part to the headers of all contrib modules
which I
On Fri, Jan 13, 2023 at 5:33 PM vignesh C wrote:
> Adding support for CREATE/ALTER/DROP Publication ddl deparsing.
> The attached v61 patch has the changes for the same.
>
Hi Vignesh,
this doesn't seem to compile:
gcc -std=gnu99 -Wall -Wmissing-prototypes -Wpointer-arith
On Sun, 15 Jan 2023 at 06:02, Robert Haas wrote:
>
> On Sat, Jan 14, 2023 at 2:26 AM vignesh C wrote:
> > I'm not sure if any work is left here, if there is nothing more to do,
> > can we close this?
>
> There's a discussion on another thread about some follow-up
> documentation adjustments, but
On Sat, Jan 14, 2023 at 6:12 PM David G. Johnston <
david.g.johns...@gmail.com> wrote:
> While the function owner has their own pg_db_role_setting preference for
> this setting,
>
Should we be pointing out that if the role with CREATEROLE isn't also a
LOGIN role then there is little point to
Without this patch:
$ mkdir 000; chmod 000 ./000
$ strace -fe open,stat ./tmp_install/usr/local/pgsql/bin/pg_restore -vvv -l
./000
...
pg_restore: allocating AH for ./000, format 0
pg_restore: attempting to ascertain archive format
stat("./000", {st_mode=S_IFDIR|000, st_size=4096, ...}) = 0
On Sat, Jan 14, 2023 at 5:31 PM Robert Haas wrote:
> On Fri, Jan 13, 2023 at 8:29 PM David G. Johnston
> wrote:
> >> The point of the security definer section is to explain how to safely
> write
> >> security definer functions that you grant to less privileged users
> >
> > Yeah, we are really
On Sat, Jan 14, 2023 at 2:26 AM vignesh C wrote:
> I'm not sure if any work is left here, if there is nothing more to do,
> can we close this?
There's a discussion on another thread about some follow-up
documentation adjustments, but feel free to close the CF entry for
this patch.
--
Robert
On Fri, Jan 13, 2023 at 8:29 PM David G. Johnston
wrote:
>> The point of the security definer section is to explain how to safely write
>> security definer functions that you grant to less privileged users
>
> Yeah, we are really good at "how".
>
> +If the security definer function intends to
I've attached a patch for $SUBJECT, which allows us to remove a use of the
unconstify macro in basic_archive. This is just a pet peeve, but maybe it
bothers others, too.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
diff --git a/contrib/basic_archive/basic_archive.c
On Sat, Jan 14, 2023 at 10:40:40AM +0100, Gilles Darold wrote:
> Nathan, please confirm and fix the status of this commit fest entry.
Yes, thank you for taking care of this. I believe the only changes in this
patch that didn't make it into ff9618e are the following documentation
adjustments.
Hi Pavel,
Thanks for pointing out the tests. I completely agree that using an
exception inside on-login trigger should be tested. It cannot be done via
regular *.sql/*.out regress tests, thus I have added another perl test to
authentication group doing this.
Attached v36 patch contains this test
On Sun, Jan 08, 2023 at 01:45:25PM -0600, Justin Pryzby wrote:
> On Thu, Dec 22, 2022 at 11:08:59AM -0600, Justin Pryzby wrote:
> > There's a couple of lz4 bits which shouldn't be present in 002: file
> > extension and comments.
> BTW I noticed that cfdopen() was accidentally committed to
vignesh C writes:
> The patch does not apply on top of HEAD as in [1], please post a rebased
> patch:
Yeah, sideswiped by 3c6fc5820 apparently. No substantive change needed.
regards, tom lane
diff --git a/contrib/postgres_fdw/deparse.c b/contrib/postgres_fdw/deparse.c
Ok, I've updated the patch to handle every function that inputs or
outputs intervals, as well as added some tests. In the process I
noticed that some of the existing date/timestamp/timestamptz don't
handle infinite values properly. For example,
postgres=# SELECT age('infinity'::timestamp);
age
On Tue, Jan 10, 2023 at 11:28:36AM +, Hari krishna Maddileti wrote:
> Thanks Team for showing interest.
>
> Please find the attached patch, which uses the same approach as mentioned in
> previous email to implement input functions to parse pg_distinct,
> pg_dependency and pg_mcv_list
Hi,
On 2023-01-14 00:48:52 -0800, Jeff Davis wrote:
> On Mon, 2022-12-26 at 14:20 +0530, Bharath Rupireddy wrote:
> > Please review the attached v2 patch further.
>
> I'm still unclear on the performance goals of this patch. I see that it
> will reduce syscalls, which sounds good, but to what
I wrote:
> OK, I'll take a look at that and make a new draft.
Here's version 2, incorporating your suggestions and with some
further work to make it handle 9.2 fully. I think this could
be committable so far as HEAD is concerned, though I still
need to make versions of AdjustUpgrade.pm for the
On Fri, 2023-01-13 at 11:57 -0800, Peter Geoghegan wrote:
> You're adding a layer of indirection that's going to set things up
> for
> later patches that add a layer of indirection for version ICU
> libraries (and even libc itself), and some of the details only make
> sense in that context. This
Andrew Dunstan writes:
> On 2023-01-13 Fr 19:48, Tom Lane wrote:
>> Attached are two patches, one for PG git and one for the buildfarm
>> client, that create a working POC for this approach.
> OK, we've been on parallel tracks (sorry about that). Let's run with
> yours, as it covers more ground.
>
> I agree with your idea and try to implement it and will soon attach a
> patch with a solution.
>
Additionally, if those OR constants repeat you'll see ...
If all constants are the same value, fine
explain select * from x where ((ID = 1) OR (ID = 1) OR (ID = 1));
Index Only Scan using x_id on x
I agree with your idea and try to implement it and will soon attach a
patch with a solution.
I also have a really practical example confirming that such optimization
can be useful.
A query was written that consisted of 5 conditions due to the fact
that the ORM framework couldn't work
On 2023-01-13 Fr 19:48, Tom Lane wrote:
> This is a followup to the discussion at [1], in which we agreed that
> it's time to fix the buildfarm client so that knowledge about
> cross-version discrepancies in pg_dump output can be moved into
> the community git tree, making it feasible for people
On Thu, Jan 12, 2023 at 5:55 AM Matthias van de Meent
wrote:
> On Thu, 12 Jan 2023 at 11:59, Gurjeet Singh wrote:
> > ... defining an operator
> > gives you many additional features that the planner can use to
> > optimize your query differently, which it can't do with functions. See
> > the
> Looks like you're right ; show_all_settings() elides settings marked
> "noshow".
>
> Do you know how you'd implement a fix ?
I could think of the following options.
Option-1 is, expose a function like pg_settings_get_no_show_all()
which just returns the parameters which are just listed as
Hi!
Fails due to recent changes. Working on it.
On Sat, Jan 14, 2023 at 9:56 AM vignesh C wrote:
> On Sun, 8 Jan 2023 at 01:40, Nikita Malakhov wrote:
> >
> > Hi!
> >
> > Thank you for your attention.
> > I've rebased the patchset onto the latest master (from 07.01), but the
> second part is
On Fri, Jan 13, 2023 at 3:44 PM houzj.f...@fujitsu.com
wrote:
>
> On Friday, January 13, 2023 1:43 PM Masahiko Sawada
> wrote:
> > On Thu, Jan 12, 2023 at 9:34 PM houzj.f...@fujitsu.com
> > wrote:
In GetLogicalLeaderApplyWorker(), we can use shared lock instead
exclusive as we are just
On Sat, Jan 14, 2023 at 10:29 PM Thomas Munro wrote:
> But if that's the general idea, I suppose there would be two ways to
> give higher priority to signals/latches that arrive in the same set of
> events: (1) scan the events array twice (for latches then
> connections), or (2) check our pending
Hi!
>The patch does not apply on top of HEAD ...
Here is a fixed version.
Small additional fixes:
1) added CRC calculation for empty 'pg_control_log' file;
2) added saving 'errno' before calling LWLockRelease and restoring after
that;
3) corrected pg_upgrade for case old cluster does not have
Le 11/01/2023 à 18:54, Nathan Bossart a écrit :
On Wed, Jan 11, 2023 at 02:22:26PM +0100, Gilles Darold wrote:
I'm moving this commitfest entry to Ready for Committers.
Thank you for reviewing.
I have changed the status to "Returned with feedback" as per commit
ff9618e8 this patch might not
On Sat, Jan 14, 2023 at 8:55 PM Tom Lane wrote:
> "houzj.f...@fujitsu.com" writes:
> > I noticed one BF failure[1] when monitoring the BF for some other commit.
> > [1]
> > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=malleefowl=2023-01-13%2009%3A54%3A51
> > ...
> > So it seems the
> On Sat, Jan 14, 2023 at 7:32 AM Tatsuo Ishii wrote:
>>
>> There seem to be a small typo in backup.sgml
>> (archive_command is unnecessarily
>> repeated). Attached is a patch to fix that.
>>
>
> LGTM.
Fix pushed. Thanks.
Best reagards,
--
Tatsuo Ishii
SRA OSS LLC
English:
On Mon, 2022-12-26 at 14:20 +0530, Bharath Rupireddy wrote:
> Please review the attached v2 patch further.
I'm still unclear on the performance goals of this patch. I see that it
will reduce syscalls, which sounds good, but to what end?
Does it allow a greater number of walsenders? Lower
33 matches
Mail list logo
