On Thu, 19 Jan 2023 at 06:01, Vik Fearing wrote:
> Thank you for the review. Attached is a new version rebased to d540a02a72.
I've only a bunch of nit-picks, personal preferences and random
thoughts to offer as a review:
1. I'd be inclined *not* to mention the possible future optimisation in:
On Wed, Jan 11, 2023 at 3:16 AM sirisha chamarthi
wrote:
>
> Hi Hackers,
>
> vacuum is not able to clean up dead tuples when OldestXmin is not moving
> (because of a long running transaction or when hot_standby_feedback is
> behind). Even though OldestXmin is not moved from the last time it
On Mon, Jan 23, 2023 at 1:29 AM Tom Lane wrote:
>
> Another thing that has a bad smell about it is the fact that
> process_syncing_tables_for_sync uses two transactions in the first
> place. There's a comment there claiming that it's for crash safety,
> but I can't help suspecting it's really
On Thu, Jan 19, 2023 at 3:27 PM Nitin Jadhav
wrote:
>
> > Possibly a better answer is to refactor into separate functions,
> > along the lines of
> >
> > static bool
> > ConfigOptionIsShowable(struct config_generic *conf)
> >
> > static void
> > GetConfigOptionValues(struct config_generic *conf,
On 11/29/22 8:12 PM, Michael Paquier wrote:
On Tue, Nov 29, 2022 at 09:32:34PM +0100, Daniel Gustafsson wrote:
On the whole I tend to agree with Jacob upthread, while this does provide
consistency it doesn't seem to move the needle for best practices. Allowing
On Mon, Jan 23, 2023 at 8:47 AM Amit Kapila wrote:
>
> On Fri, Jan 20, 2023 at 11:48 AM Masahiko Sawada
> wrote:
> >
> > >
> > > Yet another way is to use the existing parameter logical_decode_mode
> > > [1]. If the value of logical_decoding_mode is 'immediate', then we can
> > > immediately
Dear Ted,
Thanks for reviewing! PSA new version.
> For v25-0001-Add-PQConnCheck-and-PQCanConnCheck-to-libpq.patch ,
> `pqConnCheck_internal` only has one caller which is quite short.
> Can pqConnCheck_internal and PQConnCheck be merged into one func ?
I divided the function for feature
On Fri, Jan 20, 2023 at 4:15 PM Amit Kapila wrote:
>
> On Tue, Jan 17, 2023 at 2:41 PM Amit Kapila wrote:
> >
> > Let me try to summarize the discussion till now. The problem we are
> > trying to solve here is to allow a shutdown to complete when walsender
> > is not able to send the entire WAL.
On Mon, Jan 23, 2023 at 1:29 AM Tom Lane wrote:
>
> On my machine, the src/test/subscription/t/002_types.pl test
> usually takes right about 1.5 seconds:
>
> $ time make check PROVE_FLAGS=--timer PROVE_TESTS=t/002_types.pl
> ...
> [14:22:12] t/002_types.pl .. ok 1550 ms ( 0.00 usr 0.00 sys +
On Thu, Jan 12, 2023 at 05:37:40PM +0530, Bharath Rupireddy wrote:
> I understand. I don't mind discussing something like [1] with the
> following behaviour and discarding till_end_of_wal functions
> altogether:
> If start_lsn is NULL, error out/return NULL.
> If end_lsn isn't specified, default
On Sun, Jan 22, 2023 at 10:42 PM Joel Jacobson wrote:
> I did write the code like you suggest first, but changed it,
> since I realised the extra "else if" needed could be eliminated,
> and thought div_var_int64() wouldn't be slower than div_var_int() since
> I thought 64-bit instructions in
> Thank you for reviewing! PSA new patch set.
Sorry, I missed the updated file in the patch. New version will be posted soon.
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
On Thu, 19 Jan 2023 at 20:44, David Rowley wrote:
> Thanks. Pending one last look, I'm planning to move ahead with it
> unless there are any further objections or concerns.
I've now pushed this.
Thank you to everyone who reviewed or gave input on this patch.
David
On Sun, Jan 22, 2023 at 09:50:29PM -0500, Isaac Morland wrote:
> However, one of the jobs (Windows - Server 2019, MinGW64 - Meson) is paused
> and appears never to have run:
>
> https://cirrus-ci.com/task/6687014536347648
Yeah, mingw is currently set to run only when manually "triggered" by
the
On Mon, Jan 23, 2023 at 6:21 AM Peter Smith wrote:
>
> 1.
>
> It makes no real difference, but I was wondering about:
> "update txn progress" versus "update progress txn"
>
Yeah, I think we can go either way but I still prefer "update progress
txn" as that is more closer to
On Fri, Jan 20, 2023 at 11:48 AM Masahiko Sawada wrote:
>
> >
> > Yet another way is to use the existing parameter logical_decode_mode
> > [1]. If the value of logical_decoding_mode is 'immediate', then we can
> > immediately switch to partial serialize mode. This will eliminate the
> >
On Sun, 22 Jan 2023 at 21:37, Justin Pryzby wrote:
> On Sun, Jan 22, 2023 at 08:23:25PM -0500, Isaac Morland wrote:
> > > Were you able to test with your own github account ?
> >
> > I haven’t had a chance to try this. I must confess to being a bit
> confused
> > by the distinction between
On Tue, Jan 17, 2023 at 08:44:27PM -0800, Nathan Bossart wrote:
> Thanks. Here's a rebased version of the last patch.
Thanks for the rebase.
The final state of the documentation is as follows:
51. Archive and Recovery Modules
51.1. Archive Module Initialization Functions
51.2. Archive
On Sun, Jan 22, 2023 at 08:23:25PM -0500, Isaac Morland wrote:
> > Were you able to test with your own github account ?
>
> I haven’t had a chance to try this. I must confess to being a bit confused
> by the distinction between running the CI tests and doing "make check";
> ideally I would like
Hi,
On 2023-01-22 09:05:27 -0800, Jeff Davis wrote:
> On Sat, 2023-01-21 at 14:01 -0800, Andres Freund wrote:
> > There are good reasons to have 'peer' authentication set up for the
> > user
> > running postgres, so admin scripts can connect without issues. Which
> > unfortunately then also means
Andres Freund writes:
> On 2023-01-22 19:28:42 -0500, Tom Lane wrote:
>> Hmm ... right offhand, the only objection I can see is that the
>> pg_bsd_indent files use the BSD 4-clause license, which is not ours.
>> However, didn't UCB grant a blanket exception years ago that said
>> that people
On Sun, 22 Jan 2023 at 17:27, Justin Pryzby wrote:
> On Sun, Jan 22, 2023 at 04:28:21PM -0500, Isaac Morland wrote:
> > On Sun, 22 Jan 2023 at 15:04, Tom Lane wrote:
> But now I'm having a problem I don't understand: the CI are still
> failling,
> > but not in the psql test. Instead, I get
Hi,
On 2023-01-22 19:28:42 -0500, Tom Lane wrote:
> Andres Freund writes:
> > I think I've proposed this before, but I still think that as long as we rely
> > on pg_bsd_indent, we should have it be part of our source tree and
> > automatically built. It's no wonder that barely anybody indents
Hi,
On 2023-01-22 19:50:10 -0500, Andrew Dunstan wrote:
> On 2023-01-22 Su 18:14, Tom Lane wrote:
> > Jelte Fennema writes:
> >> Maybe I'm not understanding your issue correctly, but for such
> >> a case you could push two commits at the same time.
> > I don't know that much about git commit
Here are my review comments for patch v4-0001
==
General
1.
It makes no real difference, but I was wondering about:
"update txn progress" versus "update progress txn"
I thought that the first way sounds more natural. YMMV.
If you change this then there is impact for the typedef, function
On 2023-01-22 Su 18:14, Tom Lane wrote:
> Jelte Fennema writes:
>> Maybe I'm not understanding your issue correctly, but for such
>> a case you could push two commits at the same time.
> I don't know that much about git commit hooks, but do they really
> only check the final state of a series
On Sun, Jan 22, 2023 at 07:28:42PM -0500, Tom Lane wrote:
> Andres Freund writes:
>> I think I've proposed this before, but I still think that as long as we rely
>> on pg_bsd_indent, we should have it be part of our source tree and
>> automatically built. It's no wonder that barely anybody
On Fri, Jan 20, 2023 at 12:32:58PM +0900, Michael Paquier wrote:
> FWIW, no objections from here. This maps with EXPLAIN where the query
> ID is only printed under VERBOSE.
While looking at this change, I have been wondering about something..
Isn't the knowledge of the query ID something that
Andres Freund writes:
> I think I've proposed this before, but I still think that as long as we rely
> on pg_bsd_indent, we should have it be part of our source tree and
> automatically built. It's no wonder that barely anybody indents their
> patches, given that it requires building
Hi,
On 2023-01-22 18:28:27 -0500, Tom Lane wrote:
> Andres Freund writes:
> > On 2023-01-22 18:20:49 +0100, Jelte Fennema wrote:
> >> I don't think the amount of pain is really much lower if we reformat
> >> 10,000 or 300,000 lines of code, without automation both would be
> >> quite painful.
On Sun, Jan 22, 2023 at 3:28 PM Tom Lane wrote:
> So the more I think about it the less excited I am about depending on
> clang-format, because version skew in peoples' clang installations seems
> inevitable, and there's good reason to fear that that would show up
> as varying indentation
On Mon, Jan 23, 2023 at 11:34 AM Tom Lane wrote:
> I spent some more time staring at this and came up with what seems like
> a workable patch, based on the idea that what we want to indent is
> specifically initialization expressions. pg_bsd_indent does have some
> understanding of that:
Andres Freund writes:
> On 2023-01-22 18:20:49 +0100, Jelte Fennema wrote:
>> I don't think the amount of pain is really much lower if we reformat
>> 10,000 or 300,000 lines of code, without automation both would be
>> quite painful. But the git commands I shared in my previous email
>> should
On 1/22/23 22:33, Justin Pryzby wrote:
> On Sun, Jan 22, 2023 at 07:19:41PM +0100, Tomas Vondra wrote:
>> On 1/21/23 19:53, Egor Rogov wrote:
>>> Hi Tomas,
>>> On 21.01.2023 00:50, Tomas Vondra wrote:
This simply adds two functions, accepting/producing anyarray - one for
lower bounds,
Jelte Fennema writes:
> Maybe I'm not understanding your issue correctly, but for such
> a case you could push two commits at the same time.
I don't know that much about git commit hooks, but do they really
only check the final state of a series of commits?
In any case, I'm still down on the
On Sun, Jan 22, 2023, at 14:25, Dean Rasheed wrote:
> I just modified the previous test you posted:
>
> \timing on
> SELECT count(numeric_div_volatile(1e131071,123456)) FROM
> generate_series(1,1e4);
>
> Time: 2048.060 ms (00:02.048)-- HEAD
> Time: 2422.720 ms (00:02.423)-- With patch
>
Andres Freund writes:
> I strongly dislike it, I rarely get it right by hand - but it does have some
> benefit over aligning variable names based on the length of the type names as
> uncrustify/clang-format: In their approach an added local variable can cause
> all the other variables to be
Hi,
On 2023-01-22 17:34:52 -0500, Tom Lane wrote:
> I spent some more time staring at this and came up with what seems like
> a workable patch, based on the idea that what we want to indent is
> specifically initialization expressions.
That's awesome. Thanks for doing that.
> Proposed patch
Hi,
On 2023-01-22 18:20:49 +0100, Jelte Fennema wrote:
> > But switching away from that intermixed with a lot of other changes isn't
> > going to be fun.
>
> I don't think the amount of pain is really much lower if we reformat
> 10,000 or 300,000 lines of code, without automation both would be
Thomas Munro writes:
> On Fri, Jan 20, 2023 at 2:43 PM Tom Lane wrote:
>> Yeah :-(. That's enough of a rat's nest that I've not really wanted to.
>> But I'd support applying such a fix if someone can figure it out.
> This may be a clue: the place where declarations are treated
> differently
On Sun, Jan 22, 2023 at 04:28:21PM -0500, Isaac Morland wrote:
> On Sun, 22 Jan 2023 at 15:04, Tom Lane wrote:
>
> > Isaac Morland writes:
> > > On Sun, 22 Jan 2023 at 14:26, Alvaro Herrera
> > > wrote:
> > >> This one would fail the sanity check that all roles created by
> > >> regression
On Sun, 22 Jan 2023 at 16:56, Justin Pryzby wrote:
> On Sun, Jan 22, 2023 at 03:04:14PM -0500, Tom Lane wrote:
>
> That's excessive. The policy Alvaro mentions applies to globally-visible
> > object names (i.e., database, role, and tablespace names), and it's there
> > to try to ensure that
Hi,
On 2023-01-22 22:19:10 +0100, Jelte Fennema wrote:
> Maybe I'm not understanding your issue correctly, but for such
> a case you could push two commits at the same time.
Right.
> Apart from that "git diff -w" will hide any whitespace changes so I'm not I
> personally wouldn't consider it
On Sun, Jan 22, 2023 at 03:04:14PM -0500, Tom Lane wrote:
> Isaac Morland writes:
> > On Sun, 22 Jan 2023 at 14:26, Alvaro Herrera
> > wrote:
> >> This one would fail the sanity check that all roles created by
> >> regression tests need to have names that start with "regress_".
>
> > Thanks for
On Sun, Jan 22, 2023 at 07:19:41PM +0100, Tomas Vondra wrote:
> On 1/21/23 19:53, Egor Rogov wrote:
> > Hi Tomas,
> > On 21.01.2023 00:50, Tomas Vondra wrote:
> >> This simply adds two functions, accepting/producing anyarray - one for
> >> lower bounds, one for upper bounds. I don't think it can
On Sun, 22 Jan 2023 14:42:46 -0600
"Karl O. Pinc" wrote:
> Attached are 2 patches:
>
> v10-0001-List-trusted-and-obsolete-extensions.patch
>
> List trusted extenions in 4 columns, with the CSS altered
> to put spacing between vertical columns.
In theory, a number of other simplelist
On Sun, 22 Jan 2023 at 15:04, Tom Lane wrote:
> Isaac Morland writes:
> > On Sun, 22 Jan 2023 at 14:26, Alvaro Herrera
> > wrote:
> >> This one would fail the sanity check that all roles created by
> >> regression tests need to have names that start with "regress_".
>
> > Thanks for the
Maybe I'm not understanding your issue correctly, but for such
a case you could push two commits at the same time. Apart
from that "git diff -w" will hide any whitespace changes so I'm
not I personally wouldn't consider it important to split such
changes across commits.
On Sun, 22 Jan 2023 08:09:03 -0600
"Karl O. Pinc" wrote:
> On Sat, 21 Jan 2023 08:11:43 -0600
> "Karl O. Pinc" wrote:
>
> > Attached are 2 v9 patch versions. I don't think I like them.
> > I think the v8 versions are better. But I thought it
> > wouldn't hurt to show them to you.
> >
> > On
Isaac Morland writes:
> On Sun, 22 Jan 2023 at 14:26, Alvaro Herrera
> wrote:
>> This one would fail the sanity check that all roles created by
>> regression tests need to have names that start with "regress_".
> Thanks for the correction. Now I feel like I've skipped some of the
> readings!
>
On my machine, the src/test/subscription/t/002_types.pl test
usually takes right about 1.5 seconds:
$ time make check PROVE_FLAGS=--timer PROVE_TESTS=t/002_types.pl
...
[14:22:12] t/002_types.pl .. ok 1550 ms ( 0.00 usr 0.00 sys + 0.70 cusr
0.25 csys = 0.95 CPU)
[14:22:13]
I noticed
On Sun, 22 Jan 2023 at 14:26, Alvaro Herrera
wrote:
> On 2023-Jan-22, Isaac Morland wrote:
>
> > I’ve re-written the tests to create a test-specific role and functions so
> > there is no longer a dependency on the superuser name.
>
> This one would fail the sanity check that all roles created by
On 2023-Jan-22, Isaac Morland wrote:
> I’ve re-written the tests to create a test-specific role and functions so
> there is no longer a dependency on the superuser name.
This one would fail the sanity check that all roles created by
regression tests need to have names that start with "regress_".
Jelte Fennema writes:
> When reading the emails in this discussion from 2 years ago
> it seems like the respondents wouldn't mind updating the
> typedefs.list manually. And proposed approach number 3
> seemed to have support overall, i.e. fail a push to master
> when pgindent was not run on the
Nathan Bossart writes:
> On Tue, Jan 10, 2023 at 10:59:14AM +0530, Amit Kapila wrote:
>> I haven't looked in detail but isn't it better to explain somewhere in
>> the comments that it achieves to rate limit the restart of workers in
>> case of error and allows them to restart immediately in case
> diff --git a/src/backend/commands/copy.c b/src/backend/commands/copy.c
> new file mode 100644
> index e34f583..aa3cca0
> --- a/src/backend/commands/copy.c
> +++ b/src/backend/commands/copy.c
> @@ -274,12 +274,6 @@ DoCopy(ParseState *pstate, const CopyStm
> {
>
On Sun, 22 Jan 2023 at 00:45, Justin Pryzby wrote:
> On Sun, Jan 22, 2023 at 12:18:34AM -0500, Isaac Morland wrote:
>
> > It turns out that my tests wanted the owner to be “vagrant” rather than
> > “postgres”. This is apparently because I was running as that user (in a
> > Vagrant VM) when
On 1/21/23 19:53, Egor Rogov wrote:
> Hi Tomas,
>
> On 21.01.2023 00:50, Tomas Vondra wrote:
>> Hi Egor,
>>
>> While reviewing a patch improving join estimates for ranges [1] I
>> realized we don't show stats for ranges in pg_stats, and I recalled we
>> had this patch.
>>
>> I rebased the v2, and
But I do think this discussion about other formatting tools
is distracting from the main pain point I wanted to discuss:
our current formatting tool is not run consistently enough.
The only thing that another tool will change in this
regard is that there is no need to update typedefs.list.
It
On Sun, 22 Jan 2023 at 15:41, Joel Jacobson wrote:
>
> On Sun, Jan 22, 2023, at 11:06, Dean Rasheed wrote:
> > Seems like a reasonable idea, with some pretty decent gains.
> >
> > Note, however, that for a divisor having fewer than 5 or 6 digits,
> > it's now significantly slower because it's
> But so far I haven't seen one that can make that
> column be column +12.
Thanks for clarifying what the current variable declaration indention
rule is. Indeed neither uncrustify or clang-format seem to support
that. Getting uncrustify to support it might not be too difficult, but
the question
On Sat, 2023-01-21 at 14:01 -0800, Andres Freund wrote:
> There are good reasons to have 'peer' authentication set up for the
> user
> running postgres, so admin scripts can connect without issues. Which
> unfortunately then also means that postgres_fdw etc can connect to
> the current
> database
Peter Geoghegan writes:
> On Sat, Jan 21, 2023 at 3:39 PM Jelte Fennema wrote:
>> ... For clang-format you should use
>> at least clang-format 15, otherwise it has some bugs in the alignment
>> logic.
> Really? I have been using 14, which is quite recent. Did you just
> figure this out
On Sun, 15 Jan 2023 at 23:02, vignesh C wrote:
>
> On Sun, 8 Jan 2023 at 21:00, vignesh C wrote:
> >
> > On Tue, 3 Jan 2023 at 13:13, vignesh C wrote:
> > >
> > > Hi All,
> > >
> > > Just a reminder that Commitfest 2023-01 has started.
> > > There are many patches based on the latest run from
pg_stat_progress_analyze was added in v13 (a166d408e).
For tables with inheritance children, do_analyze_rel() and
acquire_sample_rows() are called twice. The first time through,
pgstat_progress_start_command() has memset() the progress array to zero.
But the 2nd time, ANALYZE_BLOCKS_DONE is
Andrew Dunstan writes:
>> ... btw, can we get away with making the diff run be "diff -upd"
>> not just "diff -u"? I find diff output for C files noticeably
>> more useful with those options, but I'm unsure about their
>> portability.
> I think they are available on Linux, MacOS and FBSD, and on
On Sun, Jan 22, 2023, at 11:06, Dean Rasheed wrote:
> Seems like a reasonable idea, with some pretty decent gains.
>
> Note, however, that for a divisor having fewer than 5 or 6 digits,
> it's now significantly slower because it's forced to go through
> div_var_int64() instead of div_var_int() for
On Fri, Jan 20, 2023 at 12:38 AM Robert Haas wrote:
>
> I think that the handling of lp_valid[] in the loop that begins with
> "Loop over offset and populate predecessor array from all entries that
> are present in successor array" is very confusing. I think that
> lp_valid[] should be answering
On Sun, 22 Jan 2023 at 13:42, Joel Jacobson wrote:
>
> Hi,
>
> On platforms where we support 128bit integers, we could accelerate division
> when the number of digits in the divisor is larger than 8 and less than or
> equal to 16 digits, i.e. when the divisor that fits in a 64-bit integer but
>
On 2023-01-21 Sa 11:10, Tom Lane wrote:
> Andrew Dunstan writes:
I think we could do better with some automation tooling for committers
here. One low-risk and simple change would be to provide a
non-destructive mode for pgindent that would show you the changes if any
it would
On Sat, 21 Jan 2023 08:11:43 -0600
"Karl O. Pinc" wrote:
> Attached are 2 v9 patch versions. I don't think I like them.
> I think the v8 versions are better. But I thought it
> wouldn't hurt to show them to you.
>
> On Fri, 20 Jan 2023 14:22:25 -0600
> "Karl O. Pinc" wrote:
>
> > Attached
On Saturday, January 21, 2023 3:36 AM I wrote:
> Kindly have a look at the patch v18.
I've conducted some refactoring for v18.
Now the latest patch should be tidier and
the comments would be clearer and more aligned as a whole.
Attached the updated patch v19.
Best Regards,
Takamichi
Hello.
I have registered it as patch in the commit fest:
https://commitfest.postgresql.org/42/4138/
Best regards,
Michail.
On Mon, 9 Jan 2023 at 17:44, Dean Rasheed wrote:
>
> On Mon, 9 Jan 2023 at 16:23, Vik Fearing wrote:
> >
> > Bikeshedding here. Instead of Yet Another WITH Clause, could we perhaps
> > make a MERGING() function analogous to the GROUPING() function that goes
> > with grouping sets?
> >
> > MERGE
Hi,
On 2023-01-21 15:32:45 -0800, Peter Geoghegan wrote:
> Attached is my .clang-format, since you asked for it. It was
> originally based on stuff that both you and Peter E posted several
> years back, I believe. Plus the timescaledb one in one or two places.
> I worked a couple of things out
75 matches
Mail list logo
