Re: Time delayed LR (WAS Re: logical replication restrictions)

On Mon, Feb 27, 2023 at 1:50 PM Masahiko Sawada wrote: > > On Mon, Feb 27, 2023 at 3:34 PM Amit Kapila wrote: > > > > > --- > > > Why do we not to delay sending COMMIT PREPARED messages? > > > > > > > I think we need to either add delay for prepare or commit prepared as > > otherwise, it will

Re: XID formatting and SLRU refactorings (was: Add 64-bit XIDs into PostgreSQL 15)

(CC list trimmed, gmail wouldn't let me send otherwise) On 22/02/2023 16:29, Maxim Orlov wrote: On Tue, 21 Feb 2023 at 16:59, Aleksander Alekseev mailto:aleksan...@timescale.com>> wrote: One thing that still bothers me is that during the upgrade we only migrate the CLOG segments (i.e.

Optimize walsender handling invalid messages of 'drop publication'

Hi all, Before PG 14, walsender process has to handle invalid message in one XLOG (PG 14 provide a particular XLOG type: XLOG_XACT_INVALIDATIONS). This may bring some problems which has been discussed in previous mail:

Re: Allow logical replication to copy tables in binary format

On Mon, Feb 20, 2023 at 3:37 PM shiy.f...@fujitsu.com wrote: > > On Thu, Feb 16, 2023 8:48 PM Amit Kapila wrote: > > > > So, doesn't this mean that there is no separate failure mode during > > the initial copy? I am clarifying this to see if the patch really > > needs a separate copy_format

Re: Provide PID data for "cannot wait on a latch owned by another process" in latch.c

Uggg^2 At Mon, 27 Feb 2023 17:53:08 +0900 (JST), Kyotaro Horiguchi wrote in > > Please tidy up the followging sentence properly and natural but in a > > moderately formal way, within the context of computer programs, and > > provide explanations for the individual changes you made. > >

Re: Provide PID data for "cannot wait on a latch owned by another process" in latch.c

Uggg! At Mon, 27 Feb 2023 17:48:10 +0900 (JST), Kyotaro Horiguchi wrote in > At Mon, 27 Feb 2023 09:20:39 +0900, Michael Paquier > wrote in > > Hi all, > > > > While doing something I should not have done, I have been able to > > trigger latch.c with the error of $subject. Adding in the

RE: Time delayed LR (WAS Re: logical replication restrictions)

Dear Sawada-san, Amit, Thank you for reviewing! > + * > + * LOGICALREP_PROTO_MIN_SEND_DELAY_VERSION_NUM is the minimum > protocol version > + * with support for delaying to send transactions. Introduced in PG16. > */ > #define LOGICALREP_PROTO_MIN_VERSION_NUM 1 > #define

Re: Provide PID data for "cannot wait on a latch owned by another process" in latch.c

At Mon, 27 Feb 2023 09:20:39 +0900, Michael Paquier wrote in > Hi all, > > While doing something I should not have done, I have been able to > trigger latch.c with the error of $subject. Adding in the elog > generated some information about the PID owning the latch and > MyProcPid has made me

Re: Change xl_hash_vacuum_one_page.ntuples from int to uint16

Hi, On 2/27/23 6:27 AM, Amit Kapila wrote: On Fri, Feb 17, 2023 at 7:44 PM Drouvot, Bertrand wrote: On 2/16/23 1:26 PM, Drouvot, Bertrand wrote: Hi, On 2/16/23 12:00 PM, Amit Kapila wrote: BTW, feel free to create the second patch (to align the types for variables/arguments) as that

Re: Add support for unit "B" to pg_size_pretty()

On 22.02.23 03:39, David Rowley wrote: hmm. I didn't really code pg_size_pretty with aliases in mind. I don't think you can do this. There's code in pg_size_pretty() and pg_size_pretty_numeric() that'll not work correctly. We look ahead to the next unit to check if there is one so we know we

Real config values for bytes needs quotes?

Hello. I found it frustrating that the line "shared_buffers = 0.1GB" in postgresql.conf postgresql.conf was causing an error and that the value required (additional) surrounding single quotes. The attached patch makes the parser accept the use of non-quoted real values followed by a unit for

Re: [PATCH] Support SK_SEARCHNULL / SK_SEARCHNOTNULL for heap-only scans

On 22/02/2023 15:03, Aleksander Alekseev wrote: Additionally, practice shows that for an extension author it's very easy to miss a comment in skey.h: """ * SK_SEARCHARRAY, SK_SEARCHNULL and SK_SEARCHNOTNULL are supported only * for index scans, not heap scans; """ ... which results in many

Re: Time delayed LR (WAS Re: logical replication restrictions)

On Mon, Feb 27, 2023 at 3:34 PM Amit Kapila wrote: > > On Mon, Feb 27, 2023 at 11:11 AM Masahiko Sawada > wrote: > > > > On Thu, Feb 23, 2023 at 9:10 PM Hayato Kuroda (Fujitsu) > > wrote: > > > > > > Thank you for reviewing! PSA new version. > > > > > > > > > > Thank you for updating the

Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher

On Mon, Feb 27, 2023 at 12:35 PM Önder Kalacı wrote: > > >> Wouldn't a table-level option like 'apply_index_scan' be better than a >> subscription-level option with a default value as false? Anyway, the >> bigger point is that we don't see a better way to proceed here than to >> introduce some

Re: PGDOCS - sgml linkend using single-quotes

On 18/01/2023 00:37, Peter Smith wrote: I happened to notice some examples of SGML linkends that were using single quotes instead of double quotes. It didn't seem to be the conventional style because grepping (from doc/src/sgml folder) showed only a tiny fraction using single quotes.

<    1   2