On 04/01/23 18:10, Ankit Kumar Pandey wrote:
On 29/12/22 20:58, Ankit Kumar Pandey wrote:
>
> On 24/12/22 18:22, Ankit Pandey wrote:
>> Hi,
>>
>> This is a PoC patch which implements distinct operation in window
>> aggregates (without order by and for single column aggregation, final
>>
And again:
TRAP: failed Assert("PMSignalState->PMChildFlags[slot] ==
PM_CHILD_ASSIGNED"), File: "../src/backend/storage/ipc/pmsigna...
https://cirrus-ci.com/task/6558324615806976
On Sun, Mar 12, 2023 at 1:34 AM Önder Kalacı wrote:
>
>>
>> I think we can add such a test (which relies on existing buggy
>> behavior) later after fixing the existing bug. For now, it would be
>> better to remove that test and add it after we fix dropped columns
>> issue in HEAD.
>
>
> Alright,
On Wed, Mar 8, 2023 at 10:47 PM Michael Paquier wrote:
> I may be missing something, but you cannot use directly a "postgres"
> command in a TAP test, can you? See 1a9d802, that has fixed a problem
> when TAP tests run with a privileged account on Windows.
I was joking. But I did have a real
On Fri, Mar 10, 2023 at 1:05 PM Thomas Munro wrote:
> On Fri, Mar 10, 2023 at 11:37 AM Nathan Bossart
> wrote:
> > On Thu, Mar 09, 2023 at 05:27:08PM -0500, Tom Lane wrote:
> > > Is it reasonable to assume that all modern platforms can time
> > > millisecond delays accurately? Ten years ago I'd
On Sat, Mar 11, 2023 at 11:55:22PM +, Imseih (AWS), Sami wrote:
> It appears you must "make clean; make install" to correctly compile after
> applying the patch.
In a git repository, I've learnt to rely on this simple formula, even
if it means extra cycles when running ./configure:
git clean
> On Mar 11, 2023, at 6:37 PM, Andres Freund wrote:
>
> Hi,
>
> On my buildfarm host (for all my animals) I noted that slapd was by far the
> biggest contributor to syslog. Even though there's not normally slapd
> running. It's of course the slapds started by various tests.
>
> Would
Hi,
On 2023-02-22 06:47:34 -0500, Andrew Dunstan wrote:
> Given its nature and purpose as a module we don't want to run against an
> installed instance, shouldn't src/test/modules/unsafe_tests have
> NO_INSTALLCHECK=1 in its Makefile and runningcheck:false in its meson.build?
Seems like a good
Hi,
On 2023-03-10 08:18:34 +0100, Peter Eisentraut wrote:
> Here is an updated patch. I have done some cosmetic polishing and fixed a
> minor Windows-related bug.
>
> In my mind, the patch is complete.
>
> If someone wants to do some in-depth code review, I suggest focusing on the
> following
> If I remove this patch and recompile again, then "initdb -D $PGDATA" works.
It appears you must "make clean; make install" to correctly compile after
applying the patch.
Regards,
Sami Imseih
Amazon Web Services (AWS)
Hi,
On 2023-03-11 15:34:55 -0800, Mark Dilger wrote:
> > On Mar 11, 2023, at 3:22 PM, Andres Freund wrote:
> >
> > Something like the attached.
>
> I like that your patch doesn't make the test longer. I assume you've already
> run the tests and that it works.
I did check that, yes :). My
Hi,
On my buildfarm host (for all my animals) I noted that slapd was by far the
biggest contributor to syslog. Even though there's not normally slapd
running. It's of course the slapds started by various tests.
Would anybody mind if I add 'logfile_only' to slapd's config in LdapServer.pm?
That
> On Mar 11, 2023, at 3:22 PM, Andres Freund wrote:
>
> Something like the attached.
I like that your patch doesn't make the test longer. I assume you've already
run the tests and that it works.
> I don't know enough perl to know how to interpolate something like
> use constant ROWCOUNT
Hi,
On 2023-03-09 12:15:16 -0800, Mark Dilger wrote:
> > Somewhat random note:
> >
> > Is it intentional that we VACUUM FREEZE test ROWCOUNT times? That's
> > effectively O(ROWCOUNT^2), albeit with small enough constants to not really
> > matter. I don't think we need to insert the rows
On Thu, Dec 15, 2022 at 10:13:23AM -0600, Justin Pryzby wrote:
> Rebased on c727f511b.
Rebased on 30a53b792.
With minor changes including fixes to an intermediate patch.
> This patch record was "closed for lack of interest", but I think what's
> actually needed is committer review of which
Hi Alvaro,
On Thu, 9 Mar 2023 10:22:49 +0100
Alvaro Herrera wrote:
> On 2023-Jan-22, Karl O. Pinc wrote:
>
> > Actually, this CSS, added to doc/src/sgml/stylesheet.css,
> > makes the column spacing look pretty good:
> Okay, this looks good to me too. However, for it to actually work, we
>
Hi,
On 2023-03-09 18:31:10 -0500, Andrew Dunstan wrote:
> Another thing: the test for uuid.h is too strict. On Fedora 36 the OSSP
> header is in /usr/include, not /usr/include/ossp (I got around that for now
> by symlinking it, but obviously that's a nasty hack we can't ask people to
> do)
Yea,
Hi Amit, all
> > This triggers tuples_equal to fail. To fix that, I improved the
> tuples_equal
> > such that it skips the dropped columns.
> >
>
> By any chance, have you tried with generated columns?
Yes, it shows the same behavior.
> See
>
Hi all,
(cc'ed Amit as he has the context)
While working on [1], I realized that on HEAD there is a problem with the
$subject. Here is the relevant discussion on the thread [2]. Quoting my
own notes on that thread below;
I realized that the dropped columns also get into the tuples_equal()
>
> [1]
> subscription tests:
> PATCHED: WAL buffers hit - 1972, misses - 32616
Can you share more details about the test here?
I went through the v8 patch. Following are my thoughts to improve the
WAL buffer hit ratio.
Currently the no-longer-needed WAL data present in WAL buffers gets
cleared
On Sat, Mar 11, 2023 at 09:55:33AM -0500, Melanie Plageman wrote:
> Subject: [PATCH v3 2/3] use shared buffers when failsafe active
>
> + /*
> + * Assume the caller who allocated the memory for the
> + * BufferAccessStrategy object will free it.
> +
Le 04/03/2023 à 20:18, Tom Lane a écrit :
As noted, "childs" is bad English and "partitions" is flat out wrong
(unless you change it to recurse only to partitions, which doesn't
seem like a better definition). We could go with
--[exclude-]table-and-children, or maybe
> On Mar 9, 2023, at 11:18 PM, Peter Eisentraut
> wrote:
>
> Here is an updated patch.
Thanks, Peter. The patch appears to be in pretty good shape, but I have a few
comments and concerns.
CEKIsVisible() and CMKIsVisible() are obviously copied from
TSParserIsVisible(), and the code
Hi Georgios,
11.03.2023 13:50, gkokola...@pm.me wrote:
I can not answer about the buildfarms. Do you think that adding an explicit
check for this warning in meson would help? I am a bit uncertain as I think
that type-limits are included in extra.
@@ -1748,6 +1748,7 @@ common_warning_flags = [
On Fri, Mar 10, 2023 at 9:30 PM Masahiko Sawada
wrote:
>
> On Fri, Mar 10, 2023 at 3:42 PM John Naylor
> wrote:
> > I'd suggest sharing your todo list in the meanwhile, it'd be good to
discuss what's worth doing and what is not.
>
> Apart from more rounds of reviews and tests, my todo items
> On Tue, Feb 28, 2023 at 3:16 AM Bharath Rupireddy
> wrote:
>
> > On Thu, Jan 12, 2023 at 6:06 AM Andres Freund wrote:
> > >
> > > On 2023-01-11 17:26:19 -0700, David G. Johnston wrote:
> > > > Should we just add "ring_buffers" to the existing "shared_buffers" and
> > > > "temp_buffers"
Hi,
I've done a rebase of a patch to the current master.
--
Andrei Zubkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
From e43e9eab39bbd377665a7cad3b7fe7162f8f6578 Mon Sep 17 00:00:00 2001
From: Andrei Zubkov
Date: Sat, 11 Mar 2023 09:53:10 +0300
Subject:
> 7. Is it possible to add a benchmark which shows improvement against
HEAD ?
Please ignore this from my earlier mail, I just saw stats now.
Thanks,
Ankit
--- Original Message ---
On Saturday, March 11th, 2023 at 7:00 AM, Alexander Lakhin
wrote:
> Hello,
> 23.02.2023 23:24, Tomas Vondra wrote:
>
> > On 2/23/23 16:26, Tomas Vondra wrote:
> >
> > > Thanks for v30 with the updated commit messages. I've pushed 0001 after
> > > fixing a
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: not tested
Spec compliant: not tested
Documentation:not tested
Hello,
Adding some review comments:
1. In list_member_ptr, will it be
> Subject: Re: Ability to reference other extensions by schema in extension
> scripts
>
> "Regina Obe" writes:
> >> requires = 'extfoo, extbar'
> >> no_relocate = 'extfoo'
>
> > So when no_relocate is specified, where would that live?
>
> In the control file.
>
> > Would I mark the extfoo as
31 matches
Mail list logo
