Re: ICU locale validation / canonicalization

On 09.03.23 21:17, Jeff Davis wrote: Personally, I'm not on board with this behavior: => CREATE COLLATION test (provider = icu, locale = 'de@collation=phonebook'); NOTICE:  0: using language tag "de-u-co-phonebk" for locale "de@collation=phonebook" I mean, maybe that is a thing we want to

Re: Add macros for ReorderBufferTXN toptxn

On Fri, 10 Mar 2023 at 04:36, Peter Smith wrote: > > Hi, > > During a recent code review, I was confused multiple times by the > toptxn member of ReorderBufferTXN, which is defined only for > sub-transactions. > > e.g. txn->toptxn member == NULL means the txn is a top level txn. > e.g.

RE: [Proposal] Add foreign-server health checks infrastructure

Dear Katsuragi-san, > Hi, > > I updated the status of the patch to ready for committer. > > regards, Thank you so much for your reviewing! Now we can wait comments from senior members and committers. Best Regards, Hayato Kuroda FUJITSU LIMITED

Re: Combine pg_walinspect till_end_of_wal functions with others

On Fri, Mar 10, 2023 at 04:45:06PM +0530, Bharath Rupireddy wrote: > Any comments on the attached v5 patch? I have reviewed the patch, and found it pretty messy. The tests should have been divided into their own patch, I think. This is rather straight-forward once the six functions have their

Re: CI and test improvements

On 03.02.23 15:26, Justin Pryzby wrote: rebased, and re-including a patch to show code coverage of changed files. This constant flow of patches under one subject doesn't lend itself well to the commit fest model of trying to finish things up. I can't quite tell which of these patches are

Re: meson: Non-feature feature options

On 09.03.23 14:54, Daniel Gustafsson wrote: On 9 Mar 2023, at 14:45, Peter Eisentraut wrote: How about we just hardcode "openssl" here instead? We could build that array dynamically, of course, but maybe we leave that until we actually have a need? At least for 16 keeping it hardcoded

Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher

Hi Shi Yu, > > > > > > > > > Reading [1], I think I can follow what you suggest. So, basically, > > > if the leftmost column is not filtered, we have the following: > > > > > >> but the entire index would have to be scanned, so in most cases the > planner > > would prefer a sequential table

Re: [Proposal] Add foreign-server health checks infrastructure

On 2023-03-10 18:07, Katsuragi Yuta wrote: On 2023-03-08 13:40, Hayato Kuroda (Fujitsu) wrote: Dear Vignesh, Thank you for reviewing! PSA new version. Hi, Thank you for the comments, Vignesh. Thank you for updating the patch, Kuroda-san. This fix looks fine to me. And also, there seems

<    1   2