RE: Smoothing the subtrans performance catastrophe

2023-03-21 Thread Kurlaev Jaroslav
Hello Simon, Can you please provide the test cases that you used to plot the performance graph you've attached. Also do you know if your optimization will be useful for a very large amount of subtransactions per transaction (around 1000)? -- Thanks, Yaroslav

Re: [PoC] Improve dead tuple storage for lazy vacuum

2023-03-21 Thread Masahiko Sawada
On Tue, Mar 21, 2023 at 2:41 PM John Naylor wrote: > > > On Mon, Mar 20, 2023 at 9:34 PM Masahiko Sawada wrote: > > > > On Mon, Mar 20, 2023 at 9:34 PM John Naylor > > wrote: > > > That's an interesting idea, and the analogous behavior to aset could be a > > > good thing for readability and

Re: Data is copied twice when specifying both child and parent table in publication

2023-03-21 Thread Amit Kapila
On Mon, Mar 20, 2023 at 11:22 PM Jacob Champion wrote: > > On Fri, Mar 17, 2023 at 9:45 PM Amit Kapila wrote: > > > There are a bunch of moving parts and hidden subtleties here, and I fell > > > into a few traps when I was working on my patch, so it'd be nice to have > > > additional coverage.

Re: Dropped and generated columns might cause wrong data on subs when REPLICA IDENTITY FULL

2023-03-21 Thread Amit Kapila
On Mon, Mar 20, 2023 at 6:28 PM Amit Kapila wrote: > > On Mon, Mar 20, 2023 at 2:58 PM Önder Kalacı wrote: > > > > > > I applied all patches for all the versions, and re-run the subscription > > tests, > > all looks good to me. > > > > LGTM. I'll push this tomorrow unless there are more

Re: Allow logical replication to copy tables in binary format

2023-03-21 Thread Amit Kapila
On Tue, Mar 21, 2023 at 7:03 AM Peter Smith wrote: > > > == > src/test/subscription/t/014_binary.pl > > 4. > # - > # Test mismatched column types with/without binary mode > # - > > # Test

<    1   2