Hi Mr.Momjian
> First, am I correct?
Yes, you are correct. This patch uses new special aggregate functions for
partial aggregate
(then we call this partialaggfunc).
> Second, how far away is this from being committable
> and/or what work needs to be done to get it committable, either for PG 16
Hi,
I was working on committing patch 0001 from [1] and was a bit confused about
some of the changes to the WAL format for gist and hash index vacuum. It
looked to me that the changed code just flat out would not work.
Turns out the problem is that we don't reach deletion for hash and gist
Hi,
On 2023-03-30 18:23:41 +0200, Drouvot, Bertrand wrote:
> On 3/30/23 9:04 AM, Andres Freund wrote:
> > I think this commit is ready to go. Unless somebody thinks differently, I
> > think I might push it tomorrow.
>
> Great! Once done, I'll submit a new patch so that GlobalVisTestFor() can make
On Mon, 20 Mar 2023 at 11:50, Melanie Plageman
wrote:
> Attached is an updated v6.
I had a look over the v6-0001 patch. There are a few things I think
could be done better:
"Some operations will access a large number of pages at a time", does
this really need "at a time"? I think it's more
On Fri, Mar 31, 2023 at 4:15 AM Corey Huinker
wrote:
> For those who already responded, are your concerns limited to the
dependency issue? Would you have concerns about a templating library that
was developed by us and included in-tree?
Libraries (and abstractions in general) require some mental
On Fri, Mar 31, 2023 at 5:15 AM Jacob Champion wrote:
>
> On Wed, Mar 29, 2023 at 2:00 AM Amit Kapila wrote:
> > Pushed.
>
> While rebasing my logical-roots patch over the top of this, I ran into
> another situation where mixed viaroot settings can duplicate data. The
> key idea is to subscribe
Hi,
On 2023-03-09 08:23:46 -0500, Melanie Plageman wrote:
> Good idea. v3 attached.
I committed this, after some small regression test changes. I was worried that
the query for testing buffer hits might silently change in the future, so I
added an EXPLAIN for the query. Also removed the need for
On Friday, March 31, 2023 12:05 AM Robert Haas wrote:
Hi,
>
> On Tue, Mar 28, 2023 at 1:52 PM Jeff Davis wrote:
> > On Fri, 2023-03-24 at 00:17 -0700, Jeff Davis wrote:
> > > The other patch you posted seems like it makes a lot of progress in
> > > that direction, and I think that should go
Dave Cramer
On Thu, 30 Mar 2023 at 15:40, Jeff Davis wrote:
> On Thu, 2023-03-30 at 07:06 -0500, Merlin Moncure wrote:
> > This ought to be impossible IMO. All libpq routines except PQexec
> > have an explicit expectation on format (via resultformat parameter)
> > that should not be
On Thu, Dec 15, 2022 at 10:23:05PM +,
fujii.y...@df.mitsubishielectric.co.jp wrote:
> Hi Mr.Freund.
>
> > cfbot complains about some compiler warnings when building with clang:
> > https://cirrus-ci.com/task/6606268580757504
> >
> > deparse.c:3459:22: error: equality comparison with
Andres Freund writes:
> On 2023-03-30 17:15:20 -0400, Corey Huinker wrote:
>> For those who already responded, are your concerns limited to the
>> dependency issue? Would you have concerns about a templating library that
>> was developed by us and included in-tree? I'm not suggesting suggesting
It seems that lately, the patch attachments are lacking version
numbers. It causes unnecessary confusion. For example, I sometimes
fetch patches from this thread locally to "diff" them with previous
patches to get a rough overview of the changes -- that has now become
more difficult.
Can you
On Thu, Mar 30, 2023 at 2:41 PM Peter Geoghegan wrote:
> pg@regression:5432 [1402115]=# SELECT
> count(*)
> FROM
> pg_get_wal_block_info ('0/10E9D80', '/', true);
> ┌─[ RECORD 1 ]───┐
> │ count │ 17,031,979 │
> └───┴┘
>
> Time: 15235.499 ms (00:15.235)
>
>
On Wed, Mar 29, 2023 at 8:28 PM Bharath Rupireddy
wrote:
> I took a look at v9 and LGTM.
Pushed, thanks.
There is still an outstanding question around the overhead of
outputting FPIs and even block data from pg_get_wal_block_info(). At
one point Melanie suggested that we'd need to do something
Hi,
On 2023-03-30 17:15:20 -0400, Corey Huinker wrote:
> For those who already responded, are your concerns limited to the
> dependency issue? Would you have concerns about a templating library that
> was developed by us and included in-tree? I'm not suggesting suggesting we
> write one at this
Hi,
I pushed this version! Thanks all, for the contribution and reviews.
> > I would either put WalUsage into PgStat_PendingWalStats (so that it has
> > all the same members as PgStat_WalStats), or figure out a way to
> > maintain WalUsage separately from PgStat_WalStats or something else.
> >
On Thu, 2023-03-30 at 08:59 +0200, Peter Eisentraut wrote:
> I don't think the special handling of IsBinaryUpgrade is needed or
> wanted. I would hope that with this feature, all old-style locale
> IDs
> would go away, but this way we would keep them forever. If we
> believe
> that
>
> I don't think that's remotely a starter. Asking people to install an old
> and possibly buggy version of a perl module is not something we should do.
>
> I think the barrier for this is pretty high. I try to keep module
> requirements for the buildfarm client pretty minimal, and this could
>
> I think many of those could just be replaced by multi-line strings and/or
> here
> documents to get most of the win.
>
I agree that a pretty good chunk of it can be done with here-docs, but
template files do have attractive features (separation of concerns, syntax
highlighting, etc) that made
> On 30 Mar 2023, at 22:29, Tom Lane wrote:
> Daniel Gustafsson writes:
>>> On 30 Mar 2023, at 20:44, Tom Lane wrote:
>>> Another idea could be for pg_regress to enforce that "select count(*)
>>> from pg_roles" gives the same answer before and after the test run.
>
>> That wouldn't prevent
Daniel Gustafsson writes:
>> On 30 Mar 2023, at 20:44, Tom Lane wrote:
>> Maybe it'd be close enough to expect there to be no roles named
>> "regress_xxx". In combination with
>> -DENFORCE_REGRESSION_TEST_NAME_RESTRICTIONS, that would prevent us
>> from accidentally leaving stuff behind, and we
On 30.03.23 20:35, Stephen Frost wrote:
I do feel that column encryption is a useful capability and there's
large parts of this approach that I agree with, but I dislike the idea
of having our clients be able to depend on what gets returned for
non-encrypted columns while not being able to trust
On 2023-03-30 Th 15:06, Daniel Gustafsson wrote:
On 30 Mar 2023, at 19:06, Corey Huinker wrote:
Some other digging around shows that the module has been around since 1996
(Perl5 was 1994) and hasn't had a feature update (or any update for that
matter) since 2003. So it should meet our
On Thu, Mar 30, 2023 at 2:52 PM Jeff Davis wrote:
> > Mmm, I don't agree. Suppose A can SET ROLE to B or C, and B can SET
> > ROLE to A. With the patch as written, actions on B's tables are not
> > confined by the SECURITY_RESTRICTED_OPERATION flag, but actions on
> > C's
> > tables are.
>
> It's
On 30.03.23 17:55, Andres Freund wrote:
I find it very hard to belief that details of the catalog representation like
this will matter to users. How would would it conceivably affect users that we
store (key, encryption method) in pg_attribute vs storing an oid that's
effectively a foreign key
On Thu, 2023-03-30 at 07:06 -0500, Merlin Moncure wrote:
> This ought to be impossible IMO. All libpq routines except PQexec
> have an explicit expectation on format (via resultformat parameter)
> that should not be overridden. PQexec ought to be explicitly
> documented and wired to only request
> On 30 Mar 2023, at 04:57, Masahiko Sawada wrote:
> As another idea, why don't we use macros for that? For example,
> suppose VacuumCostStatus is like:
>
> typedef enum VacuumCostStatus
> {
>VACUUM_COST_INACTIVE_LOCKED = 0,
>VACUUM_COST_INACTIVE,
>VACUUM_COST_ACTIVE,
> }
On Mon, Mar 27, 2023 at 7:04 PM Thomas Munro wrote:
> I found another problem. I realised that ... FULL JOIN ... LIMIT n
> might be able to give wrong answers with unlucky scheduling.
> Unfortunately I have been unable to reproduce the phenomenon I am
> imagining yet but I can't think of any
> On 30 Mar 2023, at 20:44, Tom Lane wrote:
> Maybe it'd be close enough to expect there to be no roles named
> "regress_xxx". In combination with
> -DENFORCE_REGRESSION_TEST_NAME_RESTRICTIONS, that would prevent us
> from accidentally leaving stuff behind, and we could hope that it doesn't
>
Hi,
> This patch, although moderately complicated, was moved between several
> commitfests. I think it would be great if it made it to PG16. I'm
> inclined to change the status of the patchset to RfC in a bit, unless
> anyone has a second opinion.
> I added a test module in
> On 30 Mar 2023, at 19:06, Corey Huinker wrote:
> Some other digging around shows that the module has been around since 1996
> (Perl5 was 1994) and hasn't had a feature update (or any update for that
> matter) since 2003. So it should meet our baseline 5.14 requirement, which
> came out in
On Thu, 2023-03-30 at 09:41 -0400, Robert Haas wrote:
> On Thu, Mar 30, 2023 at 1:19 AM Jeff Davis wrote:
> > I say just take the special case out of 0001. If the trigger
> > doesn't
> > work as a SECURITY_RESTRICTED_OPERATION, and is also ENABLED
> > ALWAYS,
> > then the user can just use the
Hi,
On 2023-03-30 13:06:46 -0400, Corey Huinker wrote:
> Is there a barrier to us using non-core perl modules, in this case
> Text::Template?
I don't think we should have a hard build-time dependency on non-core perl
modules. On some operating systems having to install such dependencies is
quite
Robert Haas writes:
> On Thu, Mar 30, 2023 at 1:07 PM Tom Lane wrote:
>> This oversight broke repeated runs of "make installcheck".
> GH. You would think that I would have learned better by now, but
> evidently not. Is there some way we can add an automated guard against
> this?
Hm. We
Greetings,
* Andres Freund (and...@anarazel.de) wrote:
> On 2023-03-30 16:01:46 +0200, Peter Eisentraut wrote:
> > On 30.03.23 03:29, Andres Freund wrote:
> > > > One might think that, but the precedent in other equivalent systems is
> > > > that
> > > > you reference the key and the algorithm
On Thu, Mar 30, 2023 at 1:07 PM Tom Lane wrote:
> Clean up role created in new subscription test.
>
> This oversight broke repeated runs of "make installcheck".
GH. You would think that I would have learned better by now, but
evidently not. Is there some way we can add an automated guard
On Thu, Mar 30, 2023 at 11:11 AM Jelte Fennema wrote:
> Regarding the actual patch. I think the code looks good. Mainly the
> tests and docs are lacking for the new option. Like I said for the
> tests you can borrow the tests I updated for my v2 patch, I think
> those should work fine for the new
On Wed, Mar 29, 2023 at 2:00 AM Amit Kapila wrote:
> Pushed.
While rebasing my logical-roots patch over the top of this, I ran into
another situation where mixed viaroot settings can duplicate data. The
key idea is to subscribe to two publications with mixed settings, as
before, and add a
Greetings,
* Jacob Champion (jchamp...@timescale.com) wrote:
> On 3/20/23 09:32, Robert Haas wrote:
> > I think this is the root of our disagreement.
>
> Agreed.
I've read all the way back to the $SUBJECT change to try and get an
understanding of the questions here and it's not been easy, in
Corey Huinker writes:
> Is there a barrier to us using non-core perl modules, in this case
> Text::Template?
Use for what exactly?
I'd be hesitant to require such things to build from a tarball,
or to run regression tests. If it's used to build a generated file
that we include in tarballs,
On 30/3/2023 12:57, Julien Rouhaud wrote:
Extensions could need to pass some query-related data through all stages of
the query planning and execution. As a trivial example, pg_stat_statements
uses queryid at the end of execution to save some statistics. One more
reason - extensions now conflict
Is there a barrier to us using non-core perl modules, in this case
Text::Template?
I think it would be a tremendous improvement in readability and
maintainability over our current series of print statements, some
multiline, some not.
The module itself works like this
On Wed, Mar 29, 2023 at 8:51 AM Drouvot, Bertrand <
bertranddrouvot...@gmail.com> wrote:
> Hi,
>
> On 3/29/23 11:44 AM, Drouvot, Bertrand wrote:
>
> >
> > Looking forward to your feedback,
>
> Just realized that more polishing was needed.
>
> Done in V2 attached.
>
> Regards,
>
> --
> Bertrand
Hi,
On Thu, Mar 30, 2023 at 2:45 PM Jeff Davis wrote:
>
> On Thu, 2023-03-02 at 23:58 -0800, Jeff Davis wrote:
> > On Thu, 2023-03-02 at 11:45 -0800, Jeff Davis wrote:
> > > In this case it looks easier to add the right API than to be sure
> > > about
> > > whether it's needed or not.
> >
> > I
Hi Reid!
Some thoughts
I was looking at lmgr/proc.c, and I see a potential integer overflow - both
max_total_bkend_mem and result are declared as “int”, so the expression
“max_total_bkend_mem * 1024 * 1024 - result * 1024 * 1024” could have a problem
when max_total_bkend_mem is set to 2G or
On Tue, Mar 28, 2023 at 1:52 PM Jeff Davis wrote:
> On Fri, 2023-03-24 at 00:17 -0700, Jeff Davis wrote:
> > The other patch you posted seems like it makes a lot of progress in
> > that direction, and I think that should go in first. That was one of
> > the items I suggested previously[2], so
Hi,
On 2023-03-30 16:01:46 +0200, Peter Eisentraut wrote:
> On 30.03.23 03:29, Andres Freund wrote:
> > > One might think that, but the precedent in other equivalent systems is
> > > that
> > > you reference the key and the algorithm separately. There is some
> > > (admittedly not very
On Thu, Mar 30, 2023 at 11:30:37AM +0200, Gaetano Mendola wrote:
> I would suggest to store your images in a file system and the store paths to
> those images.
>
> You can keep files and entries in your database synced via triggers/stored
> procedures (eventually written in python since pgsql
On Thu, 30 Mar 2023 at 15:42, Robert Haas wrote:
> On Thu, Mar 30, 2023 at 1:19 AM Jeff Davis wrote:
> > I say just take the special case out of 0001. If the trigger doesn't
> > work as a SECURITY_RESTRICTED_OPERATION, and is also ENABLED ALWAYS,
> > then the user can just use the new option in
On 2023-03-27 Mo 13:18, Andres Freund wrote:
Hi,
On 2023-03-26 21:13:41 -0400, Andrew Dunstan wrote:
On Mar 26, 2023, at 5:28 PM, Andres Freund wrote:
On 2023-03-26 12:39:08 -0700, Andres Freund wrote:
First: I am *not* arguing we shouldn't repair building against strawberry perl
with
On Wed, Mar 29, 2023 at 08:26:23PM +0200, Daniel Gustafsson wrote:
> > On 29 Mar 2023, at 19:18, Bruce Momjian wrote:
> > We would have to convert all supported branches, and tell all forks to
> > do the same (hopefully at the same time). The new standard would then
> > be for all single-line
On 30.03.23 03:29, Andres Freund wrote:
One might think that, but the precedent in other equivalent systems is that
you reference the key and the algorithm separately. There is some
(admittedly not very conclusive) discussion about this near [0].
[0]:
On Thu, Mar 30, 2023 at 1:19 AM Jeff Davis wrote:
> I say just take the special case out of 0001. If the trigger doesn't
> work as a SECURITY_RESTRICTED_OPERATION, and is also ENABLED ALWAYS,
> then the user can just use the new option in 0002 to get the old
> behavior. I don't see a reason to
On 29.03.23 23:29, Riccardo Gobbo wrote:
Question: for better performance is it better to store images as BYTEA
or convert every image in base64 and store the generated string (so in
html it's enough to insert the base64 string in the tag)?
Converting an image in base64 would use a 30% more
On 30.03.23 10:49, Pavel Stehule wrote:
If I reorganize the patch to the following structure, can be it useful
for you?
1. really basic functionality (no temporary variables, no def
expressions, no memory cleaning)
SELECT variable
LET should be supported + doc, + related tests.
2.
On Thu, Mar 30, 2023 at 12:18 AM Masahiko Sawada wrote:
>
> On Wed, Mar 29, 2023 at 7:57 PM Kumar, Sachin wrote:
> >
> > > > > > From: Amit Kapila
> > > > > > > I think we won't be able to use same snapshot because the
> > > > > > > transaction will be committed.
> > > > > > > In
On Fri, Mar 24, 2023 at 5:47 PM Jacob Champion wrote:
> Okay, but this is walking back from the network example you just
> described upthread. Do you still consider that in scope, or...?
Sorry, I don't know which example you mean.
> > If machines B and C aren't under our control such that we
Hi hackers!
Could the 1 byte from the JsonPath header be used to store version?
Or how many bits from the header could be used for the version value?
On Mon, Mar 27, 2023 at 12:54 PM Nikita Malakhov wrote:
> Hi hackers!
>
> I've got a question on the JsonPath header - currently the header size
On Wed, Mar 29, 2023 at 11:04 AM Jeff Davis wrote:
> I'm not clear on what proposal you are making and/or endorsing?
>
ha -- was just backing up dave's GUC idea.
> 1. Fix our own clients, like psql, to check for binary data they can't
> process.
>
This ought to be impossible IMO. All libpq
On Thu, 30 Mar 2023 at 13:29, houzj.f...@fujitsu.com
wrote:
>
>
>
> > -Original Message-
> > From: houzj.f...@fujitsu.com
> > Sent: Thursday, March 30, 2023 2:37 PM
> >
> > On Tuesday, March 28, 2023 12:13 PM houzj.f...@fujitsu.com
> > wrote:
> > >
> > > On Monday, March 27, 2023 8:08
On 2023-Mar-29, Amit Langote wrote:
> On Wed, Mar 29, 2023 at 3:39 AM Tom Lane wrote:
> > Alvaro Herrera writes:
> > > So I'm back home and found a couple more weird errors in the log:
> >
> > > ERROR: mismatching PartitionPruneInfo found at part_prune_index 0
> > > DETALLE: plan node relids
On Wed, Mar 29, 2023 at 10:23 PM Zheng Li wrote:
>
> On Wed, Mar 29, 2023 at 5:13 AM Amit Kapila wrote:
> >
> > On Wed, Mar 29, 2023 at 2:49 AM Zheng Li wrote:
> > >
> > >
> > > I agree that a full fledged DDL deparser and DDL replication is too
> > > big of a task for one patch. I think we may
On Thu, Mar 30, 2023 at 3:16 PM vignesh C wrote:
>
> On Thu, 30 Mar 2023 at 13:29, houzj.f...@fujitsu.com
> wrote:
> >
> >
> >
> > > -Original Message-
> > > From: houzj.f...@fujitsu.com
> > > Sent: Thursday, March 30, 2023 2:37 PM
> > >
> > > On Tuesday, March 28, 2023 12:13 PM
On Thu, Mar 30, 2023 at 9:22 AM Peter Smith wrote:
>
> I have marked the CF entry for this patch as "ready for committer"
>
LGTM. I'll push this tomorrow unless there are more comments for it.
--
With Regards,
Amit Kapila.
On Thu, 30 Mar 2023 at 10:07, Denis Laxalde wrote:
> Patch 5 is missing respective changes; please find attached a fixup
> patch for these.
Thanks, attached are newly rebased patches that include this change. I
also cast the result of PQcancelSend to to void in the one case where
it's ignored on
> On 30 Mar 2023, at 10:21, Daniel Gustafsson wrote:
>
>> On 30 Mar 2023, at 10:00, Julien Rouhaud wrote:
>>
>> On Thu, Mar 30, 2023 at 3:03 PM Daniel Gustafsson wrote:
>>>
On 30 Mar 2023, at 03:48, Hayato Kuroda (Fujitsu)
wrote:
>>>
While checking the buildfarm, I found a
On Thu, 30 Mar 2023 at 13:29, houzj.f...@fujitsu.com
wrote:
>
>
>
> > -Original Message-
> > From: houzj.f...@fujitsu.com
> > Sent: Thursday, March 30, 2023 2:37 PM
> >
> > On Tuesday, March 28, 2023 12:13 PM houzj.f...@fujitsu.com
> > wrote:
> > >
> > > On Monday, March 27, 2023 8:08
I would suggest to store your images in a file system and the store paths
to those images.
You can keep files and entries in your database synced via triggers/stored
procedures (eventually written in python since pgsql doesn't allow you to
interact with the file system).
On Thu, Mar 30, 2023,
Good evening,
I'm a Master degree student at University of Padua in Italy and I'm
developing a web application as assignment for the Web application course.
Context: the Web application that my group is developing would ideally be
used to manage county side fairs where there would be foods and
Hi
st 29. 3. 2023 v 12:17 odesílatel Peter Eisentraut <
peter.eisentr...@enterprisedb.com> napsal:
> On 24.03.23 08:04, Pavel Stehule wrote:
> > Maybe I can divide the patch 0002-session-variables to three sections -
> > related to memory management, planning and execution?
>
> Personally, I
> On 30 Mar 2023, at 10:00, Julien Rouhaud wrote:
>
> On Thu, Mar 30, 2023 at 3:03 PM Daniel Gustafsson wrote:
>>
>>> On 30 Mar 2023, at 03:48, Hayato Kuroda (Fujitsu)
>>> wrote:
>>
>>> While checking the buildfarm, I found a failure on NetBSD caused by the
>>> added code[1]:
>>
>> Thanks
Dear Brar,
Thank you for updating the patch. The patch looks good to me.
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
Jelte Fennema a écrit :
> On Wed, 29 Mar 2023 at 10:43, Denis Laxalde wrote:
> > More importantly, not having PQcancelSend() creating the PGcancelConn
> > makes reuse of that value, passing through PQcancelReset(), more
> > intuitive. E.g., in the tests:
>
> You convinced me. Attached is an
Hi
ne 26. 3. 2023 v 19:44 odesílatel Dmitry Dolgov <9erthali...@gmail.com>
napsal:
> > On Fri, Mar 24, 2023 at 08:04:08AM +0100, Pavel Stehule wrote:
> > čt 23. 3. 2023 v 19:54 odesílatel Pavel Stehule >
> > napsal:
> >
> > > čt 23. 3. 2023 v 16:33 odesílatel Peter Eisentraut <
> > >
On Thu, Mar 30, 2023 at 3:03 PM Daniel Gustafsson wrote:
>
> > On 30 Mar 2023, at 03:48, Hayato Kuroda (Fujitsu)
> > wrote:
>
> > While checking the buildfarm, I found a failure on NetBSD caused by the
> > added code[1]:
>
> Thanks for reporting, I see that lapwing which runs Linux (Debian 7,
Hi,
On Wed, Mar 29, 2023 at 12:02:30PM +0500, Andrey Lepikhov wrote:
>
> Previously, we read int this mailing list some controversial opinions on
> queryid generation and Jumbling technique. Here we don't intend to solve
> these problems but help an extension at least don't conflict with others
Hi,
On 2023-03-04 12:19:57 +0100, Drouvot, Bertrand wrote:
> Subject: [PATCH v52 1/6] Add info in WAL records in preparation for logical
> slot conflict handling.
>
> Overall design:
>
> 1. We want to enable logical decoding on standbys, but replay of WAL
> from the primary might remove data
> On 30 Mar 2023, at 03:48, Hayato Kuroda (Fujitsu)
> wrote:
> While checking the buildfarm, I found a failure on NetBSD caused by the added
> code[1]:
Thanks for reporting, I see that lapwing which runs Linux (Debian 7, gcc 4.7.2)
has the same error. I'll look into it today to get a fix
On 30.03.23 04:33, Jeff Davis wrote:
Attached is a new version of the final patch, which performs
canonicalization. I'm not 100% sure that it's wanted, but it still
seems like a good idea to get the locales into a standard format in the
catalogs, and if a lot more people start using ICU in v16
On Wed, 29 Mar 2023 21:32:05 -0700
Noah Misch wrote:
> On Sun, Jan 22, 2023 at 02:42:46PM -0600, Karl O. Pinc wrote:
> > v10-0001-List-trusted-and-obsolete-extensions.patch
>
> > +
> > + These modules and extensions are obsolete:
> > +
> > +
> > +
> > +
> > +
> > +
>
>
The pg_basebackup code has WalSegSz as uint32, whereas the rest of the
code has it as int. This seems confusing, and using the extra range
wouldn't actually work. This was in the original commit (fc49e24fa6),
but I suppose it was an oversight.From 43c6b03b0d2cc044989de7722b8fd7b136fded7b Mon
81 matches
Mail list logo
