Re: Minimal logical decoding on standbys

2023-04-01 Thread Andres Freund
Hi, On 2023-03-31 12:45:51 +0200, Drouvot, Bertrand wrote: > On 3/31/23 6:33 AM, Andres Freund wrote: > > Hi, > > > > On 2023-03-30 18:23:41 +0200, Drouvot, Bertrand wrote: > > > On 3/30/23 9:04 AM, Andres Freund wrote: > > > > I think this commit is ready to go. Unless somebody thinks

Re: POC: Lock updated tuples in tuple_update() and tuple_delete()

2023-04-01 Thread Andres Freund
Hi, On 2023-04-02 03:37:19 +0300, Alexander Korotkov wrote: > On Sat, Apr 1, 2023 at 8:21 AM Andres Freund wrote: > > Given that the in-tree state has been broken for a week, I think it probably > > is time to revert the commits that already went in. > > The revised patch is attached. The most

Re: POC: Lock updated tuples in tuple_update() and tuple_delete()

2023-04-01 Thread Alexander Korotkov
.Hi! On Sat, Apr 1, 2023 at 8:21 AM Andres Freund wrote: > On 2023-03-31 16:57:41 +0300, Alexander Korotkov wrote: > > On Wed, Mar 29, 2023 at 8:34 PM Alexander Korotkov > > wrote: > > > On Mon, Mar 27, 2023 at 1:49 PM Alexander Korotkov > > > wrote: > > > > On Fri, Mar 24, 2023 at 3:39 AM

Re: Non-superuser subscription owners

2023-04-01 Thread Andres Freund
Hi, On April 1, 2023 9:00:00 AM PDT, Alexander Lakhin wrote: >Hello Robert, > >31.03.2023 23:00, Robert Haas wrote: >> That looks like a reasonable fix but I can't reproduce the problem >> locally. I thought the reason why that machine sees the problem might >> be that it uses

Re: zstd compression for pg_dump

2023-04-01 Thread Tomas Vondra
On 4/1/23 15:36, Justin Pryzby wrote: > > ... > >> If there are no concerns, why disable it outside Windows? I don't have a >> good idea how beneficial the multi-threaded compression is, so I can't >> quite judge the risk/benefits tradeoff. > > Because it's a minor/fringe feature, and it's

Re: Option to not use ringbuffer in VACUUM, using it in failsafe mode

2023-04-01 Thread Justin Pryzby
On Sat, Apr 01, 2023 at 01:29:13PM -0400, Melanie Plageman wrote: > Hi, > > I was just doing some cleanup on the main patch in this set and realized > that it was missing a few things. One of which is forbidding the > BUFFER_USAGE_LIMIT with VACUUM FULL since VACUUM FULL does not use a >

Re: Option to not use ringbuffer in VACUUM, using it in failsafe mode

2023-04-01 Thread Melanie Plageman
Hi, I was just doing some cleanup on the main patch in this set and realized that it was missing a few things. One of which is forbidding the BUFFER_USAGE_LIMIT with VACUUM FULL since VACUUM FULL does not use a BAS_VACUUM strategy. VACUUM FULL technically uses a bulkread buffer access strategy

Re: Non-superuser subscription owners

2023-04-01 Thread Alexander Lakhin
Hello Robert, 31.03.2023 23:00, Robert Haas wrote: That looks like a reasonable fix but I can't reproduce the problem locally. I thought the reason why that machine sees the problem might be that it uses -DRELCACHE_FORCE_RELEASE, but I tried that option here and the tests still pass. Anyone

Re: BUG #17877: Referencing a system column in a foreign key leads to incorrect memory access

2023-04-01 Thread Ranier Vilela
Em sex., 31 de mar. de 2023 às 16:25, Tom Lane escreveu: > Ranier Vilela writes: > > I think that commit f0d65c0 > > < > https://github.com/postgres/postgres/commit/f0d65c0eaf05d6acd3ae05cde4a31465eb3992b2 > > > > has an oversight. > > Attnum == 0, is system column too, right? > > No, it's not

Re: zstd compression for pg_dump

2023-04-01 Thread Justin Pryzby
On Sat, Apr 01, 2023 at 02:49:44PM +0200, Tomas Vondra wrote: > On 4/1/23 02:28, Justin Pryzby wrote: > > On Sat, Apr 01, 2023 at 02:11:12AM +0200, Tomas Vondra wrote: > >> On 4/1/23 01:16, Justin Pryzby wrote: > >>> On Tue, Mar 28, 2023 at 06:23:26PM +0200, Tomas Vondra wrote: > On 3/27/23

Re: is_superuser is not documented

2023-04-01 Thread Joseph Koshakow
On Wed, Mar 29, 2023 at 5:21 PM Bruce Momjian wrote: > >On Thu, Mar 2, 2023 at 12:00:43PM -0500, Joseph Koshakow wrote: >> >> >> On Thu, Mar 2, 2023 at 11:53 AM Fujii Masao < masao.fu...@oss.nttdata.com> >> wrote: >> > >> >On 2022/09/14 14:27, bt22kawamotok wrote:

Re: zstd compression for pg_dump

2023-04-01 Thread Tomas Vondra
On 4/1/23 02:28, Justin Pryzby wrote: > On Sat, Apr 01, 2023 at 02:11:12AM +0200, Tomas Vondra wrote: >> On 4/1/23 01:16, Justin Pryzby wrote: >>> On Tue, Mar 28, 2023 at 06:23:26PM +0200, Tomas Vondra wrote: On 3/27/23 19:28, Justin Pryzby wrote: > On Fri, Mar 17, 2023 at 03:43:31AM

Re: POC: Lock updated tuples in tuple_update() and tuple_delete()

2023-04-01 Thread Pavel Borisov
Hi, Andres! On Sat, 1 Apr 2023, 09:21 Andres Freund, wrote: > Given that the in-tree state has been broken for a week, I think it > probably > is time to revert the commits that already went in. > It seems that although the patch addressing the issues is not a quick fix, there is a big