Re: PostgreSQL 16 Beta 1 Released!

2023-06-02 Thread Marco Atzeri
On 25/05/2023 15:08, PostgreSQL Global Development Group wrote: PostgreSQL 16 Beta 1 Released! just me ? make -C backend/snowball install make[2]: Entering directory '/pub/devel/postgresql/postgresql-16.0-0.1.x86_64/build/src/backend/snowball' /usr/bin/mkdir -p

Re: [BUG] pg_dump does not properly deal with BEGIN ATOMIC function

2023-06-02 Thread Imseih (AWS), Sami
> So it's lacking a rule to tell it what to do in this case, and the > default is the wrong way around. I think we need to fix it in > about the same way as the equivalent case for matviews, which > leads to the attached barely-tested patch. Thanks for the patch! A test on the initially reported

Re: Cutting support for OpenSSL 1.0.1 and 1.0.2 in 17~?

2023-06-02 Thread Daniel Gustafsson
> On 2 Jun 2023, at 23:21, Michael Paquier wrote: > > On Fri, Jun 02, 2023 at 10:35:43AM +0200, Daniel Gustafsson wrote: >> I think we should avoid the is-defined-in dance and just pull out the version >> numbers for comparisons. While it's true that LibreSSL doesn't play well >> with >>

Re: Cutting support for OpenSSL 1.0.1 and 1.0.2 in 17~?

2023-06-02 Thread Michael Paquier
On Fri, Jun 02, 2023 at 10:35:43AM +0200, Daniel Gustafsson wrote: > I think we should avoid the is-defined-in dance and just pull out the version > numbers for comparisons. While it's true that LibreSSL doesn't play well with > OpenSSL versions, they do define their own which can be checked for

[Question] pgwal increasing over max_wal_size

2023-06-02 Thread Ankit Pandey
Hi all, I am facing very unusual behaviour in our production postgres system running on pg15 and deployed on AWS. pgwal is mounted on a separate EBS drive with size of 100 GBs (on disk size as seen from df -hT). max_wal_size = 95 GB, min_wal_size = 1 GB, checkpoint_completion_target = 0.9 Issue

pg_upgrade --copy-file-range

2023-06-02 Thread Thomas Munro
Hello, I was just in a pg_upgrade unconference session at PGCon where the lack of $SUBJECT came up. This system call gives the kernel the option to use fast block cloning on XFS, ZFS (as of very recently), etc, and works on Linux and FreeBSD. It's probably much the same as --clone mode on COW

Re: RFC: Logging plan of the running query

2023-06-02 Thread James Coleman
Hello, Thanks for working on this patch! On Thu, Dec 8, 2022 at 12:10 AM torikoshia wrote: > > BTW, since this patch depends on ProcessInterrupts() and EXPLAIN codes > which is used in auto_explain, I'm feeling that the following discussion > also applies to this patch. > > > -- > >

Prevent psql \watch from running queries that return no rows

2023-06-02 Thread Greg Sabino Mullane
Attached is a patch to allow a new behavior for the \watch command in psql. When enabled, this instructs \watch to stop running once the query returns zero rows. The use case is the scenario in which you are watching the output of something long-running such as pg_stat_progress_create_index, but

Re: [PATCH] Missing dep on Catalog.pm in meson rules

2023-06-02 Thread Tristan Partin
On Fri Jun 2, 2023 at 8:47 AM CDT, Andres Freund wrote: > Hi, > > On 2023-06-02 08:10:43 -0500, Tristan Partin wrote: > > > I wonder if we instead could just make perl output the files it loads and > > > handle dependencies automatically that way? But that's more work, so it's > > > probably the

Re: [BUG] pg_dump does not properly deal with BEGIN ATOMIC function

2023-06-02 Thread Kirk Wolak
On Fri, Jun 2, 2023 at 8:16 AM Tom Lane wrote: > or with -v: > > pg_dump: warning: could not resolve dependency loop among these items: > pg_dump: FUNCTION a_f (ID 218 OID 40664) > pg_dump: CONSTRAINT a_pkey (ID 4131 OID 40663) > pg_dump: POST-DATA BOUNDARY (ID 4281) > pg_dump: TABLE

Re: Adding SHOW CREATE TABLE

2023-06-02 Thread Kirk Wolak
On Thu, Jun 1, 2023 at 4:46 PM Andrew Dunstan wrote: > On 2023-06-01 Th 16:39, Kirk Wolak wrote: > > On Thu, Jun 1, 2023 at 3:13 PM Andrew Dunstan wrote: > >> On 2023-06-01 Th 12:57, Kirk Wolak wrote: >> >> PS: It dawned on me that if pg_dump had used server side code to generate >> its DDL,

Re: [PATCH] Missing dep on Catalog.pm in meson rules

2023-06-02 Thread Andres Freund
Hi, On 2023-06-02 08:10:43 -0500, Tristan Partin wrote: > > I wonder if we instead could just make perl output the files it loads and > > handle dependencies automatically that way? But that's more work, so it's > > probably the right thing to go for the manual path for now. > > I am not familar

Wrong syntax in feature description

2023-06-02 Thread Peter Smith
Hi, I noticed a feature description [1] referring to a command example: CREATE PUBLICATION ... FOR ALL TABLES IN SCHEMA ~~ AFAIK that should say "FOR TABLES IN SCHEMA" (without the "ALL", see [2]) -- [1] https://www.postgresql.org/about/featurematrix/detail/391/ [2]

Re: [PATCH] Missing dep on Catalog.pm in meson rules

2023-06-02 Thread Tristan Partin
On Fri Jun 2, 2023 at 8:00 AM CDT, Andres Freund wrote: > Hi, > > On 2023-06-01 23:06:04 -0500, Tristan Partin wrote: > > In our case, we should add the ^line to src/backend/catalog/meson.build. > > src/backend is only reached well after src/include, due to needing > dependencies on files

Re: [PATCH] Missing dep on Catalog.pm in meson rules

2023-06-02 Thread Andres Freund
Hi, On 2023-06-01 23:06:04 -0500, Tristan Partin wrote: > In our case, we should add the ^line to src/backend/catalog/meson.build. src/backend is only reached well after src/include, due to needing dependencies on files generated in src/include. I wonder if we instead could just make perl

Re: postgres_fdw: wrong results with self join + enable_nestloop off

2023-06-02 Thread Nishant Sharma
I also agree that Richard's patch is better. As it fixes the issue at the backend and does not treat pseudoconstant as local condition. I have tested Richard's patch and observe that it is resolving the problem. Patch looks good to me as well. *I only had a minor comment on below change:-*

Re: Request for new function in view update

2023-06-02 Thread Terry Brennan
Hi Heikki PostgreSQL supports only one-table views, which means that the relational operators are limited to "selection" and "projection." I have provided update methods for these two, plus for two kinds of joins and unions. I discuss a hierarchical join, when two tables together define an

Re: [BUG] pg_dump does not properly deal with BEGIN ATOMIC function

2023-06-02 Thread Tom Lane
"Imseih (AWS), Sami" writes: > With the attached repro, pg_restore fails with > pg_restore: error: could not execute query: ERROR: constraint "a_pkey" for > table "a" does not exist > Command was: CREATE FUNCTION public.a_f(c1_in text, c2 integer DEFAULT 60) > RETURNS void Hmph. The other

Re: Cutting support for OpenSSL 1.0.1 and 1.0.2 in 17~?

2023-06-02 Thread Daniel Gustafsson
> On 27 May 2023, at 04:02, Michael Paquier wrote: > Making the build fail straight when setting up things is OK > by me, but I am not convinced that X509_get_signature_nid() would be > the right choice for the job, as it is an OpenSSL artifact originally, > AFAIK. I think we should avoid the

Re: Do we want a hashset type?

2023-06-02 Thread Ants Aasma
On Wed, 31 May 2023 at 18:40, Joel Jacobson wrote: > > On Wed, May 31, 2023, at 16:53, Tomas Vondra wrote: > > I think this needs a better explanation - what exactly is a hashset in > > this context? Something like an array with a hash for faster lookup of > > unique elements, or what? > > In

Tighten a little bit the computation of potential commutator pairs

2023-06-02 Thread Richard Guo
In make_outerjoininfo, I think we can additionally check a property that's needed to apply OJ identity 3: the lower OJ in the RHS cannot be a member of inner_join_rels because we do not try to commute with any of lower inner joins. --- a/src/backend/optimizer/plan/initsplan.c +++