Hi,
On 2023-06-21 11:53:44 +0900, Michael Paquier wrote:
> Compiling Postgres up to 13 with OpenSSL 3.0 leads to a couple of
> compilation warnings with what OpenSSL considers as deprecated, like:
> sha2_openssl.c: In function pg_sha384_init
> sha2_openssl.c:70:9: warning: SHA384_Init is
Hi,
On 2023-06-16 14:15:08 -0700, Peter Geoghegan wrote:
> Attached patch adds additional hardening to nbtree page deletion. It
> makes nbtree VACUUM tolerate a certain sort of cross-page
> inconsistencies in the structure of an index (corruption). VACUUM can
> press on, avoiding an eventual
Hi,
On 2023-06-20 15:14:26 +0530, Amit Kapila wrote:
> On Mon, Jun 19, 2023 at 5:13 PM Amit Kapila wrote:
> >
> > On Sun, Jun 18, 2023 at 12:18 AM Peter Geoghegan wrote:
> > >
> > > On Sat, Jun 17, 2023 at 11:29 AM Jaime Casanova
> > > wrote:
> > > > I have been testing 16beta1, last commit
>
On Tue, Jun 20, 2023 at 09:33:45PM -0700, Nathan Bossart wrote:
> I've started seen sporadic timeouts for 009_twophase.pl in cfbot, and I'm
> wondering if it's related to this change.
>
> https://api.cirrus-ci.com/v1/task/4978271838797824/logs/test_world.log
>
On Tue, Jun 20, 2023 at 10:49:03AM +0900, Michael Paquier wrote:
> And done for v13 and v14. I have split the test and comment changes
> into their own commit, doing that for v13~HEAD.
I've started seen sporadic timeouts for 009_twophase.pl in cfbot, and I'm
wondering if it's related to this
On Wed, Jun 21, 2023 at 10:21:04AM +0900, Michael Paquier wrote:
> Looking at 0001..
Thanks for taking a look.
> -step s2_auth { SET ROLE regress_cluster_part; }
> +step s2_auth { SET ROLE regress_cluster_part; SET
> client_min_messages = ERROR; }
>
> Is this change
On Tuesday, June 20, 2023 5:44 PM Amit Kapila wrote:
>
> On Mon, Jun 19, 2023 at 5:13 PM Amit Kapila
> wrote:
> >
> > On Sun, Jun 18, 2023 at 12:18 AM Peter Geoghegan wrote:
> > >
> > > On Sat, Jun 17, 2023 at 11:29 AM Jaime Casanova
> > > wrote:
> > > > I have been testing 16beta1, last
Hi,
On 2023-06-21 08:54:48 +0530, Amit Kapila wrote:
> On Mon, Jun 19, 2023 at 11:47 PM Andres Freund wrote:
> >
> > On June 19, 2023 10:37:45 AM PDT, Tom Lane wrote:
> > >Andres Freund writes:
> > >> Unfortunately, due to some personal life business, it took until for me
> > >> to
> > >>
Hi,
On 2023-06-21 09:35:36 +0700, John Naylor wrote:
> On Wed, Jun 21, 2023 at 12:46 AM Andres Freund wrote:
> >
> > Hi,
> >
> > On 2023-06-20 10:29:41 -0700, Andres Freund wrote:
> > > On 2023-06-20 10:23:14 +0700, John Naylor wrote:
> > > > Here's a start at that, trying with postmaster only.
Michael Paquier writes:
> As a whole, I'd like to think that this is an improvement even for
> stable branches with these weird isspace() handlings, so I'm OK with
> the current status in all the branches.
Sounds like we're all content with that.
> There's an argument about \v,
> IMO, but I
On Mon, Jun 19, 2023 at 11:47 PM Andres Freund wrote:
>
> On June 19, 2023 10:37:45 AM PDT, Tom Lane wrote:
> >Andres Freund writes:
> >> Unfortunately, due to some personal life business, it took until for me to
> >> feel comfortable pushing the fix for
> >>
At Tue, 20 Jun 2023 22:27:36 +0900, torikoshia
wrote in
> On 2023-06-19 14:37, Michael Paquier wrote:
> > On Mon, Jun 19, 2023 at 11:24:29AM +0900, torikoshia wrote:
> >> Thanks, now I understand what you meant.
> > If I may ask, why is the refactoring of 0003 done after the feature in
> >
Hi all,
(adding Daniel in CC.)
Compiling Postgres up to 13 with OpenSSL 3.0 leads to a couple of
compilation warnings with what OpenSSL considers as deprecated, like:
sha2_openssl.c: In function pg_sha384_init
sha2_openssl.c:70:9: warning: SHA384_Init is deprecated =
Since OpenSSL 3.0
On Thu, Jun 15, 2023 at 7:50 PM Amit Kapila wrote:
>
> On Tue, Jun 13, 2023 at 2:06 PM Masahiko Sawada wrote:
> >
> > On Sun, Jun 11, 2023 at 5:31 AM Andres Freund wrote:
> > >
> > > A separate issue is that TransactionIdDidAbort() can end up being very
> > > slow if
> > > a lot of
On Wed, Jun 21, 2023 at 12:46 AM Andres Freund wrote:
>
> Hi,
>
> On 2023-06-20 10:29:41 -0700, Andres Freund wrote:
> > On 2023-06-20 10:23:14 +0700, John Naylor wrote:
> > > Here's a start at that, trying with postmaster only. Unfortunately, I
get
> > > "MADV_COLLAPSE failed: Invalid argument".
Re: Alvaro's comment [1] "From a translation standpoint, this doesn't
seem good".
Except, please note that there are already multiple message format
strings in the HEAD code that look like "%s for subscription ...",
that are using the get_worker_name() function for the name
substitution.
e.g.
-
On Fri, Jun 16, 2023 at 2:15 PM Peter Geoghegan wrote:
> Attached patch adds additional hardening to nbtree page deletion. It
> makes nbtree VACUUM tolerate a certain sort of cross-page
> inconsistencies in the structure of an index (corruption). VACUUM can
> press on, avoiding an eventual
On Tue, Jun 20, 2023 at 03:52:57PM -0700, Nathan Bossart wrote:
> However, I do agree that it feels inconsistent. Besides the options you
> proposed, we might also consider making REINDEX work a bit more like VACUUM
> and ANALYZE and emit a WARNING for any relations that the user is not
>
On Sun, Jun 18, 2023 at 10:57 PM Tom Lane wrote:
>
> James Coleman writes:
> > Over in "Parallelize correlated subqueries that execute within each
> > worker" [1} Richard Guo found a bug in the current version of my patch
> > in that thread. While debugging that issue I've been wondering why
> >
On Mon, Jun 19, 2023 at 4:28 PM Peter Geoghegan wrote:
> We still fall short when it comes to handling boundary cases optimally
> during backwards scans. This is at least true for a subset of
> backwards scans that request "goback=true" processing inside
> _bt_first. Attached patch improves
On Tue, Jun 20, 2023 at 09:04:26AM -0400, Evan Jones wrote:
> My one last suggestion: We *could* revert the backpatching if we are
> concerned about this change, but I'm not personally sure that is necessary.
> As we discussed, this is an unusual corner case in an "extension" type that
> many
On Tue, Jun 13, 2023 at 02:50:30PM +0900, Michael Paquier wrote:
> On Mon, Jun 12, 2023 at 02:37:15PM -0700, Nathan Bossart wrote:
> > Fair enough. I know I've been waffling in the GUC versus function
> > discussion, but FWIW v7 of the patch looks reasonable to me.
>
> +
On Tue, Jun 20, 2023 at 11:43:05AM -0700, Jeff Davis wrote:
> The only behavior I'm worried about is REINDEX. I'm not sure what we
> should do about it, or if we even want to do something about it. If we
> want REINDEX to fail in this case, we should be sure to check
> permissions on everything
I've attached rebased versions of the remaining two patches.
On Tue, Jun 20, 2023 at 11:43:05AM -0700, Jeff Davis wrote:
> * REINDEX TABLE applies to all indexes in all partitions, which seems
> a bit inconsistent.
>
> The only behavior I'm worried about is REINDEX. I'm not sure what we
>
On Tue, Jun 20, 2023 at 11:49:36AM -0700, Jeff Davis wrote:
> On Tue, 2023-06-20 at 10:56 -0700, Nathan Bossart wrote:
>> On Tue, Jun 20, 2023 at 10:49:27AM -0700, Nathan Bossart wrote:
>> > Patch incoming...
>>
>> Attached.
>
> Looks good to me.
Thanks, committed.
--
Nathan Bossart
Amazon
On 6/19/23 19:30, Heikki Linnakangas wrote:
On 18/06/2023 21:27, Joe Conway wrote:
I have proposed a targeted fix that I believe is safe to backpatch --
attached.
IIUC, Tom was +1, but Heikki was looking for a more general solution.
My issue with the more general solution is that it will
On Tue, 2023-06-20 at 12:16 -0400, Tom Lane wrote:
> Jeff Davis writes:
> > Status on collation loose ends:
>
> This all sounds good to me.
Patches attached.
0001 also removes the code to get a default locale when ICU is being
used, because that was a part of the same commit that changed the
On Tue, 2023-06-20 at 10:56 -0700, Nathan Bossart wrote:
> On Tue, Jun 20, 2023 at 10:49:27AM -0700, Nathan Bossart wrote:
> > Patch incoming...
>
> Attached.
Looks good to me.
Regards,
Jeff Davis
On 6/20/23 20:08, jian he wrote:
> On Wed, Jun 21, 2023 at 12:25 AM Tomas Vondra
> ...
>> http://www.wiscorp.com/sqlmultisets.zip
>
>> Conceptually, a multiset is an unordered collection of elements, all of the
>> same type, with dupli-
>> cates permitted. Unlike arrays, a multiset is an
On Mon, 2023-06-19 at 14:55 -0700, Nathan Bossart wrote:
> I'm hoping to commit 0002 and 0003 by the end of the week so
> that these fixes are available in 16beta2.
A few observations for the case where a user does have the MAINTAIN
privilege on a partitioned table but not the partitions:
*
On Wed, Jun 21, 2023 at 12:25 AM Tomas Vondra
wrote:
>
>
>
> On 6/20/23 16:56, Joel Jacobson wrote:
> > On Tue, Jun 20, 2023, at 14:10, Tomas Vondra wrote:
> >> On 6/20/23 12:59, Joel Jacobson wrote:
> >>> On Mon, Jun 19, 2023, at 02:00, jian he wrote:
> select
On Tue, Jun 20, 2023 at 10:49:27AM -0700, Nathan Bossart wrote:
> Patch incoming...
Attached.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
>From 8842b58808372175202960c0a7067b5f00eee122 Mon Sep 17 00:00:00 2001
From: Nathan Bossart
Date: Wed, 14 Jun 2023 11:08:03 -0700
On Tue, Jun 20, 2023 at 10:40:32AM -0700, Nathan Bossart wrote:
> On Tue, Jun 20, 2023 at 10:04:37AM -0700, Jeff Davis wrote:
>> I think v4-0001 broke the handling of toast tables? It looks like you
>> removed the check for !skip_privs but need to add it to the flags in
>>
Hi,
On 2023-06-20 10:29:41 -0700, Andres Freund wrote:
> On 2023-06-20 10:23:14 +0700, John Naylor wrote:
> > Here's a start at that, trying with postmaster only. Unfortunately, I get
> > "MADV_COLLAPSE failed: Invalid argument".
>
> I also see that. But depending on the steps, I also see
>
On Tue, Jun 20, 2023 at 09:16:59AM -0700, Jeff Davis wrote:
> On Tue, 2023-06-20 at 14:26 +0900, Michael Paquier wrote:
>> TBH, I have a mixed feeling about this line of reasoning because
>> MAINTAIN is much broader and less specific than TRUNCATE, for
>> instance, being spawned across so much
On Tue, Jun 20, 2023 at 10:04:37AM -0700, Jeff Davis wrote:
> I think v4-0001 broke the handling of toast tables? It looks like you
> removed the check for !skip_privs but need to add it to the flags in
> vacuum_is_permitted_for_relation().
Good catch. I'm not sure why some of the calls to
Hi,
On 2023-06-20 10:23:14 +0700, John Naylor wrote:
> Here's a start at that, trying with postmaster only. Unfortunately, I get
> "MADV_COLLAPSE failed: Invalid argument".
I also see that. But depending on the steps, I also see
MADV_COLLAPSE failed: Resource temporarily unavailable
I suspect
On Fri, Jun 16, 2023 at 9:24 PM Amit Kapila wrote:
> > Is there an alternative implementation I'm missing, maybe, or a way to
> > make this feature more generally applicable? "We have table Y and want
> > it to be migrated as part of table X" seems to fall squarely under the
> > logical
Alvaro Herrera writes:
> Do you mean with $MAJOR_VERSION being Postgres' version? That means we
> need to install a new symlink every year, even when pg_bsd_indent
> doesn't change. I'd rather have it call pg_bsd_indent-$INDENT_VERSION
> first, and pg_bsd_indent if that doesn't exist. I
On Mon, 2023-06-19 at 14:55 -0700, Nathan Bossart wrote:
> In v4 of the patch set, I moved the skip_privs flag refactoring to
> 0001. I
> intend to commit this tomorrow unless there is additional feedback.
I think v4-0001 broke the handling of toast tables? It looks like you
removed the check
On 2023-May-31, Bruce Momjian wrote:
> I guess we could try looking for pg_bsd_indent-$MAJOR_VERSION first,
> then pg_bsd_indent.
Do you mean with $MAJOR_VERSION being Postgres' version? That means we
need to install a new symlink every year, even when pg_bsd_indent
doesn't change. I'd rather
On 6/20/23 16:56, Joel Jacobson wrote:
> On Tue, Jun 20, 2023, at 14:10, Tomas Vondra wrote:
>> On 6/20/23 12:59, Joel Jacobson wrote:
>>> On Mon, Jun 19, 2023, at 02:00, jian he wrote:
select hashset_contains('{1,2}'::int4hashset,NULL::int);
should return null?
>>>
>>> I agree, it
On Tue, Jun 20, 2023, at 16:56, Joel Jacobson wrote:
> I think we have an opportunity here to innovate and potentially influence a
> future set concept in the SQL standard.
Adding to my previous note - If there's a worry about future SQL standards
introducing SETs with NULLs, causing
On Tue, 2023-06-20 at 14:26 +0900, Michael Paquier wrote:
> TBH, I have a mixed feeling about this line of reasoning because
> MAINTAIN is much broader and less specific than TRUNCATE, for
> instance, being spawned across so much more operations.
...
> Some users may find that surprising as they
Jeff Davis writes:
> Status on collation loose ends:
This all sounds good to me.
regards, tom lane
Andrew Dunstan writes:
> I'm intending to add some of the new pgindent features to
> pgperltidy. Preparatory to that here's a rewrite of pgperltidy in perl -
> no new features yet but it does remove the hardcoded path, and requires
> you to pass in one or more files / directories as arguments.
On 2023-06-14 We 03:37, Peter Eisentraut wrote:
On 25.05.23 15:20, Tom Lane wrote:
Peter Eisentraut writes:
Until PG15, calling pgindent without arguments would process the whole
tree. Now you get
No files to process at ./src/tools/pgindent/pgindent line 372.
Is that intentional?
It was
On Tue, Jun 20, 2023, at 14:10, Tomas Vondra wrote:
> On 6/20/23 12:59, Joel Jacobson wrote:
>> On Mon, Jun 19, 2023, at 02:00, jian he wrote:
>>> select hashset_contains('{1,2}'::int4hashset,NULL::int);
>>> should return null?
>>
>> I agree, it should.
>>
>> I've now changed all functions
On 2023-06-19 14:37, Michael Paquier wrote:
On Mon, Jun 19, 2023 at 11:24:29AM +0900, torikoshia wrote:
Thanks, now I understand what you meant.
If I may ask, why is the refactoring of 0003 done after the feature in
0002? Shouldn't the order be reversed? That would make for a cleaner
git
On 2023-06-20 Tu 09:08, Tom Lane wrote:
Andrew Dunstan writes:
On 2023-06-19 Mo 17:07, Tom Lane wrote:
Is koel tracking the right repo? It just spit up with a bunch of
diffs that seem to have little to do with the commit it's claiming
caused them:
Yeah, I changed it so that instead of just
Andrew Dunstan writes:
> On 2023-06-19 Mo 17:07, Tom Lane wrote:
>> Is koel tracking the right repo? It just spit up with a bunch of
>> diffs that seem to have little to do with the commit it's claiming
>> caused them:
> Yeah, I changed it so that instead of just checking new commits it would
Thanks for the detailed discussion. To confirm that I've understood
everything:
* Michael's proposed patch to add hstore_isspace() would be a potential
fix: it resolves my original bug, and does not change the behavior of '\v'.
* We believe the change to '\v' is not a problem, and may be an
On 6/20/23 14:10, Tomas Vondra wrote:
> ...
>
> This is also what the SQL standard does for multisets - there's SQL:20nn
> draft at http://www.wiscorp.com/SQLStandards.html, and the predicate> section (p. 475) explains how this should work with NULL.
>
BTW I just notices there's also a
On 6/20/23 12:59, Joel Jacobson wrote:
> On Mon, Jun 19, 2023, at 02:00, jian he wrote:
>> select hashset_contains('{1,2}'::int4hashset,NULL::int);
>> should return null?
>
> I agree, it should.
>
> I've now changed all functions except int4hashset() (the init function)
> and the aggregate
On 2023-06-19 Mo 17:07, Tom Lane wrote:
Andrew Dunstan writes:
I have set up a new buildfarm animal called koel which will run the module.
Is koel tracking the right repo? It just spit up with a bunch of
diffs that seem to have little to do with the commit it's claiming
caused them:
On Thu, Jun 8, 2023 at 3:33 PM Andrew Dunstan wrote:
>
>
> On 2023-06-08 Th 13:41, Russell Foster wrote:
>
> Hi All:
>
> I upgraded to postgres v15, and I am getting intermittent failures for
> some of the bin regression tests when building on Windows 10. Example:
>
> perl vcregress.pl bincheck
>
On Tue, 20 Jun 2023 at 06:18, Michael Paquier wrote:
> The amount of duplication between the describe and close paths
> concerns me a bit. Should PQsendClose() and PQsendDescribe() be
> merged into a single routine (say PQsendCommand), that uses a message
> type for pqPutMsgStart and a
On Mon, Jun 19, 2023, at 02:00, jian he wrote:
> select hashset_contains('{1,2}'::int4hashset,NULL::int);
> should return null?
I agree, it should.
I've now changed all functions except int4hashset() (the init function)
and the aggregate functions to be STRICT.
I think this patch is OK to send
On Mon, Jun 19, 2023 at 9:56 PM Drouvot, Bertrand
wrote:
>
> On 6/19/23 12:03 PM, Amit Kapila wrote:
> > On Mon, Jun 19, 2023 at 11:34 AM Drouvot, Bertrand
> > wrote:
> >>
> >> Also I think we need to handle the case of invalidated replication
> >> slot(s): should
> >> we drop/recreate it/them?
On Mon, Jun 19, 2023 at 5:13 PM Amit Kapila wrote:
>
> On Sun, Jun 18, 2023 at 12:18 AM Peter Geoghegan wrote:
> >
> > On Sat, Jun 17, 2023 at 11:29 AM Jaime Casanova
> > wrote:
> > > I have been testing 16beta1, last commit
> > > a14e75eb0b6a73821e0d66c0d407372ec8376105
> > > I just let
Hi,
I updated the patches. The main changes are
* to support only dynamic wait event allocation
* to add a regression test
I appreciate any feedback.
The followings are TODO items.
* to check that meson.build works since I tested with old command `make`
now
* to make documents
* to add custom
Status on collation loose ends:
1. There's an open item "Switch to ICU for 17". It's a little bit
confusing exactly what that means, and the CF entry refers to two
items, one of which is the build-time default to --with-icu. As far as
I know, building with ICU by default is a settled issue with
Bruce Momjian писал 2023-06-20 03:42:
Apologies for the delay in my reply to this email. I looked into the
existing code and I found three things:
1) PQserverVersion() just pulls the conn->sversion value from the
existing connection because pqSaveParameterStatus() pulls the
server_version
MERGE is now a data-modification command too.
0002-doc-add-missing-mention-of-MERGE-in-MVCC.patch
Description: Binary data
Trivial fix to make the indentation consistent.
From 46977fbe5fa0a26ef77938a8fe30b9def062e8f8 Mon Sep 17 00:00:00 2001
From: Will Mortensen
Date: Sat, 27 Aug 2022 17:07:11 -0700
Subject: [PATCH 1/6] doc: fix markup indentation in MVCC
---
doc/src/sgml/mvcc.sgml | 16
1 file
On Sun, Jun 18, 2023 at 09:10:59PM -0400, Tom Lane wrote:
> What have you got in mind? We should already have validated encoding
> correctness before the text ever gets to hstore_in, and I'm not clear
> what additional checks would be useful.
I was staring at the hstore parsing code and got the
66 matches
Mail list logo
