Re: [PATCH] Avoid mixing custom and OpenSSL BIO functions

2024-05-19 Thread David Benjamin
state before that. > Rebased version attached. (The conflict was pretty trivial. Both patches add a field to some struct.) David From d949ff826aed2a7a9107be4b166fd48bcae38227 Mon Sep 17 00:00:00 2001 From: David Benjamin Date: Sun, 11 Feb 2024 10:42:25 -0500 Subject: [PATCH] Avoid mixing custom and OpenSS

Re: [PATCH] Avoid mixing custom and OpenSSL BIO functions

2024-04-19 Thread David Benjamin
Circling back here, anything else needed from my end on this patch? On Wed, Feb 21, 2024, 17:04 David Benjamin wrote: > Thanks for the very thorough comments! I've attached a new version of the > patch. > > On Thu, Feb 15, 2024 at 4:17 PM Andres Freund wrote: > >> Hi, >

Re: [PATCH] Avoid mixing custom and OpenSSL BIO functions

2024-02-22 Thread David Benjamin
Thanks for the very thorough comments! I've attached a new version of the patch. On Thu, Feb 15, 2024 at 4:17 PM Andres Freund wrote: > Hi, > > On 2024-02-11 13:19:00 -0500, David Benjamin wrote: > > I've attached a patch for the master branch to fix up the custom BIOs > used

Re: [PATCH] Avoid mixing custom and OpenSSL BIO functions

2024-02-15 Thread David Benjamin
By the way, I'm unable to add the patch to the next commitfest due to the cool off period for new accounts. How long is that period? I don't suppose there's a way to avoid it? On Mon, Feb 12, 2024 at 11:31 AM David Benjamin wrote: > On Mon, Feb 12, 2024 at 9:38 AM Daniel Gustafsson wr

Re: [PATCH] Avoid mixing custom and OpenSSL BIO functions

2024-02-13 Thread David Benjamin
On Mon, Feb 12, 2024 at 9:38 AM Daniel Gustafsson wrote: > > On 11 Feb 2024, at 19:19, David Benjamin wrote: > > It turns out the parts that came from the OpenSSL socket BIO were a > no-op, and in fact PostgreSQL is relying on it being a no-op. Instead, it's > cleaner to ju

[PATCH] Avoid mixing custom and OpenSSL BIO functions

2024-02-12 Thread David Benjamin
Hi all, I've attached a patch for the master branch to fix up the custom BIOs used by PostgreSQL, in light of the issues with the OpenSSL update recently. While c82207a548db47623a2bfa2447babdaa630302b9 (switching from BIO_get_data to BIO_get_app_data) resolved the immediate conflict, I don't