On Mon, 22 Mar 2021 at 11:14, Bharath Rupireddy
wrote:
> On Sun, Mar 7, 2021 at 7:21 PM Japin Li wrote:
>> Thank you point out this. Fixed it in v7 patch set.
>>
>> Please consider the v7 patch for futher review.
>
> Thanks for the patches. I just found the followi
about how REFRESH might be implemented
>> in future.
>
> That makes sense to me. Thanks for the comments. I'm fine to withdraw the
> patch.
>
> I would like to see if the 0001 patch(attaching here) will be useful
> at all. It just splits up the existing ExecRefreshMatView into a few
> functions to make the code readable.
+1.
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.
to put the 'if (explainInfo)' as the first check. That
>> way, the check for skipData can be simplified.
>
> Changed.
>
> Thanks for review comments. Attaching v7 patch set with changes only
> in 0002 patch. Please have a look.
>
The v7 patch looks good to me, and there is n
lems in doing so? If done
> that, we can discard the 0001 patch and comments (1) and (3) becomes
> irrelevant.
Thank you point out this. Fixed it in v7 patch set.
Please consider the v7 patch for futher review.
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.
>From a6
On Sun, 07 Mar 2021 at 17:33, Bharath Rupireddy
wrote:
> On Sun, Mar 7, 2021 at 12:13 PM Japin Li wrote:
>>
>> On Sun, 07 Mar 2021 at 14:25, Bharath Rupireddy
>> wrote:
>> > On Sun, Mar 7, 2021 at 11:49 AM Japin Li wrote:
>> >>
>> &g
On Sun, 07 Mar 2021 at 14:25, Bharath Rupireddy
wrote:
> On Sun, Mar 7, 2021 at 11:49 AM Japin Li wrote:
>>
>> On Fri, 05 Mar 2021 at 19:48, Bharath Rupireddy
>> wrote:
>> > Attaching v5 patch set for further review.
>> >
>>
>> The v5 pat
On Fri, 05 Mar 2021 at 19:48, Bharath Rupireddy
wrote:
> Attaching v5 patch set for further review.
>
The v5 patch looks good to me, if there is no objection, I'll change the
cf status to "Ready for Committer" in few days.
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.
ystem backend, how
> can I reach it? Is there any code or interface demonstration to show me?
> I am looking forward to your prompt reply. Heartfelt thanks.
Here is a document on how to create a new system catalog for PostgreSQL 11.
https://blog.japinli.top/2019/08/postgresql-new-catalog
oncurrent in get_new_heap_oid().
The others looks good to me.
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.
On Wed, 03 Mar 2021 at 20:56, David Steele wrote:
> Do you know if you will have time to review this patch during the
> current commitfest?
>
Sorry for the late reply! I think I have time to review this patch
and I will do it later.
--
Regrads,
Japin Li.
ChengDu WenWu Information T
301 - 310 of 310 matches
Mail list logo
