On Thu, Aug 17, 2023 at 3:51 PM Frédéric Yhuel
wrote:
> On 8/17/23 14:00, Frédéric Yhuel wrote:
> > On 8/17/23 09:32, Frédéric Yhuel wrote:
> >> On 8/10/23 17:06, Juan José Santamaría Flecha wrote:
> >>> Recently I restored a database from a directory format backup
On Thu, Aug 10, 2023 at 5:06 PM Juan José Santamaría Flecha <
juanjo.santama...@gmail.com> wrote:
> On Tue, Jul 4, 2023 at 9:45 AM Daniel Gustafsson wrote:
>
>> As there is no new patch submitted I will go ahead and do that, please
>> feel
>> free to resubmit
ill ignore that character and no sort key value will be generated
for it."
[1] https://en.wikipedia.org/wiki/Kashida
Regards,
Juan José Santamaría Flecha
#include "windows.h"
#include "stdio.h"
static char
comparison(int r)
{
switch (r) {
case 1:
ng
this feature would have been quite useful. So, I would like to resume the
work on this patch, unless OP or someone else is already on it.
Regards,
Juan José Santamaría Flecha
;
>
You can find a good example on how to accomplish this in:
https://github.com/farag2/Utilities/blob/master/Enable_disk_write_caching.ps1
Regards,
Juan José Santamaría Flecha
El lun, 3 jul 2023, 17:42, Alvaro Herrera
escribió:
> On 2023-Jun-19, Juan José Santamaría Flecha wrote:
>
> > Ok, let's see where the report goes:
> >
> >
> https://developercommunity.visualstudio.com/t/CompareStringEx-non-transitive/10393003?q=comparestringex
>
0393003?q=comparestringex
Regards,
Juan José Santamaría Flecha
ities. Take for example the attached program, it'll output:
s1 = s2
s2 = s3
s1 > s3
c1 > c2
c2 > c3
c1 > c3
As you can see the test for CompareStringEx() is broken, but we get a sane
answer with LCMapStringEx().
Regards,
Juan José Santamaría Flecha
compare_transitivity.c
Description: Binary data
On Fri, Jun 9, 2023 at 11:18 AM Daniel Verite
wrote:
> Juan José Santamaría Flecha wrote:
>
> > Just to make sure we are all seeing the same problem, does the attached
> > patch fix your test?
>
> The problem of the random changes in sorting disappear
>
Just to make sure we are all seeing the same problem, does the attached
patch fix your test?
Regards,
Juan José Santamaría Flecha
0001-POC-Inconsistent-results-with-libc-sorting-on-Window.patch
Description: Binary data
l so it could be
backpatchable. This looks fine for HEAD, but are you planning on something
similar for the other branches?
Doesn't pgwin32_get_file_type() fit in dirmod.c? Might be a question of
personal taste, I don't really have strong feelings against win32common.c.
Regards,
Juan José Santamaría Flecha
On Thu, Mar 16, 2023 at 2:05 AM Michael Paquier wrote:
> On Wed, Mar 15, 2023 at 12:18:25PM +0100, Juan José Santamaría Flecha
> wrote:
> > PFA a new version of the patch.
>
> +_pgftello64(FILE *stream)
> +{
> + DWORD fileType;
> +
> + fileType = GetFi
On Wed, Mar 15, 2023 at 5:57 AM Michael Paquier wrote:
> On Tue, Mar 14, 2023 at 01:26:27PM +0100, Juan José Santamaría Flecha
> wrote:
> > As highlighted in [1] fseek() might fail to error even when accessing
> > unseekable streams.
> >
> > PFA a patch th
view it.
[1]
https://www.postgresql.org/message-id/CAC%2BAXB26a4EmxM2suXxPpJaGrqAdxracd7hskLg-zxtPB50h7A%40mail.gmail.com
Regards,
Juan José Santamaría Flecha
Regards,
Juan José Santamaría Flecha
0001-fix-fseek-detection-of-unseekable-files-for-WIN32.patch
Description: Binary data
On Fri, Mar 10, 2023 at 2:37 AM Michael Paquier wrote:
> On Fri, Mar 10, 2023 at 12:12:37AM +0100, Juan José Santamaría Flecha
> wrote:
> > I've broken the patch in two:
> > 1. fixes the detection of unseekable files in checkSeek(), using logic
> that
> > hopefu
On Tue, Mar 7, 2023 at 1:36 PM Juan José Santamaría Flecha <
juanjo.santama...@gmail.com> wrote:
>
> On Thu, Mar 2, 2023 at 8:01 AM Michael Paquier
> wrote:
>
>>
>> The internal implementation of _pgstat64() is used in quite a few
>>
> places, so
set st_mode for FILE_TYPE_UNKNOWN.
> Per the documentation of GetFileType, FILE_TYPE_REMOTE is unused:
>
> https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-getfiletype
> Perhaps it would be safer to fail in this case?
>
+1, we don't know what that might involve.
[1]
https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/get-osfhandle?view=msvc-170
Regards,
Juan José Santamaría Flecha
t. Thank you for taking care of it.
Regards,
Juan José Santamaría Flecha
On Tue, Feb 28, 2023 at 12:55 PM Andrew Dunstan wrote:
> On 2023-02-27 Mo 17:20, Juan José Santamaría Flecha wrote:
>
>
> Hmm, yeah. I'm not sure I understand the point of this test anyway:
>
>
> SELECT to_char(date '2010-03-01', 'DD TMMON ' COLLATE "de_DE");
&
El lun, 27 feb 2023, 23:05, Juan José Santamaría Flecha <
juanjo.santama...@gmail.com> escribió:
>
> The command that's failing is "SET lc_time TO 'de_DE';", and that area of
> code is untouched by this patch. As mentioned in [1], the problem seems to
> come from a Wi
g is "SET lc_time TO 'de_DE';", and that area of
code is untouched by this patch. As mentioned in [1], the problem seems to
come from a Windows bug that the CI images and my development machines have
patched out.
I think we should change the locale name to make the test more robust, as
the attached. But I don't see a problem with making an alias for the
collations.
Regards,
Juan José Santamaría Flecha
0001-change-locale-name-for-test-collate.windows.win1252.patch
Description: Binary data
's locales.
>
What seems to be failing is the setlocale() for 'de_DE'. I haven't been
able to reproduce it locally, but I've seen something similar reported for
python [1].
As a workaround, can you please test "SET lc_time TO 'de-DE';"?
[1] https://bugs.python.org/issue36792
Regards,
Juan José Santamaría Flecha
> are standing on, because the tests should match Unix in their level of
> security.
>
Yes, this is correct.
>
> Only the first patch is modified, but I'm including all of them so they go
through the cfbot.
[1]
https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-creat
.org/41/4057/
Regards,
Juan José Santamaría Flecha
On Thu, Dec 1, 2022 at 8:46 AM Peter Eisentraut <
peter.eisentr...@enterprisedb.com> wrote:
>
> What is the status of this now? I think the other issue has been
> addressed?
>
Yes, that's addressed for MSVC builds. I think there are a couple of
pending issues for MinGW, but those should have
; With extra_version set to -andres the attached results in:
>
> PostgreSQL 16devel-andres on x86_64-linux, compiled by gcc-13.0.0, 64-bit
>
WFM.
Regards,
Juan José Santamaría Flecha
atch is trying to do. For version() we
get:
Configure:
PostgreSQL 16devel on x86_64-pc-linux-gnu, compiled by gcc (Debian
6.3.0-18+deb9u1) 6.3.0 20170516, 64-bit
Meson:
PostgreSQL 16devel on x86_64, compiled by gcc-6.3.0
Patched:
PostgreSQL 16devel on x86_64-linux, compiled by gcc-6.3.0
Regards,
Juan José Santamaría Flecha
On Tue, Nov 15, 2022 at 9:02 PM Andres Freund wrote:
>
> On 2022-11-15 15:35:31 +0100, Juan José Santamaría Flecha wrote:
> > On Tue, Nov 15, 2022 at 1:49 AM Andres Freund
> wrote:
> > > Hm. Is it right that the changes are only done for msvc? win32_port.h
> >
hink this is skipping
collate.linux.utf.sql and infinite_recurse.sql tests in their intended
platforms.
Regards,
Juan José Santamaría Flecha
Hello all,
As mentioned here [1] it might be interesting to complete the returned
information by version() when compiled with meson by including the
host_system.
[1]
https://www.postgresql.org/message-id/20221115195318.5v5ynapmkusgyzks%40awork3.anarazel.de
Regards,
Juan José Santamaría Flecha
SION_STR?
Regards,
Juan José Santamaría Flecha
0001-meson-define-HAVE_LOCALE_T-for-MinGW.patch
Description: Binary data
On Wed, Nov 9, 2022 at 12:02 AM Juan José Santamaría Flecha <
juanjo.santama...@gmail.com> wrote:
> On Mon, Nov 7, 2022 at 4:08 PM Peter Eisentraut <
> peter.eisentr...@enterprisedb.com> wrote:
>
>>
>> This looks pretty good to me. The refactoring of the
Hello all,
Meson doesn't see the redefinition of locale_t done
in src/include/port/win32_port.h, so is not defining
HAVE_LOCALE_T, HAVE_WCSTOMBS_L nor HAVE_MBSTOWCS_L as the
current src/tools/msvc/build.pl script does.
Please find attached a patch for so.
Regards,
Juan José Santamaría Flecha
se most locales are failing with "skipping locale
with unrecognized encoding", but checking what's wrong
with pg_get_encoding_from_locale() in MiNGW is subject for another thread.
[1]
https://stackoverflow.com/questions/56419639/what-does-beta-use-unicode-utf-8-for-worldwide-language-
. In the current
version the collations retain their native name, but an alias is created
for those with a shape that we can assume a POSIX equivalent exists.
Please find attached a new version.
Regards,
Juan José Santamaría Flecha
v7-0002-Add-collate.windows.win1252-test.patch
Description: Binary data
v7-0001-WIN32-pg_import_system_collations.patch
Description: Binary data
On Wed, Jul 20, 2022 at 1:44 PM Thomas Munro wrote:
> On Wed, Jul 20, 2022 at 10:27 PM Juan José Santamaría Flecha
> wrote:
> > Still, WIN1252 is not the wrong answer for what we are asking. Even if
> you enable UTF-8 support [1], the system will use the current default
> Wind
rrent default Windows
ANSI code page (ACP) for the locale and UTF-8 for the code page.
[1]
https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/setlocale-wsetlocale?view=msvc-170
Regards,
Juan José Santamaría Flecha
nto the new cluster?
[1]
https://www.postgresql.org/message-id/flat/0050ec23-34d9-2765-9015-98c04f0e18ac%40postgrespro.ru
Regards,
Juan José Santamaría Flecha
the test on cirrus.
Regards,
Juan José Santamaría Flecha
>
v6-0001-WIN32-pg_import_system_collations.patch
Description: Binary data
v6-0002-Add-collate.windows.win1252-test.patch
Description: Binary data
ybe this thread can push those others forward.
Regards,
Juan José Santamaría Flecha
>
,
> particularly as this would allow us to get rid of this code related to
> locales.
>
Even Windows Server 2008 [1] is at its End of Life, so this should surprise
no one.
[1]
https://docs.microsoft.com/en-us/troubleshoot/windows-server/windows-server-eos-faq/end-of-support-windows-server-2008-2008r2
Regards,
Juan José Santamaría Flecha
>
>
w64/blob/master/mingw-w64-headers/include/sdkddkver.h
Regards,
Juan José Santamaría Flecha
0001-MinGW-Windows-Vista-Warnings.patch
Description: Binary data
On Tue, Mar 22, 2022 at 2:00 AM Andres Freund wrote:
>
> Currently fails to apply, please rebase:
> http://cfbot.cputube.org/patch_37_3450.log
>
> Marked as waiting-on-author.
>
> Please, find attached a rebased version, no other significant change.
Regards,
Juan José S
Please excuse my late reply.
On Wed, Feb 16, 2022 at 12:20 PM Juan José Santamaría Flecha <
juanjo.santama...@gmail.com> wrote:
> On Tue, Feb 15, 2022 at 5:25 PM Andres Freund wrote:
>
>>
>> FWIW, I've looked at using either vcpkg or conan to more easily
>> ins
Conan and see how both compare.
[1] https://www.postgresql.org/docs/devel/install-windows-full.html
[2] https://web.mit.edu/Kerberos/
Regards,
Juan José Santamaría Flecha
. This shouldn't be a problem while
defining WIN32_LEAN_AND_MEAN, but kerberos is directly including
in .
Regards,
Juan José Santamaría Flecha
ogether, we can check at build time with
'dumpbin' to ensure that all dlls share the same vcruntime.dll.
Regards,
Juan José Santamaría Flecha
ewal.exe!main(int argc, char * * argv) Line 1005 C
The problem comes from the file descriptor passed to gzdopen() in
'src/bin/pg_basebackup/walmethods.c'. Using gzopen() instead, solves the
issue without ifdefing for WIN32. Please find attached a patch for so.
Regards,
Juan José Santamaría Flec
ly undefine X509_NAME. Please find
attached a patch for so.
Regards,
Juan José Santamaría Flecha
diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c
index 3d0168a..649bdc3 100644
--- a/src/backend/libpq/be-secure-openssl.c
+++ b/src/backend/libpq/be-secure-open
ype fields the
> way they came from the OS.
>
I think there is some value in making collation names consistent across
different platforms, e.g. making user scripts more portable. So, I'm doing
that in the attached version, just changing the object name.
Regards,
Juan José Santamaría Flecha
v4-0001-WIN32-pg_import_system_collations.patch
Description: Binary data
On Wed, Jan 19, 2022 at 9:40 PM Tom Lane wrote:
>
> Done. (I couldn't find any equivalent logic in the MSVC build scripts
> though; is there something I missed?)
>
> MSVC will use the path configured in src\tools\msvc\config.pl
> $config->{"python"},
there is no
On Wed, Jan 19, 2022 at 10:53 AM Julien Rouhaud wrote:
>
> This version doesn't apply anymore:
>
> Thanks for the heads up.
Please find attached a rebased patch. I have also rewritten some comments
to address previous reviews, code and test remain the same.
Regards,
Juan Jos
On Tue, Jan 18, 2022 at 5:49 PM Andrew Dunstan wrote:
>
> On 1/18/22 04:41, Juan José Santamaría Flecha wrote:
> > In [1] capacity for $SUBJECT was added to most of the batch scripts,
> > but clean.bat was not included. I propose to do so with the attached
> > patch.
>
...@postgrespro.ru
Regards,
Juan José Santamaría Flecha
0001-msvc-clean-bat-path-fix.patch
Description: Binary data
On Mon, Jan 10, 2022 at 4:14 PM Andrew Dunstan wrote:
>
> Pushed, and backpatched.
>
> Great, thanks.
Regards,
Juan José Santamaría Flecha
On Mon, Jan 10, 2022 at 12:51 PM Juan José Santamaría Flecha <
juanjo.santama...@gmail.com> wrote:
> Please find attached a patch for so.
>
The patch.
>
>
Regards,
>
> Juan José Santamaría Flecha
>
v2-0001-Fix-vcregress-plpython3-warnings.patch
Description: Binary data
/37/3507/
Regards,
Juan José Santamaría Flecha
On Fri, Jan 7, 2022 at 3:24 PM Andrew Dunstan wrote:
>
> In that case, just this should work:
>
> s/EXTENSION (\S*?)plpython2?u/EXTENSION $1plpython3u/g ;
>
> LGTM.
Regards,
Juan José Santamaría Flecha
On Fri, Jan 7, 2022 at 2:56 PM Juan José Santamaría Flecha <
juanjo.santama...@gmail.com> wrote:
copy-paste
> s/EXTENSION plpython2?u/EXTENSION plpython3u/g
> s/EXTENSION ([^ ]*)_plpython2?u/EXTENSION $1_plpython3u/g
>
hon2?u/EXTENSION plpython3u/g
s/EXTENSION ([^ ]*)_plpython2?u/EXTENSION \$1_plpython3u/g
Regards,
Juan José Santamaría Flecha
] http://commitfest.cputube.org/
Regards,
Juan José Santamaría Flecha
0001-Fix-vcregress-plpython3-warning.patch
Description: Binary data
ocs.microsoft.com/en-us/globalization/locale/locale-names
Regards,
Juan José Santamaría Flecha
0001-POC-Make-Windows-locale-POSIX-looking.patch
Description: Binary data
you need a database that has
successfully run pg_import_system_collations. This would be also possible
in Mingw for _WIN32_WINNT> = 0x0600, but the current value in
src\include\port\win32.h is _WIN32_WINNT = 0x0501 when compiling with
Mingw.
> Regards,
Juan José Santamaría Flecha
On Mon, Dec 13, 2021 at 9:41 AM Juan José Santamaría Flecha <
juanjo.santama...@gmail.com> wrote:
Per path tester.
> Regards,
>
> Juan José Santamaría Flecha
>
v2-0001-WIN32-pg_import_system_collations.patch
Description: Binary data
I want to propose an implementation of pg_import_system_collations() for
WIN32 using EnumSystemLocalesEx() [1], which is available from Windows
Server 2008 onwards.
The patch includes a test emulating that of collate.linux.utf8, but for
Windows-1252. The main difference is that it doesn't have
argument pointing
to
+ the directory where the tests reside. For example, use the following
+ command for running the subcription TAP tests:
Regards,
Juan José Santamaría Flecha
For instance, a local variable may exist solely for use in an
> assert()
> statement, which makes the local variable unused when NDEBUG is
> defined."
>
> [[maybe_unused]] is also recognized from Visual Studio 2017 onwards [1].
[1] https://docs.microsoft.c
d to 9 chars)
month full lower case month name (blank-padded to 9 chars)
What you are proposing looks more like a new feature than a bug.
[1] https://www.postgresql.org/docs/current/functions-formatting.html
Regards,
Juan José Santamaría Flecha
We might find pretty much anything in the wild, the safer the check the
better.
[1] https://en.wikipedia.org/wiki/Windows_10_version_history
Regards,
Juan José Santamaría Flecha
On Tue, Sep 28, 2021 at 2:50 AM Thomas Munro wrote:
> On Thu, Sep 23, 2021 at 9:13 PM Juan José Santamaría Flecha
> wrote:
> > When GetTempFileName() finds a duplicated file name and the file is
> pending for deletion, it fails with an "ERROR_ACCESS_DENIED" error
], which doesn't need a manifest.
[1]
https://www.postgresql.org/message-id/flat/CA%2BhUKG%2BoLqfBVJ_j3C03QgoshrX1KxYq0LB1vJV0OXPOcZZfhA%40mail.gmail.com#bfcc256e4eda369e369275f5b4e38185
Regards,
Juan José Santamaría Flecha
> +else
> +err = ERROR_FILE_NOT_FOUND;
>
When GetTempFileName() finds a duplicated file name and the file is pending
for deletion, it fails with an "ERROR_ACCESS_DENIED" error code. That may
describe the situation better than "ERROR_FILE_EXISTS".
Regards,
Juan José Santamaría Flecha
t; You are right about winsock2.h including some parts of windows.h, please
see note in [1]. You could move the windows.h inclusion for clarity:
+ #ifndef WIN32_LEAN_AND_MEAN
+ #define WIN32_LEAN_AND_MEAN
+ #endif
+
+ #include
#include
#include
- #include
[1]
https://docs.microsoft.com/en-us/windows/win32/winsock/creating-a-basic-winsock-application
Regards,
Juan José Santamaría Flecha
;
> Anything below Windows Server 2012 (_WIN32_WINNT = 0x0602) is no longer
supported. A patch with a bump on MIN_WINNT might be due.
Regards,
Juan José Santamaría Flecha
.
>
> The OP claimed that the printed command was not working 'as-is', which is
a valid complaint.
Quoting the command seems like a complete answer for this, as it will solve
problems with spaces and such for both Windows and Unix-like systems.
Regards,
Juan José Santamaría Flecha
api/fileapi/nf-fileapi-getfiletime#remarks
Regards,
Juan José Santamaría Flecha
On Thu, Mar 4, 2021 at 3:11 AM Michael Paquier wrote:
> On Wed, Mar 03, 2021 at 08:59:30PM +0100, Juan José Santamaría Flecha
> wrote:
> > This seems to me as if setting the variables in the shell is the proposed
> > way to do so. In the previous doc point we do the same with
on a Windows terminal as follows, before running
+ vcregress:
+
+set PROVE_FLAGS=--timer
+set PROVE_TESTS=t/020*.pl t/010*.pl
+
+
This seems to me as if setting the variables in the shell is the proposed
way to do so. In the previous doc point we do the same with the buildenv.pl
file. It looks inconsistent, as if it was one way or the other, when it
could be either.
Regards,
Juan José Santamaría Flecha
On Mon, Mar 1, 2021 at 10:18 PM Alvaro Herrera
wrote:
> On 2021-Mar-01, Juan José Santamaría Flecha wrote:
>
> > Uhm, now that you point it out, an absolute path would make the message
> > more consistent and reusable.
>
> Well. This code was introduced in a00c5
On Mon, Mar 1, 2021 at 9:09 PM Alvaro Herrera
wrote:
> On 2021-Mar-01, Juan José Santamaría Flecha wrote:
>
> > On Mon, Mar 1, 2021 at 7:50 PM Alvaro Herrera
> > wrote:
>
> > > Ah, so another way to fix it would be to make the path to pg_ctl be
> > > abso
On Mon, Mar 1, 2021 at 7:50 PM Alvaro Herrera
wrote:
> On 2021-Mar-01, Juan José Santamaría Flecha wrote:
>
> > This is not a problem with the APi, but the shell. e.g. when using a CMD:
> >
> > - This works:
> > c:\>c:\Windows\System32\notepad.exe
> > c:
/System32/notepad.exe
'Windows' is not recognized as an internal or external command,
operable program or batch file.
Regards,
Juan José Santamaría Flecha
f
back-patching, if needed. As for HEAD at least, this LGTM.
Regards,
Juan José Santamaría Flecha
using GetFileAttributesEx(). That might
work as fall back to the CreateFile() if the file attribute is not a
FILE_ATTRIBUTE_REPARSE_POINT.
Anyhow, I do not think any retry logic should be in the stat() function,
but in the caller.
Regards,
Juan José Santamaría Flecha
>
>
On Tue, Nov 3, 2020 at 10:49 PM Thomas Munro wrote:
>
> So we have:
>
> 1. Windows locale names, like "English_United States.1252". Windows
> still returns these from setlocale(), so they finish up in datcollate,
> and yet some relevant APIs don't accept them, at least on some
> machines.
>
>
best :-)
>
There has been some talk about pushing _WIN32_WINNT to newer releases, but
ended without an actual patch for doing so. Maybe we can revisit that in
another thread.
[1]
https://www.postgresql.org/message-id/20200218065418.GK4176%40paquier.xyz
Regards,
Juan José Santamaría Flecha
ook at
> GetLastError() in this step?
>
Uhm, a good question indeed, forcing errno serves no purpose there.
Regards,
Juan José Santamaría Flecha
of this.
>
Great, thanks again to everyone who has taken some time to look into this.
Regards,
Juan José Santamaría Flecha
CloseHandle() could overwrite
> errno.
>
The meaningful error should come from the previous call, and an error from
CloseHandle() could mask it. Not sure it makes a difference anyhow.
Regards,
Juan José Santamaría Flecha
ges, mostly reorganizing comments in a way
> that made more sense to me.
>
> I was working on a new version, which was pgindent-friendlier and clearer
about reporting an error when 'errno' is not informed. Please find attached
a patch with those changes.
Regards,
Juan José Santamaría Flech
that cannot be converted by simple
casting, and that for most standard date/time formats a cast is the easier
way to do so [2], I may also add that is better performing in Postgres.
[1]
https://www.postgresql.org/message-id/01fe23b2-7779-d3ee-056a-074a7385e248%40mail.de
[2] https://www.postgresql.org/docs/current/functions-formatting.html
Regards,
Juan José Santamaría Flecha
>
>
On Thu, Sep 17, 2020 at 8:47 PM Juan José Santamaría Flecha <
juanjo.santama...@gmail.com> wrote:
> On Thu, Sep 17, 2020 at 6:04 PM Tom Lane wrote:
>
>>
>> One thing I noticed, which is a pre-existing problem but maybe now
>> is a good time to consider i
t)
lstat(), where only st_mode could be informed, be acceptable?
>
> Another more trivial point is that it'd be good to run the new code
> through pgindent before committing.
>
I do not have pgindent in the WIN32 machine, but I will try to for the next
version.
Regards,
Juan José Santamaría Flecha
On Thu, Sep 17, 2020 at 9:46 AM Michael Paquier wrote:
>
> Could you send a rebase of the patch? Thanks!
>
Thanks for the reminder. Please find attached a rebased version.
Regards,
Juan José Santamaría Flecha
0001-Support-for-large-files-on-Win32-v8.patch
Description: Binary data
wn problem, previous to this patch. There have been a couple
of attempts to tackle it, and hopefully the shared-memory based stats
collector will take care of it:
https://www.postgresql.org/message-id/18986.1585585020%40sss.pgh.pa.us
Regards,
Juan José Santamaría Flecha
e filesystem (mount point) or just a directory off
> something mounted elsehwere (junction).
> >
> > And yes, the wikipedia page confirms that junctions also use
> IO_REPARSE_TAG_MOUNT_POINT.
>
> Thanks for confirming. I ran the Windows patch through pgindent,
> fixed a small t
First,Next}File() functions populate?
>
> That'd be better...
>
At first I did not see how to get DT_LNK directly, but it is possible
without additional calls, so please find attached a version with that logic.
This version also drops the enum, defining just the macros.
Regards,
Juan J
On Fri, Sep 4, 2020 at 10:28 PM Alvaro Herrera
wrote:
> On 2020-Sep-04, Juan José Santamaría Flecha wrote:
>
> > On Fri, Sep 4, 2020 at 9:37 PM Alvaro Herrera
> > wrote:
> >
> > > On 2020-Sep-04, Thomas Munro wrote:
>
> > > >
>
r 'd_type'. */
> > +enum
> > + {
> > + DT_UNKNOWN = 0,
> > +# define DT_UNKNOWN DT_UNKNOWN
>
> Uhm ... what do these #defines do? They look a bit funny.
>
> Would it make sense to give this enum a name, and then use that name in
> struct dirent's definition, instead of unsigned char?
>
They mimic POSIX dirent.h. I would rather stick to that.
Regards,
Juan José Santamaría Flecha
1 - 100 of 220 matches
Mail list logo
