Re: [Proposal] Add foreign-server health checks infrastructure

On 2023-03-10 18:07, Katsuragi Yuta wrote: On 2023-03-08 13:40, Hayato Kuroda (Fujitsu) wrote: Dear Vignesh, Thank you for reviewing! PSA new version. Hi, Thank you for the comments, Vignesh. Thank you for updating the patch, Kuroda-san. This fix looks fine to me. And also, there seems

Re: [Proposal] Add foreign-server health checks infrastructure

planning to update the status to ready for committer on next Monday. [1]: https://www.postgresql.org/message-id/TYAPR01MB5866F8EA3C06E1B43E42E4E4F5B79%40TYAPR01MB5866.jpnprd01.prod.outlook.com regards, -- Katsuragi Yuta Advanced Computing Technology Center Research and Development Headquarters

Re: [Proposal] Add foreign-server health checks infrastructure

true.' regards, -- Katsuragi Yuta Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION

Re: [Proposal] Add foreign-server health checks infrastructure

_connection_states + This function checks whether postgres_fdw_verify_connection_states + and postgres_fdw_verify_connection_states work well Should the latter (or former) postgres_fdw_verify_connection_states be postgres_fdw_verify_connection_states_all? regards, -- Katsuragi Yuta Advanced Co

Re: [Proposal] Add foreign-server health checks infrastructure

s detected."), +errhint("Plsease check the health of server."))); Is it better to use "Connection close is detected" rather than "Socket close is detected"? 9. the document of postgres_fdw The document of postgres_fdw_verify_connectio

Re: [Proposal] Add foreign-server health checks infrastructure

entry for the specified server. Current implementation returns true in that case, however the check is not performed. Suppose the checking mechanism is supported on the platform, it does not seem reasonable to return true or false when the check is not performed. What do you think? regards, -- Kat

Re: [Proposal] Add foreign-server health checks infrastructure

ta.ntt%40gmail.com regards, -- Katsuragi Yuta Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION

Re: Is psSocketPoll doing the right thing?

r the function so that it can do that properly. Does this mean that pqSocketPoll or pqSocketCheck somehow returns the poll's result including error conditions (POLLERR, POLLHUP, POLLNVAL) to callers? Then callers filter the result to make their final result. regards, -- Katsuragi Yuta Advanced Compu

Re: [Proposal] Add foreign-server health checks infrastructure

nection_states' looks straightforward. What do you think about this? 0004: Sorry, I have not read 0004. I will read. [1]: https://github.com/postgres/postgres/blob/master/doc/src/sgml/postgres-fdw.sgml#L764-L765 regards, -- Katsuragi Yuta Advanced Computing Technology Center Research a

Re: [Proposal] Add foreign-server health checks infrastructure

+/* Check whether the postgres server is still alive or not */ +extern int PQConnCheck(PGconn *conn); +extern int PQCanConnCheck(void); Aren't these PQconnCheck and PQcanConnCheck? I think the first letter following 'PQ' should be lower case. regards. -- Katsuragi Yuta Advanced Computing Technol

Re: [Proposal] Add foreign-server health checks infrastructure

ions. Like the description of postgres_fdw_disconnect_all(). For example, "This function checks the status of 'all the' remote connections..."? regards, -- Katsuragi Yuta Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION

enable pg_stat_statements to track rows processed by REFRESH MATERIALIZED VIEW

Hi, pg_stat_statements tracks the number of rows processed by some utility commands. But, currently, it does not track the number of rows processed by REFRESH MATERIALIZED VIEW. Attached patch enables pg_stat_statements to track processed rows by REFRESH MATERIALIZED VIEW. Regards, Katsuragi

Re: [PATCH] Add features to pg_stat_statements

w to evict entries from the history table and how to manage the information maintained by evicted entries. Also, providing a history table looks similar to logging. Providing the original view (# of dealloc and last_dealloc ts) and optional logging looks a simple and better way. Regards, Katsuragi Yuta

Re: [PATCH] Add features to pg_stat_statements

fixed to three? Or, will a new record be appended every time an event (Eviction or Reset or Part Reset) happens? Regards, Katsuragi Yuta

Re: [PATCH] Add features to pg_stat_statements

the actual size of the normalised queries set. I agree with the estimation of the actual size of the query set is important. It looks difficult to estimate the actual size of the query set from queryid because queryid is a 64bit hash value. Regards, Katsuragi Yuta

Re: [PATCH] Add features to pg_stat_statements

errhidestmt(true))); -- Sent from: https://www.postgresql-archive.org/PostgreSQL-hackers-f1928748.html Thank you for your comments! In addition to providing a view that is like a summary of history, logging might be a good choice. Regards, Katsuragi Yuta

Re: [PATCH] Add features to pg_stat_statements

be a choice. This idea is from legrand legrand [1]. [1] https://www.postgresql.org/message-id/1600500942767-0.post%40n3.nabble.com Regards, Katsuragi Yuta

[PATCH] Add features to pg_stat_statements

This is a proposal to add some features to pg_stat_statements. Attached is the patch of this. pg_stat_statements uses a hash table to hold statistics, and the maximum number of its entries can be configured through pg_stat_statements.max. When the number of entries exceeds the