Add checks in pg_rewind to abort if backup_label file is present

2023-12-05 Thread Krishnakumar R
Hi, Please find the attached patch for $subject and associated test. Please review. -- Thanks and Regards, Krishnakumar (KK). [Microsoft] From 80ad7293b57a2b346b0775b8f6e0e06198617154 Mon Sep 17 00:00:00 2001 From: "Krishnakumar R (KK)" Date: Tue, 5 Dec 2023 02:36:32 -0800 Subject:

Move bki file pre-processing from initdb - part 1 - initdb->genbki.pl

2023-12-04 Thread Krishnakumar R
/CAPMWgZ9TCByVjpfdsgyte4rx%3DYsrAttYay2xDK4UN4Lm%3D-wJMQ%40mail.gmail.com From 2b968de3dd559aa31095214f96773569ebec8b21 Mon Sep 17 00:00:00 2001 From: "Krishnakumar R (KK)" Date: Mon, 4 Dec 2023 01:25:20 -0800 Subject: [PATCH v4] Move some BKI token replacement from initdb to compile time via

Re: Add missing error codes to PANIC/FATAL error reports in xlogrecovery

2023-12-04 Thread Krishnakumar R
n-exclusive backup. Attached another patch which applies on top of the first patch to remove the obsolete hint. - KK From b779b53ee0cde0ab239c44f5c6c83ec530c194ab Mon Sep 17 00:00:00 2001 From: "Krishnakumar R (KK)" Date: Thu, 30 Nov 2023 00:56:40 -0800 Subject: [PATCH v2 1/2] Add m

Add missing error codes to PANIC/FATAL error reports in xlogrecovery

2023-11-30 Thread Krishnakumar R
4cc518f25710c512ba3f9452392dc6ea67c2248b Mon Sep 17 00:00:00 2001 From: "Krishnakumar R (KK)" Date: Thu, 30 Nov 2023 00:56:40 -0800 Subject: [PATCH v1] Add missing error codes to PANIC/FATAL error reports. --- src/backend/access/transam/xlogrecovery.c | 45 +++ 1 file c

Re: Move bki file pre-processing from initdb to bootstrap

2023-11-10 Thread Krishnakumar R
Thank you for review, Peter. Makes sense on the split part. Was starting to think in same lines, at the end of last iteration. Will come back shortly. On Fri, Nov 10, 2023 at 12:48 AM Peter Eisentraut wrote: > On 17.10.23 03:32, Krishnakumar R wrote: > >> The version comparison ha

Re: Move bki file pre-processing from initdb to bootstrap

2023-10-16 Thread Krishnakumar R
> The version comparison has been moved from initdb to bootstrap. This > created some compatibility problems with windows tests. For now I kept > the version check to not have \n added, which worked fine and serves > the purpose. However hoping to have something better in v3 in addition > to

Re: Move bki file pre-processing from initdb to bootstrap

2023-10-05 Thread Krishnakumar R
ny other comments. Please let me know your thoughts and review comments. -- Thanks and Regards, Krishnakumar (KK). [Microsoft] On Tue, Sep 19, 2023 at 3:18 AM Peter Eisentraut wrote: > > On 01.09.23 10:01, Krishnakumar R wrote: > > This patch moves the pre-processing for tokens in the bki

Fixup the variable name to indicate the WAL record reservation status.

2023-09-14 Thread Krishnakumar R
Hi All, Please find a small patch to improve code readability by fixing up the variable name to indicate the WAL record reservation status. The insertion is done later in the code based on the reservation status. -- Thanks and Regards, Krishnakumar (KK). [Microsoft]

Small patch modifying variable name to reflect the logic involved

2023-09-14 Thread Krishnakumar R
Hi All, Please find a small patch to improve code readability by modifying variable name to reflect the logic involved - finding diff between end and start time of WAL sync. -- Thanks and Regards, Krishnakumar (KK) [Microsoft] v1-0001-Improve-code-readability-by-modifying-variable-na.patch

Move bki file pre-processing from initdb to bootstrap

2023-09-01 Thread Krishnakumar R
Hi All, This patch moves the pre-processing for tokens in the bki file from initdb to bootstrap. With these changes the bki file will only be opened once in bootstrap and parsing will be done by the bootstrap parser. The flow of bki file processing will be as follows: - In initdb gather the