On Mon, Jan 29, 2024 at 14:50 Amit Kapila wrote:
> Pushed!
Thanks for pushing.
Regards,
Wang Wei
On Thu, Jan 25, 2024 at 20:33 Amit Kapila wrote:
> On Thu, Jan 25, 2024 at 4:01 PM Wei Wang (Fujitsu)
> wrote:
> >
> >
> > Yes, agree. I think these two parts have become slightly outdated after the
> > commit 1632ea4. So also tried to fix the first part of the com
On Thu, Jan 25, 2024 at 18:39 Amit Kapila wrote:
>
Thanks for your review.
> On Thu, Jan 25, 2024 at 2:57 PM Wei Wang (Fujitsu)
> wrote:
> >
> > In the function ReplicationSlotAcquire(), I found there is a missing in the
> > below comments:
> >
> > `
Hi,
In the function ReplicationSlotAcquire(), I found there is a missing in the
below comments:
```
/*
* Search for the slot with the specified name if the slot to acquire is
* not given. If the slot is not found, we either return -1 or error
out.
*/
s
Hi,
In the function WalReceiverMain, when the function walrcv_create_slot is called,
the fourth parameter is assigned the value "0" instead of the enum value
"CRS_EXPORT_SNAPSHOT". I think it would be better to use the corresponding enum
value.
Attach the patch to change this point.
Regards,
On Thur, Jun 8, 2023 20:02 PM shveta malik wrote:
> Thank You Vignesh for handling (a), Ajin for handling (b), Shi-san and
> Hou-san for contributing in (c).
>
> The new changes are in patch 0001, 0002, 0005 and 0008.
Thanks for updating the patch set.
Here are some comments:
===
For 0002
On Thur, June 1, 2023 at 23:42 vignesh C wrote:
> On Wed, 31 May 2023 at 14:32, Wei Wang (Fujitsu)
> wrote:
> > ~~~
> >
> > 2. Deparsed results of the partition table.
> > When I run the following SQLs:
> > ```
> > create table parent (a int primary key
On Tues, May 30, 2023 at 19:19 PM vignesh C wrote:
> The attached patch has the changes for the above.
Thanks for updating the new patch set.
Here are some comments:
===
For patch 0001
1. In the function deparse_Seq_As.
```
+ if (OidIsValid(seqdata->seqtypid))
+
On Tues, May 16, 2023 at 14:15 PM Kuroda, Hayato/黒田 隼人
wrote:
> Dear Peter,
>
> Thanks for reviewing! PSA new version patchset.
Thanks for updating the patch set.
Here are some comments:
===
For patches 0001
1. The latest patch set fails to apply because the new commit (0245f8d) in HEAD.
On Sat, April 1, 2023 at 11:00 AM Thomas Munro wrote:
>
Hi,
Thanks for your patch.
I tried to test this patch on Windows. And I did cover the new code path below:
```
+ /* We have another event to decode. */
+ cur_event = >events[next_pos + (rc - WAIT_OBJECT_0)];
```
On Tue, May 9, 2023 at 17:44 PM Hayato Kuroda (Fujitsu)
wrote:
> Thank you for reviewing! PSA new version.
Thanks for your patches.
Here are some comments for 0001 patch:
1. In the function getLogicalReplicationSlots
```
+ /*
+* Note: Currently we do not have any
On Thu, May 11, 2023 at 10:12 AM Peter Smith wrote:
> Hi Kuroda-san. I checked again the v11-0001.
>
> Here are a few more review comments.
>
> ==
> src/bin/pg_dump/pg_dump.c
>
> 1. help
>
> printf(_(" --insertsdump data as INSERT
> commands, rather than COPY\n"));
On Fri, Apr 21, 2023 at 16:48 PM Masahiko Sawada wrote:
> On Thu, Apr 20, 2023 at 8:16 PM Amit Kapila wrote:
> >
> > On Mon, Apr 17, 2023 at 9:12 AM Masahiko Sawada
> wrote:
> > >
> > > On Fri, Apr 7, 2023 at 6:37 PM Amit Kapila
> > > wrote:
> > > >
> > > > On Thu, Apr 6, 2023 at 6:57 PM
On Fri, Apr 7, 2023 11:23 AM Hou, Zhijie/侯 志杰 wrote:
>
Thanks for updating the patch set.
Here are some comments:
1. The function deparse_drop_command in 0001 patch and the function
publication_deparse_ddl_command_end in 0002 patch.
```
+/*
+ * Handle deparsing of DROP commands.
+ *
+ * Verbose
On Sat, Apr 8, 2023 at 1:32 AM Tom Lane wrote:
> "wangw.f...@fujitsu.com" writes:
> > On Tues, Apr 4, 2023 at 23:48 PM Tom Lane wrote:
> >> I like the "per eligible process" wording, at least for guc_tables.c;
> >> or maybe it could be "per server process"? That would be more
> >> accurate and
15 matches
Mail list logo
