Add privileges test for pg_stat_statements to improve coverage

Hi hackers, I proposal adding privileges test to improve test coverage of pg_stat_statements. ## test procedure ./configure --enable-coverage --enable-tap-tests --with-llvm CFLAGS=-O0 make check-world make coverage-html ## coverage before Line Coverage 74.0 %(702/949 lines) after Line

Re: Output affected rows in EXPLAIN

Hi hackers, Indeed, I think it is a little confusing that when executing EXPLAIN(ANALYZE), even though an update is actually occurring, the commandtag of the update result is not returned. However, the manual also describes the information that will be affected when EXPLAIN (ANALYZE) is

Re: pg_get_indexdef() modification to use TxnSnapshot

Hi hackers, With '0001-pg_get_indexdef-modification-to-access-catalog-based.patch' patch, I confirmed that definition information can be collected even if the index is droped during pg_dump. The regression test (make check-world) has passed. I also tested the view definition for a similar

Re: pg_rewind: warn when checkpoint hasn't happened after promotion

hi Heikki, Thanks to mail, and thanks also for the commit(0a0500207a) to fix the document. I'm glad the problem was solved. Best Regards, Keisuke Kuroda NTT COMWARE 2023-02-27 16:33 に Heikki Linnakangas さんは書きました: On 16/11/2022 07:17, kuroda.keis...@nttcom.co.jp wrote: I fixed this last week

Re: pg_rewind: warn when checkpoint hasn't happened after promotion

Hi, hackers The issue here is pg_rewind looks into control file to determine the soruce timeline, because the control file is not updated until the first checkpoint ends after promotion finishes, even though file blocks are already diverged. Even in that case history file for the new timeline