On Tue, 31 Oct 2023 at 23:42, Corey Huinker wrote:
>>
>>
>> I think the SQL statements should end with semicolons. Our SQL examples
>> are usually written like that.
>
>
> ok
>
>
>>
>>
>> Our general style with CTEs seems to be (according to
>>
On Fri, 14 Jul 2023 at 20:17, Tomas Vondra
wrote:
>
> On 7/9/23 23:44, Tomas Vondra wrote:
> > ...
> >>> Yes, my previous message was mostly about backwards compatibility, and
> >>> this may seem a bit like an argument against it. But that message was
> >>> more a question "If we do this, is it
On Thu, 28 Sept 2023 at 10:23, Michael Paquier wrote:
>
> On Sat, Jun 03, 2023 at 07:42:36PM -0400, Fabrízio de Royes Mello wrote:
> > So in order to improve things a bit in this area I'm proposing to add a
> > test module for Table Access Method similar what we already have for Index
> > Access
On Wed, 25 Oct 2023 at 19:06, Andrei Zubkov wrote:
>
> Hi Aleksander,
>
> On Wed, 2023-10-25 at 16:17 +0300, Aleksander Alekseev wrote:
> > On top of that not sure if I see the patch on the November commitfest
> > [1]. Please make sure it's there so that cfbot will check the patch.
>
> Yes, this
On Sat, 10 Jun 2023 at 07:57, James Coleman wrote:
>
> I've previously noted in "Add last commit LSN to
> pg_last_committed_xact()" [1] that it's not possible to monitor how
> many bytes of WAL behind a logical replication slot is (computing such
> is obviously trivial for physical slots) because
On Wed, 20 Sept 2023 at 17:27, Daniel Gustafsson wrote:
>
> > On 20 Sep 2023, at 11:24, Peter Eisentraut wrote:
> >
> > On 06.08.23 21:39, Ahmed Ibrahim wrote:
> >> I have addressed the pg version compatibility with the FORCE option in
> >> drop. Here is the last version of the patch
> >
> >
On Tue, 26 Sept 2023 at 04:38, Nathan Bossart wrote:
>
> On Fri, Sep 15, 2023 at 02:25:38PM -0700, Yurii Rashkovskii wrote:
> > Thank you for the feedback. I've updated the glossary and updated the
> > terminology to be consistent. Please see the new patch attached.
>
> Thanks for the new version
On Fri, 2 Dec 2022 at 05:05, Kohei KaiGai wrote:
>
> > > IIUC, we already can use ctid in the where clause on the latest
> > > PostgreSQL, can't we?
> >
> > Oh, sorry, I missed the TidRangeScan. My apologies for the noise.
> >
> I made the ctidscan extension when we developed CustomScan API
>
On Tue, 15 Aug 2023 at 08:09, Peter Smith wrote:
>
> A rebase was needed due to a recent push [1].
I have changed the status of the patch to "Waiting on Author" as
Amit's queries at [1] have not been verified and concluded. Please
feel free to address them and change the status back again.
[1]
On Fri, 5 Jan 2024 at 10:49, Peter Smith wrote:
>
> Here are some review comments for patch v1-0001.
>
> ==
> doc/src/sgml/ref/pgupgrade.sgml
>
> 1. GENERAL - blank lines
>
> Most (but not all) of your procedure steps are preceded by blank lines
> to make them more readable in the SGML. Add
subscribing the changes from node2 by using
> + ALTER
> SUBSCRIPTION ... ENABLE,
> + for e.g.:
> +
> +node2=# ALTER SUBSCRIPTION sub1_node2_node1 ENABLE;
> +ALTER SUBSCRIPTION
> +node2=# ALTER SUBSCRIPTION sub2_node2_node1 ENABLE;
> +ALTER SUBSCRIPTION
On Thu, 14 Dec 2023 at 02:13, Imseih (AWS), Sami wrote:
>
> Hi,
>
>
>
> A recent case in the field in which a database session_authorization is
>
> altered to a non-superuser, non-owner of tables via alter database .. set
> session_authorization ..
>
> caused autovacuum to skip tables.
>
>
>
>
On Tue, 28 Nov 2023 at 18:23, Jingxian Li wrote:
>
> Hi hackers,
>
> I found a problem when doing the test shown below:
>
> Time
>
> Session A
>
> Session B
>
> T1
>
> postgres=# create table test(a int);
>
> CREATE TABLE
>
> postgres=# insert into test values (1);
>
> INSERT 0 1
>
>
>
> T2
>
>
On Thu, 7 Dec 2023 at 13:52, Richard Guo wrote:
>
>
> On Mon, Sep 25, 2023 at 3:11 PM Richard Guo wrote:
>>
>> If the grouping expression is a Var or PHV, we can just set its
>> nullingrels, very straightforward. For an expression that is neither a
>> Var nor a PHV, I'm not quite sure how to
On Tue, 29 Aug 2023 at 06:29, Jimmy Yih wrote:
>
> Thanks for the insightful response! I have attached an updated patch
> that moves the proposed logic to the end of StartupXLOG where it seems
> more correct to do this. It also helps with backporting (if it's
> needed) since the archiver process
On Thu, 13 Apr 2023 at 23:34, Fujii Masao wrote:
>
>
>
> On 2023/04/13 11:00, Kyotaro Horiguchi wrote:
> > Agreed, it seems to be a leftover when we moved to parse_int_param()
> > in that area.
>
> It looks like there was an oversight in commit e7a2217978. I've attached a
> patch (0002) that
On Thu, 9 Feb 2023 at 12:02, Masahiko Sawada wrote:
>
> On Wed, Feb 8, 2023 at 1:13 PM Amit Kapila wrote:
> >
> > On Wed, Feb 8, 2023 at 1:19 AM Andres Freund wrote:
> > >
> > > On 2023-02-01 11:23:57 +0530, Amit Kapila wrote:
> > > > On Tue, Jan 31, 2023 at 6:08 PM Masahiko Sawada
> > > >
On Tue, 17 Oct 2023 at 04:18, Thomas Munro wrote:
>
> I pushed the retry-loop-in-frontend-executables patch and the
> missing-locking-in-SQL-functions patch yesterday. That leaves the
> backup ones, which I've rebased and attached, no change. It sounds
> like we need some more healthy debate
On Sat, 6 Jan 2024 at 01:47, Robert Haas wrote:
>
> On Thu, Mar 23, 2023 at 11:02 PM Kyotaro Horiguchi
> wrote:
> > [ new patch ]
>
> Well, I guess nobody is too excited about fixing this, because it's
> been another 10 months with no discussion. Andres doesn't even seem to
> think this is as
On Thu, 7 Dec 2023 at 04:50, Nathan Bossart wrote:
>
> On Wed, Dec 06, 2023 at 11:30:02AM -0600, Nathan Bossart wrote:
> > On Wed, Dec 06, 2023 at 06:27:04PM +0100, Peter Eisentraut wrote:
> >> Makes sense. Can you commit that?
> >
> > Yes, I will do so shortly.
>
> Committed. Apologies for the
On Wed, 10 Jan 2024 at 18:37, vignesh C wrote:
>
> On Wed, 10 Jan 2024 at 14:08, Bharath Rupireddy
> wrote:
> >
> > Hi,
> >
> > I've been observing a failure in t/038_save_logical_slots_shutdown.pl
> > of late on my developer system:
> >
On Wed, 10 Jan 2024 at 15:50, Amit Kapila wrote:
>
> On Thu, Jan 4, 2024 at 2:22 PM vignesh C wrote:
> >
> > We have documentation on how to upgrade "publisher" and "subscriber"
> > at [1], but currently we do not have any documentation on how
On Wed, 10 Jan 2024 at 15:04, Amit Kapila wrote:
>
> On Wed, Jan 10, 2024 at 2:59 PM Shlok Kyal wrote:
> >
> > This patch is not applying on the HEAD. Please rebase and share the
> > updated patch.
> >
>
> IIRC, there were some regressions observed with this patch. So, one
> needs to analyze
On Wed, 10 Jan 2024 at 14:08, Bharath Rupireddy
wrote:
>
> Hi,
>
> I've been observing a failure in t/038_save_logical_slots_shutdown.pl
> of late on my developer system:
>
> t/038_save_logical_slots_shutdown.pl .. 1/?
> # Failed test 'Check that the slot's confirmed_flush LSN is the same
> as
On Wed, 6 Dec 2023 at 12:53, Euler Taveira wrote:
>
> On Thu, Nov 9, 2023, at 8:12 PM, Michael Paquier wrote:
>
> On Thu, Nov 09, 2023 at 03:41:53PM +0100, Peter Eisentraut wrote:
> > On 08.11.23 00:12, Michael Paquier wrote:
> >> - Should the subdirectory pg_basebackup be renamed into something
On Wed, 3 Jan 2024 at 08:54, Amit Kapila wrote:
>
> On Wed, Jan 3, 2024 at 7:10 AM Michael Paquier wrote:
> >
> > On Tue, Jan 02, 2024 at 02:07:58PM +, Bertrand Drouvot wrote:
> > > + wal_level_insufficient means that the
> > > +is insufficient on the primary
> > > +
On Wed, 10 Jan 2024 at 03:48, Robert Haas wrote:
>
> Hi,
>
> I think we need to be more aggressive about marking things returned
> with feedback when they don't get updated. If a patch is waiting for
> reviews for a long time, well, that's one thing. Maybe we eventually
> close it due to lack of
On Thu, 16 Nov 2023 at 05:30, jian he wrote:
>
> On Fri, Nov 3, 2023 at 12:34 AM Marko Tiikkaja wrote:
> >
> > I am now. Thanks! :-) Will try to keep an eye on the builds in the future.
> >
> > Attached v4 of the patch which should fix the issue.
> >
>
> doc seems to still have an issue.
>
On Tue, 9 Jan 2024 at 14:31, Andrei Lepikhov wrote:
>
> Here is a new version of GROUP-BY optimization without sort model.
>
> On 21/12/2023 17:53, Alexander Korotkov wrote:
> > I'd like to make some notes.
> >
> > 1) As already mentioned, there is clearly a repetitive pattern for the
> > code
On Mon, 4 Sept 2023 at 16:59, Kyotaro Horiguchi wrote:
>
> At Thu, 24 Aug 2023 11:22:32 +0900 (JST), Kyotaro Horiguchi
> wrote in
> > I could turn this into something like undo longs in a simple form, but
> > I'd rather not craft a general-purpose undo log system for this unelss
> > it's
On Fri, 8 Dec 2023 at 15:17, Kartyshov Ivan wrote:
>
> Should rise disscusion on separate utility statement or find
> case where procedure version is failed.
>
> 1) Classic (wait_classic_v3.patch)
> https://www.postgresql.org/message-id/3cc883048264c2e9af022033925ff8db%40postgrespro.ru
>
On Sat, 21 Oct 2023 at 18:34, Konstantin Knizhnik wrote:
>
> Hi hackers,
>
> EXPLAIN statement has a list of options (i.e. ANALYZE, BUFFERS, COST,...)
> which help to provide useful details of query execution.
> In Neon we have added PREFETCH option which shows information about page
>
On Tue, 4 Jul 2023 at 06:56, James Coleman wrote:
>
> On Sun, Jun 11, 2023 at 10:23 PM James Coleman wrote:
> >
> > ...
> > > And while trying the v9 patch I came across a crash with the query
> > > below.
> > >
> > > set min_parallel_table_scan_size to 0;
> > > set parallel_setup_cost to 0;
> >
On Sat, 25 Nov 2023 at 06:49, Heikki Linnakangas wrote:
>
> On 19/11/2023 02:04, Andres Freund wrote:
> > On 2023-11-17 11:37:21 +0100, Heikki Linnakangas wrote:
> >> The new facility makes it easier to optimize bulk loading, as the
> >> logic for buffering, WAL-logging, and syncing the relation
On Sat, 6 Jan 2024 at 05:50, Paul Jungwirth
wrote:
>
> Getting caught up on reviews from November and December:
>
> On 11/19/23 22:57, jian he wrote:
> >
> > I believe the following part should fail. Similar tests on
> > src/test/regress/sql/generated.sql. line begin 347.
> >
> > drop table
On Fri, 20 Jan 2023 at 15:30, vignesh C wrote:
>
> On Wed, 16 Nov 2022 at 15:35, vignesh C wrote:
> >
> > On Wed, 16 Nov 2022 at 09:34, Ian Lawrence Barwick
> > wrote:
> > >
> > > 2022年11月7日(月) 22:39 vignesh C :
> > > >
> > > >
On Thu, 9 Nov 2023 at 21:48, Heikki Linnakangas wrote:
>
> On 18/09/2023 07:08, David Rowley wrote:
> > On Fri, 15 Sept 2023 at 22:37, Heikki Linnakangas wrote:
> >>> I've added a call to LockAssertNoneHeld(false) in there.
> >>
> >> I don't see it in the patch?
> >
> > hmm. I must've git
On Mon, 8 Jan 2024 at 22:50, Jelte Fennema-Nio wrote:
>
> On Mon, 8 Jan 2024 at 07:22, vignesh C wrote:
> > Here is a list of "Needs review" entries for which there has not been
> > much communication on the thread and needs help in proceeding further.
>
>
s | Nathan Bossart
Add additional extended protocol commands to psql: \parse and \bindx |
Anthonin Bonnefoy
Function to log backtrace of postgres processes | Vignesh C/Bharath Rupireddy
Check consistency of GUC defaults between .sample.conf and
pg_settings.boot_val | Nathan Bossart
archive modules
On Tue, 24 Oct 2023 at 22:00, Nathan Bossart wrote:
>
> On Tue, Sep 12, 2023 at 03:53:28PM +0100, Dagfinn Ilmari Mannsåker wrote:
> > Tom Lane writes:
> >> It's possible that we could get away with just summarily changing
> >> the argument type from text to regclass. ISTR that we did exactly
>
On Tue, 12 Sept 2023 at 14:39, Peter Eisentraut wrote:
>
> On 11.09.23 13:59, Jelte Fennema wrote:
> > @Tom and @Robert, since you originally suggested extending the
> > protocol for this, I think some input from you on the protocol design
> > would be quite helpful. BTW, this protocol extension
On Fri, 8 Dec 2023 at 19:15, Ashutosh Bapat
wrote:
>
> > > > pg_replication_slot could be set back to null.
> > >
> > > In this case, since the basebackup was taken after the slot was
> > > invalidated, it
> > > does not require the WAL that was removed. But it seems that once the
> > >
On Mon, 7 Aug 2023 at 19:25, Sandro Santilli wrote:
>
> On Tue, Aug 01, 2023 at 08:24:15PM +0200, Daniel Gustafsson wrote:
> > > On 28 Jun 2023, at 10:29, Daniel Gustafsson wrote:
> > >
> > >> On 31 May 2023, at 21:07, Sandro Santilli wrote:
> > >> On Thu, Apr 27, 2023 at 12:49:57PM +0200,
On Wed, 1 Nov 2023 at 11:25, Richard Guo wrote:
>
>
> On Thu, Aug 10, 2023 at 3:24 PM Richard Guo wrote:
>>
>> The cfbot reminds that this patch does not apply any more, so rebase it
>> to v2.
>
>
> Attached is another rebase over the latest master. Any feedback is
> appreciated.
One of the
On Mon, 18 Sept 2023 at 18:01, Jelte Fennema-Nio wrote:
>
> @Euler thanks for the review. I addressed the feedback.
>
> On Fri, 15 Sept 2023 at 01:41, Andy Fan wrote:
> > What if a client has *cached* an old version of RowDescription
> > and the server changed it to something new and sent
On Thu, 29 Jun 2023 at 13:20, John Morris wrote:
>
> Background
>
> ==
>
> PostgreSQL has an amazing variety of routines for accessing files. Consider
> just the “open file” routines.
>PathNameOpenFile, OpenTemporaryFile, BasicOpenFile, open, fopen,
> BufFileCreateFileSet,
>
>
On Wed, 1 Nov 2023 at 16:43, Peter Eisentraut wrote:
>
> Here is an updated version of this patch. It doesn't have any new
> functionality, just a rebase and some minor adjustments.
>
> I have split up the one patch into several ones, which could be
> considered incrementally, namely:
>
>
On Fri, 21 Jul 2023 at 02:59, Ivan Panchenko wrote:
>
> Friday, 14 July 2023, 23:27 +03:00 от Tom Lane :
>
> =?UTF-8?B?SXZhbiBQYW5jaGVua28=?= writes:
> > Четверг, 6 июля 2023, 14:48 +03:00 от Peter Eisentraut <
> > pe...@eisentraut.org >:
> >> If the transform deals with a built-in type, then
On Wed, 1 Nov 2023 at 03:38, Matthias van de Meent
wrote:
>
> (now really to -hackers)
> Hi,
>
> Over at [0] I'd implemented an optimization that allows us to skip
> calling _bt_compare in _bt_moveright in many common cases. This patch,
> when stacked on top of the prefix truncation patch,
On Tue, 31 Oct 2023 at 14:36, Dmitry Dolgov <9erthali...@gmail.com> wrote:
>
> > On Fri, Oct 27, 2023 at 05:02:44PM +0200, Dmitry Dolgov wrote:
> > > On Thu, Oct 26, 2023 at 09:08:42AM +0900, Michael Paquier wrote:
> > > typedef struct ArrayExpr
> > > {
> > > +
On Thu, 7 Dec 2023 at 20:06, Anthonin Bonnefoy
wrote:
>
> Hi,
>
> Thanks for the review!
>
> > ```
> > +-- Worker can take some additional time to end and report their spans
> > +SELECT pg_sleep(0.2);
> > + pg_sleep
> > +--
> > +
> > +(1 row)
> > ```
> >
> > Pretty sure this will fail on
On Tue, 21 Nov 2023 at 09:52, Adam Hendel wrote:
>
> Hello,
>
> On Mon, Nov 13, 2023 at 6:01 PM Andres Freund wrote:
>>
>> Hi,
>>
>> On 2023-11-13 11:55:07 -0600, Adam Hendel wrote:
>> > Currently, pgbench will log individual transactions to a logfile when the
>> > `--log` parameter flag is
On Mon, 1 Jan 2024 at 19:26, Andy Fan wrote:
>
>
> Andy Fan writes:
>
> >
> > Some Known issues:
> > --
> >
> > 1. Currently only Scan & Join nodes are considered for this feature.
> > 2. JIT is not adapted for this purpose yet.
>
> JIT is adapted for this feature in v2. Any
On Mon, 20 Nov 2023 at 10:00, Amit Langote wrote:
>
> On Thu, Sep 28, 2023 at 5:26 PM Amit Langote wrote:
> > On Tue, Sep 26, 2023 at 10:06 PM Amit Langote
> > wrote:
> > > After sleeping on this, I think we do need the checks after all the
> > > ExecInitNode() calls too, because we have many
On Tue, 21 Nov 2023 at 01:47, Schoemans Maxime wrote:
>
> On 14/11/2023 20:46, Tom Lane wrote:
> > I took a brief look through this very interesting work. I concur
> > with Tomas that it feels a little odd that range join selectivity
> > would become smarter than scalar inequality join
On Wed, 22 Nov 2023 at 13:01, Kyotaro Horiguchi wrote:
>
> Anyway, this requires rebsaing, and done.
Few tests are failing at [1], kindly post an updated patch:
/tmp/cirrus-ci-build/src/test/recovery --testgroup recovery --testname
039_end_of_wal -- /usr/local/bin/perl -I
On Sun, 29 Oct 2023 at 11:14, Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Andres,
>
> While tracking BF failures related with pg_ugprade, I found the same failure
> has still happened [1] - [4].
> According to the log, the output directory was remained even after the
> successful upgrade [5].
> I
On Thu, 28 Dec 2023 at 09:27, jian he wrote:
>
> On Wed, Dec 20, 2023 at 8:27 PM Masahiko Sawada wrote:
> >
> >
> > Why do we need to use SPI? I think we can form heap tuples and insert
> > them to the error table. Creating the error table also doesn't need to
> > use SPI.
> >
> Thanks for
On Tue, 2 Jan 2024 at 15:58, Amit Kapila wrote:
>
> On Fri, Dec 29, 2023 at 2:26 PM vignesh C wrote:
> >
> > On Thu, 28 Dec 2023 at 15:59, Amit Kapila wrote:
> > >
> > > On Wed, Dec 13, 2023 at 12:09 PM vignesh C wrote:
> > > >
> > >
On Wed, 3 Jan 2024 at 11:25, Amit Kapila wrote:
>
> On Wed, Jan 3, 2024 at 6:21 AM Michael Paquier wrote:
> >
> > On Tue, Jan 02, 2024 at 03:58:25PM +0530, Amit Kapila wrote:
> > > On Fri, Dec 29, 2023 at 2:26 PM vignesh C wrote:
> > >> Thanks, th
logical replication cluster b)
Upgrade cascaded logical replication cluster c) Upgrade 2 node
circular logical replication cluster.
Thoughts?
[1] - https://www.postgresql.org/docs/devel/pgupgrade.html
Regards,
Vignesh
From 9458a2c62a0702316d9ab339cd01dac0e088c52e Mon Sep 17 00:00:00 2001
From:
On Wed, 3 Jan 2024 at 14:49, Amit Kapila wrote:
>
> On Wed, Jan 3, 2024 at 12:09 PM vignesh C wrote:
> >
> > On Wed, 1 Nov 2023 at 19:28, Ashutosh Bapat
> > wrote:
> > >
> > > At this stage the standby would have various replication objects like
On Wed, 1 Nov 2023 at 19:28, Ashutosh Bapat
wrote:
>
> At this stage the standby would have various replication objects like
> publications, subscriptions, origins inherited from the upstream
> server and possibly very much active. With failover slots, it might
> inherit replication slots. Is it
On Tue, 2 Jan 2024 at 15:43, Magnus Hagander wrote:
>
> On Tue, Jan 2, 2024 at 3:45 AM vignesh C wrote:
> >
> > On Mon, 1 Jan 2024 at 21:01, Magnus Hagander wrote:
> > >
> > > On Mon, Jan 1, 2024 at 4:35 AM vignesh C wrote:
> > > >
> &
On Mon, 1 Jan 2024 at 21:01, Magnus Hagander wrote:
>
> On Mon, Jan 1, 2024 at 4:35 AM vignesh C wrote:
> >
> > On Sun, 24 Dec 2023 at 18:40, vignesh C wrote:
> > >
> > > On Sun, 24 Dec 2023 at 07:16, Michael Paquier wrote:
> > > >
> > &
On Wed, 6 Dec 2023 at 12:53, Euler Taveira wrote:
>
> On Thu, Nov 9, 2023, at 8:12 PM, Michael Paquier wrote:
>
> On Thu, Nov 09, 2023 at 03:41:53PM +0100, Peter Eisentraut wrote:
> > On 08.11.23 00:12, Michael Paquier wrote:
> >> - Should the subdirectory pg_basebackup be renamed into something
On Sun, 24 Dec 2023 at 18:40, vignesh C wrote:
>
> On Sun, 24 Dec 2023 at 07:16, Michael Paquier wrote:
> >
> > On Sat, Dec 23, 2023 at 08:52:38AM +0530, vignesh C wrote:
> > > I didn't see anyone volunteering for the January Commitfest, so I'll
> > > volunte
On Sun, 31 Dec 2023 at 06:19, Michael Paquier wrote:
>
> On Fri, Dec 29, 2023 at 02:41:55PM +0530, vignesh C wrote:
> > Commitfest 2024-01 is starting in 3 days!
> > Please register the patches which have not yet registered. Also if
> > someone has some pending patch t
Hi,
Commitfest 2024-01 is starting in 3 days!
Please register the patches which have not yet registered. Also if
someone has some pending patch that is not yet submitted, please
submit and register for 2024-01 Commitfest.
I will be having a look at the commitfest entries, correcting the
status if
On Thu, 28 Dec 2023 at 15:59, Amit Kapila wrote:
>
> On Wed, Dec 13, 2023 at 12:09 PM vignesh C wrote:
> >
> > Thanks for the comments, the attached v25 version patch has the
> > changes for the same.
> >
>
> I have looked at it again and made some cosmetic c
On Sun, 24 Dec 2023 at 07:16, Michael Paquier wrote:
>
> On Sat, Dec 23, 2023 at 08:52:38AM +0530, vignesh C wrote:
> > I didn't see anyone volunteering for the January Commitfest, so I'll
> > volunteer to be CF manager for January 2024 Commitfest.
>
> (Adding Magnu
On Fri, 22 Dec 2023 at 01:17, Daniel Verite wrote:
>
> vignesh C wrote:
>
> > Thanks for the updated patch, any reason why this is handled only in csv.
> > postgres=# copy test1 from '/home/vignesh/postgres/inst/bin/copy1.out';
> > COPY 1
> > postgr
Hi,
I didn't see anyone volunteering for the January Commitfest, so I'll
volunteer to be CF manager for January 2024 Commitfest.
Regards,
Vignesh
On Wed, 20 Dec 2023 at 21:13, Peter Eisentraut wrote:
>
> On 20.12.23 12:40, Andres Freund wrote:
> > Hm, or perhaps we should just get rid of sed use altogether. The sepgsql
> > case
> > is trivially translateable to perl, and postprocess_dtrace.sed isn't
> > much harder.
>
> Maybe yeah, but
On Tue, 19 Dec 2023 at 16:57, Daniel Verite wrote:
>
> vignesh C wrote:
>
> > I noticed that these tests are passing without applying patch too:
>
> > +insert into copytest2(test) values('line1'), ('\.'), ('line2');
> > +copy (select test from copy
On Tue, 19 Dec 2023 at 20:54, Peter Eisentraut wrote:
>
> On 18.12.23 14:52, Peter Eisentraut wrote:
> >> 2) I had seen that if sed/gzip is not available meson build will fail:
> >> 2.a)
> >> Program gsed sed found: NO
> >> meson.build:334:6: ERROR: Program 'gsed sed' not found or not executable
On Tue, 19 Dec 2023 at 21:22, Nathan Bossart wrote:
>
> On Tue, Dec 19, 2023 at 03:44:43PM +0100, Jelte Fennema-Nio wrote:
> > On Tue, 19 Dec 2023 at 11:59, vignesh C wrote:
> >> I noticed that this change can be done in several other places too.
> >
> > M
On Mon, 18 Dec 2023 at 19:00, Jelte Fennema-Nio wrote:
>
> The more I think about it and look at the code, the more I like the
> usage of the loop style proposed in the previous 0003 patch (which
> automatically declares a loop variable for the scope of the loop using
> a second for loop).
>
> I
On Tue, 19 Dec 2023 at 02:06, Daniel Verite wrote:
>
> Hi,
>
> PFA a patch that attempts to fix the bug that \. on a line
> by itself is handled incorrectly by COPY FROM ... CSV.
> This issue has been discussed several times previously,
> for instance in [1] and [2], and mentioned in the
> doc
On Wed, 6 Dec 2023 at 12:59, Michael Paquier wrote:
>
> On Wed, Dec 06, 2023 at 12:15:50PM +0530, Shubham Khanna wrote:
> > Patch is not applying. Please share the Rebased Version. Please find the
> > error:
>
> Thanks. Here you go with a v6.
Few comments:
1) Now that the MSVC build scripts
On Wed, 13 Dec 2023 at 01:56, Masahiko Sawada wrote:
>
> On Thu, Dec 7, 2023 at 8:15 PM vignesh C wrote:
> >
> > On Tue, 5 Dec 2023 at 10:56, Michael Paquier wrote:
> > >
> > > On Mon, Dec 04, 2023 at 04:30:49PM +0530, Amit Kapila wrote:
> > >
On Thu, 7 Dec 2023 at 07:20, Masahiko Sawada wrote:
>
> On Mon, Dec 4, 2023 at 8:01 PM Amit Kapila wrote:
> >
> > On Fri, Dec 1, 2023 at 11:24 PM vignesh C wrote:
> > >
> > > The attached v22 version patch has the changes for the same.
> > >
>
hat this is safe. Shouldn't this be a
> poll_query_until(), polling that the state of the relation is what we
> want it to be after requesting a fresh of the publication on the
> subscriber?
This is not required as the table will be added in init state after
"Alter Subscription ... Refresh ..
On Tue, 5 Dec 2023 at 11:11, Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Sawada-san, hackers,
>
> Based on comments I made a fix. PSA the patch.
>
Thanks for the patch, the changes look good to me.
Regards,
Vignesh
oid FROM pg_subscription WHERE subname = 'regress_sub4'");
> +my $reporigin = 'pg_' . qq($subid);
> +
> +# Drop the subscription's replication origin
> +$old_sub->safe_psql('postgres',
> + "SELECT pg_replication_origin_drop('$reporigin')");
> +
> +$old_sub-
On Thu, 30 Nov 2023 at 13:35, Amit Kapila wrote:
>
> On Wed, Nov 29, 2023 at 3:02 PM Amit Kapila wrote:
> >
>
> In general, the test cases are a bit complex to understand, so, it
> will be difficult to enhance these later. The complexity comes from
> the fact that one upgrade test is trying to
On Thu, 30 Nov 2023 at 06:37, Peter Smith wrote:
>
> Here are some review comments for patch v20-0001
>
> ==
>
> 1. getSubscriptions
>
> + if (dopt->binary_upgrade && fout->remoteVersion >= 17)
> + appendPQExpBufferStr(query, " s.subenabled\n");
> + else
> + appendPQExpBufferStr(query, "
On Wed, 29 Nov 2023 at 15:02, Amit Kapila wrote:
>
> On Tue, Nov 28, 2023 at 4:12 PM vignesh C wrote:
> >
>
> Few comments on the latest patch:
> ===
> 1.
> + if (fout->remoteVersion >= 17)
> + appendPQExpBufferStr(query, &qu
On Mon, 27 Nov 2023 at 06:53, Peter Smith wrote:
>
> Here are some review comments for patch set v19*
>
> //
>
> v19-0001.
>
> No comments
>
> ///
>
> v19-0002.
>
> (I saw that both changes below seemed cut/paste from similar
> functions, but I will ask the questions anyway).
>
> ==
>
On Sat, 25 Nov 2023 at 17:50, Amit Kapila wrote:
>
> 2.
> + * b) SUBREL_STATE_SYNCDONE: A relation upgraded while in this state
> + * would retain the replication origin in certain cases.
>
> I think this is vague. Can we briefly describe cases where the origins
> would be retained?
Modified
>
On Mon, 27 Nov 2023 at 17:12, Amit Kapila wrote:
>
> On Mon, Nov 27, 2023 at 3:18 PM vignesh C wrote:
> >
> > On Sat, 25 Nov 2023 at 17:50, Amit Kapila wrote:
> > >
> > > On Sat, Nov 25, 2023 at 7:21 AM vignesh C wrote:
> > > >
> > >
&g
On Fri, 24 Nov 2023 at 18:37, Shubham Khanna
wrote:
>
> n Fri, Nov 24, 2023 at 6:33 PM vignesh C wrote:
> >
> > Hi,
> >
> > Improved tab completion for "ALTER DEFAULT PRIVILEGE" and "ALTER TABLE":
> > 1) GRANT, REVOKE and FOR USER keyword
On Sat, 25 Nov 2023 at 17:50, Amit Kapila wrote:
>
> On Sat, Nov 25, 2023 at 7:21 AM vignesh C wrote:
> >
>
> Few comments on v19:
> ==
> 1.
> +
> + The subscriptions will be migrated to the new cluster in a disabled
> s
On Mon, 20 Nov 2023 at 05:27, Michael Paquier wrote:
>
> On Sun, Nov 19, 2023 at 06:56:05AM +0530, vignesh C wrote:
> > On Sun, 19 Nov 2023 at 06:52, vignesh C wrote:
> >> On Fri, 10 Nov 2023 at 19:26, vignesh C wrote:
> >>> I will analyze more on this and po
and/
Modified
The attached v19 version patch has the changes for the same.
Regards,
Vignesh
From 5f3a248ff1f723c01d55bcaeb665c5f8f38824a1 Mon Sep 17 00:00:00 2001
From: Vignesh C
Date: Mon, 30 Oct 2023 12:31:59 +0530
Subject: [PATCH v19] Preserve the full subscription's state during pg_upgrade
On Thu, 23 Nov 2023 at 05:56, Peter Smith wrote:
>
> Here are some review comments for patch v17-0001
>
> ==
> src/bin/pg_dump/pg_dump.c
>
> 1. getSubscriptionTables
>
> +/*
> + * getSubscriptionTables
> + * Get information about subscription membership for dumpable tables. This
> + *
On Tue, 21 Nov 2023 at 07:11, Michael Paquier wrote:
>
> On Mon, Nov 20, 2023 at 09:49:41AM +0530, Amit Kapila wrote:
> > On Tue, Nov 14, 2023 at 7:21 AM vignesh C wrote:
> >> There are couple of things happening here: a) In the first part we
> >> take care of
,
> + "no change in table tab_not_upgraded1 afer enable subscription which
> is not part of the publication"
>
> /afer/after/
Modified
> ~~~
>
> 14.
> +# --
> +# Check that pg_upgrade refuses to run a) if there's
On Thu, 16 Nov 2023 at 18:25, Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Vignesh,
>
> Thanks for updating the patch! Here are some comments.
> They are mainly cosmetic because I have not read yours these days.
>
> 01. binary_upgrade_add_sub_rel_state()
>
> ```
> +/* We must check these things
t;port, '-P', $new_sub1->port,
> + $mode,
> + ],
> + 'run of pg_upgrade --check for old instance when the subscription
> tables are in ready state'
> +);
>
> Should that message say "init state" instead of "ready state"?
Modified
> ~~~
>
>
201 - 300 of 1500 matches
Mail list logo
