On Mon, 24 Apr 2023 at 12:52, Julien Rouhaud wrote:
>
> Hi,
>
> On Tue, Apr 18, 2023 at 01:40:51AM +, Hayato Kuroda (Fujitsu) wrote:
> >
> > I found a cfbot failure on macOS [1]. According to the log,
> > "SELECT count(*) FROM t2" was executed before synchronization was done.
> >
> > ```
> >
*** functions like pg_get_constraintdef,
pg_get_function_arguments, pg_get_function_result,
pg_get_function_identity_arguments, pg_get_function_sqlbody,
pg_get_expr, pg_get_partkeydef, pg_get_statisticsobjdef and
pg_get_triggerdef.
The Attached patch has the changes for the same.
Regards,
Vignesh
On Fri, 9 Jun 2023 at 08:31, Michael Paquier wrote:
>
> On Tue, Jun 06, 2023 at 06:43:44PM +0530, vignesh C wrote:
> > Please find the attached patches that can be applied on back branches
> > too. v5*master.patch can be applied on master, v5*PG15.patch can be
> > applie
gards,
Vignesh
From d582676214f3fd5068c343f42116fa256be18958 Mon Sep 17 00:00:00 2001
From: Vignesh C
Date: Tue, 6 Jun 2023 17:07:37 +0530
Subject: [PATCH v5] Remove duplicate find_in_log sub routines from tap tests.
Remove duplicate find_in_log sub routines from tap tests.
---
src/test/per
On Thu, 1 Jun 2023 at 07:42, Yu Shi (Fujitsu) wrote:
>
> On Wed, May 31, 2023 5:41 PM shveta malik wrote:
> >
> > PFA the set of patches consisting above changes. All the changes are
> > made in 0008 patch.
> >
> > Apart from above changes, many partition attach/detach related tests
> > are
On Sun, 4 Jun 2023 at 03:51, Michael Paquier wrote:
>
> On Mon, May 29, 2023 at 07:49:52AM +0530, vignesh C wrote:
> > Thanks for the comment, the attached v3 version patch has the changes
> > for the same.
>
> -if (find_in_log(
> - $node, $log_offset
On Mon, 22 May 2023 at 15:50, Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Wang,
>
> Thank you for reviewing! PSA new version.
>
> > For patches 0001
> >
> > 1. The latest patch set fails to apply because the new commit (0245f8d) in
> > HEAD.
>
> I didn't notice that. Thanks, fixed.
>
> > 2. In file
On Mon, 22 May 2023 at 15:50, Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Wang,
>
> Thank you for reviewing! PSA new version.
Thanks for the updated patch, Few comments:
Few comments
1) check_for_parameter_settings, check_for_confirmed_flush_lsn and
check_are_logical_slots_active functions all have
On Sat, 27 May 2023 at 17:32, Andrew Dunstan wrote:
>
>
> On 2023-05-26 Fr 20:35, vignesh C wrote:
>
> On Fri, 26 May 2023 at 04:09, Michael Paquier wrote:
>
> On Thu, May 25, 2023 at 06:34:20PM +0100, Dagfinn Ilmari Mannsåker wrote:
>
> However, none of the othe
plex with multiple checks. I was not able to make it simple with
the approach I tried. How about having a common function
check_connect_log_contents which has the common log contents check for
connect_ok and connect_fails function like the v2-0002 patch attached.
Regards,
Vignesh
From 1e835b6d032ea38
On Thu, 25 May 2023 at 23:04, Dagfinn Ilmari Mannsåker
wrote:
>
> vignesh C writes:
>
> > Hi,
> >
> > The recovery tap test has 4 implementations of find_in_log sub routine
> > for various uses, I felt we can generalize these and have a single
> > fu
On Fri, 26 May 2023 at 15:25, shveta malik wrote:
>
> I have attempted to convert pg_get_indexdef() to use
> systable_beginscan() based on transaction-snapshot rather than using
> SearchSysCache(). The latter does not have any old info and thus
> provides only the latest info as per the committed
,
VIgnesh
From 7c4b6731a27c031ad27f6f88150c1dfaae1f46fe Mon Sep 17 00:00:00 2001
From: Vignesh C
Date: Thu, 25 May 2023 10:47:16 +0530
Subject: [PATCH] Remove duplicate find_in_log sub routines from tap tests.
Remove duplicate find_in_log sub routines from tap tests.
---
src/test/authentication/t
On Mon, 22 May 2023 at 11:27, shveta malik wrote:
>
> On Wed, May 17, 2023 at 4:45 PM vignesh C wrote:
> >
> > On Wed, 17 May 2023 at 15:41, shveta malik wrote:
> > >
> > > On Fri, May 12, 2023 at 12:03 PM shveta malik
> > > wrote:
> > >
On Fri, 5 May 2023 at 12:34, Amit Kapila wrote:
>
> On Fri, May 5, 2023 at 11:08 AM Drouvot, Bertrand
> wrote:
> >
> > On 5/4/23 6:43 AM, Amit Kapila wrote:
> > > On Thu, May 4, 2023 at 8:37 AM vignesh C wrote:
> > >>
> > >> Thanks for po
On Wed, 3 May 2023 at 15:59, Amit Kapila wrote:
>
> On Tue, May 2, 2023 at 4:52 PM Drouvot, Bertrand
> wrote:
> >
> >
> > As per your suggestion, changing the insert ordering (like in V8 attached)
> > makes it now work on the failing environment too.
> >
>
> I think it is better to use
On Wed, 26 Apr 2023 at 12:02, Masahiko Sawada wrote:
>
> On Tue, Mar 28, 2023 at 3:22 PM houzj.f...@fujitsu.com
> wrote:
> >
> > On Tuesday, March 28, 2023 1:41 PM Amit Kapila
> > wrote:
> > >
> > > On Mon, Mar 27, 2023 at 5:37 PM Amit Kapila
> > > wrote:
> > > >
> > > > On Mon, Mar 27, 2023
On Wed, 26 Apr 2023 at 13:45, Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 4/26/23 6:06 AM, vignesh C wrote:
> > On Tue, 25 Apr 2023 at 12:51, Drouvot, Bertrand
> > wrote:
> > Thanks for the updated patch.
> > Few comments:
>
> Thanks for
On Tue, 25 Apr 2023 at 12:51, Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 4/25/23 6:23 AM, Amit Kapila wrote:
> > On Mon, Apr 24, 2023 at 3:36 PM Drouvot, Bertrand
> > wrote:
> >>
> >> Without the second "pg_log_standby_snapshot()" then
> >> wait_for_subscription_sync() would be waiting
> >> some
On Wed, 12 Apr 2023 at 21:45, Drouvot, Bertrand
wrote:
>
> hi hackers,
>
> In the logical decoding on standby thread [1], Andres proposed 2 new tests
> (that I did
> not find the time to complete before the finish line):
>
> - Test that we can subscribe to the standby (with the publication
existing tests were there only for password_required
as true.
Regards,
Vignesh
From d0379b915a449d5763bd7665a1ec32edad009bd3 Mon Sep 17 00:00:00 2001
From: Vignesh C
Date: Fri, 21 Apr 2023 11:54:17 +0530
Subject: [PATCH] Display 'password_required' option for \dRs+ command.
In commit c3afe8cf5a
On Thu, 20 Apr 2023 at 23:10, Tom Lane wrote:
>
> The Core Team would like to extend our congratulations to
> Nathan Bossart, Amit Langote, and Masahiko Sawada, who have
> accepted invitations to become our newest Postgres committers.
>
> Please join me in wishing them much success and few
On Thu, 20 Apr 2023 at 11:01, Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Vignesh,
>
> Thank you for reviewing! PSA new patchset.
>
> > > Additionally, I added a checking functions in 0003
> > > According to pg_resetwal and other functions, the length of
> > CHECKPOINT_SHUTDOWN
> > > record seems
On Wed, 19 Apr 2023 at 17:26, shaurya jain <12345shau...@gmail.com> wrote:
>
> Hi Team,
>
> Could you please help me with this, It's urgent for the production
> environment.
>
> On Wed, Apr 19, 2023 at 3:44 PM shaurya jain <12345shau...@gmail.com> wrote:
>>
>> Hi Team,
>>
>> Could you please
On Fri, 14 Apr 2023 at 16:00, Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Julien,
>
> > Sorry for the delay, I didn't had time to come back to it until this
> > afternoon.
>
> No issues, everyone is busy:-).
>
> > I don't think that your analysis is correct. Slots are guaranteed to be
> > stopped
On Fri, 14 Apr 2023 at 16:00, Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Julien,
>
> > Sorry for the delay, I didn't had time to come back to it until this
> > afternoon.
>
> No issues, everyone is busy:-).
>
> > I don't think that your analysis is correct. Slots are guaranteed to be
> > stopped
On Sat, 15 Apr 2023 at 06:38, vignesh C wrote:
>
> On Fri, 14 Apr 2023 at 13:06, vignesh C wrote:
> >
> > Few comments:
Few more comments:
1) since missing_ok is passed as false, if there is an error the error
will be handled in find_string_in_jsonbcontainer, "missing
On Fri, 14 Apr 2023 at 13:06, vignesh C wrote:
>
> Few comments:
Some more comments on 0001 patch:
Few comments:
1) We could add a space after the 2nd parameter
+ * Note we don't have the luxury of sprintf-like compiler warnings for
+ * malformed argument lists.
+ */
+static O
On Fri, 7 Apr 2023 at 08:52, houzj.f...@fujitsu.com
wrote:
>
> On Friday, April 7, 2023 11:13 AM houzj.f...@fujitsu.com
>
> >
> > On Tuesday, April 4, 2023 7:35 PM shveta malik
> > wrote:
> > >
> > > On Tue, Apr 4, 2023 at 8:43 AM houzj.f...@fujitsu.com
> > > wrote:
> > >
> > > > Attach the
On Thu, 30 Mar 2023 at 13:29, houzj.f...@fujitsu.com
wrote:
>
>
>
> > -Original Message-
> > From: houzj.f...@fujitsu.com
> > Sent: Thursday, March 30, 2023 2:37 PM
> >
> > On Tuesday, March 28, 2023 12:13 PM houzj.f...@fujitsu.com
> > wrote:
> > >
> > > On Monday, March 27, 2023 8:08
On Thu, 30 Mar 2023 at 13:29, houzj.f...@fujitsu.com
wrote:
>
>
>
> > -Original Message-
> > From: houzj.f...@fujitsu.com
> > Sent: Thursday, March 30, 2023 2:37 PM
> >
> > On Tuesday, March 28, 2023 12:13 PM houzj.f...@fujitsu.com
> > wrote:
> > >
> > > On Monday, March 27, 2023 8:08
On Sun, 26 Mar 2023 at 18:08, vignesh C wrote:
>
> On Thu, 23 Mar 2023 at 09:22, Ajin Cherian wrote:
> >
> > On Mon, Mar 20, 2023 at 8:17 PM houzj.f...@fujitsu.com
> > wrote:
> > >
> > > Attach the new patch set which addressed above comments.
&
On Thu, 23 Mar 2023 at 09:22, Ajin Cherian wrote:
>
> On Mon, Mar 20, 2023 at 8:17 PM houzj.f...@fujitsu.com
> wrote:
> >
> > Attach the new patch set which addressed above comments.
> > 0002,0003,0004 patch has been updated in this version.
> >
> > Best Regards,
> > Hou zj
>
> Attached a
On Thu, 23 Mar 2023 at 09:22, Ajin Cherian wrote:
>
> On Mon, Mar 20, 2023 at 8:17 PM houzj.f...@fujitsu.com
> wrote:
> >
> > Attach the new patch set which addressed above comments.
> > 0002,0003,0004 patch has been updated in this version.
> >
> > Best Regards,
> > Hou zj
>
> Attached a
On Fri, 17 Mar 2023 at 17:55, Melih Mutlu wrote:
>
> Hi,
>
> Sharing v17.
>
> Amit Kapila , 17 Mar 2023 Cum, 03:02 tarihinde şunu
> yazdı:
>>
>> I think to reduce the risk of breakage, let's change the check to
>> >=v16. Also, accordingly, update the doc and commit message.
>
>
> Done.
>
> Peter
On Thu, 16 Mar 2023 at 21:55, Tomas Vondra
wrote:
>
> Hi!
>
> On 3/16/23 08:38, Masahiko Sawada wrote:
> > Hi,
> >
> > On Wed, Mar 15, 2023 at 9:52 PM Tomas Vondra
> > wrote:
> >>
> >>
> >>
> >> On 3/14/23 08:30, John Naylor wrote:
> >>> I tried a couple toy examples with various combinations of
On Thu, 16 Mar 2023 at 21:55, Tomas Vondra
wrote:
>
> Hi!
>
> On 3/16/23 08:38, Masahiko Sawada wrote:
> > Hi,
> >
> > On Wed, Mar 15, 2023 at 9:52 PM Tomas Vondra
> > wrote:
> >>
> >>
> >>
> >> On 3/14/23 08:30, John Naylor wrote:
> >>> I tried a couple toy examples with various combinations of
On Wed, 15 Mar 2023 at 15:30, Melih Mutlu wrote:
>
> Hi,
>
> Please see the attached patch.
One comment:
1) There might be a chance the result order of select may vary as
"ORDER BY" is not specified, Should we add "ORDER BY" as the table
has multiple rows:
+# Check the synced data on the
On Tue, 14 Mar 2023 at 12:37, Peter Smith wrote:
>
> Thanks for the review!
>
> On Mon, Mar 13, 2023 at 6:19 PM vignesh C wrote:
> ...
> > Few comments:
> > 1) Can we move the macros along with the other macros present in this
> > file, just above this struc
On Tue, 14 Mar 2023 at 14:36, Önder Kalacı wrote:
>
>
> Amit Kapila , 14 Mar 2023 Sal, 11:59 tarihinde şunu
> yazdı:
>>
>> On Tue, Mar 14, 2023 at 12:48 PM Önder Kalacı wrote:
>> >>
>> >> 2.
>> >> +# make sure that the subscriber has the correct data after the update
>> >> UPDATE
>> >>
>> >>
On Fri, 10 Mar 2023 at 04:36, Peter Smith wrote:
>
> Hi,
>
> During a recent code review, I was confused multiple times by the
> toptxn member of ReorderBufferTXN, which is defined only for
> sub-transactions.
>
> e.g. txn->toptxn member == NULL means the txn is a top level txn.
> e.g.
egards,
Vignesh
From 63b53a87253af6e5d08f473cb0d568c2321a2bd3 Mon Sep 17 00:00:00 2001
From: Vignesh C
Date: Fri, 3 Mar 2023 15:54:00 +0530
Subject: [PATCH v1] Implement IF NOT EXISTS for CREATE PUBLICATION AND CREATE
SUBSCRIPTION
Implement IF NOT EXISTS for CREATE PUBLICATION AND CREATE SUBSC
On Wed, 8 Mar 2023 at 21:46, Önder Kalacı wrote:
>
> Hi Vignesh C,
>
>>
>>
>> Few comments
>> 1) Maybe this change is not required:
>> fallback if no other solution is possible. If a replica identity other
>> than full is set on the publish
On Tue, 7 Mar 2023 at 19:17, Önder Kalacı wrote:
>
> Hi Amit, Peter
>
>>
>> > > Let me give an example to demonstrate why I thought something is fishy
>> > > here:
>> > >
>> > > Imagine rel has a (non-default) REPLICA IDENTITY with Oid=.
>> > > Imagine the same rel has a PRIMARY KEY with
On Fri, 3 Mar 2023 at 18:40, Önder Kalacı wrote:
>
> Hi Vignesh,
>
> Thanks for the review
>
>>
>> 1) We are currently calling RelationGetIndexList twice, once in
>> FindUsableIndexForReplicaIdentityFull function and in the caller too,
>> we could avoid one of the calls by passing the indexlist
On Tue, 7 Mar 2023 at 09:53, Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Katsuragi-san,
>
> Thank you for reviewing! PSA new version patches.
>
> > I think we can update the status to ready for committer after
> > this fix, if there is no objection.
>
> That's a very good news for me! How about other
gt; +}
> > > >
> > > > 9b.
> > > > I understand why this function was put here beside the other static
> > > > functions in "Support Routines" but IMO it really belongs nearby (i.e.
> > > > directly above) the only caller (format_p
On Thu, 2 Mar 2023 at 20:53, Önder Kalacı wrote:
>
> Hi,
>
>>
>> Is it just a matter of testing other
>> index types
>
>
> Yes, there are more to it. build_replindex_scan_key()
> only works for btree indexes, as it does BTEqualStrategyNumber.
>
> I might expect a few more limitations like that.
On Tue, 28 Feb 2023 at 21:21, Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Amit,
>
> > Few comments:
>
> Thank you for reviewing! PSA new version.
Thanks for the updated patch, few comments:
1) Currently we have added the delay during the decode of commit,
while decoding the commit walsender process
On Tue, 28 Feb 2023 at 01:22, Melih Mutlu wrote:
>
> Hi,
>
> Thanks for all of your reviews!
>
> So, I made some changes in the v10 according to your comments.
>
> 1- copy_format is changed to a boolean parameter copy_binary.
> It sounds easier to use a boolean to enable/disable binary copy.
On Fri, 17 Feb 2023 at 02:38, Jonathan S. Katz wrote:
>
> On 2/16/23 2:43 PM, Jonathan S. Katz wrote:
> > On 2/16/23 2:38 PM, Alvaro Herrera wrote:
> >> On 2023-Feb-16, Jonathan S. Katz wrote:
> >>
> >>> On 2/16/23 12:53 PM, Alvaro Herrera wrote:
> >>
> I don't think this is the fault of
Hi,
The output sql generated by pg_dump for the below function refers to a
modified table name:
create table t1 (c1 int);
create table t2 (c1 int);
CREATE OR REPLACE FUNCTION test_fun(c1 int)
RETURNS void
LANGUAGE SQL
BEGIN ATOMIC
WITH delete_t1 AS (
DELETE FROM t1 WHERE c1 = $1
On Fri, 10 Feb 2023 at 21:50, vignesh C wrote:
> The attached v68 version patch has the changes for the same.
I was not sure if we should support ddl replication of
create/alter/drop subscription commands as there might be some data
inconsistency issues in the following cases:
#node1
On Tue, 7 Feb 2023 at 17:35, vignesh C wrote:
>
> On Mon, 6 Feb 2023 at 17:02, vignesh C wrote:
> >
> > On Mon, 6 Feb 2023 at 06:47, Peter Smith wrote:
> > >
> > > Here are some comments for patch v63-0002.
> > >
> > > This is
On Mon, 6 Feb 2023 at 17:02, vignesh C wrote:
>
> On Mon, 6 Feb 2023 at 06:47, Peter Smith wrote:
> >
> > Here are some comments for patch v63-0002.
> >
> > This is a WIP because I have not yet looked at the large file -
> > ddl_deparse.c.
> &g
On Wed, 1 Feb 2023 at 14:49, Alvaro Herrera wrote:
>
> On 2023-Jan-31, vignesh C wrote:
>
> > On Tue, 3 Jan 2023 at 18:38, vignesh C wrote:
>
> > > The patch does not apply on top of HEAD as in [1], please post a rebased
> > > patch:
> > > === Ap
On Wed, 1 Feb 2023 at 11:25, Julien Rouhaud wrote:
>
> On Wed, Feb 1, 2023 at 10:44 AM vignesh C wrote:
> >
> > I don't have permissions to close the commitfest, could one of them
> > help in closing the commitfest.
>
> It's technically 17:53 at Anywher
On Sun, 29 Jan 2023 at 22:05, vignesh C wrote:
>
> On Sun, 22 Jan 2023 at 22:00, vignesh C wrote:
> >
> > On Sun, 15 Jan 2023 at 23:02, vignesh C wrote:
> > >
> > > On Sun, 8 Jan 2023 at 21:00, vignesh C wrote:
> > > >
>
On Tue, 17 Jan 2023 at 17:17, vignesh C wrote:
>
> On Tue, 29 Nov 2022 at 20:24, Nazir Bilal Yavuz wrote:
> >
> > Hi,
> >
> > Thanks for the patch!
> >
> >
> > On 10/29/22 12:54, Marina Polyakova wrote:
> > >
> > >
On Tue, 17 Jan 2023 at 17:10, vignesh C wrote:
>
> On Wed, 16 Nov 2022 at 10:18, Ian Lawrence Barwick wrote:
> >
> > 2022年9月3日(土) 17:28 Dong Wook Lee :
> > >
> > > Hi hackers,
> > > I write a tiny patch about vacuumlo to improve test coverage.
&
On Tue, 17 Jan 2023 at 17:06, vignesh C wrote:
>
> On Fri, 25 Nov 2022 at 18:08, Peter Eisentraut
> wrote:
> >
> > On 23.08.22 03:38, Dong Wook Lee wrote:
> > > I made a small patch for xml2 to improve test coverage.
> > > However, there
On Fri, 4 Nov 2022 at 07:02, Ian Lawrence Barwick wrote:
>
> 2022年7月27日(水) 2:47 chenhj :
> >
> > Hi hackers,
> >
> > I have rebase this patch and made some improvements.
> >
> >
> > 1. A header is added to each chunk in the pcd file, which records the chunk
> > of which block the chunk belongs
On Mon, 16 Jan 2023 at 19:56, vignesh C wrote:
>
> On Thu, 3 Nov 2022 at 15:06, Ian Lawrence Barwick wrote:
> >
> > 2022年9月30日(金) 1:04 Matthias van de Meent :
> > >
> > > On Wed, 28 Sept 2022 at 19:40, Bruce Momjian wrote:
> > > >
> > >
On Tue, 3 Jan 2023 at 18:38, vignesh C wrote:
>
> On Sun, 20 Nov 2022 at 11:42, Nikolay Shaplov wrote:
> >
> > В письме от воскресенье, 6 ноября 2022 г. 19:22:09 MSK пользователь Nikolay
> > Shaplov написал:
> >
> > > > > > cfbot reports the
On Fri, 6 Jan 2023 at 11:46, vignesh C wrote:
>
> On Sun, 13 Nov 2022 at 04:15, Tom Lane wrote:
> >
> > Andy Fan writes:
> > > In the past we pull-up the ANY-sublink with 2 steps, the first step is to
> > > pull up the sublink as a subquery, and the next s
On Thu, 8 Dec 2022 at 00:33, Andres Freund wrote:
>
> Hi,
>
> On 2022-11-04 09:25:52 +0100, Drouvot, Bertrand wrote:
> > Please find attached a rebase in v7.
>
> cfbot complains that the docs don't build:
> https://cirrus-ci.com/task/6694349031866368?logs=docs_build#L296
>
> [03:24:27.317]
On Wed, 18 Jan 2023 at 23:57, Joe Conway wrote:
>
> The following review has been posted through the commitfest application:
> make installcheck-world: not tested
> Implements feature: not tested
> Spec compliant: not tested
> Documentation:not tested
>
> This needs
On Mon, 16 Jan 2023 at 20:07, vignesh C wrote:
>
> On Fri, 4 Nov 2022 at 04:59, Ian Lawrence Barwick wrote:
> >
> > 2022年7月13日(水) 19:13 Przemysław Sztoch :
> > >
> > > Dear Michael P.,
> > >
> > > 3. The matter is not that simple. When
On Wed, 11 Jan 2023 at 22:17, vignesh C wrote:
>
> On Tue, 8 Nov 2022 at 02:16, Fabien COELHO wrote:
> >
> >
> > Hello Ian,
> >
> > > cfbot reports the patch no longer applies. As CommitFest 2022-11 is
> > > currently underway, thi
On Mon, 30 Jan 2023 at 17:30, vignesh C wrote:
>
> On Mon, 30 Jan 2023 at 13:00, houzj.f...@fujitsu.com
> wrote:
> >
> > On Monday, January 30, 2023 2:32 PM Amit Kapila
> > wrote:
> > >
> > > On Mon, Jan 30, 2023 at 9:20 AM vignesh C wrote:
>
On Mon, 30 Jan 2023 at 13:00, houzj.f...@fujitsu.com
wrote:
>
> On Monday, January 30, 2023 2:32 PM Amit Kapila
> wrote:
> >
> > On Mon, Jan 30, 2023 at 9:20 AM vignesh C wrote:
> > >
> > > On Sat, 28 Jan 2023 at 11:26, Amit Kapila wrote:
> &g
On Mon, 30 Jan 2023 at 13:00, houzj.f...@fujitsu.com
wrote:
>
> On Monday, January 30, 2023 2:32 PM Amit Kapila
> wrote:
> >
> > On Mon, Jan 30, 2023 at 9:20 AM vignesh C wrote:
> > >
> > > On Sat, 28 Jan 2023 at 11:26, Amit Kapila wrote:
> &g
On Mon, 30 Jan 2023 at 13:00, houzj.f...@fujitsu.com
wrote:
>
> On Monday, January 30, 2023 2:32 PM Amit Kapila
> wrote:
> >
> > On Mon, Jan 30, 2023 at 9:20 AM vignesh C wrote:
> > >
> > > On Sat, 28 Jan 2023 at 11:26, Amit Kapila wrote:
> &g
On Fri, 27 Jan 2023 at 17:46, Amit Kapila wrote:
>
> On Fri, Jan 27, 2023 at 3:45 PM vignesh C wrote:
> >
> > On Mon, 23 Jan 2023 at 10:52, Amit Kapila wrote:
> > >
> > > IIRC, this is done to prevent concurrent drops of origin drop say by
> > >
On Sat, 28 Jan 2023 at 11:26, Amit Kapila wrote:
>
> On Sat, Jan 28, 2023 at 9:36 AM houzj.f...@fujitsu.com
> wrote:
> >
> > On Friday, January 27, 2023 8:16 PM Amit Kapila
> > >
> > > On Fri, Jan 27, 2023 at 3:45 PM vignesh C wrote:
> > > >
On Sun, 22 Jan 2023 at 22:00, vignesh C wrote:
>
> On Sun, 15 Jan 2023 at 23:02, vignesh C wrote:
> >
> > On Sun, 8 Jan 2023 at 21:00, vignesh C wrote:
> > >
> > > On Tue, 3 Jan 2023 at 13:13, vignesh C wrote:
> > > >
> > > > Hi All,
On Sun, 25 Sept 2022 at 05:29, Dmitry Dolgov <9erthali...@gmail.com> wrote:
>
> > On Sat, Sep 24, 2022 at 04:07:14PM +0200, Dmitry Dolgov wrote:
> > > On Fri, Sep 16, 2022 at 09:25:13PM +0300, Sergei Kornilov wrote:
> > > Hello!
> > >
> > > Unfortunately the patch needs another rebase due to the
On Mon, 16 Jan 2023 at 04:49, Tomas Vondra
wrote:
>
> cfbot didn't like the rebased / split patch, and after looking at it I
> believe it's a bug in parallel apply of large transactions (216a784829),
> which seems to have changed interpretation of in_remote_transaction and
>
On Tue, 1 Nov 2022 at 16:40, Thomas Munro wrote:
>
> On Fri, Oct 28, 2022 at 4:56 PM Thomas Munro wrote:
> > See attached sketch patches. I guess the main thing that may not be
> > good enough is the use of a fixed sized latch buffer. Memory
> > allocation in don't-throw-here environments like
On Tue, 17 Jan 2023 at 19:01, Amit Langote wrote:
>
> On Wed, Dec 28, 2022 at 4:28 PM Amit Langote wrote:
> >
> > Hi,
> >
> > Rebased the SQL/JSON patches over the latest HEAD. I've decided to
> > keep the same division of code into individual commits as that
> > mentioned in the revert commit
On Thu, 26 Jan 2023 at 19:53, Melih Mutlu wrote:
>
> Hi Shveta,
>
> Thanks for reviewing.
>
> shveta malik , 25 Oca 2023 Çar, 16:02 tarihinde şunu
> yazdı:
>>
>> On Mon, Jan 23, 2023 at 6:30 PM Melih Mutlu wrote:
>> --I see initial data copied, but new catalog columns srrelslotname
>> and
Regards,
Vignesh
From 83aa8b6a0c7b4de42c1bf7aa6cfd863830a86c76 Mon Sep 17 00:00:00 2001
From: Vignesh C
Date: Fri, 27 Jan 2023 15:17:09 +0530
Subject: [PATCH] Lock the replication origin record instead of locking the
pg_replication_origin relation.
Lock the replication origin record instead of locking the
pg_replication_orig
On Sun, 15 Jan 2023 at 23:02, vignesh C wrote:
>
> On Sun, 8 Jan 2023 at 21:00, vignesh C wrote:
> >
> > On Tue, 3 Jan 2023 at 13:13, vignesh C wrote:
> > >
> > > Hi All,
> > >
> > > Just a reminder that Commitfest 2023-01 has started.
>
On Wed, 16 Nov 2022 at 15:35, vignesh C wrote:
>
> On Wed, 16 Nov 2022 at 09:34, Ian Lawrence Barwick wrote:
> >
> > 2022年11月7日(月) 22:39 vignesh C :
> > >
> > > On Fri, 4 Nov 2022 at 08:19, Ian Lawrence Barwick
> > > wrote:
> > > >
>
On Thu, 19 Jan 2023 at 18:29, Amit Kapila wrote:
>
> On Thu, Jan 19, 2023 at 4:25 PM vignesh C wrote:
> >
> > On Thu, 19 Jan 2023 at 12:06, Takamichi Osumi (Fujitsu)
> > wrote:
> > >
> > > Updated the comment and the function call.
> > >
On Sat, 7 Jan 2023 at 10:37, Nathan Bossart wrote:
>
> rebased for cfbot
The patch does not apply on top of HEAD as in [1], please post a rebased patch:
=== Applying patches on top of PostgreSQL commit ID
d540a02a724b9643205abce8c5644a0f0908f6e3 ===
=== applying patch
On Tue, 3 Jan 2023 at 19:49, Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 12/10/22 10:54 AM, Drouvot, Bertrand wrote:
> > Hi,
> >
> > On 12/7/22 11:11 AM, Drouvot, Bertrand wrote:
> >> Hi,
> >>
> >>> Hi,
> >>>
> >>> As [1] mentioned above has been committed (83a1a1b566), please find
> >>> attached V5
On Wed, 3 Aug 2022 at 09:04, David Rowley wrote:
>
> On Wed, 3 Aug 2022 at 07:04, Jacob Champion wrote:
> > This entry has been waiting on author input for a while (our current
> > threshold is roughly two weeks), so I've marked it Returned with
> > Feedback.
>
> Thanks for taking care of this.
On Sat, 14 Jan 2023 at 15:47, Dmitry Koval wrote:
>
> Hi!
>
> >The patch does not apply on top of HEAD ...
>
> Here is a fixed version.
> Small additional fixes:
> 1) added CRC calculation for empty 'pg_control_log' file;
> 2) added saving 'errno' before calling LWLockRelease and restoring after
On Fri, 6 Jan 2023 at 00:19, Reid Thompson
wrote:
>
> On Tue, 2023-01-03 at 16:22 +0530, vignesh C wrote:
> >
> > The patch does not apply on top of HEAD as in [1], please post a
> > rebased patch:
> > ...
> > Regards,
> > Vignesh
> >
>
>
On Wed, 18 Jan 2023 at 03:30, Melanie Plageman
wrote:
>
> v49 attached
>
> On Tue, Jan 17, 2023 at 2:12 PM Andres Freund wrote:
> > On 2023-01-17 12:22:14 -0500, Melanie Plageman wrote:
> >
> > > > > +typedef struct PgStat_BackendIO
> > > > > +{
> > > > > + PgStat_Counter
> > > > >
On Fri, 6 Jan 2023 at 11:20, vignesh C wrote:
>
> On Tue, 3 Jan 2023 at 16:01, vignesh C wrote:
> >
> > On Tue, 29 Nov 2022 at 00:57, Daniel Gustafsson wrote:
> > >
> > > > On 28 Nov 2022, at 20:02, Nikolay Shaplov wrote:
> > >
> > > >
On Thu, 19 Jan 2023 at 12:06, Takamichi Osumi (Fujitsu)
wrote:
>
> Updated the comment and the function call.
>
> Kindly have a look at the updated patch v17.
Thanks for the updated patch, few comments:
1) min_apply_delay was accepting values like '600 m s h', I was not
sure if we should allow
On Tue, 29 Nov 2022 at 20:24, Nazir Bilal Yavuz wrote:
>
> Hi,
>
> Thanks for the patch!
>
>
> On 10/29/22 12:54, Marina Polyakova wrote:
> >
> > 1) The ECPG tests fail because they use the SQL_ASCII encoding [2],
> > the database template0 uses the ICU locale provider and SQL_ASCII is
> > not
On Wed, 16 Nov 2022 at 10:18, Ian Lawrence Barwick wrote:
>
> 2022年9月3日(土) 17:28 Dong Wook Lee :
> >
> > Hi hackers,
> > I write a tiny patch about vacuumlo to improve test coverage.
> > I hope my work is meaningful.
>
> Hi
>
> While reviewing the patch backlog, we have determined that this patch
On Fri, 25 Nov 2022 at 18:08, Peter Eisentraut
wrote:
>
> On 23.08.22 03:38, Dong Wook Lee wrote:
> > I made a small patch for xml2 to improve test coverage.
> > However, there was a problem using the functions below.
> >
> > - xpath_number
> > - xpath_bool
> > - xpath_nodeset
> > - xpath_list
>
On Wed, 12 Oct 2022 at 10:48, Michael Paquier wrote:
>
> On Fri, Sep 09, 2022 at 06:37:07PM +0200, Alvaro Herrera wrote:
> > Would it work to use get_object_address() instead? That would save
> > having to write a lookup-and-lock function with a retry loop for each
> > object type.
>
> Jeite,
On Fri, 4 Nov 2022 at 04:59, Ian Lawrence Barwick wrote:
>
> 2022年7月13日(水) 19:13 Przemysław Sztoch :
> >
> > Dear Michael P.,
> >
> > 3. The matter is not that simple. When I change priorities (ie
> > Latin-ASCII.xml is less important than Unicode decomposition),
> > then "U + 33D7" changes not
On Mon, 12 Dec 2022 at 22:06, Frédéric Yhuel wrote:
>
>
>
> On 12/11/22 06:29, Ian Lawrence Barwick wrote:
> > 2022年7月26日(火) 20:58 Frédéric Yhuel :
> >>
> >>
> >>
> >> On 4/14/22 14:25, Frédéric Yhuel wrote:
> >>>
> >>>
> >>> On 3/19/22 01:57, Imseih (AWS), Sami wrote:
> I looked at your
On Thu, 3 Nov 2022 at 15:06, Ian Lawrence Barwick wrote:
>
> 2022年9月30日(金) 1:04 Matthias van de Meent :
> >
> > On Wed, 28 Sept 2022 at 19:40, Bruce Momjian wrote:
> > >
> > > On Thu, Sep 22, 2022 at 11:12:32PM +0200, Matthias van de Meent wrote:
> > > > On Thu, 8 Sept 2022 at 23:24, Tom Lane
401 - 500 of 1500 matches
Mail list logo
