On Sun, 15 Jan 2023 at 09:39, Ajin Cherian wrote:
>
> On Fri, Jan 13, 2023 at 5:33 PM vignesh C wrote:
> > Adding support for CREATE/ALTER/DROP Publication ddl deparsing.
> > The attached v61 patch has the changes for the same.
> >
>
> Hi Vignesh,
> this does
On Sun, 8 Jan 2023 at 21:00, vignesh C wrote:
>
> On Tue, 3 Jan 2023 at 13:13, vignesh C wrote:
> >
> > Hi All,
> >
> > Just a reminder that Commitfest 2023-01 has started.
> > There are many patches based on the latest run from [1] which require
> > a)
On Sun, 15 Jan 2023 at 06:02, Robert Haas wrote:
>
> On Sat, Jan 14, 2023 at 2:26 AM vignesh C wrote:
> > I'm not sure if any work is left here, if there is nothing more to do,
> > can we close this?
>
> There's a discussion on another thread about some follow-up
>
On Tue, 10 Jan 2023 at 23:16, Robert Haas wrote:
>
> On Thu, Jan 5, 2023 at 2:53 PM Robert Haas wrote:
> > On Tue, Jan 3, 2023 at 3:11 PM Robert Haas wrote:
> > > Committed and back-patched 0001 with fixes for the issues that you
> > > pointed out.
> > >
> > > Here's a trivial rebase of the
On Sat, 31 Dec 2022 at 02:32, Tom Lane wrote:
>
> I wrote:
> > Richard Guo writes:
> >> While we are here, I wonder if we can do the same trick for
> >> distinctClause, to cope with cases like
> >> select distinct a.x, b.y from a, b where a.x = b.y;
>
> > We do that already, no?
>
> Oh, wait, I
On Wed, 4 Jan 2023 at 17:32, David Geier wrote:
>
> I fixed the compilation error on CFBot.
> I missed adding instr_time.c to the Meson makefile.
> New patch set attached.
The patch does not apply on top of HEAD as in [1], please post a rebased patch:
=== Applying patches on top of PostgreSQL
On Sun, 8 Jan 2023 at 01:40, Nikita Malakhov wrote:
>
> Hi!
>
> Thank you for your attention.
> I've rebased the patchset onto the latest master (from 07.01), but the second
> part is still
> in pre-patch shape - it is working, but tests are failing due to changes in
> TOAST relations
> logic -
On Mon, 5 Dec 2022 at 13:42, Dmitry Koval wrote:
>
> Hi!
>
> >I think storing this in pg_control is a bad idea. That file is
> >extremely critical and if you break it, you're pretty much SOL on
> >recovering your data. I suggest that this should use a separate file.
>
> Thanks. Operation log
On Thu, 12 Jan 2023 at 21:09, Takamichi Osumi (Fujitsu)
wrote:
>
> On Thursday, January 12, 2023 12:04 PM Kyotaro Horiguchi
> wrote:
> > At Wed, 11 Jan 2023 12:46:24 +, "Hayato Kuroda (Fujitsu)"
> > wrote in
> > > them. Which version is better?
> >
> >
> > Some comments by a quick loock,
On Thu, 12 Jan 2023 at 05:22, Michael Paquier wrote:
>
> On Wed, Jan 11, 2023 at 10:29:25PM +0530, vignesh C wrote:
> > I too felt keeping it simpler is better. How about using the simple
> > first version of patch itself?
>
> Okay, I have just done that, then, after chec
On Wed, 11 Jan 2023 at 12:19, Michael Paquier wrote:
>
> On Wed, Jan 11, 2023 at 12:10:33PM +0900, Kyotaro Horiguchi wrote:
> > It suggests the *kinds* of objects that are part of the extension, but
> > lists the objects of that kind regardless of dependency. I read
> > Michael suggested (and I
On Fri, 9 Dec 2022 at 16:01, Christoph Heiss wrote:
>
> Thanks for the review!
>
> On 12/8/22 12:19, Melih Mutlu wrote:
> > Hi Christoph,
> >
> > I just took a quick look at your patch.
> > Some suggestions:
> >
> > + else if (Matches("ALTER", "VIEW", MatchAny, "SET", "("))
> > +
On Tue, 8 Nov 2022 at 02:16, Fabien COELHO wrote:
>
>
> Hello Ian,
>
> > cfbot reports the patch no longer applies. As CommitFest 2022-11 is
> > currently underway, this would be an excellent time to update the patch.
>
> Attached a v5 which is just a rebase.
The patch does not apply on top of
On Sat, 31 Dec 2022 at 19:47, Peter Eisentraut
wrote:
>
> On 21.12.22 06:46, Peter Eisentraut wrote:
> > And another update. The main changes are that I added an 'unspecified'
> > CMK algorithm, which indicates that the external KMS knows what it is
> > but the database system doesn't. This was
On Tue, 29 Nov 2022 at 18:16, Daniel Gustafsson wrote:
>
> > On 3 Nov 2022, at 21:47, Daniel Gustafsson wrote:
>
> > The patch adds a new GUC, ignore_event_trigger with two option values, 'all'
> > and 'none' (the login event patch had 'login' as well).
>
> The attached v2 fixes a small bug
On Thu, 22 Dec 2022 at 11:11, Jeff Davis wrote:
>
> On Sat, 2022-12-17 at 19:14 -0800, Jeff Davis wrote:
> > Attached is a new patch series. I think there are enough changes that
> > this has become more of a "rework" of the collation code rather than
> > just a refactoring. This is a
On Wed, 11 Jan 2023 at 16:14, Melih Mutlu wrote:
>
> Hi,
>
> Thanks for your review.
>
> shiy.f...@fujitsu.com , 11 Oca 2023 Çar, 11:56
> tarihinde şunu yazdı:
>>
>> On Mon, Nov 14, 2022 8:08 PM Melih Mutlu wrote:
>> 1.
>> +# Binary enabled subscription should fail
>>
On Tue, 10 Jan 2023 at 02:41, Melanie Plageman
wrote:
>
> Attached is v45 of the patchset. I've done some additional code cleanup
> and changes. The most significant change, however, is the docs. I've
> separated the docs into its own patch for ease of review.
>
> The docs patch here was edited
On Tue, 10 Jan 2023 at 19:41, Takamichi Osumi (Fujitsu)
wrote:
>
> On Tuesday, January 3, 2023 4:01 PM vignesh C wrote:
> Hi, thanks for your review !
>
> Please have a look at the updated patch.
Thanks for the updated patch, few comments:
1) Comment inconsistency across c
On Tue, 10 Jan 2023 at 00:06, Corey Huinker wrote:
>
> On Mon, Jan 9, 2023 at 10:01 AM Maxim Orlov wrote:
>>
>> Hi!
>>
>> In overall, I think we move in the right direction. But we could make code
>> better, should we?
>>
>> + /* Capture exit code for SHELL_EXIT_CODE */
>> +
On Thu, 5 Jan 2023 at 20:45, Peter Eisentraut
wrote:
>
> Patch needed a rebase; no functionality changes.
The patch does not apply on top of HEAD as in [1], please post a rebased patch:
=== Applying patches on top of PostgreSQL commit ID
d952373a987bad331c0e499463159dd142ced1ef ===
=== applying
On Mon, 9 Jan 2023 at 08:01, vignesh C wrote:
>
> On Wed, 4 Jan 2023 at 04:13, Karl O. Pinc wrote:
> >
> > On Tue, 3 Jan 2023 21:35:09 +0100
> > Brar Piening wrote:
> >
> > > On 02.01.2023 at 21:53, Karl O. Pinc wrote:
> > > > If the auth
On Wed, 4 Jan 2023 at 04:13, Karl O. Pinc wrote:
>
> On Tue, 3 Jan 2023 21:35:09 +0100
> Brar Piening wrote:
>
> > On 02.01.2023 at 21:53, Karl O. Pinc wrote:
> > > If the author will look over my version of the patch I believe it
> > > can be approved and sent on to the committers.
> >
> >
On Tue, 3 Jan 2023 at 13:13, vignesh C wrote:
>
> Hi All,
>
> Just a reminder that Commitfest 2023-01 has started.
> There are many patches based on the latest run from [1] which require
> a) Rebased on top of head b) Fix compilation failures c) Fix test
> failure, please h
On Sun, 11 Dec 2022 at 09:21, Anton A. Melnikov wrote:
>
>
> On 07.12.2022 21:03, Andres Freund wrote:
>
> >
> > This CF entry causes tests to fail on all platforms:
> > https://cirrus-ci.com/build/5755408111894528
> >
> > E.g.
> >
On Fri, 6 Jan 2023 at 15:33, Dean Rasheed wrote:
>
> On Fri, 6 Jan 2023 at 02:38, vignesh C wrote:
> >
> > On Thu, 5 Jan 2023 at 18:22, Dean Rasheed wrote:
> > >
> > > That leads to the attached, which barring objections, I'll push shortly.
> >
>
On Thu, 22 Dec 2022 at 23:11, Eric Radman wrote:
>
> On Thu, Dec 22, 2022 at 10:08:17AM +, Dag Lem wrote:
> >
> > The calculation of quotient and remainder can be replaced by less costly
> > masking and shifting.
> >
> > Defining
> >
> > #define OCT_DIGIT_BITS 3
> > #define OCT_DIGIT_BITMASK
On Fri, 9 Dec 2022 at 16:01, Christoph Heiss wrote:
>
> Thanks for the review!
>
> On 12/8/22 12:19, Melih Mutlu wrote:
> > Hi Christoph,
> >
> > I just took a quick look at your patch.
> > Some suggestions:
> >
> > + else if (Matches("ALTER", "VIEW", MatchAny, "SET", "("))
> > +
On Fri, 4 Nov 2022 at 03:36, David Christensen
wrote:
>
> > Unless somebody in the community remembers open questions/issues with
> > TDE that were never addressed I suggest simply iterating with our
> > usual testing/reviewing process. For now I'm going to change the
> > status of the CF entry
On Sat, 29 Oct 2022 at 08:24, Andres Freund wrote:
>
> The patches here aren't fully polished (as will be evident). But they should
> be more than good enough to discuss whether this is a sane direction.
The patch does not apply on top of HEAD as in [1], please post a rebased patch:
=== Applying
On Sun, 13 Nov 2022 at 04:15, Tom Lane wrote:
>
> Andy Fan writes:
> > In the past we pull-up the ANY-sublink with 2 steps, the first step is to
> > pull up the sublink as a subquery, and the next step is to pull up the
> > subquery if it is allowed. The benefits of this method are obvious,
> >
On Wed, 7 Dec 2022 at 13:27, Michael Paquier wrote:
>
> Hi all,
>
> This thread is a follow-up of the recent discussion about query
> jumbling with DDL statements, where the conclusion was that we'd want
> to generate all this code automatically for all the nodes:
>
On Mon, 26 Dec 2022 at 14:04, Amit Kapila wrote:
>
> On Sat, Dec 24, 2022 at 3:28 PM Dilip Kumar wrote:
> >
> > On Sat, Dec 24, 2022 at 8:56 AM Amit Kapila wrote:
> > >
> > > > >
> > > > > OK, I removed the modification in 022_twophase_cascade.pl and combine
> > > > > the two patches.
> > > >
On Thu, 5 Jan 2023 at 18:52, Bharath Rupireddy
wrote:
>
> On Wed, Jan 4, 2023 at 8:19 PM Drouvot, Bertrand
> wrote:
> >
> > I think it makes sense to somehow align the pg_walinspect functions with
> > the pg_waldump "features".
> > And since [1] added FPI "extraction" then +1 for the proposed
On Wed, 4 Jan 2023 at 00:27, Garen Torikian wrote:
>
> Sure. Rebased onto HEAD.
>
There is one more merge conflict, please post a rebased patch:
=== Applying patches on top of PostgreSQL commit ID
eb5ad4ff05fd382ac98cab60b82f7fd6ce4cfeb8 ===
=== applying patch
On Tue, 3 Jan 2023 at 16:01, vignesh C wrote:
>
> On Tue, 29 Nov 2022 at 00:57, Daniel Gustafsson wrote:
> >
> > > On 28 Nov 2022, at 20:02, Nikolay Shaplov wrote:
> >
> > > From my reviewer's point of view patch is ready for commit.
> > >
> &g
On Fri, 6 Jan 2023 at 04:32, Tom Lane wrote:
>
> vignesh C writes:
> > On Thu, 5 Jan 2023 at 03:17, Tom Lane wrote:
> >> The bigger picture here though is that in examples such as the one
> >> you gave at the top of the thread, it's not very clear to me that
On Thu, 5 Jan 2023 at 18:22, Dean Rasheed wrote:
>
> On Tue, 6 Dec 2022 at 19:12, vignesh C wrote:
> >
> > On Tue, 6 Dec 2022 at 20:42, Melih Mutlu wrote:
> > >
> > > Also one little suggestion:
> > >
> > >> + if (ends_with(prev_wd, ')
On Thu, 5 Jan 2023 at 03:17, Tom Lane wrote:
>
> vignesh C writes:
> > [ v3-0001-Fix-for-invalidating-logical-replication-relation.patch ]
>
> (btw, please don't send multiple patch versions with the same number,
> it's very confusing.)
Since it was just rebasing
On Tue, 1 Nov 2022 at 15:54, Etsuro Fujita wrote:
>
> Hi David,
>
> On Sat, Oct 1, 2022 at 5:54 AM David Zhang wrote:
> > After rebase the file `postgres_fdw.out` and applied to master branch,
> > make and make check are all ok for postgres_fdw.
>
> Thanks for testing! Attached is a rebased
On Fri, 21 Oct 2022 at 11:31, Michael Paquier wrote:
>
> On Thu, Sep 29, 2022 at 09:23:38PM -0400, Tom Lane wrote:
> > Hmmm ... I'd tend to do SELECT COUNT(*) FROM. But can't we provide
> > any actual checks on the sanity of the output? I realize that the
> > output's far from static, but still
On Fri, 2 Dec 2022 at 18:08, Andrew Dunstan wrote:
>
>
> On 2022-12-01 Th 21:10, Andres Freund wrote:
> > Hi,
> >
> > On 2022-12-01 20:56:18 -0500, Tom Lane wrote:
> >> Andres Freund writes:
> >>> On 2022-12-01 20:30:36 -0500, Tom Lane wrote:
> If we remove that, won't we have a whole lot
On Tue, 25 Oct 2022 at 09:42, Thomas Munro wrote:
>
> I pushed the bug fixes from this series, without their accompanying
> tests. Here's a rebase of the test suite, with all those tests now
> squashed into the main test patch, and also the
> tell-Windows-to-be-more-like-Unix patch. Registered
On Fri, 9 Dec 2022 at 12:20, Amit Langote wrote:
>
> On Fri, Dec 9, 2022 at 3:07 PM Amit Langote wrote:
> > On Thu, Dec 8, 2022 at 6:12 PM Alvaro Herrera
> > wrote:
> > > On 2022-Dec-07, Amit Langote wrote:
> > > > However, this
> > > > approach of not storing the placeholder in the stored
On Tue, 3 Jan 2023 at 14:08, David Geier wrote:
>
> Hi Lukas,
>
> On 1/2/23 20:50, Lukas Fittl wrote:
> > Thanks for continuing to work on this patch, and my apologies for
> > silence on the patch.
>
> It would be great if you could review it.
> Please also share your thoughts around exposing the
On Thu, 17 Nov 2022 at 16:34, Antonin Houska wrote:
>
> Tomas Vondra wrote:
>
> > Hi,
> >
> > I did a quick initial review of the v20 patch series. I plan to do a
> > more thorough review over the next couple days, if time permits. In
> > general I think the patch is in pretty good shape.
>
>
On Wed, 23 Nov 2022 at 03:28, David Rowley wrote:
>
> On Thu, 3 Nov 2022 at 06:25, Andres Freund wrote:
> > Attached is an experimental patch/hack for that. It ended up being more
> > beneficial to make the access ordering more optimal than prefetching the
> > tuple
> > contents, but I'm not at
On Tue, 27 Dec 2022 at 02:32, Nikita Malakhov wrote:
>
> Hi hackers!
>
> Pluggable TOAST API with catalog control table PG_TOASTREL - pre-patch.
>
> Pluggable TOAST - TOAST API rework - introduce PG_TOASTREL catalog
> relation containing TOAST dependencies. NOTE: here is a pre-patch,
On Tue, 27 Sept 2022 at 08:26, James Coleman wrote:
>
> On Mon, Mar 21, 2022 at 8:48 PM Andres Freund wrote:
> >
> > Hi,
> >
> > On 2022-01-22 20:25:19 -0500, James Coleman wrote:
> > > On the other hand this is a dramatically simpler patch series.
> > > Assuming the approach is sound, it should
On Fri, 1 Jul 2022 at 16:49, Alexander Korotkov wrote:
>
> Hackers,
>
> When working in the read committed transaction isolation mode
> (default), we have the following sequence of actions when
> tuple_update() or tuple_delete() find concurrently updated tuple.
>
> 1.
On Mon, 2 Jan 2023 at 13:47, Peter Eisentraut
wrote:
>
> On 08.12.22 03:30, Peter Smith wrote:
> > PSA patches for v9*
> >
> > v9-0001 - Now the table rows are ordered per PeterE's suggestions [1]
>
> committed
>
> > v9-0002 - All the review comments from DavidJ [2] are addressed
>
> I'm not sure
On Tue, 3 Jan 2023 at 22:01, Jacob Champion wrote:
>
> On Tue, Jan 3, 2023 at 4:14 AM vignesh C wrote:
> > The patch does not apply on top of HEAD as in [1], please post a rebased
> > patch:
>
> Hi Vignesh -- this is a patch for the CF app, not the Postgres repo,
On Fri, 2 Dec 2022 at 19:06, Ranier Vilela wrote:
>
> Hi, thanks for reviewing this.
>
> Em sex., 2 de dez. de 2022 às 09:24, John Naylor
> escreveu:
>>
>>
>> On Thu, Dec 1, 2022 at 8:02 PM Ranier Vilela wrote:
>> >
>> > Hi,
>> >
>> > I believe that has room for improving generation node
On Sun, 20 Nov 2022 at 11:42, Nikolay Shaplov wrote:
>
> В письме от воскресенье, 6 ноября 2022 г. 19:22:09 MSK пользователь Nikolay
> Shaplov написал:
>
> > > > > cfbot reports the patch no longer applies. As CommitFest 2022-11 is
> > > > > currently underway, this would be an excellent time to
On Thu, 8 Dec 2022 at 08:17, Amit Langote wrote:
>
> On Wed, Dec 7, 2022 at 8:54 PM Amit Langote wrote:
> > Per Alvaro's advice, forking this from [1].
> >
> > In that thread, Tom had asked if it wouldn't be better to find a new
> > place to put extraUpdatedCols [2] instead of RangeTblEntry,
On Fri, 16 Dec 2022 at 04:47, Bagga, Rishu wrote:
> Rebased and updated a new patch addressing the critical section issue in
> RecordNewMultliXact.In GetNewMultiXactId, we now make our ReadBuffer
> calls before starting the critical section, but while holding the
> MultiXactGenLock, so we always
On Fri, 19 Aug 2022 at 21:18, wrote:
>
> Andrey Borodin wrote 2022-08-18 06:35:
> >
> > I like the idea of one knob instead of one per each SLRU. Maybe we
> > even could deduce sane value from NBuffers? That would effectively
> > lead to 0 knobs :)
> >
> > Your patch have a prefix "v22-0006",
On Wed, 21 Sept 2022 at 10:55, Fujii Masao wrote:
>
>
>
> On 2022/09/21 0:51, Alvaro Herrera wrote:
> > The rules starting at line 4111 make me a bit nervous, since nowhere
> > we're restricting them to operating only on MERGE lines. I don't think
> > it's a real problem since USING is not
On Thu, 6 Oct 2022 at 03:35, Garen Torikian wrote:
>
> After digging into it, you are completely correct. I had to do a bit more
> reading to understand the relationships between UTF-8 and wchar, but
> ultimately the existing locale support works for my use case.
>
> Therefore I have updated
On Wed, 9 Nov 2022 at 06:34, Justin Pryzby wrote:
>
> On Thu, Oct 20, 2022 at 10:40:40PM -0500, Justin Pryzby wrote:
> > On Thu, Aug 04, 2022 at 04:16:06PM +1200, Thomas Munro wrote:
> > > On Thu, Aug 4, 2022 at 3:38 PM Justin Pryzby wrote:
> > > > [train wreck]
> > >
> > > Oh my, so I'm getting
On Fri, 30 Dec 2022 at 09:29, Thomas Munro wrote:
>
> On Wed, Nov 23, 2022 at 11:57 AM Justin Pryzby wrote:
> > [PATCH 02/10] cirrus/macos: switch to "macos_instance" / M1..
>
> Duelling patches.
>
> Bilal's patch[1] uses the matrix feature to run the tests on both
> Intel and ARM, which made
On Wed, 26 Oct 2022 at 04:25, Jacob Champion wrote:
>
> On Mon, Aug 8, 2022 at 8:45 AM Andres Freund wrote:
> > On 2022-08-08 08:37:41 -0700, Jacob Champion wrote:
> > > Agreed. This probably bleeds over into the other documentation thread
> > > a bit -- how do we want to communicate the subtle
On Tue, 20 Dec 2022 at 04:27, Corey Huinker wrote:
>
>
> Attached is my work in progress to implement the changes to the CAST()
> function as proposed by Vik Fearing.
>
> This work builds upon the Error-safe User Functions work currently ongoing.
>
> The proposed changes are as follows:
>
>
On Thu, 8 Dec 2022 at 19:44, Reid Thompson
wrote:
>
> On Sun, 2022-11-27 at 09:40 -0600, Justin Pryzby wrote:
> > > BTW, these should have some kind of prefix, like PG_ALLOC_* to
> > > avoid causing the same kind of problem for someone else that
> > > another header caused for you by defining
On Fri, 9 Dec 2022 at 20:41, Reid Thompson
wrote:
>
> On Tue, 2022-12-06 at 10:32 -0800, Andres Freund wrote:
> > Hi,
> >
> > On 2022-11-26 22:22:15 -0500, Reid Thompson wrote:
> > > rebased/patched to current master && current pg-stat-activity-
> > > backend-memory-allocated
> >
> > This version
On Mon, 2 Jan 2023 at 10:04, Imseih (AWS), Sami wrote:
>
> >cfbot is complaining that this patch no longer applies. Sami, would you
> >mind rebasing it?
>
> Rebased patch attached.
CFBot shows some compilation errors as in [1], please post an updated
version for the same:
[07:01:58.889]
On Tue, 4 Oct 2022 at 10:20, Ken Kato wrote:
>
> > The problem is that you're not closing the
>
> Thank you for the reviews and comments.
> I closed the so that the problem should be fixed now.
The patch does not apply on top of HEAD as in [1], please post a rebased patch:
=== Applying patches
On Tue, 20 Dec 2022 at 07:22, Hayato Kuroda (Fujitsu)
wrote:
>
> Dear hackers,
>
> PSA rebased patches.
The patch does not apply on top of HEAD as in [1], please post a rebased patch:
=== Applying patches on top of PostgreSQL commit ID
92957ed98c5c565362ce665266132a7f08f6b0c0 ===
=== applying
On Wed, 21 Dec 2022 at 11:04, Corey Huinker wrote:
>
> I've rebased and updated the patch to include documentation.
>
> Regression tests have been moved to a separate patchfile because error
> messages will vary by OS and configuration, so we probably can't do a stable
> regression test, but
On Wed, 28 Dec 2022 at 16:17, Peter Eisentraut
wrote:
>
> Most callers of BufFileRead() want to check whether they read the full
> specified length. Checking this at every call site is very tedious.
> This patch provides additional variants BufFileReadExact() and
> BufFileReadMaybeEOF() that
On Tue, 29 Nov 2022 at 00:57, Daniel Gustafsson wrote:
>
> > On 28 Nov 2022, at 20:02, Nikolay Shaplov wrote:
>
> > From my reviewer's point of view patch is ready for commit.
> >
> > Thank you for your patience :-)
>
> Thanks for review.
>
> The attached tweaks a few comments and attempts to
Hi All,
Just a reminder that Commitfest 2023-01 has started.
There are many patches based on the latest run from [1] which require
a) Rebased on top of head b) Fix compilation failures c) Fix test
failure, please have a look and rebase it so that it is easy for the
reviewers and committers:
1.
On Tue, 27 Dec 2022 at 14:59, Hayato Kuroda (Fujitsu)
wrote:
> Note that more than half of the modifications are done by Osumi-san.
1) This global variable can be removed as it is used only in
send_feedback which is called from maybe_delay_apply so we could pass
it as a function argument:
+ *
On Tue, 3 Jan 2023 at 07:52, Michael Paquier wrote:
>
> On Wed, Dec 28, 2022 at 10:52:38AM +0530, vignesh C wrote:
> > If no one has volunteered for the upcoming (January 2023) commitfest.
> > I would like to volunteer for it.
>
> If you want to be up to the task, that w
On Wed, 7 Dec 2022 at 17:50, Alvaro Herrera wrote:
>
> I think this patch is split badly.
>
> You have:
>
> 0001 an enormous patch including some required infrastructure, plus the
> DDL deparsing bits themselves.
>
> 0002 another enormous (though not as much) patch, this time for
> DDL
;ALTER", "EXTENSION", MatchAny, "ADD|DROP",
> "FOREIGN"))
> + COMPLETE_WITH("DATA WRAPPER", "TABLE");
>
> The DROP could be matched with the objects that are actually part of
> the so-said exten
Hi All,
If no one has volunteered for the upcoming (January 2023) commitfest.
I would like to volunteer for it.
Regards,
Vignesh
On Wed, 7 Dec 2022 at 17:50, Alvaro Herrera wrote:
>
> I think this patch is split badly.
>
> You have:
>
> 0001 an enormous patch including some required infrastructure, plus the
> DDL deparsing bits themselves.
>
> 0002 another enormous (though not as much) patch, this time for
> DDL
Hi,
The Commitfest 2022-11 status still shows as "In Progress", Shouldn't
the status be changed to "Closed" and the entries be moved to the next
commitfest.
Regards,
Vignesh
On Wed, 16 Nov 2022 at 18:30, Ian Lawrence Barwick wrote:
>
> 2022年11月14日(月) 22:38 Ian Lawrence Barwick :
> >
> >
than one
place.
The attached v4 patch is rebased on top of HEAD.
Regards,
Vignesh
From c1436c498d1d939384999ecb508d5da3403abc90 Mon Sep 17 00:00:00 2001
From: Vignesh C
Date: Wed, 7 Dec 2022 00:27:37 +0530
Subject: [PATCH v4] Tab completion for ALTER FUNCTION/PROCEDURE/
On Tue, 29 Nov 2022 at 17:51, li jie wrote:
>
> I will continue to give feedback for this patch.
Thanks a lot, that will be very helpful for us.
> 1. LIKE STORAGE
> ```
> CREATE TABLE ctlt (a text, c text);
> ALTER TABLE ctlt ALTER COLUMN c SET STORAGE EXTERNAL;
> CREATE TABLE ctlt_storage
Hi,
While reviewing/testing one of the patches I found the following Assert:
#0 __pthread_kill_implementation (no_tid=0, signo=6,
threadid=139624429171648) at ./nptl/pthread_kill.c:44
#1 __pthread_kill_internal (signo=6, threadid=139624429171648) at
./nptl/pthread_kill.c:78
#2
Hi,
While reviewing/testing one of the patches I found the following Assert:
#0 0x55c6312ba639 in pgstat_unlink_relation (rel=0x7fb73bcbac58)
at pgstat_relation.c:161
#1 0x55c6312bbb5a in pgstat_relation_delete_pending_cb
(entry_ref=0x55c6335563a8) at pgstat_relation.c:839
#2
Hi,
Tab completion for ALTER EXTENSION ADD and DROP was missing, this
patch adds the tab completion for the same.
Regards,
Vignesh
From 35e9e8bd22ae8767baa95a04c41ee8f68a9c5338 Mon Sep 17 00:00:00 2001
From: Vignesh C
Date: Sat, 26 Nov 2022 20:18:58 +0530
Subject: [PATCH v1] Missing tab
On Fri, 25 Nov 2022 at 11:47, vignesh C wrote:
>
> On Sun, 20 Nov 2022 at 09:29, vignesh C wrote:
> >
> > On Fri, 11 Nov 2022 at 11:03, Peter Smith wrote:
> > >
> > > On Fri, Nov 11, 2022 at 4:17 PM Peter Smith wrote:
> > > >
> > > >
On Sun, 20 Nov 2022 at 09:29, vignesh C wrote:
>
> On Fri, 11 Nov 2022 at 11:03, Peter Smith wrote:
> >
> > On Fri, Nov 11, 2022 at 4:17 PM Peter Smith wrote:
> > >
> > > On Fri, Nov 11, 2022 at 4:09 PM Peter Smith wrote:
> > > >
>
On Mon, 14 Nov 2022 at 12:14, Amit Kapila wrote:
>
> Hi,
>
> The thread title doesn't really convey the topic under discussion, so
> changed it. IIRC, this has been mentioned by others as well in the
> thread.
>
> On Sat, Nov 12, 2022 at 7:21 PM vignesh C wrote:
> &
On Tue, 22 Nov 2022 at 05:59, Michael Paquier wrote:
>
> On Fri, Oct 28, 2022 at 05:34:37PM +0530, vignesh C wrote:
> > Those also should be handled, attached v2 version includes the changes
> > for the same.
>
> The basic options supported by PROCEDURE are a subset of ROU
On Thu, 17 Nov 2022 at 17:48, Daniel Gustafsson wrote:
>
> > On 17 Nov 2022, at 10:56, vignesh C wrote:
>
> > When I was reviewing one of the patches, I found a typo in the
> > comments of SH_LOOKUP and SH_LOOKUP_HASH. I felt "lookup up" should
> >
Hi,
When I was reviewing one of the patches, I found a typo in the
comments of SH_LOOKUP and SH_LOOKUP_HASH. I felt "lookup up" should
have been "lookup".
Attached a patch to modify it.
Regards,
Vignesh
From 03feb3121dbd9a78547a15cf5998e44ffb65626e Mon Sep 17 00:00:00 2001
F
On Wed, 16 Nov 2022 at 14:28, wangw.f...@fujitsu.com
wrote:
>
> On Mon, Nov 14, 2022 at 0:56 AM vignesh C wrote:
> > >
> > > Attach new patches.
> >
>
> Thanks for your comments.
>
> > Here we are having tables list to store the relids and table_infos
On Tue, 15 Nov 2022 at 11:17, Peter Smith wrote:
>
> On Sun, Nov 13, 2022 at 11:47 AM vignesh C wrote:
> >
> > On Mon, 24 Oct 2022 at 13:15, Peter Smith wrote:
> > >
> > > Hi hackers.
> > >
> > > There is a docs Logical Replication
On Wed, 16 Nov 2022 at 09:34, Ian Lawrence Barwick wrote:
>
> 2022年11月7日(月) 22:39 vignesh C :
> >
> > On Fri, 4 Nov 2022 at 08:19, Ian Lawrence Barwick wrote:
> > >
> > > Hi
> > >
> > > cfbot reports the patch no longer applies [1]. As Comm
On Fri, 11 Nov 2022 at 11:13, wangw.f...@fujitsu.com
wrote:
>
> On Fri, Oct 21, 2022 at 17:02 PM Peter Smith wrote:
> >
>
> Thanks for your comments. Sorry for not replying in time.
>
> > On Mon, Oct 17, 2022 at 4:49 PM wangw.f...@fujitsu.com
> > wrote:
> > >
> > > On Wed, Oct 5, 2022 at
On Mon, 24 Oct 2022 at 13:15, Peter Smith wrote:
>
> Hi hackers.
>
> There is a docs Logical Replication section "31.10 Configuration
> Settings" [1] which describes some logical replication GUCs, and
> details on how they interact with each other and how to take that into
> account when setting
On Thu, 11 Aug 2022 at 02:03, Euler Taveira wrote:
>
> On Wed, Aug 10, 2022, at 9:39 AM, osumi.takami...@fujitsu.com wrote:
>
> Minor review comments for v6.
>
> Thanks for your review. I'm attaching v7.
>
> "If the subscriber sets min_apply_delay parameter, ..."
>
> I suggest we use subscription
n updated patch which is rebased on top of HEAD.
Regards,
Vignesh
From 22d17bd8eeb2c35870b80cbc41c23e89e2c8f981 Mon Sep 17 00:00:00 2001
From: Vignesh C
Date: Sun, 6 Nov 2022 06:34:44 +0530
Subject: [PATCH v9 1/2] Add RESET clause to Alter Publication which will reset
the publication with defaul
On Wed, 2 Nov 2022 at 05:13, vignesh C wrote:
>
> On Mon, 31 Oct 2022 at 16:17, vignesh C wrote:
> >
> > On Thu, 27 Oct 2022 at 16:02, vignesh C wrote:
> > >
> > > On Thu, 27 Oct 2022 at 02:09, Zheng Li wrote:
> > > >
> > > > > Add
On Mon, 31 Oct 2022 at 16:17, vignesh C wrote:
>
> On Thu, 27 Oct 2022 at 16:02, vignesh C wrote:
> >
> > On Thu, 27 Oct 2022 at 02:09, Zheng Li wrote:
> > >
> > > > Adding support for deparsing of CREATE/ALTER/DROP LANGUAGE for ddl
> > > > re
On Thu, 27 Oct 2022 at 16:02, vignesh C wrote:
>
> On Thu, 27 Oct 2022 at 02:09, Zheng Li wrote:
> >
> > > Adding support for deparsing of CREATE/ALTER/DROP LANGUAGE for ddl
> > > replication.
> >
> > Adding support for deparsing of:
> > COMM
501 - 600 of 1500 matches
Mail list logo
