Re: [HACKERS] Allow INSTEAD OF DELETE triggers to modify the tuple for RETURNING

2024-03-15 Thread Aleksander Alekseev
Hi, > it took me a while to figure out why the doc build fails. > > [...] > > Anyway, based on your patch, I modified it, also added a slightly more > complicated test. Thank you for keeping the patch up-to-date. Unfortunately, it seems to be needing another rebase, according to cfbot. Best

Re: [HACKERS] Allow INSTEAD OF DELETE triggers to modify the tuple for RETURNING

2024-01-15 Thread jian he
On Tue, Jan 9, 2024 at 6:21 PM vignesh C wrote: > > > doc seems to still have an issue. > > https://cirrus-ci.com/github/postgresql-cfbot/postgresql/commitfest%2F45%2F4617 > > > > In the regress test, do we need to clean up the created object after we use it. > > tested passed, looking at

Re: [HACKERS] Allow INSTEAD OF DELETE triggers to modify the tuple for RETURNING

2024-01-09 Thread vignesh C
On Thu, 16 Nov 2023 at 05:30, jian he wrote: > > On Fri, Nov 3, 2023 at 12:34 AM Marko Tiikkaja wrote: > > > > I am now. Thanks! :-) Will try to keep an eye on the builds in the future. > > > > Attached v4 of the patch which should fix the issue. > > > > doc seems to still have an issue. >

Re: [HACKERS] Allow INSTEAD OF DELETE triggers to modify the tuple for RETURNING

2023-11-15 Thread jian he
On Fri, Nov 3, 2023 at 12:34 AM Marko Tiikkaja wrote: > > I am now. Thanks! :-) Will try to keep an eye on the builds in the future. > > Attached v4 of the patch which should fix the issue. > doc seems to still have an issue.

Re: [HACKERS] Allow INSTEAD OF DELETE triggers to modify the tuple for RETURNING

2023-11-02 Thread Marko Tiikkaja
On Thu, Nov 2, 2023 at 12:24 PM Shlok Kyal wrote: > I went through the CFbot and found that docs build run is giving some > error (link: https://cirrus-ci.com/task/5712582359646208): > > Just wanted to make sure you are aware of the issue. I am now. Thanks! :-) Will try to keep an eye on the

Re: [HACKERS] Allow INSTEAD OF DELETE triggers to modify the tuple for RETURNING

2023-11-02 Thread Shlok Kyal
Hi, On Thu, 19 Oct 2023 at 16:35, Marko Tiikkaja wrote: > > Hi, > > Thank you for the feedback. > > Apparently it took me six years, but I've attached the latest version > of the patch which I believe addresses all issues. I'll add it to the > open commitfest. > > > .m I went through the CFbot

Re: [HACKERS] Allow INSTEAD OF DELETE triggers to modify the tuple for RETURNING

2023-10-19 Thread Marko Tiikkaja
Hi, Thank you for the feedback. Apparently it took me six years, but I've attached the latest version of the patch which I believe addresses all issues. I'll add it to the open commitfest. .m instead_of_delete_returning_v3.patch Description: Binary data