On Mon, Jan 9, 2023 at 7:29 PM Xing Guo wrote:
>
> Thank you John. This is my first patch, I'll keep it in mind that
> adding a version number next time I sending the patch.
Welcome to the community! You may also consider reviewing a patch from the
current commitfest, since we can always use
On 1/9/23, John Naylor wrote:
> On Thu, Jan 5, 2023 at 8:18 AM John Naylor
> wrote:
>>
>> The label TSS_BUILDRUNS has a similar style and also the following
> comment, so I will push this patch with a similar comment added unless
> someone wants to make a case for doing otherwise.
>>
>> * Note
On Thu, Jan 5, 2023 at 8:18 AM John Naylor
wrote:
>
> The label TSS_BUILDRUNS has a similar style and also the following
comment, so I will push this patch with a similar comment added unless
someone wants to make a case for doing otherwise.
>
> * Note that mergeruns sets the correct
On Fri, Sep 16, 2022 at 1:43 PM Richard Guo wrote:
>
>
> On Wed, Jul 27, 2022 at 5:10 PM Xing Guo wrote:
>>
>> The bounded heap sorting status flag is set twice in sort_bounded_heap()
and tuplesort_performsort(). This patch helps remove one of them.
>
>
> Revisiting this patch I think maybe it's
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: not tested
Spec compliant: not tested
Documentation:not tested
Removing "state->status = TSS_SORTEDINMEM" should be fine as it is
Hi Richard,
Sorry for not responding for a long time, I missed the previous email
by accident :-)
I attached a newer patch based on your suggestions and created an
entry in cf manager.
https://commitfest.postgresql.org/40/3924/
Best Regards,
Xing Guo
On 9/16/22, Richard Guo wrote:
> On Wed,
On Wed, Jul 27, 2022 at 5:10 PM Xing Guo wrote:
> The bounded heap sorting status flag is set twice in sort_bounded_heap()
> and tuplesort_performsort(). This patch helps remove one of them.
>
Revisiting this patch I think maybe it's better to remove the setting of
Tuplesort status from
On Wed, Jul 27, 2022 at 5:10 PM Xing Guo wrote:
> The bounded heap sorting status flag is set twice in sort_bounded_heap()
> and tuplesort_performsort(). This patch helps remove one of them.
>
+1. Looks good to me.
Thanks
Richard
Hi hackers,
The bounded heap sorting status flag is set twice in sort_bounded_heap()
and tuplesort_performsort(). This patch helps remove one of them.
Best Regards,
Xing
diff --git a/src/backend/utils/sort/tuplesort.c b/src/backend/utils/sort/tuplesort.c
index d90a1aebdf..84dc0d07f9 100644
---
