Re: [PATCH] postgresql.conf.sample comment alignment.

2023-10-31 Thread Peter Smith
On Tue, Oct 31, 2023 at 11:51 PM Bruce Momjian wrote: > ... > Patch applied to master. Perhaps someday we will adjust tabs, but for > now, this is an improvements. I made a few small adjustments myself. > I had long forgotten this old patch. Thanks for resurrecting it and pushing! == Kind

Re: [PATCH] postgresql.conf.sample comment alignment.

2023-10-31 Thread Bruce Momjian
On Thu, Aug 4, 2022 at 12:42:38PM +1000, Peter Smith wrote: > On Thu, Aug 4, 2022 at 11:09 AM Michael Paquier wrote: > > > > On Wed, Aug 03, 2022 at 12:58:04PM +0200, Alvaro Herrera wrote: > > > On 2022-Aug-01, Tom Lane wrote: > > >> One idea for avoiding confusion is to legislate that we won't

Re: [PATCH] postgresql.conf.sample comment alignment.

2022-08-03 Thread Peter Smith
On Thu, Aug 4, 2022 at 11:09 AM Michael Paquier wrote: > > On Wed, Aug 03, 2022 at 12:58:04PM +0200, Alvaro Herrera wrote: > > On 2022-Aug-01, Tom Lane wrote: > >> One idea for avoiding confusion is to legislate that we won't > >> use tabs at all in this file (which we could enforce via > >>

Re: [PATCH] postgresql.conf.sample comment alignment.

2022-08-03 Thread Julien Rouhaud
On Thu, Aug 04, 2022 at 10:09:27AM +0900, Michael Paquier wrote: > On Wed, Aug 03, 2022 at 12:58:04PM +0200, Alvaro Herrera wrote: > > On 2022-Aug-01, Tom Lane wrote: > >> One idea for avoiding confusion is to legislate that we won't > >> use tabs at all in this file (which we could enforce via >

Re: [PATCH] postgresql.conf.sample comment alignment.

2022-08-03 Thread Michael Paquier
On Wed, Aug 03, 2022 at 12:58:04PM +0200, Alvaro Herrera wrote: > On 2022-Aug-01, Tom Lane wrote: >> One idea for avoiding confusion is to legislate that we won't >> use tabs at all in this file (which we could enforce via >> .gitattributes, I think). > > +1. That's not the first time this 4- or

Re: [PATCH] postgresql.conf.sample comment alignment.

2022-08-03 Thread Alvaro Herrera
On 2022-Aug-01, Tom Lane wrote: > One idea for avoiding confusion is to legislate that we won't > use tabs at all in this file (which we could enforce via > .gitattributes, I think). +1. > But that might just be making things equally inconvenient for > everybody. In this situation, the only

Re: [PATCH] postgresql.conf.sample comment alignment.

2022-08-01 Thread Peter Smith
On Tue, Aug 2, 2022 at 10:03 AM Tom Lane wrote: > > Peter Smith writes: > > This patch tweaks a some tabbing and replaces some spaces with tabs to > > improve slightly the comment alignment in file > > 'postgresql.conf.sample' > > Hmm ... the parts you want to change generally look OK to me. > I

Re: [PATCH] postgresql.conf.sample comment alignment.

2022-08-01 Thread Tom Lane
Peter Smith writes: > This patch tweaks a some tabbing and replaces some spaces with tabs to > improve slightly the comment alignment in file > 'postgresql.conf.sample' Hmm ... the parts you want to change generally look OK to me. I wonder if you are looking at it with tab stops set to 4 spaces

[PATCH] postgresql.conf.sample comment alignment.

2022-08-01 Thread Peter Smith
This patch tweaks a some tabbing and replaces some spaces with tabs to improve slightly the comment alignment in file 'postgresql.conf.sample' PSA. -- Kind Regards, Peter Smith. Fujitsu Australia v1-0001-Align-the-comments.patch Description: Binary data