Re: [meson] add missing pg_attribute_aligned for MSVC in meson build

2022-10-15 Thread Andres Freund
Hi, On 2022-10-15 12:02:14 -0700, Andres Freund wrote: > See the attached patch fixing those omissions. I'll push it to HEAD once it > has the CI stamp of approval. Done. Thanks for the report!

Re: [meson] add missing pg_attribute_aligned for MSVC in meson build

2022-10-15 Thread Andres Freund
Hi, On 2022-10-14 10:59:28 +0800, Junwang Zhao wrote: > Commit ec3c9cc add pg_attribute_aligned in MSVC[1], > which was pushed one day before the meson commits, > so meson build missed this feature. Good catch. It shouldn't have practical consequences for the moment, given that msvc doesn't suppo

Re: [meson] add missing pg_attribute_aligned for MSVC in meson build

2022-10-13 Thread Michael Paquier
On Fri, Oct 14, 2022 at 10:59:28AM +0800, Junwang Zhao wrote: > Commit ec3c9cc add pg_attribute_aligned in MSVC[1], > which was pushed one day before the meson commits, > so meson build missed this feature. > > [1]: > https://www.postgresql.org/message-id/caaaqye-hbtzvr3msomtk+hyw2s0e0oapzmw8icsm

[meson] add missing pg_attribute_aligned for MSVC in meson build

2022-10-13 Thread Junwang Zhao
Hi Andres, Commit ec3c9cc add pg_attribute_aligned in MSVC[1], which was pushed one day before the meson commits, so meson build missed this feature. [1]: https://www.postgresql.org/message-id/caaaqye-hbtzvr3msomtk+hyw2s0e0oapzmw8icsmytma+mn...@mail.gmail.com -- Regards Junwang Zhao 0001-mes