Re: Add support for __attribute__((returns_nonnull))

2024-01-08 Thread Michael Paquier
On Mon, Jan 08, 2024 at 05:04:58PM -0600, Tristan Partin wrote: > The idea I had in mind initially was PGLC_localeconv(), but I couldn't > prove that anything changed with the annotation added. The second patch > in my previous email was attempt at deriving real-world benefit, but > nothing I did

Re: Add support for __attribute__((returns_nonnull))

2024-01-08 Thread Tristan Partin
On Sun Dec 31, 2023 at 9:29 PM CST, John Naylor wrote: On Thu, Dec 28, 2023 at 1:20 AM Tristan Partin wrote: > I recently wound up in a situation where I was checking for NULL return > values of a function that couldn't ever return NULL because the > inability to allocate memory was always

Re: Add support for __attribute__((returns_nonnull))

2023-12-31 Thread John Naylor
On Thu, Dec 28, 2023 at 1:20 AM Tristan Partin wrote: > I recently wound up in a situation where I was checking for NULL return > values of a function that couldn't ever return NULL because the > inability to allocate memory was always elog(ERROR)ed (aborted). It sounds like you have a ready

Re: Add support for __attribute__((returns_nonnull))

2023-12-27 Thread Tristan Partin
match reality. -- Tristan Partin Neon (https://neon.tech) From fe4916093d0ce036e7b70595b39351b4ecf93798 Mon Sep 17 00:00:00 2001 From: Tristan Partin Date: Tue, 19 Dec 2023 14:39:03 -0600 Subject: [PATCH v2 1/2] Add support for __attribute__((returns_nonnull)) Allows for marking functions that can't

Re: Add support for __attribute__((returns_nonnull))

2023-12-27 Thread Peter Eisentraut
On 19.12.23 21:43, Tristan Partin wrote: Here is a patch which adds support for the returns_nonnull attribute alongside all the other attributes we optionally support. I recently wound up in a situation where I was checking for NULL return values of a function that couldn't ever return NULL

Add support for __attribute__((returns_nonnull))

2023-12-19 Thread Tristan Partin
: Tue, 19 Dec 2023 14:39:03 -0600 Subject: [PATCH v1] Add support for __attribute__((returns_nonnull)) Allows for marking functions that can't possibly return NULL, like those that always elog(ERROR) for instance in the case of failures. --- src/include/c.h | 12 1 file changed, 12