Re: Add test module for Custom WAL Resource Manager feature

2022-11-15 Thread Jeff Davis
On Wed, 2022-11-16 at 10:27 +0900, Michael Paquier wrote: > On Wed, Nov 16, 2022 at 10:26:32AM +0900, Michael Paquier wrote: > > Not many buildfarm members test 32b builds, but lapwing does. > > Well, it didn't take long: >

Re: Add test module for Custom WAL Resource Manager feature

2022-11-15 Thread Michael Paquier
On Wed, Nov 16, 2022 at 10:26:32AM +0900, Michael Paquier wrote: > Not many buildfarm members test 32b builds, but lapwing does. Well, it didn't take long: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=lapwing=2022-11-16%2000%3A40%3A11 -- Michael signature.asc Description: PGP

Re: Add test module for Custom WAL Resource Manager feature

2022-11-15 Thread Michael Paquier
On Tue, Nov 15, 2022 at 04:29:08PM -0800, Jeff Davis wrote: > Committed with some significant revisions (ae168c794f): > > * changed to insert a deterministic message, rather than a random > one, which allows more complete testing > * fixed a couple bugs > * used a static initializer for the

Re: Add test module for Custom WAL Resource Manager feature

2022-11-15 Thread Jeff Davis
On Mon, 2022-11-14 at 09:34 +0530, Bharath Rupireddy wrote: > Thanks. I would like to keep it simple. > > I've added some more comments and attached v2 patch herewith. Please > review. Committed with some significant revisions (ae168c794f): * changed to insert a deterministic message, rather

Re: Add test module for Custom WAL Resource Manager feature

2022-11-13 Thread Bharath Rupireddy
On Sat, Nov 12, 2022 at 4:40 AM Jeff Davis wrote: > > On Fri, 2022-11-11 at 17:01 +0530, Bharath Rupireddy wrote: > > Hi, > > > > Inspired by recent commits 9fcdf2c, e813e0e and many small test > > modules/extensions under src/test/modules, I would like to propose > > one > > such test module for

Re: Add test module for Custom WAL Resource Manager feature

2022-11-11 Thread Jeff Davis
On Fri, 2022-11-11 at 17:01 +0530, Bharath Rupireddy wrote: > Hi, > > Inspired by recent commits 9fcdf2c, e813e0e and many small test > modules/extensions under src/test/modules, I would like to propose > one > such test module for Custom WAL Resource Manager feature introduced > by > commit

Add test module for Custom WAL Resource Manager feature

2022-11-11 Thread Bharath Rupireddy
Hi, Inspired by recent commits 9fcdf2c, e813e0e and many small test modules/extensions under src/test/modules, I would like to propose one such test module for Custom WAL Resource Manager feature introduced by commit 5c279a6. It not only covers the code a bit, but it also demonstrates usage of