Re: Allow +group in pg_ident.conf

2023-03-01 Thread Michael Paquier
On Wed, Mar 01, 2023 at 02:26:21PM -0500, Gregory Stark (as CFM) wrote: > So I'll set it to "Waiting on Author" pending that new patchset... There is still an entry as of https://commitfest.postgresql.org/42/4112/. Support for group detection in pg_ident.conf has been added in efb6f4a already, so

Re: Allow +group in pg_ident.conf

2023-03-01 Thread Gregory Stark (as CFM)
On Wed, 11 Jan 2023 at 04:00, Jelte Fennema wrote: > > I'm working on a new patchset for my commitfest entry. So I'll set it to "Waiting on Author" pending that new patchset... -- Gregory Stark As Commitfest Manager

Re: Allow +group in pg_ident.conf

2023-01-11 Thread Jelte Fennema
I'm working on a new patchset for my commitfest entry. I'll make sure to include a third patch for the +group support, and I'll include you (Andrew) in the thread when I send it. On Wed, 11 Jan 2023 at 02:14, Michael Paquier wrote: > > On Tue, Jan 10, 2023 at 09:42:19AM -0500, Andrew Dunstan

Re: Allow +group in pg_ident.conf

2023-01-10 Thread Michael Paquier
On Tue, Jan 10, 2023 at 09:42:19AM -0500, Andrew Dunstan wrote: > Ok, that sounds reasonable, but the cfbot doesn't like patches that > depend on other patches in a different email. Maybe you can roll this up > as an extra patch in your next version? It's pretty small. This can go two ways if

Re: Allow +group in pg_ident.conf

2023-01-10 Thread Andrew Dunstan
On 2023-01-10 Tu 07:09, Jelte Fennema wrote: > Having looked closer now, I'm pretty sure you should base this patch > on top of my patch: https://commitfest.postgresql.org/41/4081/ > Mainly because you also need the token version of pg_role, which is > one of the things my patch adds. Ok, that

Re: Allow +group in pg_ident.conf

2023-01-10 Thread Jelte Fennema
Having looked closer now, I'm pretty sure you should base this patch on top of my patch: https://commitfest.postgresql.org/41/4081/ Mainly because you also need the token version of pg_role, which is one of the things my patch adds. > if (regexp_pgrole[0] == '+') For these lines you'll need to

Re: Allow +group in pg_ident.conf

2023-01-09 Thread Michael Paquier
On Mon, Jan 09, 2023 at 05:33:14PM -0500, Andrew Dunstan wrote: > I've adapted a sentence from the pg_hba.conf documentation so we stay > consistent. + + If the database-username begins with a + + character, then the operating system user can login as + any user belonging to that role,

Re: Allow +group in pg_ident.conf

2023-01-09 Thread Jelte Fennema
This seems very much related to my patch here: https://commitfest.postgresql.org/41/4081/ (yes, somehow the thread got split. I blame outlook) I'll try to review this one soonish.

Re: Allow +group in pg_ident.conf

2023-01-09 Thread Andrew Dunstan
On 2023-01-09 Mo 13:24, Nathan Bossart wrote: > On Mon, Jan 09, 2023 at 08:00:26AM -0500, Andrew Dunstan wrote: >> + If the database-username begins with a >> + + character, then the operating system user can login >> as >> + any user belonging to that role, similarly to how user names

Re: Allow +group in pg_ident.conf

2023-01-09 Thread Nathan Bossart
On Mon, Jan 09, 2023 at 08:00:26AM -0500, Andrew Dunstan wrote: > + If the database-username begins with a > + + character, then the operating system user can login > as > + any user belonging to that role, similarly to how user names beginning > with > + + are treated in pg_hba.conf. I

Allow +group in pg_ident.conf

2023-01-09 Thread Andrew Dunstan
Over at [1] I speculated that it might be a good idea to allow +grouprole type user names in pg_ident.conf. The use case I have in mind is where the user authenticates to pgbouncer and then pgbouncer connects as the user using a client certificate. Without this mechanism that means that you need a