Re: Allow pageinspect's bt_page_stats function to return a set of rows instead of a single row

Hamid Akhtar writes: > I wasn't aware of the meson.build file. Attached is the latest version of > the patch that contains the updated meson.build. Pushed with minor corrections, plus one major one: you missed the point of aeaaf520f, that pageinspect functions that touch relations need to be

Re: Allow pageinspect's bt_page_stats function to return a set of rows instead of a single row

The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation:not tested Looks good to me The new status of this patch is: Ready for

Re: Allow pageinspect's bt_page_stats function to return a set of rows instead of a single row

On Wed, 7 Dec 2022 at 13:01, Alvaro Herrera wrote: > On 2022-Dec-06, Andres Freund wrote: > > > Hi, > > > > On 2022-11-25 02:45:01 +0500, Hamid Akhtar wrote: > > > Rebasing the patch to the tip of the master branch. > > > > This doesn't pass tests on cfbot. Looks like possibly some files are >

Re: Allow pageinspect's bt_page_stats function to return a set of rows instead of a single row

On 2022-Dec-06, Andres Freund wrote: > Hi, > > On 2022-11-25 02:45:01 +0500, Hamid Akhtar wrote: > > Rebasing the patch to the tip of the master branch. > > This doesn't pass tests on cfbot. Looks like possibly some files are missing? The .sql file is there all right, but meson.build is not

Re: Allow pageinspect's bt_page_stats function to return a set of rows instead of a single row

Hi, On 2022-11-25 02:45:01 +0500, Hamid Akhtar wrote: > Rebasing the patch to the tip of the master branch. This doesn't pass tests on cfbot. Looks like possibly some files are missing?

Re: Allow pageinspect's bt_page_stats function to return a set of rows instead of a single row

On Mon, 21 Nov 2022 at 17:34, Naeem Akhter wrote: > The following review has been posted through the commitfest application: > make installcheck-world: tested, passed > Implements feature: tested, passed > Spec compliant: not tested > Documentation:not tested > >

Re: Allow pageinspect's bt_page_stats function to return a set of rows instead of a single row

The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: not tested Documentation:not tested i've tested and verified the documentation.

Re: Allow pageinspect's bt_page_stats function to return a set of rows instead of a single row

On Wed, 12 Oct 2022 at 10:51, Michael Paquier wrote: > On Mon, Sep 12, 2022 at 03:18:59PM -0400, Tom Lane wrote: > > I spun up a 32-bit VM, since that had been on my to-do list anyway, > > and it looks like I was right: > > This feedback has not been addressed and the thread is idle four >

Re: Allow pageinspect's bt_page_stats function to return a set of rows instead of a single row

On Mon, Sep 12, 2022 at 03:18:59PM -0400, Tom Lane wrote: > I spun up a 32-bit VM, since that had been on my to-do list anyway, > and it looks like I was right: This feedback has not been addressed and the thread is idle four weeks, so I have marked this CF entry as RwF. Please feel free to

Re: Allow pageinspect's bt_page_stats function to return a set of rows instead of a single row

I wrote: > 3. I think it's highly likely that the new test case is not portable. > In particular a machine with MAXALIGN 4 would be likely to put a > different number of tuples per page, or do the page split differently > so that the page with fewer index tuples isn't page 3. Unfortunately > I

Re: Allow pageinspect's bt_page_stats function to return a set of rows instead of a single row

Hamid Akhtar writes: > Attached is the rebased version of the patch > (pageinspect_btree_multipagestats_03.patch) for the master branch. I looked through this and cleaned up the code a little (attached). There are still some issues before it could be considered committable: 1. Where's the

Re: Allow pageinspect's bt_page_stats function to return a set of rows instead of a single row

On Tue, 6 Sept 2022 at 11:25, Ibrar Ahmed wrote: > > > On Mon, Aug 1, 2022 at 11:29 PM Naeem Akhter > wrote: > >> The following review has been posted through the commitfest application: >> make installcheck-world: tested, passed >> Implements feature: tested, passed >> Spec compliant:

Re: Allow pageinspect's bt_page_stats function to return a set of rows instead of a single row

On Mon, Aug 1, 2022 at 11:29 PM Naeem Akhter wrote: > The following review has been posted through the commitfest application: > make installcheck-world: tested, passed > Implements feature: tested, passed > Spec compliant: not tested > Documentation:not tested > >

Re: Allow pageinspect's bt_page_stats function to return a set of rows instead of a single row

The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: not tested Documentation:not tested Looks good to me. The new status of this patch is: Ready for

Re: Allow pageinspect's bt_page_stats function to return a set of rows instead of a single row

On Sun, 31 Jul 2022 at 18:00, Hamid Akhtar wrote: > > > On Thu, 28 Jul 2022 at 00:36, Tom Lane wrote: > >> Hamid Akhtar writes: >> > That attached patch is based on the master branch. It makes the >> following >> > changes to the pageinspect contrib module: >> > - Updates

Re: Allow pageinspect's bt_page_stats function to return a set of rows instead of a single row

On Thu, 28 Jul 2022 at 00:36, Tom Lane wrote: > Hamid Akhtar writes: > > That attached patch is based on the master branch. It makes the following > > changes to the pageinspect contrib module: > > - Updates bt_page_stats_internal function to accept 3 arguments instead > of > > 2. > > - The

Re: Allow pageinspect's bt_page_stats function to return a set of rows instead of a single row

Hamid Akhtar writes: > That attached patch is based on the master branch. It makes the following > changes to the pageinspect contrib module: > - Updates bt_page_stats_internal function to accept 3 arguments instead of > 2. > - The function now uses SRF macros to return a set rather than a single

Re: Allow pageinspect's bt_page_stats function to return a set of rows instead of a single row

On Fri, 1 Jul 2022 at 13:01, Drouvot, Bertrand wrote: > Hi, > On 6/30/22 10:24 AM, Hamid Akhtar wrote: > > On Mon, 27 Jun 2022 at 15:52, Bharath Rupireddy < > bharath.rupireddyforpostg...@gmail.com> wrote: > >> On Mon, Jun 27, 2022 at 1:40 PM Drouvot, Bertrand >> wrote: >> > >> > Hi, >> > >> >

Re: Allow pageinspect's bt_page_stats function to return a set of rows instead of a single row

On Thu, 30 Jun 2022 at 14:27, Bharath Rupireddy < bharath.rupireddyforpostg...@gmail.com> wrote: > On Thu, Jun 30, 2022 at 1:54 PM Hamid Akhtar > wrote: > > > >> Do we have any > >> difference in the execution times for the above query vs the new > >> function introduced in the v1 patch? If

Re: Allow pageinspect's bt_page_stats function to return a set of rows instead of a single row

On Thu, Jun 30, 2022 at 1:54 PM Hamid Akhtar wrote: > >> Do we have any >> difference in the execution times for the above query vs the new >> function introduced in the v1 patch? If there's not much difference, I >> would suggest adding an SQL function around the generate_series >> approach in

Re: Allow pageinspect's bt_page_stats function to return a set of rows instead of a single row

On Mon, 27 Jun 2022 at 15:52, Bharath Rupireddy < bharath.rupireddyforpostg...@gmail.com> wrote: > On Mon, Jun 27, 2022 at 1:40 PM Drouvot, Bertrand > wrote: > > > > Hi, > > > > On 6/27/22 9:31 AM, Hamid Akhtar wrote: > > > > > > Hello Hackers, > > > > While working on one of my blogs on the

Re: Allow pageinspect's bt_page_stats function to return a set of rows instead of a single row

On Mon, Jun 27, 2022 at 1:40 PM Drouvot, Bertrand wrote: > > Hi, > > On 6/27/22 9:31 AM, Hamid Akhtar wrote: > > > Hello Hackers, > > While working on one of my blogs on the B-Tree indexes, I needed to look at a > range of B-Tree page statistics. So the goto solution was to use pageinspect. >

Allow pageinspect's bt_page_stats function to return a set of rows instead of a single row

Hello Hackers, While working on one of my blogs on the B-Tree indexes , I needed to look at a range of B-Tree page statistics. So the goto solution was to use pageinspect. However, reviewing stats for