Re: pgsql: Allow tailoring of ICU locales with custom rules

2023-09-04 Thread Amit Kapila
On Tue, Aug 22, 2023 at 10:55 PM Jeff Davis wrote: > > On Mon, 2023-08-14 at 10:34 +0200, Peter Eisentraut wrote: > > I have investigated this. My assessment is that how PostgreSQL > > interfaces with ICU is correct. Whether what ICU does is correct > > might > > be debatable. I have filed a

Re: pgsql: Allow tailoring of ICU locales with custom rules

2023-08-22 Thread Jeff Davis
On Mon, 2023-08-14 at 10:34 +0200, Peter Eisentraut wrote: > I have investigated this.  My assessment is that how PostgreSQL > interfaces with ICU is correct.  Whether what ICU does is correct > might > be debatable.  I have filed a bug with ICU about this: >

Re: pgsql: Allow tailoring of ICU locales with custom rules

2023-08-14 Thread Peter Eisentraut
On 24.07.23 04:46, Amit Kapila wrote: On Fri, Mar 10, 2023 at 3:24 PM Peter Eisentraut wrote: On 08.03.23 21:57, Jeff Davis wrote: * It appears rules IS NULL behaves differently from rules=''. Is that desired? For instance: create collation c1(provider=icu,

Re: pgsql: Allow tailoring of ICU locales with custom rules

2023-07-23 Thread Amit Kapila
On Fri, Mar 10, 2023 at 3:24 PM Peter Eisentraut wrote: > > On 08.03.23 21:57, Jeff Davis wrote: > > > * It appears rules IS NULL behaves differently from rules=''. Is that > > desired? For instance: > >create collation c1(provider=icu, > > locale='und-u-ka-shifted-ks-level1', > >

Re: pgsql: Allow tailoring of ICU locales with custom rules

2023-03-10 Thread Peter Eisentraut
On 08.03.23 21:57, Jeff Davis wrote: On Wed, 2023-03-08 at 16:03 +, Peter Eisentraut wrote: Allow tailoring of ICU locales with custom rules Late review: * Should throw error when provider != icu and rules != NULL I have fixed that. * Explain what the example means. By itself, users

Re: Allow tailoring of ICU locales with custom rules

2023-03-08 Thread Peter Eisentraut
On 08.03.23 15:18, Laurenz Albe wrote: On Fri, 2023-03-03 at 13:45 +0100, Peter Eisentraut wrote: Ok, here is a version with an initdb option and also a createdb option (to expose the CREATE DATABASE option). You can mess with people by setting up your databases like this: initdb -D data

Re: Allow tailoring of ICU locales with custom rules

2023-03-08 Thread Laurenz Albe
On Fri, 2023-03-03 at 13:45 +0100, Peter Eisentraut wrote: > Ok, here is a version with an initdb option and also a createdb option > (to expose the CREATE DATABASE option). > > You can mess with people by setting up your databases like this: > > initdb -D data --locale-provider=icu

Re: Allow tailoring of ICU locales with custom rules

2023-03-08 Thread Laurenz Albe
On Tue, 2023-03-07 at 22:06 -0800, Jeff Davis wrote: > On Fri, 2023-03-03 at 13:45 +0100, Peter Eisentraut wrote: > > You can mess with people by setting up your databases like this: > > > > initdb -D data --locale-provider=icu --icu-rules=' < c < b < e < d' > > > > ;-) > > Would we be the

Re: Allow tailoring of ICU locales with custom rules

2023-03-07 Thread Jeff Davis
On Fri, 2023-03-03 at 13:45 +0100, Peter Eisentraut wrote: > You can mess with people by setting up your databases like this: > > initdb -D data --locale-provider=icu --icu-rules=' < c < b < e < d' > > ;-) Would we be the first major database to support custom collation rules? This sounds

Re: Allow tailoring of ICU locales with custom rules

2023-03-03 Thread Peter Eisentraut
: Peter Eisentraut Date: Fri, 3 Mar 2023 11:46:56 +0100 Subject: [PATCH v7] Allow tailoring of ICU locales with custom rules This exposes the ICU facility to add custom collation rules to a standard collation. Discussion: https://www.postgresql.org/message-id/flat/821c71a4-6ef0-d366-9acf-bb8e367f7.

Re: Allow tailoring of ICU locales with custom rules

2023-03-02 Thread Laurenz Albe
On Wed, 2023-02-22 at 18:35 +0100, Peter Eisentraut wrote: > > - there doesn't seem to be a way to add rules to template1. > > If someone wants to have icu rules and initial contents to their new > > databases, I think they need to create a custom template database > > (from template0) for that

Re: Allow tailoring of ICU locales with custom rules

2023-02-22 Thread Peter Eisentraut
option. Is that too many initdb options then? It would be easy to add, if we think it's worth it. From b566e8756fbf78da804f5538d68350cda7a9bab3 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Wed, 22 Feb 2023 18:33:47 +0100 Subject: [PATCH v6] Allow tailoring of ICU locales with custom

Re: Allow tailoring of ICU locales with custom rules

2023-02-20 Thread Daniel Verite
Peter Eisentraut wrote: [patch v5] Two quick comments: - pg_dump support need to be added for CREATE COLLATION / DATABASE - there doesn't seem to be a way to add rules to template1. If someone wants to have icu rules and initial contents to their new databases, I think they need to

Re: Allow tailoring of ICU locales with custom rules

2023-02-20 Thread Peter Eisentraut
09:46:48 +0100 Subject: [PATCH v5] Allow tailoring of ICU locales with custom rules This exposes the ICU facility to add custom collation rules to a standard collation. Discussion: https://www.postgresql.org/message-id/flat/821c71a4-6ef0-d366-9acf-bb8e367f7...@enterprisedb.com --- doc/src/sgml/ca

Re: Allow tailoring of ICU locales with custom rules

2023-02-14 Thread Laurenz Albe
On Mon, 2023-02-06 at 22:16 +0100, Peter Eisentraut wrote: > Right.  Here is a new patch with this fixed. Thanks. I played some more with it, and still are still some missing odds and ends: - There is a new option ICU_RULES to CREATE DATABASE, but it is not reflected in \h CREATE DATABASE.

Re: Allow tailoring of ICU locales with custom rules

2023-02-06 Thread Peter Eisentraut
atch with this fixed. From 7ca76032097397d685a313500c96a41b2c38ecc6 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Mon, 6 Feb 2023 21:58:24 +0100 Subject: [PATCH v4] Allow tailoring of ICU locales with custom rules This exposes the ICU facility to add custom collation rules to a standard coll

Re: Allow tailoring of ICU locales with custom rules

2023-02-04 Thread Laurenz Albe
On Sat, 2023-02-04 at 14:41 +0100, Daniel Verite wrote: > Laurenz Albe wrote: > > > Cool so far.  Now I created a database with that locale: > > > >  CREATE DATABASE teutsch LOCALE_PROVIDER icu ICU_LOCALE german_phone > >     LOCALE "de_AT.utf8" TEMPLATE template0; > > > > Now the rules

Re: Allow tailoring of ICU locales with custom rules

2023-02-04 Thread Daniel Verite
Laurenz Albe wrote: > Cool so far. Now I created a database with that locale: > > CREATE DATABASE teutsch LOCALE_PROVIDER icu ICU_LOCALE german_phone > LOCALE "de_AT.utf8" TEMPLATE template0; > > Now the rules are not in "pg_database": The parameter after ICU_LOCALE is passed

Re: Allow tailoring of ICU locales with custom rules

2023-01-31 Thread Laurenz Albe
On Mon, 2023-01-16 at 12:18 +0100, Peter Eisentraut wrote: > Updated patch attached. I like that patch. It applies and passes regression tests. I played with it: CREATE COLLATION german_phone (LOCALE = 'de-AT', PROVIDER = icu, RULES = ' < ö'); SELECT * FROM (VALUES ('od'), ('oe'),

Re: Allow tailoring of ICU locales with custom rules

2023-01-16 Thread Peter Eisentraut
Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Wed, 14 Dec 2022 10:15:03 +0100 Subject: [PATCH v3] Allow tailoring of ICU locales with custom rules This exposes the ICU facility to add custom collation rules to a standard collation. Discussion: https://www.postgresql.org/message-id/flat

Re: Allow tailoring of ICU locales with custom rules

2023-01-10 Thread vignesh C
On Thu, 5 Jan 2023 at 20:45, Peter Eisentraut wrote: > > Patch needed a rebase; no functionality changes. The patch does not apply on top of HEAD as in [1], please post a rebased patch: === Applying patches on top of PostgreSQL commit ID d952373a987bad331c0e499463159dd142ced1ef === === applying

Re: Allow tailoring of ICU locales with custom rules

2023-01-05 Thread Peter Eisentraut
;. The code is pretty straightforward.  It mainly just records these rules in the catalog and feeds them to ICU when creating the collator object. From ae729e2d5d37a382b713ea95897ccb35d0c1 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Wed, 14 Dec 2022 10:15:03 +0100 Subject: [P

Allow tailoring of ICU locales with custom rules

2022-12-14 Thread Peter Eisentraut
log and feeds them to ICU when creating the collator object.From b0d42407a60e116d3ccb0ed04505aa362f8a6a1d Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Wed, 14 Dec 2022 10:15:03 +0100 Subject: [PATCH] Allow tailoring of ICU locales with custom rules This exposes the ICU facility to add custom