On Thu, Jun 29, 2023 at 8:19 AM Michael Paquier wrote:
> Nothing much to add, so applied with the initial comment fix.
Thanks for pushing it!
Thanks
Richard
On Thu, 29 Jun 2023 at 08:19, Michael Paquier wrote:
> On Wed, Jun 28, 2023 at 09:26:02PM +0800, Japin Li wrote:
>> +1. LGTM.
>
> Nothing much to add, so applied with the initial comment fix.
Thanks!
--
Regrads,
Japin Li.
On Wed, Jun 28, 2023 at 09:26:02PM +0800, Japin Li wrote:
> +1. LGTM.
Nothing much to add, so applied with the initial comment fix.
--
Michael
signature.asc
Description: PGP signature
On Wed, 28 Jun 2023 at 16:27, Richard Guo wrote:
> On Wed, Jun 28, 2023 at 3:36 PM Michael Paquier wrote:
>
>> On Wed, Jun 28, 2023 at 03:09:55PM +0800, Richard Guo wrote:
>> > +1. To nitpick, how about we remove the blank line just before removing
>> > the key for top level entry?
>> >
>> >
On Wed, Jun 28, 2023 at 3:36 PM Michael Paquier wrote:
> On Wed, Jun 28, 2023 at 03:09:55PM +0800, Richard Guo wrote:
> > +1. To nitpick, how about we remove the blank line just before removing
> > the key for top level entry?
> >
> > - /* Also remove entries for top level statements */
> > +
On Wed, Jun 28, 2023 at 03:09:55PM +0800, Richard Guo wrote:
> +1. To nitpick, how about we remove the blank line just before removing
> the key for top level entry?
>
> - /* Also remove entries for top level statements */
> + /* Also remove entries if exist for top level statements */
>
On Wed, Jun 28, 2023 at 3:04 PM Michael Paquier wrote:
> On Wed, Jun 28, 2023 at 12:15:47PM +0800, Japin Li wrote:
> > - /* Remove the key if it exists, starting with the
> top-level entry */
> > + /* Remove the key if it exists, starting with the
> non-top-level entry
On Wed, Jun 28, 2023 at 12:15:47PM +0800, Japin Li wrote:
> - /* Remove the key if it exists, starting with the top-level
> entry */
> + /* Remove the key if it exists, starting with the non-top-level
> entry */
> key.toplevel = false;
> entry
On Wed, 28 Jun 2023 at 11:22, Richard Guo wrote:
> On Wed, Jun 28, 2023 at 10:53 AM Japin Li wrote:
>
>>
>> Hi, hackers
>>
>> There has $subject that introduced by commit 6b4d23feef6. When we reset
>> the entries
>> if all parameters are avaiable, non-top-level entries removed first, then
>>
On Wed, Jun 28, 2023 at 10:53 AM Japin Li wrote:
>
> Hi, hackers
>
> There has $subject that introduced by commit 6b4d23feef6. When we reset
> the entries
> if all parameters are avaiable, non-top-level entries removed first, then
> top-level
> entries.
I did not see the diffs. Maybe
Hi, hackers
There has $subject that introduced by commit 6b4d23feef6. When we reset the
entries
if all parameters are avaiable, non-top-level entries removed first, then
top-level
entries.
On branch REL_15_STABLE
Your branch is up to date with 'origin/REL_15_STABLE'.
Changes not staged for
11 matches
Mail list logo
