RE: Avoid distributing new catalog snapshot again for the transaction being decoded.

2022-11-29 Thread wangw.f...@fujitsu.com
On Sat, Nov 26, 2022 at 19:50 PM Amit Kapila wrote: > On Fri, Nov 25, 2022 at 5:30 PM Ashutosh Bapat > wrote: > > > > Hi Hou, > > Thanks for the patch. With a simple condition, we can eliminate the > > need to queueing snapshot change in the current transaction and then > > applying it. Saves

Re: Avoid distributing new catalog snapshot again for the transaction being decoded.

2022-11-26 Thread Amit Kapila
On Fri, Nov 25, 2022 at 5:30 PM Ashutosh Bapat wrote: > > Hi Hou, > Thanks for the patch. With a simple condition, we can eliminate the > need to queueing snapshot change in the current transaction and then > applying it. Saves some memory and computation. This looks useful. > > When the queue

Re: Avoid distributing new catalog snapshot again for the transaction being decoded.

2022-11-25 Thread Ashutosh Bapat
Hi Hou, Thanks for the patch. With a simple condition, we can eliminate the need to queueing snapshot change in the current transaction and then applying it. Saves some memory and computation. This looks useful. When the queue snapshot change is processed in ReorderBufferProcessTXN(), we call

Avoid distributing new catalog snapshot again for the transaction being decoded.

2022-11-25 Thread houzj.f...@fujitsu.com
Hi, When doing some other related work, I noticed that when decoding the COMMIT record via SnapBuildCommitTxn()-> SnapBuildDistributeNewCatalogSnapshot() we will add a new snapshot to all transactions including the one being decoded(just committed one). But since we've already done required