On Wed, 3 Oct 2018 at 15:58, Madeleine Thompson wrote:
> This diff looks good to me. Also, it applies cleanly against
> abd9ca377d669a6e0560e854d7e987438d0e612e and passes `make
> check-world`.
>
> I agree that this is not suitable for a patch release.
>
Pushed to master. Thanks for the review.
On Wed, Oct 3, 2018 at 9:04 AM Dean Rasheed wrote:
>
> On Thu, 27 Sep 2018 at 14:22, Dean Rasheed wrote:
> > I'll post an updated patch in a while.
> >
>
> I finally got round to looking at this again. Here is an update, based
> on the review comments.
>
> The next question is whether or not to
Dean Rasheed writes:
> The next question is whether or not to back-patch this. Although this
> was reported as a bug, my inclination is to apply this to HEAD only,
> based on the lack of prior complaints. That also matches our decision
> for other similar patches, e.g., 7d9a4737c2.
+1 for no
On Thu, 27 Sep 2018 at 14:22, Dean Rasheed wrote:
> I'll post an updated patch in a while.
>
I finally got round to looking at this again. Here is an update, based
on the review comments.
The next question is whether or not to back-patch this. Although this
was reported as a bug, my inclination
On 27 September 2018 at 06:12, Madeleine Thompson wrote:
> This is my first PostgreSQL review. Hopefully I'm getting it right. I
> independently ran into the bug in question and found that the author had
> already written a patch. I'm happy the author wrote this.
>
Thanks for the review. And
By the way, I did not see the discussion thread or notice that an author of the
paper I mentioned and the reporter of the bug were the same person until after
I wrote the review. Oops.
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: not tested
Documentation:not tested
This is my first PostgreSQL review. Hopefully I'm getting it right.
