On 22.09.23 22:01, Tristen Raab wrote:
The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: tested, passed
Spec compliant: not tested
Documentation:not tested
Hello,
I've reviewed all 4 of
The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: tested, passed
Spec compliant: not tested
Documentation:not tested
Hello,
I've reviewed all 4 of your patches, each one applies and builds
On 12.07.23 15:41, Alvaro Herrera wrote:
On 2023-Jul-12, Gurjeet Singh wrote:
The init-steps are severely under-documented in pgbench --help output.
I think at least a pointer to the the pgbench docs should be mentioned
in the pgbench --help output; an average user may not rush to read the
On 12.07.23 19:47, Gurjeet Singh wrote:
If you end up with variant 3 or 4, please use double quotes instead of
single quotes.
Will do.
I believe you're suggesting this because in the neighboring help text
the string literals use double quotes. I see that other utilities,
such as psql also
On Wed, Jul 12, 2023 at 3:08 AM Peter Eisentraut wrote:
>
> On 12.07.23 09:42, Gurjeet Singh wrote:
> > These two variants show the two extremes; bare minimum vs. everything
> > but the kitchen sink. So one may feel the need to find a middle ground
> > and provide a "sufficient, but not too much"
On 2023-Jul-12, Gurjeet Singh wrote:
> The init-steps are severely under-documented in pgbench --help output.
> I think at least a pointer to the the pgbench docs should be mentioned
> in the pgbench --help output; an average user may not rush to read the
> code to find the explanation, but a
On 12.07.23 09:42, Gurjeet Singh wrote:
These two variants show the two extremes; bare minimum vs. everything
but the kitchen sink. So one may feel the need to find a middle ground
and provide a "sufficient, but not too much" variant. I have attempted
that in variants 3 and 4; also attached.
These patches were created during an unrelated discussion about pgbench.
Please see emails [1] - [6] linked below, for the past discussion.
In brief:
> $ pgbench -i -I dtGvp -s 500
The init-steps are severely under-documented in pgbench --help output.
I think at least a pointer to the the
