On Wed, Jul 28, 2021 at 01:16:19PM -0400, Tom Lane wrote:
> I do not see any RESTART option in SQL:2021 11.72 definition>. Since we don't document it either, there's really no
> expectation that anyone would use it.
Okay, good point. I was not aware of that.
> I don't particularly think that
Fujii Masao writes:
> On 2021/07/28 23:53, Bharath Rupireddy wrote:
>> -1. IMHO, this is something creating more confusion to the user. We
>> say that we allow both START and RESTART that RESTART is accepted as a
>> consequence of our internal option handling in gram.y. Instead, I
>> recommend
On 2021/07/28 23:53, Bharath Rupireddy wrote:
On Wed, Jul 28, 2021 at 11:50 AM Michael Paquier wrote:
On Mon, Jul 26, 2021 at 04:57:53PM +0900, Michael Paquier wrote:
FWIW, like Ashutosh upthread, my vote would be to do nothing here in
terms of behavior changes as this is just breaking a
On Wed, Jul 28, 2021 at 11:50 AM Michael Paquier wrote:
>
> On Mon, Jul 26, 2021 at 04:57:53PM +0900, Michael Paquier wrote:
> > FWIW, like Ashutosh upthread, my vote would be to do nothing here in
> > terms of behavior changes as this is just breaking a behavior for the
> > sake of breaking it,
On Mon, Jul 26, 2021 at 04:57:53PM +0900, Michael Paquier wrote:
> FWIW, like Ashutosh upthread, my vote would be to do nothing here in
> terms of behavior changes as this is just breaking a behavior for the
> sake of breaking it, so there are chances that this is going to piss
> some users that
On Sat, Jul 24, 2021 at 09:56:40PM +0530, Bharath Rupireddy wrote:
> LGTM. PSA v2 patch.
FWIW, like Ashutosh upthread, my vote would be to do nothing here in
terms of behavior changes as this is just breaking a behavior for the
sake of breaking it, so there are chances that this is going to piss
e. Allowing both START and
> * RESTART option for CREATE SEQUENCE may cause confusion to user.
> * Hence, we throw error for CREATE SEQUENCE if RESTART option is
> * specified. However, it can be used with ALTER SEQUENCE.
> */
>
> I would remove the first sentence, because it
in my environment.
Regarding your comments in the patch:
/*
* Restarting a sequence while defining it doesn't make any sense
* and it may override the START value. Allowing both START and
* RESTART option for CREATE SEQUENCE may cause confusion to user.
* Hence, we throw error for CREATE SEQUENCE
On Thu, Apr 8, 2021 at 3:16 PM Suraj Kharage
wrote:
>> > The RESTART clause in the CREATE SEQUENCE doesn't make sense
>> > to me, it should be restricted, IMO.
>
> +1
>
>>
>> Thanks! Attaching a patch that throws an error if the RESTART option
>> is specified with CREATE SEQUENCE. Please have a
On Thu, Apr 8, 2021 at 2:03 PM Bharath Rupireddy <
bharath.rupireddyforpostg...@gmail.com> wrote:
>
> >
> > The RESTART clause in the CREATE SEQUENCE doesn't make sense
> > to me, it should be restricted, IMO.
>
+1
>
> Thanks! Attaching a patch that throws an error if the RESTART option
> is
ecause it may
override the START option." in err_detail along with the error
message?
With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com
From 819d653cc2be54e822826f08905f6ce8ec2f8418 Mon Sep 17 00:00:00 2001
From: Bharath Rupireddy
Date: Thu, 8 Apr 2021 13:35:38 +05
On Wed, Apr 7, 2021 at 6:52 PM Bharath Rupireddy
wrote:
>
> On Wed, Apr 7, 2021 at 6:04 PM Ashutosh Bapat
> wrote:
> > At best CREATE SEQUENCE START ... RESTART ... can be a shorthand
> > for CREATE SEQUENCE ... START; ALTER SEQUENCE ... RESTART run back to
> > back. So it looks useful but
On Wed, Apr 7, 2021 at 6:04 PM Ashutosh Bapat
wrote:
> At best CREATE SEQUENCE START ... RESTART ... can be a shorthand
> for CREATE SEQUENCE ... START; ALTER SEQUENCE ... RESTART run back to
> back. So it looks useful but in rare cases.
I personally feel that let's not mix up START and
tively, do we need to throw an error if the user is not
> supposed to use the "restart" option with CREATE SEQUENCE?
>
> IMO, allowing the "restart" option for CREATE SEQUENCE doesn't make
> sense when we have the "start" option, so it's better to throw an
>
on behaviour for ALTER
SEQUENCE, we have no mention of it in the CREATE SEQUENCE docs page.
Do we need to document the above behaviour for CREATE SEQUENCE?
Alternatively, do we need to throw an error if the user is not
supposed to use the "restart" option with CREATE SEQUENCE?
IMO, allowing
15 matches
Mail list logo
