Re: Code checks for App Devs, using new options for transaction behavior

2023-03-23 Thread Tom Lane
Greg Stark writes: > On Thu, 27 Oct 2022 at 07:10, Simon Riggs > wrote: >> * nested transactions = off (default) | all | on >> Handle nested BEGIN/COMMIT, which can cause chaos on failure. > I think we've been burned pretty badly by GUCs that control SQL > semantics before. Yeah, this idea is

Re: Code checks for App Devs, using new options for transaction behavior

2023-03-23 Thread Greg Stark
On Thu, 27 Oct 2022 at 07:10, Simon Riggs wrote: > > In the past, developers have wondered how we can provide "--dry-run" > functionality That would be an awesome functionality, indeed. I have concerns of how feasible it is in general but I think providing features to allow developers to build

Re: Code checks for App Devs, using new options for transaction behavior

2022-11-22 Thread Simon Riggs
On Mon, 7 Nov 2022 at 14:25, Simon Riggs wrote: > > On Wed, 2 Nov 2022 at 07:40, Simon Riggs wrote: > > > > What will be the behavior if someone declares a savepoint with this > > > name ("_internal_nested_xact"). Will this interfere with this new > > > functionality? > > > > Clearly! I guess

Re: Code checks for App Devs, using new options for transaction behavior

2022-11-07 Thread Simon Riggs
On Wed, 2 Nov 2022 at 07:40, Simon Riggs wrote: > > What will be the behavior if someone declares a savepoint with this > > name ("_internal_nested_xact"). Will this interfere with this new > > functionality? > > Clearly! I guess you are saying we should disallow them. > > > Have we tested

Re: Code checks for App Devs, using new options for transaction behavior

2022-11-02 Thread Simon Riggs
On Wed, 2 Nov 2022 at 03:52, Dilip Kumar wrote: > > On Mon, Oct 31, 2022 at 6:54 PM Simon Riggs > wrote: > > > > > > What is the behavior if "nested_transactions" value is changed within > > > > a transaction execution, suppose the value was on and we have created > > > > a few levels of nested

Re: Code checks for App Devs, using new options for transaction behavior

2022-11-01 Thread Dilip Kumar
On Mon, Oct 31, 2022 at 6:54 PM Simon Riggs wrote: > > > > What is the behavior if "nested_transactions" value is changed within > > > a transaction execution, suppose the value was on and we have created > > > a few levels of nested subtransactions and within the same transaction > > > I

Re: Code checks for App Devs, using new options for transaction behavior

2022-10-31 Thread Simon Riggs
On Mon, 31 Oct 2022 at 12:22, Dilip Kumar wrote: > > On Mon, Oct 31, 2022 at 5:03 PM Dilip Kumar wrote: > > > > On Mon, Oct 31, 2022 at 4:23 PM Dilip Kumar wrote: > > > > > > On Sun, Oct 30, 2022 at 11:32 PM Simon Riggs > > > wrote: > > > > > > > > On Fri, 28 Oct 2022 at 10:33, Simon Riggs >

Re: Code checks for App Devs, using new options for transaction behavior

2022-10-31 Thread Simon Riggs
On Mon, 31 Oct 2022 at 11:33, Dilip Kumar wrote: > What is the behavior if "nested_transactions" value is changed within > a transaction execution, suppose the value was on and we have created > a few levels of nested subtransactions and within the same transaction > I switched it to off or to

Re: Code checks for App Devs, using new options for transaction behavior

2022-10-31 Thread Dilip Kumar
On Mon, Oct 31, 2022 at 5:03 PM Dilip Kumar wrote: > > On Mon, Oct 31, 2022 at 4:23 PM Dilip Kumar wrote: > > > > On Sun, Oct 30, 2022 at 11:32 PM Simon Riggs > > wrote: > > > > > > On Fri, 28 Oct 2022 at 10:33, Simon Riggs > > > wrote: > > > > > > > Thanks for the feedback, I will make all

Re: Code checks for App Devs, using new options for transaction behavior

2022-10-31 Thread Dilip Kumar
On Mon, Oct 31, 2022 at 4:23 PM Dilip Kumar wrote: > > On Sun, Oct 30, 2022 at 11:32 PM Simon Riggs > wrote: > > > > On Fri, 28 Oct 2022 at 10:33, Simon Riggs > > wrote: > > > > > Thanks for the feedback, I will make all of those corrections in the > > > next version. > > > > New version

Re: Code checks for App Devs, using new options for transaction behavior

2022-10-31 Thread Dilip Kumar
On Sun, Oct 30, 2022 at 11:32 PM Simon Riggs wrote: > > On Fri, 28 Oct 2022 at 10:33, Simon Riggs > wrote: > > > Thanks for the feedback, I will make all of those corrections in the > > next version. > > New version attached. I've rolled 002-004 into one patch, but can > split again as needed.

Re: Code checks for App Devs, using new options for transaction behavior

2022-10-30 Thread Simon Riggs
On Fri, 28 Oct 2022 at 10:33, Simon Riggs wrote: > Thanks for the feedback, I will make all of those corrections in the > next version. New version attached. I've rolled 002-004 into one patch, but can split again as needed. -- Simon Riggshttp://www.EnterpriseDB.com/

Re: Code checks for App Devs, using new options for transaction behavior

2022-10-28 Thread Simon Riggs
On Fri, 28 Oct 2022 at 07:54, Erik Rijkers wrote: > > Op 27-10-2022 om 18:35 schreef Simon Riggs: > > On Thu, 27 Oct 2022 at 12:09, Simon Riggs > > wrote: > > > >> Comments please > > > > Update from patch tester results. > > > > > [001_psql_parse_only.v1.patch ] > >

Re: Code checks for App Devs, using new options for transaction behavior

2022-10-28 Thread Erik Rijkers
Op 27-10-2022 om 18:35 schreef Simon Riggs: On Thu, 27 Oct 2022 at 12:09, Simon Riggs wrote: Comments please Update from patch tester results. > [001_psql_parse_only.v1.patch ] > [002_nested_xacts.v7.patch] > [003_rollback_on_commit.v1.patch ] >

Re: Code checks for App Devs, using new options for transaction behavior

2022-10-27 Thread Simon Riggs
On Thu, 27 Oct 2022 at 12:09, Simon Riggs wrote: > Comments please Update from patch tester results. -- Simon Riggshttp://www.EnterpriseDB.com/ 002_nested_xacts.v7.patch Description: Binary data 001_psql_parse_only.v1.patch Description: Binary data

Code checks for App Devs, using new options for transaction behavior

2022-10-27 Thread Simon Riggs
In the past, developers have wondered how we can provide "--dry-run" functionality https://www.postgresql.org/message-id/15791.1450383201%40sss.pgh.pa.us This is important for application developers, especially when migrating programs to Postgres. Presented here are 3 features aimed at