Re: Consider \v to the list of whitespace characters in the parser

2023-07-05 Thread Michael Paquier
On Tue, Jul 04, 2023 at 09:28:21AM +0900, Michael Paquier wrote: > Yeah, thanks. I have looked again at that this morning, and did not notice any missing spots, so applied.. Let's see how it goes. -- Michael signature.asc Description: PGP signature

Re: Consider \v to the list of whitespace characters in the parser

2023-07-03 Thread Michael Paquier
On Mon, Jul 03, 2023 at 08:15:03PM -0400, Tom Lane wrote: > Assuming we don't want to change either of these distinctions, > the v2 patch looks about right to me. Yeah, thanks. Peter, what's your take? -- Michael signature.asc Description: PGP signature

Re: Consider \v to the list of whitespace characters in the parser

2023-07-03 Thread Tom Lane
Michael Paquier writes: > On Mon, Jul 03, 2023 at 12:17:10PM +0200, Peter Eisentraut wrote: >> In scan.l, you might want to ponder horiz_space: Even though \v is clearly >> not "horizontal space", horiz_space already includes \f, which is also not >> horizontal IMO. I think horiz_space is really

Re: Consider \v to the list of whitespace characters in the parser

2023-07-03 Thread Michael Paquier
On Mon, Jul 03, 2023 at 12:17:10PM +0200, Peter Eisentraut wrote: > SQL has "whitespace", which includes any Unicode character with the > White_Space property (which includes \v), and , which is > implementation-defined. > > So nothing there speaks against treating \v as a (white)space character

Re: Consider \v to the list of whitespace characters in the parser

2023-07-03 Thread Peter Eisentraut
On 21.06.23 08:45, Michael Paquier wrote: One thing I was wondering: has the SQL specification anything specific about the way vertical tabs should be parsed? SQL has "whitespace", which includes any Unicode character with the White_Space property (which includes \v), and , which is

Consider \v to the list of whitespace characters in the parser

2023-06-21 Thread Michael Paquier
Hi all, (Adding Evan in CC as he has reported the original issue with hstore.) $subject has showed up as a subject for discussion when looking at the set of whitespace characters that we use in the parsers: