On 04.10.22 08:57, Amul Sul wrote:
On Tue, Oct 4, 2022 at 12:00 PM Peter Eisentraut
wrote:
On 16.05.22 10:27, Peter Eisentraut wrote:
Inspired by [0], I looked to convert more macros to inline functions.
Here is another one from the same batch of work that I somehow didn't
send in last
On Tue, Oct 4, 2022 at 12:00 PM Peter Eisentraut
wrote:
>
> On 16.05.22 10:27, Peter Eisentraut wrote:
> > Inspired by [0], I looked to convert more macros to inline functions.
>
> Here is another one from the same batch of work that I somehow didn't
> send in last time.
>
I think assertion can
, rather than a normal external function.)
From 6d1e97d8d03e2a01842dacd3528bf2dbf40377cf Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Tue, 19 Jul 2022 06:58:12 +0200
Subject: [PATCH] Convert macros to static inline functions (rel.h)
---
src/include/utils/rel.h | 23 ---
1
On Mon, May 16, 2022 at 1:28 AM Peter Eisentraut
wrote:
> Inspired by [0], I looked to convert more macros to inline functions.
> The attached patches are organized "bottom up" in terms of their API
> layering; some of the later ones depend on some of the earlier ones.
Big +1 from me.
I
else
+#endif
Can we have a switch case like store_att_byval() instead of if-else,
code would look more symmetric, IMO.
doneFrom 75cc12a425a58340799376bc1e2dfdebfcb7ea0a Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Mon, 23 May 2022 07:28:13 +0200
Subject: [PATCH v2] Convert macros to sta
On 2022-May-16, Amul Sul wrote:
> +static inline OffsetNumber
> +PageGetMaxOffsetNumber(Page page)
> +{
> + if (((PageHeader) page)->pd_lower <= SizeOfPageHeaderData)
> + return 0;
> + else
> + return PageHeader) page)->pd_lower - SizeOfPageHeaderData)
> / sizeof(ItemIdData));
On Mon, May 16, 2022 at 1:58 PM Peter Eisentraut
wrote:
>
>
> Inspired by [0], I looked to convert more macros to inline functions.
> The attached patches are organized "bottom up" in terms of their API
> layering; some of the later ones depend on some of the earlier ones.
>
All the patches look
2001
From: Peter Eisentraut
Date: Mon, 16 May 2022 09:58:13 +0200
Subject: [PATCH] Convert macros to static inline functions (block.h)
Remove BlockIdIsValid(), which wasn't used and is unnecessary.
Remove BlockIdCopy(), which wasn't used and can be done by struct
assignment.
(BlockIdEquals()
