On 3/31/23 03:04, shiy.f...@fujitsu.com wrote:
> I noticed that a similar problem has been discussed in this thread, see [1]
> [2]
> [3] [4].
Ah, thank you. I didn't go far back enough in the thread...
> It seems complicated to fix it if we want to automatically skip tables
> that have been
On 3/30/23 20:01, Peter Smith wrote:
> For example, Just imagine if logic could be made smarter to recognize
> that since there was already the 'part_def' being subscribed so it
> should NOT use the default 'copy_data=true' when the REFRESH launches
> the ancestor table 'part'...
>
> Even if that
On Fri, Mar 31, 2023 2:16 AM Jacob Champion wrote:
>
> On Wed, Mar 29, 2023 at 2:00 AM Amit Kapila
> wrote:
> > Pushed.
>
> While rebasing my logical-roots patch over the top of this, I ran into
> another situation where mixed viaroot settings can duplicate data. The
> key idea is to subscribe
On Fri, Mar 31, 2023 at 5:15 AM Jacob Champion wrote:
>
> On Wed, Mar 29, 2023 at 2:00 AM Amit Kapila wrote:
> > Pushed.
>
> While rebasing my logical-roots patch over the top of this, I ran into
> another situation where mixed viaroot settings can duplicate data. The
> key idea is to subscribe
On Wed, Mar 29, 2023 at 2:00 AM Amit Kapila wrote:
> Pushed.
While rebasing my logical-roots patch over the top of this, I ran into
another situation where mixed viaroot settings can duplicate data. The
key idea is to subscribe to two publications with mixed settings, as
before, and add a
On Tue, Mar 28, 2023 at 11:14 PM Jacob Champion wrote:
>
> On Tue, Mar 28, 2023 at 2:59 AM wangw.f...@fujitsu.com
>
> > > Would it
> > > be enough to just replace that whole thing with gpt.attrs?
> >
> > Make sense.
> > Changed as suggested.
>
> LGTM, by inspection. Thanks!
>
Pushed.
--
With
On Wed, Mar 29, 2023 at 7:44 AM Peter Smith wrote:
>
> A minor review comment for v25-0001.
>
> ==
> src/backend/commands/subscriptioncmds.c
>
> 1.
> @@ -1936,21 +1936,56 @@ fetch_table_list(WalReceiverConn *wrconn, List
> *publications)
> WalRcvExecResult *res;
> StringInfoData cmd;
>
A minor review comment for v25-0001.
==
src/backend/commands/subscriptioncmds.c
1.
@@ -1936,21 +1936,56 @@ fetch_table_list(WalReceiverConn *wrconn, List
*publications)
WalRcvExecResult *res;
StringInfoData cmd;
TupleTableSlot *slot;
- Oid tableRow[3] = {TEXTOID, TEXTOID,
On Tue, Mar 28, 2023 at 2:59 AM wangw.f...@fujitsu.com
wrote:
> The scenario of this bug is to subscribe to two publications at the same time,
> and these two publications publish parent table and child table respectively.
> And option via_root is specified in both publications or only in the
>
On Tues, Mar 28, 2023 at 18:00 PM Wang, Wei/王 威 wrote:
> Attach the new patch.
Sorry, I attached the wrong patch.
Here is the correct new version patch which addressed all comments so far.
Regards,
Wang Wei
v25-0001-Avoid-syncing-data-twice-for-the-publish_via_par.patch
Description:
On Tues, Mar 28, 2023 at 7:02 AM Jacob Champion wrote:
> On Mon, Mar 20, 2023 at 11:22 PM Amit Kapila
> wrote:
> > If the tests you have in mind are only related to this patch set then
> > feel free to propose them here if you feel the current ones are not
> > sufficient.
>
> I think the new
On Mon, Mar 20, 2023 at 11:22 PM Amit Kapila
wrote:
> If the tests you have in mind are only related to this patch set then
> feel free to propose them here if you feel the current ones are not
> sufficient.
I think the new tests added by Wang cover my concerns (thanks!). I share
Peter's comment
I looked at v24-0001.
==
src/test/subscription/t/028_row_filter.pl
+# Check expected replicated rows for tap_pub_parent_sync and
+# tap_pub_child_sync
+# Since the option publish_via_partition_root of tap_pub_parent_sync is true,
+# so the row filter of tap_pub_parent_sync will be used:
+#
On Mon, Mar 27, 2023 at 11:32 AM Amit Kapila wrote:
> On Mon, Mar 27, 2023 at 7:03 AM Peter Smith
> wrote:
> >
> >
> > 1.
> > +# two publications, one publishing through ancestor and another one
> > directly
> > +# publsihing the partition, with different row filters
> >
On Mon, Mar 27, 2023 at 7:03 AM Peter Smith wrote:
>
>
> 1.
> +# two publications, one publishing through ancestor and another one directly
> +# publsihing the partition, with different row filters
> +$node_publisher->safe_psql('postgres',
> + "CREATE PUBLICATION tap_pub_viaroot_sync_1 FOR TABLE
Here are some review comments for v23-0001.
==
src/test/subscription/t/028_row_filter.pl
1.
+# two publications, one publishing through ancestor and another one directly
+# publsihing the partition, with different row filters
+$node_publisher->safe_psql('postgres',
+ "CREATE PUBLICATION
On Fri, Mar 24, 2023 at 2:36 PM wangw.f...@fujitsu.com
wrote:
>
> On Fri, Mar 24, 2023 at 14:17 PM Amit Kapila wrote:
>
> And I found there is a problem in the three back-branch patches
> (HEAD_v21_0002*,
> REL15_* and REL14_*):
> In the function fetch_table_list, we use pg_partition_ancestors
On Fri, Mar 24, 2023 at 9:49 AM Peter Smith wrote:
> On Thu, Mar 23, 2023 at 8:11 PM wangw.f...@fujitsu.com
> wrote:
> >
> > On Thu, Mar 23, 2023 at 12:27 PM Peter Smith
> wrote:
> > > Here are some review comments for patch v20-0001.
> >
> ...
> > > ==
> > >
On Fri, Mar 24, 2023 at 14:17 PM Amit Kapila wrote:
> > > > ==
> > > > src/test/subscription/t/028_row_filter.pl
> > > >
> > > > 7.
> > > > +# insert data into partitioned table.
> > > > +$node_publisher->safe_psql('postgres',
> > > > + "INSERT INTO tab_rowfilter_viaroot_part(a) VALUES(13),
On Fri, Mar 24, 2023 at 10:14 AM Peter Smith wrote:
>
Thanks for the information.
> BTW, since this patch changes the signature of the API
> pg_get_publication_tables, I assume the example in the CREATE
> SUBSCRIPTION Notes [1] may not work anymore.
The use case you mentioned is still work.
>
On Fri, Mar 24, 2023 at 7:19 AM Peter Smith wrote:
>
> Hi Wang-san. I looked at the v21-0001 patch.
>
> I don't have any new review comments -- only follow-ups for some of my
> previous v20 comments that were rejected.
>
> On Thu, Mar 23, 2023 at 8:11 PM wangw.f...@fujitsu.com
> wrote:
> >
> >
BTW, since this patch changes the signature of the API
pg_get_publication_tables, I assume the example in the CREATE
SUBSCRIPTION Notes [1] may not work anymore.
Meanwhile, Tom Lane suggested [2] that the example could be re-written
to avoid even mentioning pg_get_publication_tables at all.
Hi Wang-san. I looked at the v21-0001 patch.
I don't have any new review comments -- only follow-ups for some of my
previous v20 comments that were rejected.
On Thu, Mar 23, 2023 at 8:11 PM wangw.f...@fujitsu.com
wrote:
>
> On Thu, Mar 23, 2023 at 12:27 PM Peter Smith wrote:
> > Here are some
On Thu, Mar 23, 2023 at 5:51 PM Amit Kapila wrote:
>
> On Thu, Mar 23, 2023 at 9:57 AM Peter Smith wrote:
> >
> > Here are some review comments for patch v20-0001.
> >
> > ==
> > General.
> >
> > 1.
> > That function 'pg_get_publication_tables' does not seem to be
> > described in the PG
On Thu, Mar 23, 2023 at 12:27 PM Peter Smith wrote:
> Here are some review comments for patch v20-0001.
Thanks for your comments.
> ==
> src/backend/commands/subscriptioncmds.c
>
> 3. fetch_table_list
>
> + /* Get the list of tables from the publisher. */
> + if (server_version >= 16)
On Thu, Mar 23, 2023 at 9:57 AM Peter Smith wrote:
>
> Here are some review comments for patch v20-0001.
>
> ==
> General.
>
> 1.
> That function 'pg_get_publication_tables' does not seem to be
> described in the PG documentation. Why isn't it in the "System Catalog
> Information Functions"
Here are some review comments for patch v20-0001.
==
General.
1.
That function 'pg_get_publication_tables' does not seem to be
described in the PG documentation. Why isn't it in the "System Catalog
Information Functions" table [1] ?
I asked this same question a long time ago but then the
On Wed, Mar 22, 2023 at 14:32 PM Kuroda, Hayato/黒田 隼人
wrote:
> Dear Wang,
>
> Thank you for updating patch! Following are comments form v19-0001.
Thanks for your comments.
> 01. logical-replication.sgml
>
> I found a following statement in logical-replication.sgml. I think this may
> cause
On Wed, Mar 22, 2023 at 12:50 PM Peter Smith wrote:
> Here are some review comments for patch code of HEAD_v19-0001
Thanks for your comments.
> ==
> doc/src/sgml/ref/create_publication.sgml
>
> 1.
> +
> + There can be a case where a subscription combines multiple
> +
Dear Wang,
Thank you for updating patch! Following are comments form v19-0001.
01. logical-replication.sgml
I found a following statement in logical-replication.sgml. I think this may
cause
mis-reading because it's OK when publishers list partitions and
publish_via_root is true.
```
A
Here are some review comments for patch code of HEAD_v19-0001
==
doc/src/sgml/ref/create_publication.sgml
1.
+
+ There can be a case where a subscription combines multiple
+ publications. If a root partitioned table is published by any
+ subscribed
On Mon, Mar 20, 2023 at 21:18 PM Kuroda, Hayato/黒田 隼人
wrote:
> Dear Wang,
>
> I have tested about multilevel partitions, and it worked well.
> Followings are my comments for v18-0001.
Thanks for your comments and testing.
> 01. pg_get_publication_tables
>
> ```
> + ListCell
On Mon, Mar 20, 2023 at 15:32 PM Peter Smith wrote:
> Here are some review comments for v17-0001.
Thanks for your comments.
> ==
> src/backend/catalog/pg_publication.c
>
> 1. filter_partitions
>
> -static List *
> -filter_partitions(List *relids)
> +static void
> +filter_partitions(List
On Sat, Mar 18, 2023 at 7:37 AM Jacob Champion wrote:
> On Thu, Mar 16, 2023 at 11:28 PM wangw.f...@fujitsu.com
> wrote:
> > Attach the new patch set.
Thanks for your comments and testing.
> For example, the corner case mentioned in 0003, with multiple
> publications having conflicting
On Mon, Mar 20, 2023 at 18:15 PM Amit Kapila wrote:
>
Thanks for your comments.
> On Mon, Mar 20, 2023 at 1:02 PM Peter Smith
> wrote:
> >
> >
> > ==
> > src/include/catalog/pg_proc.dat
> >
> > 4.
> > +{ oid => '6119',
> > + descr => 'get information of the tables in the given publication
On Mon, Mar 20, 2023 at 11:22 PM Jacob Champion wrote:
>
> On Fri, Mar 17, 2023 at 9:45 PM Amit Kapila wrote:
> > > There are a bunch of moving parts and hidden subtleties here, and I fell
> > > into a few traps when I was working on my patch, so it'd be nice to have
> > > additional coverage.
On Fri, Mar 17, 2023 at 9:45 PM Amit Kapila wrote:
> > There are a bunch of moving parts and hidden subtleties here, and I fell
> > into a few traps when I was working on my patch, so it'd be nice to have
> > additional coverage. I'm happy to contribute effort in that area if it's
> > helpful.
>
Dear Wang,
I have tested about multilevel partitions, and it worked well.
Followings are my comments for v18-0001.
01. pg_get_publication_tables
```
+ ListCell *lc;
```
This definition can be inside of the "for (i = 0; i < nelems; i++)".
02. pg_get_publication_tables
```
-
On Mon, Mar 20, 2023 at 1:02 PM Peter Smith wrote:
>
>
> ==
> src/include/catalog/pg_proc.dat
>
> 4.
> +{ oid => '6119',
> + descr => 'get information of the tables in the given publication array',
>
> Should that be worded in a way to make it more clear that the
> "publication array" is
On Mon, Mar 20, 2023 at 1:02 PM Peter Smith wrote:
>
>
> 2. pg_get_publication_tables
>
> + else
> + {
> + List*relids,
> +*schemarelids;
> +
> + relids = GetPublicationRelations(pub_elem->oid,
> + pub_elem->pubviaroot ?
> + PUBLICATION_PART_ROOT :
> + PUBLICATION_PART_LEAF);
> +
Here are some review comments for v17-0001.
==
src/backend/catalog/pg_publication.c
1. filter_partitions
-static List *
-filter_partitions(List *relids)
+static void
+filter_partitions(List *table_infos)
{
- List*result = NIL;
ListCell *lc;
- ListCell *lc2;
- foreach(lc, relids)
On Fri, Mar 17, 2023 at 20:07 PM Amit Kapila wrote:
> On Fri, Mar 17, 2023 at 11:58 AM wangw.f...@fujitsu.com
> wrote:
> >
> > On Thu, Mar 16, 2023 at 20:25 PM Amit Kapila
> wrote:
> > >
> >
> > Thanks for your comments.
> >
> > > + if (server_version >= 16)
> > > + {
> > > +
On Sat, Mar 18, 2023 at 5:06 AM Jacob Champion wrote:
>
> On Thu, Mar 16, 2023 at 11:28 PM wangw.f...@fujitsu.com
> wrote:
> > Attach the new patch set.
>
> Hi,
>
> I ran into this problem while hacking on [1], so thank you for tackling
> it! I have no strong opinions on the implementation
On Thu, Mar 16, 2023 at 11:28 PM wangw.f...@fujitsu.com
wrote:
> Attach the new patch set.
Hi,
I ran into this problem while hacking on [1], so thank you for tackling
it! I have no strong opinions on the implementation itself; I just want
to register a concern that the tests have not kept up
On Fri, Mar 17, 2023 at 11:58 AM wangw.f...@fujitsu.com
wrote:
>
> On Thu, Mar 16, 2023 at 20:25 PM Amit Kapila wrote:
> >
>
> Thanks for your comments.
>
> > + if (server_version >= 16)
> > + {
> > + appendStringInfo(, "SELECT DISTINCT N.nspname, C.relname,\n"
> > + " ( SELECT
On Thu, Mar 16, 2023 at 20:25 PM Amit Kapila wrote:
>
Thanks for your comments.
> + if (server_version >= 16)
> + {
> + appendStringInfo(, "SELECT DISTINCT N.nspname, C.relname,\n"
> + " ( SELECT array_agg(a.attname ORDER BY a.attnum)\n"
> + "FROM pg_attribute
On Wed, Feb 8, 2023 at 9:21 AM wangw.f...@fujitsu.com
wrote:
>
> I think this failure is caused by the recently commit (b7ae039) in the current
> HEAD. Rebased the patch set and attach them.
>
+ if (server_version >= 16)
+ {
+ appendStringInfo(, "SELECT DISTINCT N.nspname, C.relname,\n"
+ "
On Wed, Feb 8, 2023 4:29 AM Andres Freund wrote:
> Hi,
>
> On 2022-11-16 08:58:31 +, wangw.f...@fujitsu.com wrote:
> > Attach the new patch set.
>
> This patch causes several of the tests to fail. See e.g.:
>
> https://cirrus-ci.com/task/6587624765259776
>
> Most of the failures appear to
Hi,
On 2022-11-16 08:58:31 +, wangw.f...@fujitsu.com wrote:
> Attach the new patch set.
This patch causes several of the tests to fail. See e.g.:
https://cirrus-ci.com/task/6587624765259776
Most of the failures appear to be due to the main regression tests failing:
On Thurs, Nov 17, 2022 at 13:58 PM vignesh C wrote:
> On Wed, 16 Nov 2022 at 14:28, wangw.f...@fujitsu.com
> wrote:
> >
> > On Mon, Nov 14, 2022 at 0:56 AM vignesh C wrote:
> > > >
> > > > Attach new patches.
> > >
> >
> > Thanks for your comments.
> >
> > > Here we are having tables list to
On Wed, 16 Nov 2022 at 14:28, wangw.f...@fujitsu.com
wrote:
>
> On Mon, Nov 14, 2022 at 0:56 AM vignesh C wrote:
> > >
> > > Attach new patches.
> >
>
> Thanks for your comments.
>
> > Here we are having tables list to store the relids and table_infos
> > list which stores pubid along with
On Mon, Nov 14, 2022 at 0:56 AM vignesh C wrote:
> >
> > Attach new patches.
>
Thanks for your comments.
> Here we are having tables list to store the relids and table_infos
> list which stores pubid along with relid. Here tables list acts as a
> temporary list to get filter_partitions and
On Fri, 11 Nov 2022 at 11:13, wangw.f...@fujitsu.com
wrote:
>
> On Fri, Oct 21, 2022 at 17:02 PM Peter Smith wrote:
> >
>
> Thanks for your comments. Sorry for not replying in time.
>
> > On Mon, Oct 17, 2022 at 4:49 PM wangw.f...@fujitsu.com
> > wrote:
> > >
> > > On Wed, Oct 5, 2022 at
On Tues, Nov 8, 2022 at 12:12 PM Osumi, Takamichi/大墨 昂道
wrote:
> On Monday, October 17, 2022 2:49 PM Wang, Wei/王 威
> wrote:
> > Attach the new patch set.
> Hi, thank you for posting the new patches.
>
>
> Here are minor comments on the HEAD_v13-0002.
Thanks for your comments.
> (1)
On Fri, Oct 21, 2022 at 17:02 PM Peter Smith wrote:
> Here are my review comments for HEAD patches v13*
Thanks for your comments.
> Patch HEAD_v13-0002
>
> 1. Commit message
>
> The following usage scenarios are not described in detail in the manual:
> If one subscription subscribes multiple
On Fri, Oct 21, 2022 at 17:02 PM Peter Smith wrote:
>
Thanks for your comments. Sorry for not replying in time.
> On Mon, Oct 17, 2022 at 4:49 PM wangw.f...@fujitsu.com
> wrote:
> >
> > On Wed, Oct 5, 2022 at 11:08 AM Peter Smith
> wrote:
> > > Hi Wang-san. Here are my review comments for
On Monday, October 17, 2022 2:49 PM Wang, Wei/王 威
wrote:
> Attach the new patch set.
Hi, thank you for posting the new patches.
Here are minor comments on the HEAD_v13-0002.
(1) Suggestion for the document description
+
+ If a root partitioned table is published by any
2022年10月17日(月) 14:49 wangw.f...@fujitsu.com :
>
> On Wed, Oct 5, 2022 at 11:08 AM Peter Smith wrote:
> > Hi Wang-san. Here are my review comments for HEAD_v12-0001 patch.
>
> Thanks for your comments.
>
> > ==
> >
> > 1. Missing documentation.
> >
> > In [1] you wrote:
> > > I think the
Here are my review comments for HEAD patches v13*
//
Patch HEAD_v13-0001
I already posted some follow-up questions. See [1]
/
Patch HEAD_v13-0002
1. Commit message
The following usage scenarios are not described in detail in the manual:
If one subscription subscribes multiple
On Mon, Oct 17, 2022 at 4:49 PM wangw.f...@fujitsu.com
wrote:
>
> On Wed, Oct 5, 2022 at 11:08 AM Peter Smith wrote:
> > Hi Wang-san. Here are my review comments for HEAD_v12-0001 patch.
>
...
> >
> > 3. QUESTION - pg_get_publication_tables / fetch_table_list
> >
> > When the same table is
On Wed, Oct 5, 2022 at 23:05 PM Osumi, Takamichi/大墨 昂道
wrote:
> Hi, thank you for the updated patches!
>
>
> Here are my minor review comments for HEAD v12.
Thanks for your comments.
> (1) typo & suggestion to reword one comment
>
>
> +* Publications support
On Wed, Oct 5, 2022 at 11:08 AM Peter Smith wrote:
> Hi Wang-san. Here are my review comments for HEAD_v12-0001 patch.
Thanks for your comments.
> ==
>
> 1. Missing documentation.
>
> In [1] you wrote:
> > I think the behaviour of multiple publications with parameter
>
On Wednesday, September 28, 2022 5:36 PM Wang, Wei/王 威
wrote:
> Also rebased the patch because the change in the HEAD (20b6847).
>
> Attach the new patches.
Hi, thank you for the updated patches!
Here are my minor review comments for HEAD v12.
(1) typo & suggestion to reword one comment
+
Hi Wang-san. Here are my review comments for HEAD_v12-0001 patch.
==
1. Missing documentation.
In [1] you wrote:
> I think the behaviour of multiple publications with parameter
> publish_via_partition_root could be added to the pg-doc later in a separate
> patch.
~
That doesn't seem
On Tues, Sep 27, 2022 at 16:45 PM Peter Smith wrote:
> Here are my review comments for the HEAD_v11-0001 patch:
Thanks for your comments.
> ==
>
> 1. General - Another related bug?
>
> In [1] Hou-san wrote:
>
> For another case you mentioned (via_root used when publishing child)
> CREATE
Here are my review comments for the HEAD_v11-0001 patch:
==
1. General - Another related bug?
In [1] Hou-san wrote:
For another case you mentioned (via_root used when publishing child)
CREATE PUBLICATION pub1 for TABLE parent;
CREATE PUBLICATION pub2 for TABLE child with
On Mon, Sep 26, 2022 at 10:31 AM Osumi, Takamichi/大墨 昂道
wrote:
> Hi, thank you for updating the patchset.
>
>
> FYI, I noticed that the patch for head is no longer applicable.
Thanks for your kindly reminder and comment.
> $ git apply --check
On Tuesday, September 20, 2022 3:18 PM Wang, Wei/王 威
wrote:
> Rebased the patch based on the changes in HEAD (20b6847).
> Attach the new patches.
Hi, thank you for updating the patchset.
FYI, I noticed that the patch for head is no longer applicable.
$ git apply --check
On Mon, Sept 19, 2022 at 14:52 PM Peter Smith wrote:
> FYI, I'm not sure why the cfbot hasn't reported this, but the apply v9
> patch failed for me on HEAD as below:
>
> [postgres@CentOS7-x64 oss_postgres_misc]$ git apply
> ../patches_misc/HEAD_v9-0001-Fix-data-replicated-twice-when-specifying-
FYI, I'm not sure why the cfbot hasn't reported this, but the apply v9
patch failed for me on HEAD as below:
[postgres@CentOS7-x64 oss_postgres_misc]$ git apply
../patches_misc/HEAD_v9-0001-Fix-data-replicated-twice-when-specifying-publish.patch
--verbose
Checking patch
On Tues, Aug 9, 2022 at 15:15 PM Peter Smith wrote:
> Here are some review comment for the HEAD_v8 patch:
Thanks for your comments.
> 1. Commit message
>
> If there are two publications, one of them publish a parent table with
> (publish_via_partition_root = true) and another publish child
On Wednesday, August 10, 2022 7:45 AM Peter Smith wrote:
>
> Here are some more review comments for the HEAD_v8 patch:
>
> ==
>
> 1. Commit message
>
> If there are two publications, one of them publish a parent table with
> (publish_via_partition_root = true) and another publish child
Here are some more review comments for the HEAD_v8 patch:
==
1. Commit message
If there are two publications, one of them publish a parent table with
(publish_via_partition_root = true) and another publish child table,
subscribing to both publications from one subscription results in two
Here are some review comment for the HEAD_v8 patch:
==
1. Commit message
If there are two publications, one of them publish a parent table with
(publish_via_partition_root = true) and another publish child table,
subscribing to both publications from one subscription results in two initial
On Thur, Jul 28, 2022 at 17:17 PM Peter Smith wrote:
> Here are some review comments for the HEAD_v7-0001 patch:
Thanks for your comments.
> 2. Commit message.
>
> 2a.
>
> If there are two publications that publish the parent table and the child
> table
> separately, and both specify the
On Thursday, July 28, 2022 5:17 PM Peter Smith wrote:
> Here are some review comments for the HEAD_v7-0001 patch:
>
> ==
>
> 1.
>
> I have a fundamental question about this patch.
>
> IIUC the purpose of this patch is to ensure that (when
> publish_via_root = true) the copy of the
Here are some review comments for the HEAD_v7-0001 patch:
==
1.
I have a fundamental question about this patch.
IIUC the purpose of this patch is to ensure that (when
publish_via_root = true) the copy of the partition data will happen
only once (e.g. from one parent table on one of the
On Thur, Jul 14, 2022 at 12:46 PM Peter Smith wrote:
> Here are some review comments for the v6 patch (HEAD only):
Thanks for your comments.
> 1. Commit message
>
> If there are two publications that publish the parent table and the child
> table
> separately, and both specify the option
Here are some review comments for the v6 patch (HEAD only):
HEAD_v6-0001
1. Commit message
If there are two publications that publish the parent table and the child table
separately, and both specify the option PUBLISH_VIA_PARTITION_ROOT, subscribing
to both
On Wed, May 18, 2022 4:51 PM I wrote:
> Attach the new patch.
Since there are some new commits in HEAD (0ff20288, fd0b9dc and 52b5c53) that
improve the functions pg_get_publication_tables and fetch_table_list, we cannot
apply the patch cleanly. Therefore, I rebased the patch based on the changes
On Wed, May 18, 2022 4:38 PM I wrote:
> Attach the patches.(Only changed the patch for HEAD.)
Sorry, I forgot to update commit message.
Attach the new patch.
1. Only update the commit message for HEAD_v5.
Regards,
Wang wei
HEAD_v5-0001-Fix-data-replicated-twice-when-specifying-PUBLISH.patch
On Fri, May 13, 2022 10:57 PM Osumi, Takamichi/大墨 昂道
wrote:
> On Friday, May 13, 2022 6:42 PM Wang, Wei/王 威
> wrote:
> > Attach the patches.(Only changed the patch for HEAD.).
> > 1. Optimize the code. Reduce calls to function filter_partitions.
> > [suggestions by Amit-san] 2. Improve the
On Tues, May 17, 2022 9:03 PM Amit Kapila wrote:
> On Fri, May 13, 2022 at 3:11 PM wangw.f...@fujitsu.com
> wrote:
> >
> > Attach the patches.(Only changed the patch for HEAD.).
> >
Thanks for your comments.
> # publications
> -{ oid => '6119', descr => 'get OIDs of tables in a publication',
>
On Fri, May 13, 2022 at 3:11 PM wangw.f...@fujitsu.com
wrote:
>
> Attach the patches.(Only changed the patch for HEAD.).
>
# publications
-{ oid => '6119', descr => 'get OIDs of tables in a publication',
+{ oid => '6119', descr => 'get OIDs of tables in one or more publications',
proname =>
On Friday, May 13, 2022 6:42 PM Wang, Wei/王 威 wrote:
> Attach the patches.(Only changed the patch for HEAD.).
> 1. Optimize the code. Reduce calls to function filter_partitions.
> [suggestions by
> Amit-san] 2. Improve the alias name in SQL. [suggestions by Amit-san] 3.
> Improve coding
On Fri, May 13, 2022 1:59 PM Amit Kapila wrote:
> On Fri, May 13, 2022 at 7:32 AM wangw.f...@fujitsu.com
> wrote:
> >
> > Attach the patches.(Only changed the patch for HEAD.).
> >
>
> Few comments:
> =
Thanks for your comments.
> 1.
> @@ -1135,6 +1172,15 @@
On Fri, May 13, 2022 at 7:32 AM wangw.f...@fujitsu.com
wrote:
>
> Attach the patches.(Only changed the patch for HEAD.).
>
Few comments:
=
1.
@@ -1135,6 +1172,15 @@ pg_get_publication_tables(PG_FUNCTION_ARGS)
if (publication->pubviaroot)
tables = filter_partitions(tables);
}
+
On Thur, May 12, 2022 9:48 AM osumi.takami...@fujitsu.com
wrote:
> On Wednesday, May 11, 2022 11:33 AM I wrote:
> > On Monday, May 9, 2022 10:51 AM wangw.f...@fujitsu.com
> > wrote:
> > > Attach new patches.
> > > The patch for HEAD:
> > > 1. Modify the approach. Enhance the API of function
> >
On Wednesday, May 11, 2022 11:33 AM I wrote:
> On Monday, May 9, 2022 10:51 AM wangw.f...@fujitsu.com
> wrote:
> > Attach new patches.
> > The patch for HEAD:
> > 1. Modify the approach. Enhance the API of function
> > pg_get_publication_tables to handle one publication or an array of
> >
On Monday, May 9, 2022 10:51 AM wangw.f...@fujitsu.com
wrote:
> Attach new patches.
> The patch for HEAD:
> 1. Modify the approach. Enhance the API of function
> pg_get_publication_tables to handle one publication or an array of
> publications.
> The patch for REL14:
> 1. Improve the table sync
On Tue, Apr 28, 2022 9:22 AM Shi, Yu/侍 雨 wrote:
> Thanks for your patches.
>
> Here's a comment on the patch for REL14.
Thanks for your comments.
> + appendStringInfo(, "SELECT DISTINCT ns.nspname, c.relname\n"
> + " FROM
>
On Sun, Apr 24, 2022 2:16 PM Wang, Wei/王 威 wrote:
>
> Attach the new patches.[suggestions by Amit-San]
> The patch for HEAD:
> 1. Add a new function to get tables info by a publications array.
> The patch for REL14:
> 1. Use an alias to make the statement understandable. BTW, I adjusted the
>
On Sun, Apr 24, 2022 at 2:16 PM I wrote:
> On Thur, Apr 21, 2022 at 5:41 PM Amit Kapila wrote:
> > IIRC, the column list and row filter also have some issues exactly due to
> > this
> > reason, so, I would like those cases to be also mentioned here and probably
> > include the tests for them in
On Thur, Apr 21, 2022 at 5:41 PM Amit Kapila wrote:
>
Thanks for your comments.
> On Tue, Apr 19, 2022 at 2:23 PM shiy.f...@fujitsu.com
> wrote:
> >
> > On Tue, Apr 19, 2022 3:05 PM houzj.f...@fujitsu.com
> wrote:
> > >
> > > One suggestion is that can we simplify the code by moving the logic
On Tue, Apr 19, 2022 at 2:23 PM shiy.f...@fujitsu.com
wrote:
>
> On Tue, Apr 19, 2022 3:05 PM houzj.f...@fujitsu.com
> wrote:
> >
> > One suggestion is that can we simplify the code by moving the logic of
> > checking
> > the ancestor into the SQL ?. For example, we could filter the outpout of
On Tue, Apr 19, 2022 4:53 PM Shi, Yu/侍 雨 wrote:
> On Tue, Apr 19, 2022 3:05 PM houzj.f...@fujitsu.com
> wrote:
> >
> > > -Original Message-
> > > From: Wang, Wei/王 威
> > On Thursday, April 7, 2022 11:08 AM
> > >
> > > On Thur, Mar 10, 2021 at 10:08 AM houzj.f...@fujitsu.com wrote:
> > >
On Tue, Apr 19, 2022 3:05 PM houzj.f...@fujitsu.com
wrote:
>
> > -Original Message-
> > From: Wang, Wei/王 威
> On Thursday, April 7, 2022 11:08 AM
> >
> > On Thur, Mar 10, 2021 at 10:08 AM houzj.f...@fujitsu.com wrote:
> > > Hi,
> > >
> > > When reviewing some logical replication related
> -Original Message-
> From: Wang, Wei/王 威
On Thursday, April 7, 2022 11:08 AM
>
> On Thur, Mar 10, 2021 at 10:08 AM houzj.f...@fujitsu.com wrote:
> > Hi,
> >
> > When reviewing some logical replication related features. I noticed another
> > possible problem if the subscriber
On Thur, Mar 10, 2021 at 10:08 AM houzj.f...@fujitsu.com wrote:
> Hi,
>
> When reviewing some logical replication related features. I noticed another
> possible problem if the subscriber subscribes multiple publications which
> publish parent and child table.
>
> For example:
>
> pub
>
Hi,
When reviewing some logical replication related features. I noticed another
possible problem if the subscriber subscribes multiple publications which
publish parent and child table.
For example:
pub
create table t (a int, b int, c int) partition by range (a);
create table t_1 partition
1 - 100 of 149 matches
Mail list logo
