Re: Detecting some cases of missing backup_label

2023-12-21 Thread David Steele
On 12/21/23 07:37, Andres Freund wrote: On 2023-12-20 13:11:37 -0400, David Steele wrote: I've run this through a bunch of scenarios (in my head) with parallel backups and it does seem to hold up. I think we'd need to write the state file before XLOG_BACKUP_START just in case. Seems better to

Re: Detecting some cases of missing backup_label

2023-12-21 Thread Andres Freund
Hi, On 2023-12-20 13:11:37 -0400, David Steele wrote: > I've run this through a bunch of scenarios (in my head) with parallel > backups and it does seem to hold up. > > I think we'd need to write the state file before XLOG_BACKUP_START just in > case. Seems better to have an extra state file

Re: Detecting some cases of missing backup_label

2023-12-20 Thread David Steele
On 12/18/23 10:39, Stephen Frost wrote: Greetings, * Stephen Frost (sfr...@snowman.net) wrote: * Andres Freund (and...@anarazel.de) wrote: I recently mentioned to Robert (and also Heikki earlier), that I think I see a way to detect an omitted backup_label in a relevant subset of the cases

Re: Detecting some cases of missing backup_label

2023-12-18 Thread Stephen Frost
Greetings, * Stephen Frost (sfr...@snowman.net) wrote: > * Andres Freund (and...@anarazel.de) wrote: > > I recently mentioned to Robert (and also Heikki earlier), that I think I > > see a > > way to detect an omitted backup_label in a relevant subset of the cases > > (it'd > > apply to the

Re: Detecting some cases of missing backup_label

2023-12-05 Thread Stephen Frost
Greetings, * Andres Freund (and...@anarazel.de) wrote: > I recently mentioned to Robert (and also Heikki earlier), that I think I see a > way to detect an omitted backup_label in a relevant subset of the cases (it'd > apply to the pg_control as well, if we moved to that). Robert encouraged me >

Detecting some cases of missing backup_label

2023-11-30 Thread Andres Freund
Hi, I recently mentioned to Robert (and also Heikki earlier), that I think I see a way to detect an omitted backup_label in a relevant subset of the cases (it'd apply to the pg_control as well, if we moved to that). Robert encouraged me to share the idea, even though it does not provide complete