Re: Document that server will start even if it's unable to open some TCP/IP ports

2023-10-01 Thread Gurjeet Singh
On Tue, Sep 26, 2023 at 4:02 PM Bruce Momjian wrote: > > Patch applied back to PG 11. +Peter E. since I received the following automated note: > Closed in commitfest 2023-09 with status: Moved to next CF (petere) Just a note that this patch has been committed (3fea854691), so I have marked the

Re: Document that server will start even if it's unable to open some TCP/IP ports

2023-09-26 Thread Bruce Momjian
On Tue, Sep 12, 2023 at 05:25:44PM -0700, Gurjeet Singh wrote: > On Fri, Sep 8, 2023 at 7:52 AM Bruce Momjian wrote: > > > > On Thu, Sep 7, 2023 at 09:21:07PM -0700, Nathan Bossart wrote: > > > On Thu, Sep 07, 2023 at 07:13:44PM -0400, Bruce Momjian wrote: > > > > On Thu, Sep 7, 2023 at

Re: Document that server will start even if it's unable to open some TCP/IP ports

2023-09-12 Thread Gurjeet Singh
On Fri, Sep 8, 2023 at 7:52 AM Bruce Momjian wrote: > > On Thu, Sep 7, 2023 at 09:21:07PM -0700, Nathan Bossart wrote: > > On Thu, Sep 07, 2023 at 07:13:44PM -0400, Bruce Momjian wrote: > > > On Thu, Sep 7, 2023 at 02:54:13PM -0700, Nathan Bossart wrote: > > >> IMO the phrase "open a port" is

Re: Document that server will start even if it's unable to open some TCP/IP ports

2023-09-08 Thread Nathan Bossart
On Fri, Sep 08, 2023 at 10:52:10AM -0400, Bruce Momjian wrote: > On Thu, Sep 7, 2023 at 09:21:07PM -0700, Nathan Bossart wrote: >> On Thu, Sep 07, 2023 at 07:13:44PM -0400, Bruce Momjian wrote: >> > On Thu, Sep 7, 2023 at 02:54:13PM -0700, Nathan Bossart wrote: >> >> IMO the phrase "open a port"

Re: Document that server will start even if it's unable to open some TCP/IP ports

2023-09-08 Thread Bruce Momjian
On Thu, Sep 7, 2023 at 09:21:07PM -0700, Nathan Bossart wrote: > On Thu, Sep 07, 2023 at 07:13:44PM -0400, Bruce Momjian wrote: > > On Thu, Sep 7, 2023 at 02:54:13PM -0700, Nathan Bossart wrote: > >> IMO the phrase "open a port" is kind of nonstandard. I think we should say > >> something along

Re: Document that server will start even if it's unable to open some TCP/IP ports

2023-09-07 Thread Nathan Bossart
On Thu, Sep 07, 2023 at 07:13:44PM -0400, Bruce Momjian wrote: > On Thu, Sep 7, 2023 at 02:54:13PM -0700, Nathan Bossart wrote: >> IMO the phrase "open a port" is kind of nonstandard. I think we should say >> something along the lines of >> >> If listen_addresses is not empty, the server

Re: Document that server will start even if it's unable to open some TCP/IP ports

2023-09-07 Thread Bruce Momjian
On Thu, Sep 7, 2023 at 02:54:13PM -0700, Nathan Bossart wrote: > Thanks for picking this up. > > On Thu, Sep 07, 2023 at 03:33:57PM -0400, Bruce Momjian wrote: > > The default value is > class="systemname">localhost, > > which allows only local TCP/IP loopback > >

Re: Document that server will start even if it's unable to open some TCP/IP ports

2023-09-07 Thread Nathan Bossart
Thanks for picking this up. On Thu, Sep 07, 2023 at 03:33:57PM -0400, Bruce Momjian wrote: > The default value is class="systemname">localhost, > which allows only local TCP/IP loopback connections > to be > - made. While client authentication ( + made. If

Re: Document that server will start even if it's unable to open some TCP/IP ports

2023-09-07 Thread Bruce Momjian
On Mon, Jun 12, 2023 at 11:57:45PM -0700, Gurjeet Singh wrote: > On Mon, Jun 12, 2023 at 10:59 PM Nathan Bossart > wrote: > > On Sat, May 27, 2023 at 03:17:21PM -0700, Gurjeet Singh wrote: > > > If listen_addresses is empty, then server won't try to open any TCP/IP > > > ports. The patch does not

Re: Document that server will start even if it's unable to open some TCP/IP ports

2023-07-11 Thread Gurjeet Singh
On Mon, Jun 19, 2023 at 5:48 PM Bruce Momjian wrote: > > On Tue, Jun 13, 2023 at 11:11:04PM -0400, Tom Lane wrote: > > > > There is certainly an argument that such a condition indicates that > > something's very broken in our configuration and we should complain. > > But I'm not sure how exciting

Re: Document that server will start even if it's unable to open some TCP/IP ports

2023-06-19 Thread Bruce Momjian
On Tue, Jun 13, 2023 at 11:11:04PM -0400, Tom Lane wrote: > Kyotaro Horiguchi writes: > > If I had to say, I would feel it rather surprising if server > > successfully starts even when any explicitly-specified port can't be > > opened (which is the current case). > > There is certainly an

Re: Document that server will start even if it's unable to open some TCP/IP ports

2023-06-13 Thread Tom Lane
Kyotaro Horiguchi writes: > If I had to say, I would feel it rather surprising if server > successfully starts even when any explicitly-specified port can't be > opened (which is the current case). There is certainly an argument that such a condition indicates that something's very broken in our

Re: Document that server will start even if it's unable to open some TCP/IP ports

2023-06-13 Thread Kyotaro Horiguchi
At Tue, 13 Jun 2023 14:38:14 -0700, Nathan Bossart wrote in > On Tue, Jun 13, 2023 at 04:28:31PM -0400, Tom Lane wrote: > > Nathan Bossart writes: > >> Before we spend too much time trying to document the current behavior, I > >> think we should see if we can change it to something less

Re: Document that server will start even if it's unable to open some TCP/IP ports

2023-06-13 Thread Nathan Bossart
On Tue, Jun 13, 2023 at 04:28:31PM -0400, Tom Lane wrote: > Nathan Bossart writes: >> Before we spend too much time trying to document the current behavior, I >> think we should see if we can change it to something less surprising (i.e., >> failing to start if the server fails for any address).

Re: Document that server will start even if it's unable to open some TCP/IP ports

2023-06-13 Thread Tom Lane
Nathan Bossart writes: > Before we spend too much time trying to document the current behavior, I > think we should see if we can change it to something less surprising (i.e., > failing to start if the server fails for any address). The original > objections around kernel support for IPv6 might

Re: Document that server will start even if it's unable to open some TCP/IP ports

2023-06-13 Thread Nathan Bossart
On Mon, Jun 12, 2023 at 11:57:45PM -0700, Gurjeet Singh wrote: > Perhaps we can prefix that statement with "If listen_addresses is not > empty", like so: Before we spend too much time trying to document the current behavior, I think we should see if we can change it to something less surprising

Re: Document that server will start even if it's unable to open some TCP/IP ports

2023-06-13 Thread Gurjeet Singh
On Mon, Jun 12, 2023 at 10:59 PM Nathan Bossart wrote: > On Sat, May 27, 2023 at 03:17:21PM -0700, Gurjeet Singh wrote: > > If listen_addresses is empty, then server won't try to open any TCP/IP > > ports. The patch does not change any language related to that. > > Your proposed change notes that

Re: Document that server will start even if it's unable to open some TCP/IP ports

2023-06-12 Thread Nathan Bossart
On Sat, May 27, 2023 at 03:17:21PM -0700, Gurjeet Singh wrote: > Upon further testing, I saw that server will not start only if it is > unable to open the port on _all_ the interfaces/addresses. It it's > able to open the port on at least one, the server will start. This surprised me. I would've

Document that server will start even if it's unable to open some TCP/IP ports

2023-05-27 Thread Gurjeet Singh
The attached patch clarifies that the server will start even if it is unable to open the port on some of the TCP/IP addresses listed (or implied by a value of '*' or localhost) in listen_addresses parameter. I think it is important to call this out, because I was surprised to see that the server