Re: Doubled test for SET statements in pg_stat_statements tests

2023-11-08 Thread Michael Paquier
On Wed, Nov 08, 2023 at 10:33:23AM +0300, Sergei Kornilov wrote: > is checked twice in contrib/pg_stat_statements/sql/utility.sql on > lines 278-286 and 333-341. Is this on any purpose? I think the > second set of tests is not needed and can be removed, as in the > attached patch. Thanks,

Doubled test for SET statements in pg_stat_statements tests

2023-11-07 Thread Sergei Kornilov
Hello! I noticed that the same block -- SET statements. -- These use two different strings, still they count as one entry. SET work_mem = '1MB'; Set work_mem = '1MB'; SET work_mem = '2MB'; RESET work_mem; SET enable_seqscan = off; SET enable_seqscan = on; RESET enable_seqscan; is checked twice