Re: File API cleanup

2023-02-20 Thread Peter Eisentraut
On 23.12.22 09:33, Peter Eisentraut wrote: On 01.12.22 09:25, Peter Eisentraut wrote: Here are a couple of patches that clean up the internal File API and related things a bit: Here are two follow-up patches that clean up some stuff related to the earlier patch set.  I suspect these are all

Re: File API cleanup

2022-12-23 Thread Peter Eisentraut
On 01.12.22 09:25, Peter Eisentraut wrote: Here are a couple of patches that clean up the internal File API and related things a bit: Here are two follow-up patches that clean up some stuff related to the earlier patch set. I suspect these are all historically related.

Re: File API cleanup

2022-12-01 Thread Peter Eisentraut
On 01.12.22 09:55, Bharath Rupireddy wrote: can we have a generic, single function file_exists() in fd.c/file_utils.c so that both backend and frontend code can use it? I see there are 3 uses and definitions of it in jit.c, dfmgr.c and pg_regress.c. This will reduce the code duplication.

Re: File API cleanup

2022-12-01 Thread Bharath Rupireddy
On Thu, Dec 1, 2022 at 1:55 PM Peter Eisentraut wrote: > > Here are a couple of patches that clean up the internal File API and > related things a bit: > > 0001-Update-types-in-File-API.patch > > Make the argument types of the File API match stdio better: > > - Change the data buffer to

File API cleanup

2022-12-01 Thread Peter Eisentraut
Here are a couple of patches that clean up the internal File API and related things a bit: 0001-Update-types-in-File-API.patch Make the argument types of the File API match stdio better: - Change the data buffer to void *, from char *. - Change FileWrite() data buffer to const on