Re: Fix Brin Private Spool Initialization (src/backend/access/brin/brin.c)

Em sáb., 30 de dez. de 2023 19:19, Tomas Vondra < tomas.von...@enterprisedb.com> escreveu: > On 12/29/23 18:02, Ranier Vilela wrote: > > > > ... > > > > As I wrote, the new patch version was for consideration. > > It seems more like a question of style, so it's better to remove it. > > > > Anyway

Re: Fix Brin Private Spool Initialization (src/backend/access/brin/brin.c)

On 12/29/23 18:02, Ranier Vilela wrote: > > ... > > As I wrote, the new patch version was for consideration. > It seems more like a question of style, so it's better to remove it. > > Anyway +1 for your original patch. > I've pushed my original patch. Thanks for the report. regards --

Re: Fix Brin Private Spool Initialization (src/backend/access/brin/brin.c)

Em sex., 29 de dez. de 2023 às 08:53, Ranier Vilela escreveu: > Em qui., 28 de dez. de 2023 às 22:16, Tomas Vondra < > tomas.von...@enterprisedb.com> escreveu: > >> >> >> On 12/27/23 12:37, Ranier Vilela wrote: >> > Em ter., 26 de dez. de 2023 às 19:07, Tomas Vondra >> >

Re: Fix Brin Private Spool Initialization (src/backend/access/brin/brin.c)

On 12/29/23 14:53, Ranier Vilela wrote: > > > Em sex., 29 de dez. de 2023 às 10:33, Tomas Vondra > mailto:tomas.von...@enterprisedb.com>> > escreveu: > > > > On 12/29/23 12:53, Ranier Vilela wrote: > > Em qui., 28 de dez. de 2023 às 22:16, Tomas Vondra > >

Re: Fix Brin Private Spool Initialization (src/backend/access/brin/brin.c)

Em sex., 29 de dez. de 2023 às 10:33, Tomas Vondra < tomas.von...@enterprisedb.com> escreveu: > > > On 12/29/23 12:53, Ranier Vilela wrote: > > Em qui., 28 de dez. de 2023 às 22:16, Tomas Vondra > > mailto:tomas.von...@enterprisedb.com>> > > escreveu: > > > > > > > > On 12/27/23 12:37, Ranier

Re: Fix Brin Private Spool Initialization (src/backend/access/brin/brin.c)

On 12/29/23 12:53, Ranier Vilela wrote: > Em qui., 28 de dez. de 2023 às 22:16, Tomas Vondra > mailto:tomas.von...@enterprisedb.com>> > escreveu: > > > > On 12/27/23 12:37, Ranier Vilela wrote: > > Em ter., 26 de dez. de 2023 às 19:07, Tomas Vondra > >

Re: Fix Brin Private Spool Initialization (src/backend/access/brin/brin.c)

Em qui., 28 de dez. de 2023 às 22:16, Tomas Vondra < tomas.von...@enterprisedb.com> escreveu: > > > On 12/27/23 12:37, Ranier Vilela wrote: > > Em ter., 26 de dez. de 2023 às 19:07, Tomas Vondra > > mailto:tomas.von...@enterprisedb.com>> > > escreveu: > > > > > > > > On 12/26/23 19:10, Ranier

Re: Fix Brin Private Spool Initialization (src/backend/access/brin/brin.c)

On 12/27/23 12:37, Ranier Vilela wrote: > Em ter., 26 de dez. de 2023 às 19:07, Tomas Vondra > mailto:tomas.von...@enterprisedb.com>> > escreveu: > > > > On 12/26/23 19:10, Ranier Vilela wrote: > > Hi, > > > > The commit b437571 >

Re: Fix Brin Private Spool Initialization (src/backend/access/brin/brin.c)

Em ter., 26 de dez. de 2023 às 19:07, Tomas Vondra < tomas.von...@enterprisedb.com> escreveu: > > > On 12/26/23 19:10, Ranier Vilela wrote: > > Hi, > > > > The commit b437571 I > > think has an oversight. > > When allocate memory and initialize

Re: Fix Brin Private Spool Initialization (src/backend/access/brin/brin.c)

On 12/26/23 19:10, Ranier Vilela wrote: > Hi, > > The commit b437571 I > think has an oversight. > When allocate memory and initialize private spool in function: > _brin_leader_participate_as_worker > > The behavior is the bs_spool (heap and

Fix Brin Private Spool Initialization (src/backend/access/brin/brin.c)

Hi, The commit b437571 I think has an oversight. When allocate memory and initialize private spool in function: _brin_leader_participate_as_worker The behavior is the bs_spool (heap and index fields) are left empty. The code affected is: