Re: Fix proposal for comparaison bugs in PostgreSQL::Version

2022-11-18 Thread Andrew Dunstan
On 2022-11-17 Th 17:11, Andrew Dunstan wrote: > On 2022-11-04 Fr 10:06, Jehan-Guillaume de Rorthais wrote: >> On Thu, 3 Nov 2022 13:11:18 -0500 >> Justin Pryzby wrote: >> >>> On Tue, Jun 28, 2022 at 06:17:40PM -0400, Andrew Dunstan wrote: Nice catch, but this looks like massive overkill. I

Re: Fix proposal for comparaison bugs in PostgreSQL::Version

2022-11-17 Thread Andrew Dunstan
On 2022-11-04 Fr 10:06, Jehan-Guillaume de Rorthais wrote: > On Thu, 3 Nov 2022 13:11:18 -0500 > Justin Pryzby wrote: > >> On Tue, Jun 28, 2022 at 06:17:40PM -0400, Andrew Dunstan wrote: >>> Nice catch, but this looks like massive overkill. I think we can very >>> simply fix the test in just a

Re: Fix proposal for comparaison bugs in PostgreSQL::Version

2022-11-04 Thread Jehan-Guillaume de Rorthais
On Thu, 3 Nov 2022 13:11:18 -0500 Justin Pryzby wrote: > On Tue, Jun 28, 2022 at 06:17:40PM -0400, Andrew Dunstan wrote: > > Nice catch, but this looks like massive overkill. I think we can very > > simply fix the test in just a few lines of code, instead of a 190 line > > fix and a 130 line TAP

Re: Fix proposal for comparaison bugs in PostgreSQL::Version

2022-11-03 Thread Justin Pryzby
On Tue, Jun 28, 2022 at 06:17:40PM -0400, Andrew Dunstan wrote: > Nice catch, but this looks like massive overkill. I think we can very > simply fix the test in just a few lines of code, instead of a 190 line > fix and a 130 line TAP test. > > It was never intended to be able to compare markers

Re: Fix proposal for comparaison bugs in PostgreSQL::Version

2022-07-06 Thread Jehan-Guillaume de Rorthais
On Tue, 5 Jul 2022 09:59:42 -0400 Andrew Dunstan wrote: > On 2022-07-03 Su 16:12, Jehan-Guillaume de Rorthais wrote: > > On Sun, 3 Jul 2022 10:40:21 -0400 > > Andrew Dunstan wrote: > > > >> On 2022-06-29 We 05:09, Jehan-Guillaume de Rorthais wrote: > >>> On Tue, 28 Jun 2022 18:17:40 -0400 >

Re: Fix proposal for comparaison bugs in PostgreSQL::Version

2022-07-05 Thread Andrew Dunstan
On 2022-07-03 Su 16:12, Jehan-Guillaume de Rorthais wrote: > On Sun, 3 Jul 2022 10:40:21 -0400 > Andrew Dunstan wrote: > >> On 2022-06-29 We 05:09, Jehan-Guillaume de Rorthais wrote: >>> On Tue, 28 Jun 2022 18:17:40 -0400 >>> Andrew Dunstan wrote: >>> On 2022-06-28 Tu 16:53,

Re: Fix proposal for comparaison bugs in PostgreSQL::Version

2022-07-03 Thread Jehan-Guillaume de Rorthais
On Sun, 3 Jul 2022 10:40:21 -0400 Andrew Dunstan wrote: > On 2022-06-29 We 05:09, Jehan-Guillaume de Rorthais wrote: > > On Tue, 28 Jun 2022 18:17:40 -0400 > > Andrew Dunstan wrote: > > > >> On 2022-06-28 Tu 16:53, Jehan-Guillaume de Rorthais wrote: > >>> ... > >>> A better fix would be to

Re: Fix proposal for comparaison bugs in PostgreSQL::Version

2022-07-03 Thread Andrew Dunstan
On 2022-06-29 We 05:09, Jehan-Guillaume de Rorthais wrote: > On Tue, 28 Jun 2022 18:17:40 -0400 > Andrew Dunstan wrote: > >> On 2022-06-28 Tu 16:53, Jehan-Guillaume de Rorthais wrote: >>> ... >>> A better fix would be to store the version internally as version_num that >>> are trivial to

Re: Fix proposal for comparaison bugs in PostgreSQL::Version

2022-06-29 Thread Jehan-Guillaume de Rorthais
On Tue, 28 Jun 2022 18:17:40 -0400 Andrew Dunstan wrote: > On 2022-06-28 Tu 16:53, Jehan-Guillaume de Rorthais wrote: > > ... > > A better fix would be to store the version internally as version_num that > > are trivial to compute and compare. Please, find in attachment an > > implementation of

Re: Fix proposal for comparaison bugs in PostgreSQL::Version

2022-06-28 Thread Michael Paquier
On Tue, Jun 28, 2022 at 06:17:40PM -0400, Andrew Dunstan wrote: > Nice catch, but this looks like massive overkill. I think we can very > simply fix the test in just a few lines of code, instead of a 190 line > fix and a 130 line TAP test. > > It was never intended to be able to compare markers

Re: Fix proposal for comparaison bugs in PostgreSQL::Version

2022-06-28 Thread Andrew Dunstan
On 2022-06-28 Tu 16:53, Jehan-Guillaume de Rorthais wrote: > Hi, > > I found a comparaison bug when using the PostgreSQL::Version module. See: > > $ perl -I. -MPostgreSQL::Version -le ' > my $v = PostgreSQL::Version->new("9.6"); > > print "not 9.6 > 9.0" unless $v > 9.0; > print

Fix proposal for comparaison bugs in PostgreSQL::Version

2022-06-28 Thread Jehan-Guillaume de Rorthais
Hi, I found a comparaison bug when using the PostgreSQL::Version module. See: $ perl -I. -MPostgreSQL::Version -le ' my $v = PostgreSQL::Version->new("9.6"); print "not 9.6 > 9.0" unless $v > 9.0; print "not 9.6 < 9.0" unless $v < 9.0; print "9.6 <= 9.0"if $v <=