On Wed, Nov 16, 2022 at 08:29:24AM +, shiy.f...@fujitsu.com wrote:
> I have fixed the problems you saw, and improved the patch as you suggested.
>
> Besides, I noticed that the tab completion for "ALTER DEFAULT PRIVILEGES ...
> GRANT/REVOKE ..." missed "CREATE". Fix it in 0001 patch.
>
> And
On Thu, Nov 10, 2022 12:54 PM Michael Paquier wrote:
>
> On Tue, Oct 18, 2022 at 05:17:32PM +1100, Peter Smith wrote:
> > I re-tested and confirm that the patch does indeed fix the quirk I'd
> > previously reported.
> >
> > But, looking at the patch code, I don't know if it is the best way to
>
On Tue, Oct 18, 2022 at 05:17:32PM +1100, Peter Smith wrote:
> I re-tested and confirm that the patch does indeed fix the quirk I'd
> previously reported.
>
> But, looking at the patch code, I don't know if it is the best way to
> fix the problem or not. Someone with more experience of the
>
On Tue, Oct 11, 2022 at 1:28 AM shiy.f...@fujitsu.com
wrote:
>
> On Mon, Oct 10, 2022 2:12 PM shiy.f...@fujitsu.com
> wrote:
> >
> > On Tue, Oct 4, 2022 4:17 PM Peter Smith wrote:
> > >
> > > But, while testing I noticed another different quirk
> > >
> > > It seems that neither the GRANT nor
On Mon, Oct 10, 2022 2:12 PM shiy.f...@fujitsu.com
wrote:
>
> On Tue, Oct 4, 2022 4:17 PM Peter Smith wrote:
> >
> > But, while testing I noticed another different quirk
> >
> > It seems that neither the GRANT nor the REVOKE auto-complete
> > recognises the optional PRIVILEGE keyword
> >
> >
On Tue, Oct 4, 2022 4:17 PM Peter Smith wrote:
>
> On Thu, Sep 29, 2022 at 12:50 PM shiy.f...@fujitsu.com
> wrote:
> >
> > On Wed, Sep 28, 2022 1:49 PM Kyotaro Horiguchi
> wrote:
> > >
> > > At Wed, 28 Sep 2022 14:14:01 +1000, Peter Smith
> > > wrote in
> ...
> > > >
> > > > 2. tab complete
On Thu, Sep 29, 2022 at 12:50 PM shiy.f...@fujitsu.com
wrote:
>
> On Wed, Sep 28, 2022 1:49 PM Kyotaro Horiguchi
> wrote:
> >
> > At Wed, 28 Sep 2022 14:14:01 +1000, Peter Smith
> > wrote in
...
> > >
> > > 2. tab complete for GRANT
> > >
> > > test_pub=# grant
> > > ALL
Thanks! I pushed 0001.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"La rebeldía es la virtud original del hombre" (Arthur Schopenhauer)
>
> > 2a.
> > grant "GRANT" ??
>
> Yeah, for the mement I thought that might a kind of admin option but
> there's no such a privilege. REVOKE gets the same suggestion.
>
Maybe that's for "REVOKE GRANT OPTION FOR". But it is used by both GRANT and
REVOKE. I thi
At Wed, 28 Sep 2022 14:14:01 +1000, Peter Smith wrote
in
> On Tue, Sep 27, 2022 at 8:28 PM shiy.f...@fujitsu.com
> wrote:
> >
> > Hi hackers,
> >
> > I saw a problem when using tab-complete for "GRANT", "TABLES IN SCHEMA"
> > should
> > be "ALL TABLES IN SCHEMA" in the following case.
> >
> >
On Tue, Sep 27, 2022 at 8:28 PM shiy.f...@fujitsu.com
wrote:
>
> Hi hackers,
>
> I saw a problem when using tab-complete for "GRANT", "TABLES IN SCHEMA" should
> be "ALL TABLES IN SCHEMA" in the following case.
>
> postgres=# grant all on
> ALL FUNCTIONS IN SCHEMA DATABASE
his new syntax. Attach a patch to fix them.
Regards,
Shi yu
0001-Fix-some-newly-modified-tab-complete-changes-and-com.patch
Description: 0001-Fix-some-newly-modified-tab-complete-changes-and-com.patch
12 matches
Mail list logo
