Hi,
> I think I've managed to reproduce the issue. The test I've added to check
> slru flush was the one failing in the regression suite.
A consensus was reached [1] to mark this patch as RwF for now. There
are many patches to be reviewed and this one doesn't seem to be in the
best shape, so we
I think I've managed to reproduce the issue. The test I've added to check
slru flush was the one failing in the regression suite.
SELECT SUM(flushes) > :slru_flushes_before FROM pg_stat_slru;
?column?
--
t
The origin seems to be a race condition on have_slrustats (
> On 3 Mar 2023, at 09:06, Anthonin Bonnefoy
> wrote:
>
> Here's the patch rebased with Andres' suggestions.
> Happy to update it if there's any additionalj change required.
This patch crashes 031_recovery_conflict with a SIGInvalid on Windows, can you
please investigate and see what might be
Here's the patch rebased with Andres' suggestions.
Happy to update it if there's any additionalj change required.
On Wed, Mar 1, 2023 at 8:46 PM Gregory Stark (as CFM)
wrote:
> On Thu, 12 Jan 2023 at 03:46, Anthonin Bonnefoy
> wrote:
> >
> >
> > That would make sense. I've created a new patch
On Thu, 12 Jan 2023 at 03:46, Anthonin Bonnefoy
wrote:
>
>
> That would make sense. I've created a new patch with everything moved in
> pgstat_report_checkpointer().
> I did split the checkpointer flush in a pgstat_flush_checkpointer() function
> as it seemed more readable. Thought?
This patch
On Wed, Jan 11, 2023 at 5:33 PM Andres Freund wrote:
> Hi,
>
> On 2023-01-11 10:29:06 +0100, Anthonin Bonnefoy wrote:
> > Currently, the Checkpointer process only reports SLRU statistics at
> server
> > shutdown, leading to delayed statistics for SLRU flushes. This patch
> adds a
> > flush of
Hi,
On 2023-01-11 10:29:06 +0100, Anthonin Bonnefoy wrote:
> Currently, the Checkpointer process only reports SLRU statistics at server
> shutdown, leading to delayed statistics for SLRU flushes. This patch adds a
> flush of SLRU stats to the end of checkpoints.
Hm. I wonder if we should do this
Hi Anthonin,
> This patch adds a flush of SLRU stats to the end of checkpoints.
The patch looks good to me and passes the tests but let's see if
anyone else has any feedback.
Also I added a CF entry: https://commitfest.postgresql.org/42/4120/
--
Best regards,
Aleksander Alekseev
Hello hackers,
Currently, the Checkpointer process only reports SLRU statistics at server
shutdown, leading to delayed statistics for SLRU flushes. This patch adds a
flush of SLRU stats to the end of checkpoints.
Best regards,
Anthonin
flush-slru-counters.patch
Description: Binary data
